zaks.anna (Anna Zaks)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2013, 11:08 AM (221 w, 1 d)

Recent Activity

Mon, Nov 13

zaks.anna created D39964: Change code owner for Clang Static Analyzer to Devin Coughlin..
Mon, Nov 13, 9:57 AM

Tue, Oct 31

zaks.anna added a comment to D39428: [Analyzer] As suggested, use value storage for BodyFarm.

Also if you check the code snippets in the coding standard: https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto you can see that where we officially put the references.

Tue, Oct 31, 1:41 PM

Mon, Oct 30

zaks.anna accepted D39422: [analyzer] pr34779: CStringChecker: Don't get crashed by non-standard standard library function definitions..
Mon, Oct 30, 4:00 PM
zaks.anna added a comment to D38844: [analyzer] Make issue hash related tests more concise.

I'd also include some info on how it's now possible to dump the issue hash. You introduce a new debugging function here "clang_analyzer_hashDump" but it's not mentioned in the commit message.

Mon, Oct 30, 10:15 AM
zaks.anna accepted D39423: [analyzer] Left shifting a negative value is undefined.
Mon, Oct 30, 10:03 AM

Fri, Oct 27

zaks.anna accepted D39159: [analyzer] Improves the logic of GenericTaintChecker identifying stdin..

Thanks! Do you have commit access or should we commit on your behalf?

Fri, Oct 27, 11:29 AM
zaks.anna accepted D39269: [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests.

What kind of output will this start displaying?

Fri, Oct 27, 11:25 AM
zaks.anna accepted D38728: [analyzer] Use the signature of the primary template for issue hash calculation.

LGTM!

Fri, Oct 27, 11:20 AM
zaks.anna added a comment to D38844: [analyzer] Make issue hash related tests more concise.

Please, change the commit description to be more comprehensive.

Fri, Oct 27, 11:08 AM
zaks.anna added a comment to D37437: [analyzer] Fix some checker's output plist not containing the checker name.

Just to be clear, since this leads to regression to the checker API, I am asking to look into other ways of solving this problem. For example, is there a way to ensure that the checker names are set at construction?

Fri, Oct 27, 10:59 AM
zaks.anna added a comment to D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message.

Please, commit.

Fri, Oct 27, 10:55 AM
zaks.anna accepted D33729: [analyzer] lock_guard and unique_lock extension for BlockInCriticalSection Static Analyzer checker.

Thanks!

Fri, Oct 27, 10:53 AM

Mon, Oct 23

zaks.anna added a reviewer for D30691: [analyzer] Support for naive cross translational unit analysis: george.karpenkov.
Mon, Oct 23, 11:56 AM

Sat, Oct 21

zaks.anna added a comment to D39159: [analyzer] Improves the logic of GenericTaintChecker identifying stdin..

Fix looks good. Could you add a test case? The analyzer tests define their own stdin and types, so you could add an alternate definition or change the existing one so that it goes through a typedef.

Sat, Oct 21, 10:43 AM

Fri, Oct 20

zaks.anna added inline comments to D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true.
Fri, Oct 20, 9:25 AM

Thu, Oct 19

zaks.anna added inline comments to D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true.
Thu, Oct 19, 11:05 PM
zaks.anna added a reviewer for D35109: [Analyzer] SValBuilder Comparison Rearrangement: george.karpenkov.
Thu, Oct 19, 10:51 PM

Oct 13 2017

zaks.anna added a comment to D37437: [analyzer] Fix some checker's output plist not containing the checker name.

Looks like the need to have the checker name in BugType along with the checker names not being initialized early enough, leads to worse checker-writer experience. Is there a way to ensure that the checker names are set at construction?

Oct 13 2017, 8:20 PM

Oct 10 2017

zaks.anna accepted D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width.

Once the comments by @paquette are addressed, LGTM. Thanks!

Oct 10 2017, 11:20 PM

Sep 29 2017

zaks.anna accepted D38213: [Analyzer] Make testing scripts flake8-compliant.
Sep 29 2017, 10:44 PM
zaks.anna added inline comments to D37840: [Analyzer] Synthesize function body for call_once.
Sep 29 2017, 10:36 PM

Sep 28 2017

zaks.anna added a reviewer for D37478: [analyzer] Implement pointer arithmetic on constants: dcoughlin.
Sep 28 2017, 9:41 AM

Sep 25 2017

zaks.anna added inline comments to D38213: [Analyzer] Make testing scripts flake8-compliant.
Sep 25 2017, 1:03 PM
zaks.anna accepted D36737: [analyzer] Store design discussions in docs/analyzer for future use..

Thanks!

Sep 25 2017, 12:53 PM
zaks.anna added a comment to D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width.

Sorry for the wait!

Sep 25 2017, 12:50 PM
zaks.anna added inline comments to D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width.
Sep 25 2017, 12:50 PM
zaks.anna accepted D37596: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name.

Looks great! Thanks!

Sep 25 2017, 5:02 AM
zaks.anna accepted D38162: [Analyzer] Add nullability to the list of tested checkers in SATestBuild.
Sep 25 2017, 5:02 AM

Sep 18 2017

zaks.anna accepted D37840: [Analyzer] Synthesize function body for call_once.

Please, commit. I think we can take further comments post-commit.

Sep 18 2017, 7:47 PM

Sep 15 2017

zaks.anna added a comment to D37908: [Analyzer] Check function name size before performing indexing.

Looks like I rushed into accepting. This needs a test case of cause!

Sep 15 2017, 11:10 AM
zaks.anna accepted D37908: [Analyzer] Check function name size before performing indexing.
Sep 15 2017, 10:59 AM

Sep 14 2017

zaks.anna added a comment to D36690: [StaticAnalyzer] LoopWidening: Invalidate only the possibly changed regions.

Hi Peter,

Sep 14 2017, 9:43 AM

Sep 13 2017

zaks.anna accepted D37805: [analyzer] PthreadLock: add printState()..
Sep 13 2017, 8:52 AM
zaks.anna added inline comments to D37806: [analyzer] PthreadLock: Fix return values of XNU lock functions..
Sep 13 2017, 8:51 AM
zaks.anna accepted D37807: [analyzer] PthreadLock: Add the other XNU rwlock unlock functions..
Sep 13 2017, 8:47 AM
zaks.anna added a comment to D37809: [analyzer] PthreadLock: Refactor, use PostCall API. NFC..

How about committing the refactor of the code without test modifications. And committing changes to the test separately?

Sep 13 2017, 8:46 AM

Sep 6 2017

zaks.anna accepted D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.

Thank you!
Anna

Sep 6 2017, 3:53 PM
zaks.anna added a comment to D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.

Thanks for addressing the non-determinism!!!

Sep 6 2017, 3:34 PM
zaks.anna updated subscribers of D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.
Sep 6 2017, 3:21 PM
zaks.anna accepted D37500: [CSA] Move AnalysisContext.h to AnalysisDeclContext.h.

Looks good.

Sep 6 2017, 1:21 PM
zaks.anna accepted D37499: Move implementation into a cpp file.

Yes, please, commit.

Sep 6 2017, 1:21 PM
zaks.anna added a reviewer for D37499: Move implementation into a cpp file: NoQ.
Sep 6 2017, 10:06 AM

Aug 28 2017

zaks.anna added a comment to D35450: [analyzer] Support generating and reasoning over more symbolic constraint types.

But I've never used the taint tracking mode, so I don't know what would be a reasonable default for MaxComp.

that one is very experimental anyway. I'd just keep the functional changes to tain out of this patch and use the current default that taint uses.

Aug 28 2017, 11:37 AM
zaks.anna added a comment to D35110: [Analyzer] Constraint Manager Negates Difference.

Is this blocked on the same reasons as what was raised in https://reviews.llvm.org/D35109?

Aug 28 2017, 11:32 AM

Aug 27 2017

zaks.anna added a comment to D36708: [analyzer] Fix Bug34144-[MallocChecker] MallocChecker::MallocUpdateRefState(): Assertion `Sym' failed..

Hi MTC,

Aug 27 2017, 1:40 AM
zaks.anna added a comment to D26737: [analyzer] Make it possible to analyze functions even if they were inlined.

Ping?

Aug 27 2017, 1:27 AM
zaks.anna resigned from D27753: [analyzer] alpha.security.DirtyScalar Checker.
Aug 27 2017, 1:24 AM
zaks.anna added a comment to D33729: [analyzer] lock_guard and unique_lock extension for BlockInCriticalSection Static Analyzer checker.

Ping... While extending isCalled is not a must, this should not crash on the sample ObjC code.

Aug 27 2017, 1:16 AM
zaks.anna added inline comments to D35450: [analyzer] Support generating and reasoning over more symbolic constraint types.
Aug 27 2017, 1:03 AM
zaks.anna added inline comments to D37103: [StaticAnalyzer] LoopUnrolling fixes.
Aug 27 2017, 12:54 AM
zaks.anna added a comment to D36737: [analyzer] Store design discussions in docs/analyzer for future use..

I think we should have these is .rst format as this is what the rest of the documentation predominantly uses. (Note, the formatting can be very basic, it's the format that I care about.)

Aug 27 2017, 12:37 AM

Aug 25 2017

zaks.anna added inline comments to D35450: [analyzer] Support generating and reasoning over more symbolic constraint types.
Aug 25 2017, 9:44 AM

Aug 20 2017

zaks.anna added inline comments to D27918: [analyzer] OStreamChecker.
Aug 20 2017, 3:05 PM

Aug 10 2017

zaks.anna added a reviewer for D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal: dcoughlin.
Aug 10 2017, 12:57 PM

Aug 9 2017

zaks.anna added a comment to D35109: [Analyzer] SValBuilder Comparison Rearrangement.

What do you suggest? Should we widen the type of the difference, or abandon this patch and revert back to the local solution I originally used in the iterator checker?

Aug 9 2017, 10:41 PM

Aug 1 2017

zaks.anna added a comment to D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
I tried to keep this as a minimal starting example because this currently blocks @yamaguchi 's GSoC project for bash completion. There we want to complete the values for -analyzer-config and we currently don't have a good way to get a complete list of available configs from the driver :).
Aug 1 2017, 2:31 PM

Jul 31 2017

zaks.anna added a reviewer for D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.: dcoughlin.
Jul 31 2017, 8:33 AM

Jul 20 2017

zaks.anna added a reviewer for D35110: [Analyzer] Constraint Manager Negates Difference: dcoughlin.
Jul 20 2017, 9:22 AM
zaks.anna added a reviewer for D35109: [Analyzer] SValBuilder Comparison Rearrangement: dcoughlin.
Jul 20 2017, 9:22 AM

Jun 28 2017

zaks.anna added a comment to D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!.

I agree that we should not print the values of all variables. The users will be overwhelmed with the huge amount of information. It is very valuable to highlight just the right information. (I believe even the current diagnostics often produce too much info and highlighting the more important notes would be very valuable.) However, the examples you presented are very compelling. Are there ways we could highlight the same information without printing values of all variables?

Jun 28 2017, 6:51 PM

Jun 27 2017

zaks.anna added inline comments to D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .
Jun 27 2017, 6:17 PM

Jun 26 2017

zaks.anna added a reviewer for D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!: zaks.anna.
Jun 26 2017, 11:07 PM
zaks.anna added a comment to D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements.

@dcoughlin As a reviewer of both patches - could you tell us what's the difference between them? And how are we going to resolve this issue?

Jun 26 2017, 1:52 PM · Restricted Project
zaks.anna accepted D34631: [tsan] Add missing include directory for test unittests.
Jun 26 2017, 1:47 PM
zaks.anna added inline comments to D33729: [analyzer] lock_guard and unique_lock extension for BlockInCriticalSection Static Analyzer checker.
Jun 26 2017, 11:13 AM

Jun 22 2017

zaks.anna added a comment to D34102: [analyzer] Add portability package for the checkers..

This just supports the statement that this particular check should not go under unix. I understand that it will be inconsistent with the name of the malloc checker, which we probably should not change as people might be relying on the package names. I think it's better to have inconsistency than having checks applicable to windows in a package named portability.unix. If there will be checks that need to be in portability and only used for unix, we could create that sub-package later on.

Jun 22 2017, 10:28 AM

Jun 20 2017

zaks.anna added a comment to D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11.

Hmm, should there be new tests that demonstrate that we cover the new APIs?

Unless we use a new registration mechanism for some of these APIs, I'd be fine without adding a test for every API that has localization constraints.

Jun 20 2017, 1:32 PM
zaks.anna added a comment to D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .

The problem here is not in ScopeContext - it isn't going to be a huge patch. The problem is CFG-related mostly - there are many corner cases. We'll also need some help with
fixing Objective-C checkers (RetainCount, for example).

Jun 20 2017, 1:28 PM
zaks.anna added a comment to D34277: [analyzer] Bump default performance thresholds?.

In particular, there are patches to generate more symbolic expressions, that could also degrade the performance (but fix some fixmes along the way).

Jun 20 2017, 9:17 AM

Jun 17 2017

zaks.anna updated subscribers of D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation.
Jun 17 2017, 12:07 AM
zaks.anna added inline comments to D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation.
Jun 17 2017, 12:04 AM

Jun 16 2017

zaks.anna accepted D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output.

LGTM. Thank you!

Jun 16 2017, 10:48 PM
zaks.anna added a comment to D34102: [analyzer] Add portability package for the checkers..

eg. checkers for portability across linux/bsd should be off on windows by default, checkers for non-portable C++ APIs should be off in plain C code, etc

Is the checker you are moving to portability off and not useful on Windows?

Jun 16 2017, 10:37 PM
zaks.anna updated subscribers of D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11.
Jun 16 2017, 10:33 PM
zaks.anna accepted D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11.

Thanks! Do you have commit access?

Jun 16 2017, 10:32 PM
zaks.anna accepted D34277: [analyzer] Bump default performance thresholds?.

Once Artem gives more details about the codebase he tested on, I think it would be fine to commit this. We can revert/address concerns later if @a.sidorin or anyone else raises concerns based on further testing on their codebases. @a.sidorin, would this work for you?

Jun 16 2017, 12:13 PM
zaks.anna added a comment to D34277: [analyzer] Bump default performance thresholds?.

Maybe we should introduce another UMK_* for deeper analysis instead?

The difference here is not substantial enough to warrant a new level. The general motivation for bumping these numbers is that we've set the timeouts many years ago and the hardware improved quite a bit since then.

Jun 16 2017, 12:08 PM
zaks.anna added inline comments to D33645: [analyzer] Add missing documentation for static analyzer checkers.
Jun 16 2017, 11:01 AM

Jun 15 2017

zaks.anna added a comment to D30691: [analyzer] Support for naive cross translational unit analysis.

-(Anna) Scan-build-py integration of the functionality is nearly finished (see https://github.com/rizsotto/scan-build/issues/83) (--ctu switch performs both analysis phases at once). This I think could go in a different patch, but until we could keep the ctu-build.py and ctu-analyze.py scripts. Do you agree?

Jun 15 2017, 11:19 AM

Jun 14 2017

zaks.anna added a comment to D33729: [analyzer] lock_guard and unique_lock extension for BlockInCriticalSection Static Analyzer checker.

Looks good overall, but we should try and extend isCalled if possible.

Jun 14 2017, 5:03 PM
zaks.anna added inline comments to D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation.
Jun 14 2017, 4:09 PM
zaks.anna added a comment to D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.

Should this revision be "abandoned" or is the plan to iterate on it?

Jun 14 2017, 3:47 PM
zaks.anna accepted D31029: [analyzer] Fix logical not for pointers with different bit width.

Looks good with a nit!

Jun 14 2017, 3:16 PM
zaks.anna added a comment to D33645: [analyzer] Add missing documentation for static analyzer checkers.

Great cleanup! Some comments below.

Jun 14 2017, 3:10 PM
zaks.anna added a comment to D27753: [analyzer] alpha.security.DirtyScalar Checker.

This generally sounds good. Definitely do submit these changes in small pieces! See http://llvm.org/docs/DeveloperPolicy.html#incremental-development for rationale.

Jun 14 2017, 11:18 AM
zaks.anna added inline comments to D34102: [analyzer] Add portability package for the checkers..
Jun 14 2017, 11:16 AM

Jun 12 2017

zaks.anna added inline comments to D34102: [analyzer] Add portability package for the checkers..
Jun 12 2017, 8:31 AM

Jun 5 2017

zaks.anna accepted D33828: [analyzer] Don't crash when the code tries to construct an Objective-C object in AllocaRegion..
Jun 5 2017, 9:14 AM

Jun 1 2017

zaks.anna added a comment to D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width.

These are great additions!

Jun 1 2017, 11:02 PM

May 31 2017

zaks.anna accepted D33671: [analyzer] In plist alternate mode, don't add weird control flow pieces from ObjC property declarations to uses..
May 31 2017, 10:34 AM

May 23 2017

zaks.anna added a comment to D33427: Disable postdominator coverage optimizations.

LGTM. Thank you!

May 23 2017, 2:32 PM

May 22 2017

zaks.anna added a comment to D33427: Disable postdominator coverage optimizations.

Is it possible to add a regression test that demonstrates the IR pattern this diff is fixing?

May 22 2017, 11:07 PM

May 17 2017

zaks.anna added a comment to D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor..

Thanks! A couple of minor comments below.

May 17 2017, 10:44 AM
zaks.anna added inline comments to D33191: [analyzer] ObjCGenerics: account for __kindof specifiers met along a chain of casts..
May 17 2017, 8:59 AM

May 16 2017

zaks.anna accepted D33263: [scan-build] Patch to scan-build tool to support "--target=<value>" flag.

Looks good. Thank you!
Do you have commit access or should we commit?

May 16 2017, 5:21 PM

May 10 2017

zaks.anna added a comment to D32449: Modifying PthreadLockChecker.cpp to reduce false positives..

Thank you for the patch! Could you please re-submit the patch with context? Instructions on how to do that can be found here:
http://llvm.org/docs/Phabricator.html

May 10 2017, 6:32 PM

May 9 2017

zaks.anna added a comment to D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor..

That wouldn't work this way because we'd have the completely redundant "calling property accessor" piece before that, and "returning..." after that.

May 9 2017, 11:45 PM
zaks.anna added a comment to D31029: [analyzer] Fix logical not for pointers with different bit width.

Sorry for the delay!!!

May 9 2017, 11:37 PM
zaks.anna accepted D32179: [StaticAnalyzer] Move inline counter increaser to inlineCall function.

I am fine to land this without a test. @szepet, Do you have commit access or should we commit on your behalf?

May 9 2017, 11:24 PM
zaks.anna accepted D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor..

These new "extra notes" of mine might be useful (we could put them at property declaration), i could add them if everybody likes this idea.

What are these? Is there a PR?

May 9 2017, 11:22 PM