We now stash and restore the xmm registers in the trampolines so that
log handlers don't need to worry about clobbering these registers.
In response to comments in D21612.
Differential D23051
[compiler-rt][XRay] Stash xmm registers in the trampolines ClosedPublic Authored by dberris on Aug 1 2016, 10:43 PM.
Details Summary We now stash and restore the xmm registers in the trampolines so that In response to comments in D21612.
Diff Detail Event Timelinedberris updated this object.
dberris marked an inline comment as done. Comment ActionsOnly save xmm0 and xmm1 on the exit trampoline
This revision is now accepted and ready to land.Aug 3 2016, 4:39 AM Closed by commit rL277683: [compiler-rt][XRay] Stash xmm registers in the trampolines (authored by dberris). · Explain WhyAug 3 2016, 5:17 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 66606 lib/xray/xray_trampoline_x86.S
|
Wouldn't it suffice to save only xmm0 and xmm1 here? As I understood, no calling convention uses registers beyond xmm1 for return values: http://www.agner.org/optimize/calling_conventions.pdf