Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

varno (Alexis Shaw)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2016, 8:29 PM (357 w, 4 d)

Recent Activity

Apr 24 2017

varno added a comment to D29320: [XRay] A tool for Comparing xray function call graphs.

Thanks for letting me finish this.

Apr 24 2017, 3:33 PM

Apr 20 2017

varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • New branch
  • address reviewer comments
  • clang-format
  • Address Reviewer Comments
  • Change coloring metric, add labels
  • tests
Apr 20 2017, 7:09 PM

Apr 11 2017

varno added a comment to D29320: [XRay] A tool for Comparing xray function call graphs.

I have been very busy recently but I have next week off. I will be working on it then.

Apr 11 2017, 5:45 PM

Mar 22 2017

varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • Change coloring metric, add labels
Mar 22 2017, 12:12 AM

Mar 21 2017

varno planned changes to D29320: [XRay] A tool for Comparing xray function call graphs.
Mar 21 2017, 4:02 PM

Mar 20 2017

varno added a comment to D29320: [XRay] A tool for Comparing xray function call graphs.

Just doing the math now, (A/B - B/A)*100 is exactly 2x the average of x and y where x and y are defined such that :
A is x% faster than B, and B is x% slower than A. So this is really a reasonable relative difference function even intuitively, being the average of the two difference metrics.

Mar 20 2017, 4:39 PM
varno requested review of D29320: [XRay] A tool for Comparing xray function call graphs.
Mar 20 2017, 3:59 PM
varno added inline comments to D29320: [XRay] A tool for Comparing xray function call graphs.
Mar 20 2017, 3:46 PM

Mar 18 2017

varno added a comment to D29320: [XRay] A tool for Comparing xray function call graphs.

I have fixed most of the comments, and replied to all of them, Tests incoming soon.

Mar 18 2017, 11:45 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • Address Reviewer Comments
Mar 18 2017, 11:42 PM

Mar 17 2017

varno added a comment to D29320: [XRay] A tool for Comparing xray function call graphs.

Am still working on this.

Mar 17 2017, 3:34 AM

Mar 4 2017

varno added inline comments to D29320: [XRay] A tool for Comparing xray function call graphs.
Mar 4 2017, 12:32 AM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • address reviewer comments
  • clang-format
Mar 4 2017, 12:30 AM

Mar 2 2017

varno planned changes to D29320: [XRay] A tool for Comparing xray function call graphs.

Yep. This weekend

Mar 2 2017, 2:37 PM

Feb 22 2017

varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • Reduce number of available ColorMaps as requested
Feb 22 2017, 7:50 PM
varno added inline comments to D29363: [XRAY] A Color Choosing helper for XRay Graph.
Feb 22 2017, 4:28 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • clang-format
Feb 22 2017, 3:55 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • [XRAY] A Color Choosing helper for XRay Graph
  • Address Reviewer Comments and moved to piecewise HSV interpolation
Feb 22 2017, 3:47 PM

Feb 21 2017

varno planned changes to D29363: [XRAY] A Color Choosing helper for XRay Graph.
Feb 21 2017, 4:04 PM
varno requested review of D29363: [XRAY] A Color Choosing helper for XRay Graph.
Feb 21 2017, 5:47 AM

Feb 20 2017

varno added inline comments to D29363: [XRAY] A Color Choosing helper for XRay Graph.
Feb 20 2017, 1:51 AM

Feb 9 2017

varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • Address reviewer comments
    • fix mistake and address comments
    • address comments
    • rebase
    • address comments
    • -pedantic
    • rebase
Feb 9 2017, 7:59 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.

Git Rebase

Feb 9 2017, 7:57 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • spurious semicolons
Feb 9 2017, 7:54 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • Address Reviewer comments
  • clang-format
  • addres reviwer comments
  • fix comments
  • Address Reviewer comments
Feb 9 2017, 7:04 PM
varno added inline comments to D29005: [XRay] A graph Class for the llvm-xray graph.
Feb 9 2017, 4:50 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • Address Review Commits
Feb 9 2017, 4:49 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • more tests and a fix
Feb 9 2017, 3:44 AM

Feb 8 2017

varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • Address reviewer comments
  • fix mistake and address comments
  • address comments
  • rebase
Feb 8 2017, 6:38 PM
varno added inline comments to D29320: [XRay] A tool for Comparing xray function call graphs.
Feb 8 2017, 5:30 PM
varno added a comment to D29610: Fix BucketT Handling in DenseMap..

I will work on fleshing out a bug report after I finish my internship on my own time.

Feb 8 2017, 5:17 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • fix comments
Feb 8 2017, 5:15 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • Address Reviewer comments
  • clang-format
  • addres reviwer comments
Feb 8 2017, 5:08 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • fix mistake and address comments
  • address comments
Feb 8 2017, 4:25 PM

Feb 7 2017

varno updated the summary of D29005: [XRay] A graph Class for the llvm-xray graph.
Feb 7 2017, 11:27 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • Address major reviewer comment and initial tests
Feb 7 2017, 11:20 PM
varno added inline comments to D29005: [XRay] A graph Class for the llvm-xray graph.
Feb 7 2017, 2:43 PM

Feb 6 2017

varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • Address reviewer comments
Feb 6 2017, 9:16 PM
varno planned changes to D29610: Fix BucketT Handling in DenseMap..
Feb 6 2017, 7:22 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • Address Reviewer comments
  • clang-format
Feb 6 2017, 6:02 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • Address Reviewer comments
  • reply to comments
  • clang-format
Feb 6 2017, 5:59 PM
varno updated the diff for D29610: Fix BucketT Handling in DenseMap..
  • clang-format
Feb 6 2017, 5:57 PM
varno added inline comments to D29363: [XRAY] A Color Choosing helper for XRay Graph.
Feb 6 2017, 5:30 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • Address Reviewer comments
Feb 6 2017, 5:28 PM
varno added inline comments to D29610: Fix BucketT Handling in DenseMap..
Feb 6 2017, 5:27 PM
varno added inline comments to D29005: [XRay] A graph Class for the llvm-xray graph.
Feb 6 2017, 4:21 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • Address Reviewer comments
  • reply to comments
Feb 6 2017, 3:32 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.

try again

Feb 6 2017, 3:30 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.

fix up dependancy

Feb 6 2017, 3:29 PM
varno updated the summary of D29005: [XRay] A graph Class for the llvm-xray graph.
Feb 6 2017, 3:28 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • Address Reviewer comments
  • reply to comments
  • rebase on top of D29610 and simplify implementation.
Feb 6 2017, 3:27 PM
varno created D29610: Fix BucketT Handling in DenseMap..
Feb 6 2017, 3:26 PM

Jan 31 2017

varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • add in generation script
Jan 31 2017, 8:30 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.

try again

Jan 31 2017, 7:43 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.

--rebase

Jan 31 2017, 7:41 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.

roll back mistaken commit

Jan 31 2017, 7:32 PM
varno updated the diff for D29363: [XRAY] A Color Choosing helper for XRay Graph.
  • respond to comments
Jan 31 2017, 7:31 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • respond to comments
Jan 31 2017, 7:29 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
  • try that again
Jan 31 2017, 6:34 PM
varno updated the summary of D29320: [XRay] A tool for Comparing xray function call graphs.
Jan 31 2017, 6:30 PM
varno updated the summary of D29320: [XRay] A tool for Comparing xray function call graphs.
Jan 31 2017, 6:30 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.
Jan 31 2017, 6:28 PM
varno created D29363: [XRAY] A Color Choosing helper for XRay Graph.
Jan 31 2017, 6:25 PM
varno updated the diff for D29320: [XRay] A tool for Comparing xray function call graphs.

Rebase to master.

Jan 31 2017, 5:50 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.

Rebase to master

Jan 31 2017, 5:49 PM
varno created D29320: [XRay] A tool for Comparing xray function call graphs.
Jan 31 2017, 1:31 AM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • move inner class to llvm::xray::internal
  • fix Spelling mistakes
  • Make Graph.h cleaner
  • fix bugs and respond to comments
  • add comments
  • fix
  • clang-format
  • address missed comments to the color commit
  • add at method to Graph
Jan 31 2017, 12:58 AM

Jan 26 2017

varno added inline comments to D29005: [XRay] A graph Class for the llvm-xray graph.
Jan 26 2017, 1:16 AM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • clang-format
Jan 26 2017, 1:09 AM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • move inner class to llvm::xray::internal
  • fix Spelling mistakes
  • Make Graph.h cleaner
  • fix bugs and respond to comments
  • add comments
  • fix
Jan 26 2017, 1:05 AM

Jan 24 2017

varno added inline comments to D28225: Implemented color coding and Vertex labels in XRay Graph.
Jan 24 2017, 3:29 PM
varno updated the diff for D28225: Implemented color coding and Vertex labels in XRay Graph.
  • clang-format fix
Jan 24 2017, 3:28 PM
varno updated the diff for D28225: Implemented color coding and Vertex labels in XRay Graph.
  • Respond to comments
  • clang-format new
Jan 24 2017, 3:25 PM

Jan 23 2017

varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • fix Spelling mistakes
Jan 23 2017, 10:08 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.
  • move inner class to llvm::xray::internal
Jan 23 2017, 9:03 PM
varno updated the diff for D29005: [XRay] A graph Class for the llvm-xray graph.

Minimise the lib components, to add remaining changes on an as need
basis.

Jan 23 2017, 8:39 PM
varno added a comment to D28999: Allow DenseSet::iterators to be conveted to and compared with const_iterator.

I cannot commit myself, could someone do this for me?

Jan 23 2017, 8:05 PM
varno updated the diff for D28225: Implemented color coding and Vertex labels in XRay Graph.
  • Reply to comments
Jan 23 2017, 5:55 PM

Jan 22 2017

varno created D29005: [XRay] A graph Class for the llvm-xray graph.
Jan 22 2017, 10:23 PM
varno added a comment to D28225: Implemented color coding and Vertex labels in XRay Graph.

Also has been rebased to master.

Jan 22 2017, 10:12 PM
varno updated the diff for D28225: Implemented color coding and Vertex labels in XRay Graph.
  • Clang format
  • Fixed tests after rebase
  • Addressed review comments
Jan 22 2017, 10:07 PM
varno updated the diff for D28999: Allow DenseSet::iterators to be conveted to and compared with const_iterator.
  • add space
Jan 22 2017, 9:58 PM
varno updated the diff for D28999: Allow DenseSet::iterators to be conveted to and compared with const_iterator.
  • address review comments
  • add tests
Jan 22 2017, 9:50 PM
varno updated the summary of D28999: Allow DenseSet::iterators to be conveted to and compared with const_iterator.
Jan 22 2017, 7:27 PM
varno created D28999: Allow DenseSet::iterators to be conveted to and compared with const_iterator.
Jan 22 2017, 7:23 PM

Jan 15 2017

varno added a comment to D27243: Initial work on the XRay Graph tool..

Hi dblakie, I was wondering if you could land this patch for me?

Jan 15 2017, 2:15 PM

Jan 12 2017

varno added inline comments to D28225: Implemented color coding and Vertex labels in XRay Graph.
Jan 12 2017, 7:59 PM
varno added a comment to D28225: Implemented color coding and Vertex labels in XRay Graph.

Fixed and addressed comments.

Jan 12 2017, 7:56 PM
varno updated the diff for D28225: Implemented color coding and Vertex labels in XRay Graph.
  • Clang format
Jan 12 2017, 7:55 PM
varno updated the diff for D27243: Initial work on the XRay Graph tool..
  • fix tests
Jan 12 2017, 7:50 PM
varno updated the diff for D27243: Initial work on the XRay Graph tool..
  • Initial work on the XRay Graph tool.
  • clang-format
Jan 12 2017, 7:43 PM
varno added inline comments to D27243: Initial work on the XRay Graph tool..
Jan 12 2017, 3:32 PM
varno updated the diff for D27243: Initial work on the XRay Graph tool..

Rebase and addess comment.

Jan 12 2017, 3:29 PM

Jan 9 2017

varno added inline comments to D27243: Initial work on the XRay Graph tool..
Jan 9 2017, 2:43 PM

Jan 3 2017

varno updated the diff for D28225: Implemented color coding and Vertex labels in XRay Graph.
  • Fixing Test with changes added to handle color.
Jan 3 2017, 4:04 PM

Jan 2 2017

varno retitled D28225: Implemented color coding and Vertex labels in XRay Graph from to Implemented color coding and Vertex labels in XRay Graph.
Jan 2 2017, 10:35 PM

Dec 7 2016

varno updated the diff for D27243: Initial work on the XRay Graph tool..
  • Reply to dberris comments.
  • Comments
  • comments
Dec 7 2016, 5:37 PM
varno added inline comments to D27243: Initial work on the XRay Graph tool..
Dec 7 2016, 2:50 PM
varno updated the diff for D27243: Initial work on the XRay Graph tool..
  • Comments
Dec 7 2016, 2:34 PM

Dec 6 2016

varno updated the diff for D27243: Initial work on the XRay Graph tool..
  • Patch comment reply
Dec 6 2016, 10:03 PM