Page MenuHomePhabricator

rSerge (Serge Rogatch)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 4:35 AM (160 w, 2 d)

Recent Activity

Jun 9 2017

rSerge added a comment to D34027: [XRay] Fix computation of function size subject to XRay threshold.

Reached mainline in https://reviews.llvm.org/rL305072 . (with Dean's comment implemented)

Jun 9 2017, 6:27 AM
rSerge committed rL305072: [XRay] Fix computation of function size subject to XRay threshold.
[XRay] Fix computation of function size subject to XRay threshold
Jun 9 2017, 6:24 AM
rSerge closed D34027: [XRay] Fix computation of function size subject to XRay threshold.
Jun 9 2017, 6:23 AM
rSerge added inline comments to D34027: [XRay] Fix computation of function size subject to XRay threshold.
Jun 9 2017, 5:46 AM

Jun 8 2017

rSerge updated subscribers of D34027: [XRay] Fix computation of function size subject to XRay threshold.
Jun 8 2017, 4:20 AM
rSerge created D34027: [XRay] Fix computation of function size subject to XRay threshold.
Jun 8 2017, 4:20 AM

Mar 22 2017

rSerge accepted D27503: [XRay] Custom event logging intrinsic.

@dberris , I've reviewed it, but I'm not sufficiently qualified for this as I am not familiar with some parts of LLVM touched...
To the extent of my knowledge, this looks good.

Mar 22 2017, 11:04 AM

Feb 28 2017

rSerge accepted D30395: [XRay][Docs] Update the XRay documentation.
Feb 28 2017, 5:32 AM

Jan 30 2017

rSerge added a comment to D29286: [XRay][ARM32][AArch64] Fix unstable FDR tests on weak-ordering CPUs.

Reached mainline in revision 293505.

Jan 30 2017, 9:22 AM
rSerge committed rL293505: [XRay][ARM32][AArch64] Fix unstable FDR tests on weak-ordering CPUs.
[XRay][ARM32][AArch64] Fix unstable FDR tests on weak-ordering CPUs
Jan 30 2017, 9:22 AM
rSerge closed D29286: [XRay][ARM32][AArch64] Fix unstable FDR tests on weak-ordering CPUs.
Jan 30 2017, 9:22 AM
rSerge added a comment to D29286: [XRay][ARM32][AArch64] Fix unstable FDR tests on weak-ordering CPUs.

@rengolin , I think your link to the mailing list is wrong. Here is the correct one: https://groups.google.com/forum/#!topic/llvm-dev/2Lt6DEZLgmo

Jan 30 2017, 9:20 AM
rSerge created D29286: [XRay][ARM32][AArch64] Fix unstable FDR tests on weak-ordering CPUs.
Jan 30 2017, 8:59 AM

Jan 26 2017

rSerge added a comment to D28674: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in compiler-rt.

Reached mainline in revision 293186.

Jan 26 2017, 8:38 AM
rSerge added a comment to D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.

Reached mainline in revision 293185.

Jan 26 2017, 8:37 AM
rSerge committed rL293186: [XRay][Arm32] Reduce the portion of the stub and implement more staging for….
[XRay][Arm32] Reduce the portion of the stub and implement more staging for…
Jan 26 2017, 8:29 AM
rSerge closed D28674: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in compiler-rt.
Jan 26 2017, 8:29 AM
rSerge committed rL293185: [XRay][Arm32] Reduce the portion of the stub and implement more staging for….
[XRay][Arm32] Reduce the portion of the stub and implement more staging for…
Jan 26 2017, 8:28 AM
rSerge closed D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.
Jan 26 2017, 8:28 AM

Jan 25 2017

rSerge added a comment to D28948: [XRay][AArch64] More staging for tail call support in XRay AArch64 - in compiler-rt.

Reached mainline in revision 293082.

Jan 25 2017, 1:33 PM
rSerge added a comment to D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.

Reached mainline in revision 293080.

Jan 25 2017, 1:33 PM
rSerge committed rL293082: [XRay][AArch64] More staging for tail call support in XRay AArch64 - in….
[XRay][AArch64] More staging for tail call support in XRay AArch64 - in…
Jan 25 2017, 12:38 PM
rSerge closed D28948: [XRay][AArch64] More staging for tail call support in XRay AArch64 - in compiler-rt.
Jan 25 2017, 12:38 PM
rSerge committed rL293080: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.
[XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM
Jan 25 2017, 12:33 PM
rSerge closed D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.
Jan 25 2017, 12:32 PM
rSerge updated the diff for D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.

Added checking for xray instrumentation map emission in the test.

Jan 25 2017, 12:22 PM

Jan 23 2017

rSerge added a comment to D27503: [XRay] Custom event logging intrinsic.

As I understood, this patch starts adding a possibility to pass custom events to the XRay logging mechanism. So isn't it more logical to call it "custom event" rather than "custom log"? Another reason, I saw some terms similar to "custom log" somewhere in @dberris 's commits, perhaps in FDR. So I think it's desirable to avoid confusion.
And a general question: how are you going to pass these custom events to XRay logging, if currently the handler callback is not designed to take a pointer argument? It currently takes the function id and call reason code as arguments. Are you going to add the 3rd parameter like void* Data to the handler function? Trampolines may need adjustment in that case on some platforms.

Jan 23 2017, 10:36 AM
rSerge added a comment to D28674: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in compiler-rt.

Ping?

Jan 23 2017, 6:57 AM
rSerge added a comment to D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.

Ping?

Jan 23 2017, 6:56 AM
rSerge added inline comments to D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.
Jan 23 2017, 6:46 AM

Jan 20 2017

rSerge updated the summary of D28948: [XRay][AArch64] More staging for tail call support in XRay AArch64 - in compiler-rt.
Jan 20 2017, 6:51 AM
rSerge updated the summary of D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.
Jan 20 2017, 6:51 AM
rSerge created D28948: [XRay][AArch64] More staging for tail call support in XRay AArch64 - in compiler-rt.
Jan 20 2017, 5:53 AM
rSerge created D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM.
Jan 20 2017, 5:40 AM

Jan 19 2017

rSerge added a comment to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

With Thumb fix, in mainline at 292517.

Jan 19 2017, 12:39 PM
rSerge committed rL292517: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
[XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests
Jan 19 2017, 12:38 PM
rSerge committed rL292516: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such….
[XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such…
Jan 19 2017, 12:38 PM
rSerge closed D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 19 2017, 12:38 PM
rSerge added a comment to D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.

Again in mainline at revision 292516.

Jan 19 2017, 12:36 PM
rSerge closed D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 19 2017, 12:35 PM
rSerge updated the diff for D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.

Just submitting the same changes trying to workaround a glitch in Arcanist...

Jan 19 2017, 12:34 PM
rSerge added a comment to D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.

Please, note that this change can stay in mainline if https://reviews.llvm.org/D28623 is reverted because that one is real build-breaker.

Jan 19 2017, 11:48 AM
rSerge updated the diff for D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

Added detection of -mthumb test compiler option, so to mark tests as unsupported on Thumb because XRay doesn't yet support Thumb CPU mode on Arm32.

Jan 19 2017, 11:45 AM
rSerge reopened D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 19 2017, 11:41 AM
rSerge reopened D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 19 2017, 11:41 AM

Jan 17 2017

rSerge added a comment to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

Reached mainline in 292211. Thanks all!

Jan 17 2017, 4:06 AM
rSerge committed rL292211: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
[XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests
Jan 17 2017, 4:04 AM
rSerge closed D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 17 2017, 4:04 AM
rSerge committed rL292210: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such….
[XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such…
Jan 17 2017, 4:03 AM
rSerge closed D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier by committing rL292210: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such….
Jan 17 2017, 4:03 AM
rSerge closed D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 17 2017, 4:03 AM

Jan 16 2017

rSerge updated the diff for D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

PTAL.

Jan 16 2017, 9:44 AM
rSerge accepted D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.

I don't see anything wrong with it so far.

Jan 16 2017, 9:42 AM

Jan 13 2017

rSerge added inline comments to D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.
Jan 13 2017, 11:17 AM
rSerge added a comment to D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.

Where is this used?

Jan 13 2017, 10:42 AM
rSerge added a comment to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

Almost. After applying both patches, I still get:

TestCases/Linux/patching-unpatching.cc

patching-unpatching.cc:30:17: error: expected string not found in input
 // CHECK-NEXT: called: {{.*}}, type=0
                ^
<stdin>:3:1: note: scanning from here
always instrumented called
^
<stdin>:3:21: note: possible intended match here
always instrumented called
                    ^
Jan 13 2017, 9:14 AM
rSerge added a child revision for D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier: D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 13 2017, 6:54 AM
rSerge added a parent revision for D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests: D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 13 2017, 6:54 AM
rSerge added a comment to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

@rengolin , did you first apply patch https://reviews.llvm.org/D28624 before testing the current patch?
Especially the last quoted failed test seems to behave as if emission of XRay table is still broken.

Jan 13 2017, 6:53 AM
rSerge updated the diff for D28674: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in compiler-rt.

Removed the patch piece which enables back testing of XRay on Arm32 , because it goes in a separate patch ( https://reviews.llvm.org/D28623 )

Jan 13 2017, 6:48 AM
rSerge added a parent revision for D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM: D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 13 2017, 6:46 AM
rSerge added a child revision for D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier: D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.
Jan 13 2017, 6:46 AM
rSerge updated the diff for D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.

Removed the changes fixing Arm32 XRay (as they are in a separate patch https://reviews.llvm.org/D28624 ).

Jan 13 2017, 6:46 AM
rSerge updated D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.
Jan 13 2017, 5:29 AM
rSerge retitled D28674: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in compiler-rt from to [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in compiler-rt.
Jan 13 2017, 5:28 AM
rSerge retitled D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM from [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls to [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM.
Jan 13 2017, 5:27 AM
rSerge retitled D28673: [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls - in LLVM from to [XRay][Arm32] Reduce the portion of the stub and implement more staging for tail calls.
Jan 13 2017, 5:27 AM
rSerge added inline comments to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 13 2017, 3:35 AM
rSerge added a comment to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.

@rengolin , yes, please. This patch should be tested together with https://reviews.llvm.org/D28624 , because this patch only enables the tests and that one repairs XRay on Arm32.

Jan 13 2017, 3:33 AM
rSerge added inline comments to D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 13 2017, 3:23 AM

Jan 12 2017

rSerge updated subscribers of D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 12 2017, 12:37 PM
rSerge updated subscribers of D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 12 2017, 12:36 PM
rSerge added reviewers for D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier: dberris, rengolin.
Jan 12 2017, 12:36 PM
rSerge updated D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests.
Jan 12 2017, 12:35 PM
rSerge retitled D28624: [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier from to [XRay][Arm] Repair XRay table emission on Arm32 and add tests to identify such problem earlier.
Jan 12 2017, 12:35 PM
rSerge retitled D28623: [XRay][Arm] Enable back XRay testing on Arm32 and fix the failing tests from to [XRay][Arm] Enable back XRay testing on Arm32.
Jan 12 2017, 12:31 PM

Jan 10 2017

rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

Reached mainline in revision 291568.

Jan 10 2017, 8:28 AM
rSerge committed rL291568: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the….
[XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the…
Jan 10 2017, 8:27 AM
rSerge closed D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.
Jan 10 2017, 8:27 AM
rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

Hi,

Looks like this slipped through the cracks, I'll do a native run for you today and let you know how it goes.

Thanks.

Jan 10 2017, 4:06 AM
rSerge added a reviewer for D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification: pelikan.
Jan 10 2017, 4:00 AM
rSerge reopened D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

Ping?

Jan 10 2017, 3:59 AM

Jan 5 2017

rSerge requested changes to D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.
Jan 5 2017, 6:12 AM
rSerge added inline comments to D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.
Jan 5 2017, 6:12 AM

Jan 3 2017

rSerge updated the diff for D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

At a minimum, during x86_64-Linux to AArch64-Linux cross-compilation it didn't compile because of extern "C" missing. And the compiled program runs well on QEmu-AArch64-Linux .
@rengolin , what do you mean by "testing native" ? If that's compiling LLVM on AArch64 machine (i.e. without cross-compilation), then it would be challenging for me to do because on QEmu a LLVM build takes about a week, and the OS in the Arm32/AArch64 machines our team has is not exactly Linux.

Jan 3 2017, 12:13 PM

Jan 2 2017

rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

I have been able to reproduce the problem when cross-compiling from x86_64-Linux to AArch64-Linux. Investigating now...

Jan 2 2017, 11:08 AM

Dec 23 2016

rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

The second iteration has reached mainline in revision 290452 .

Dec 23 2016, 1:33 PM
rSerge committed rL290452: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the….
[XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the…
Dec 23 2016, 1:31 PM
rSerge closed D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.
Dec 23 2016, 1:31 PM
rSerge updated the diff for D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

Added the forward declaration for ____clear_cache() to fix the build.

Dec 23 2016, 10:05 AM
rSerge reopened D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.
Dec 23 2016, 10:04 AM
rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

As discussed here , presence or absence of __clear_cache built-in depends on the compiler options. The built-in is common to gcc and clang, just currently in clang it is implemented via a called function in compiler-rt, but (another version of) gcc may inline it as an intrinsic. As discussed here , earlier there was a bug in gcc that gcc was expecting the parameters to be void*, in contradiction to the documentation which says they are char*, and clang developers implemented this bug too (so that parameters are void*), and I understood that clang developers were then fixing this bug.

Dec 23 2016, 6:22 AM
rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

This broke the build. Did you manage to build this on AArch64? How did you test this?

Dec 23 2016, 4:22 AM

Dec 22 2016

rSerge added a comment to D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.

Reached mainline in https://reviews.llvm.org/rL290354 .

Dec 22 2016, 11:01 AM
rSerge committed rL290354: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the….
[XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the…
Dec 22 2016, 10:59 AM
rSerge closed D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.
Dec 22 2016, 10:59 AM

Dec 21 2016

rSerge accepted D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.
Dec 21 2016, 5:19 AM

Dec 20 2016

rSerge retitled D27996: [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification from to [XRay][AArch64] An attempt to fix test patching-unpatching.cc by flushing the instruction cache after code modification.
Dec 20 2016, 11:57 AM

Dec 16 2016

rSerge added inline comments to D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.
Dec 16 2016, 8:02 AM

Dec 13 2016

rSerge requested changes to D27038: [XRay][compiler-rt] XRay Flight Data Recorder Mode.
Dec 13 2016, 5:44 AM