This is an archive of the discontinued LLVM Phabricator instance.

Differential D22095

[asan] Enable 48-bit VMA support on aarch64
ClosedPublic

Authored by zatrazz on Jul 7 2016, 9:18 AM.

Details

Reviewers
kcc
rengolin
samsonov
eugenis
pcc
aizatsky
Summary

This patch adds 48-bits VMA support for asan on aarch64. The current
47-bit mask is not suffice since on aarch64 kernel with 48-bit vma
(default on ubuntu 16.04) the process may use full VMA range as:

[...]
ffffa39a7000-ffffa39a8000 r--p 00000000 00:00 0 [vvar]
ffffa39a8000-ffffa39a9000 r-xp 00000000 00:00 0 [vdso]
ffffa39a9000-ffffa39aa000 r--p 0001c000 08:02 13631554 /lib/aarch64-linux-gnu/ld-2.23.so
ffffa39aa000-ffffa39ac000 rw-p 0001d000 08:02 13631554 /lib/aarch64-linux-gnu/ld-2.23.so
ffffc2227000-ffffc2248000 rw-p 00000000 00:00 0 [stack]

Diff Detail

Event Timeline

zatrazz updated this revision to Diff 63084.Jul 7 2016, 9:18 AM
zatrazz retitled this revision from to [asan] Enable 48-bit VMA support on aarch64.
zatrazz updated this object.
zatrazz added reviewers: kcc, pcc, eugenis, samsonov, rengolin.
zatrazz added a project: Restricted Project.
zatrazz added a subscriber: llvm-commits.
Herald added subscribers: kubamracek, rengolin, aemerson. · View Herald TranscriptJul 7 2016, 9:18 AM
rengolin edited edge metadata.Jul 7 2016, 9:24 AM

Do *all* tests pass with this?

zatrazz added a comment.Jul 7 2016, 10:48 AM
In D22095#476829, @rengolin wrote:

Do *all* tests pass with this?

It fixes only the asan/lsan tests on 48 bits vma kernel. Other sanitizers (dfsan, tsan, msan) still fail.

aizatsky accepted this revision.Jul 7 2016, 12:59 PM
aizatsky added a reviewer: aizatsky.
This revision is now accepted and ready to land.Jul 7 2016, 12:59 PM
zatrazz closed this revision.Jul 18 2016, 10:24 AM

Revision Contents

PathSize
lib/
sanitizer_common/
2 lines

Diff 63084

lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
# endif # endif
#endif #endif
// The range of addresses which can be returned my mmap. // The range of addresses which can be returned my mmap.
// FIXME: this value should be different on different platforms. Larger values // FIXME: this value should be different on different platforms. Larger values
// will still work but will consume more memory for TwoLevelByteMap. // will still work but will consume more memory for TwoLevelByteMap.
#if defined(__mips__) #if defined(__mips__)
# define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 40) # define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 40)
#elif defined(__aarch64__)
# define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 48)
#else #else
# define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 47) # define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 47)
#endif #endif
// The AArch64 linux port uses the canonical syscall set as mandated by // The AArch64 linux port uses the canonical syscall set as mandated by
// the upstream linux community for all new ports. Other ports may still // the upstream linux community for all new ports. Other ports may still
// use legacy syscalls. // use legacy syscalls.
#ifndef SANITIZER_USES_CANONICAL_LINUX_SYSCALLS #ifndef SANITIZER_USES_CANONICAL_LINUX_SYSCALLS
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines