Page MenuHomePhabricator

aizatsky (Mike Aizatsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2015, 4:18 PM (202 w, 6 d)

Recent Activity

Mar 24 2017

aizatsky added inline comments to D31266: [sancov] fixing too aggressive instrumentation elimination.
Mar 24 2017, 9:12 AM
aizatsky updated the diff for D31266: [sancov] fixing too aggressive instrumentation elimination.

checking for post-dominators

Mar 24 2017, 9:11 AM

Mar 22 2017

aizatsky updated subscribers of D31266: [sancov] fixing too aggressive instrumentation elimination.
Mar 22 2017, 4:13 PM
aizatsky created D31266: [sancov] fixing too aggressive instrumentation elimination.
Mar 22 2017, 4:13 PM

Mar 16 2017

aizatsky accepted D31038: Fix broken links and displaced coloring in coverage-report-server.py.

Thanks

Mar 16 2017, 1:58 PM

Mar 6 2017

aizatsky committed rL297094: [libfuzzer] do not use xargs for shell expansion.
[libfuzzer] do not use xargs for shell expansion
Mar 6 2017, 3:54 PM
aizatsky closed D30371: [libfuzzer] do not use xargs for shell expansion by committing rL297094: [libfuzzer] do not use xargs for shell expansion.
Mar 6 2017, 3:54 PM · Restricted Project

Mar 3 2017

aizatsky added a comment to D30371: [libfuzzer] do not use xargs for shell expansion.

The test passes on mac without xargs. Could you verify windows?

Mar 3 2017, 2:36 PM · Restricted Project
aizatsky retitled D30371: [libfuzzer] do not use xargs for shell expansion from [libfuzzer] use find to feed xargs to [libfuzzer] do not use xargs for shell expansion.
Mar 3 2017, 2:35 PM · Restricted Project
aizatsky updated the diff for D30371: [libfuzzer] do not use xargs for shell expansion.

removed xargs

Mar 3 2017, 2:35 PM · Restricted Project
aizatsky committed rL296900: [sancov] better input parameters validation.
[sancov] better input parameters validation
Mar 3 2017, 10:34 AM
aizatsky closed D30370: [sancov] better input parameters validation by committing rL296900: [sancov] better input parameters validation.
Mar 3 2017, 10:34 AM · Restricted Project

Feb 28 2017

aizatsky added a comment to D30380: Teach lit to expand glob expressions.

PID is one of the reason there's '*' in compiler-rt tests: runtime information is often dumped in <basename>-<pid> files. These files are then fed to analysis tools by using '<basename>-*' shell glob.

Feb 28 2017, 8:19 PM

Feb 27 2017

aizatsky added a comment to D30371: [libfuzzer] do not use xargs for shell expansion.

Oh right!

I don't know what the intent was but this is the name of the binary, so it is likely that it use to expand to itself only?

Feb 27 2017, 12:32 PM · Restricted Project
aizatsky added a comment to D30380: Teach lit to expand glob expressions.

I am confused you say glob expansion happens before other substitution. Shouldn't it be in the opposite order if you want %[[%T/*]] to work?

Feb 27 2017, 12:30 PM

Feb 24 2017

aizatsky added reviewers for D30371: [libfuzzer] do not use xargs for shell expansion: kcc, mpividori, zturner, mehdi_amini.
Feb 24 2017, 8:20 PM · Restricted Project
aizatsky created D30371: [libfuzzer] do not use xargs for shell expansion.
Feb 24 2017, 8:18 PM · Restricted Project
aizatsky added a reviewer for D30370: [sancov] better input parameters validation: vitalybuka.
Feb 24 2017, 7:00 PM · Restricted Project
aizatsky created D30370: [sancov] better input parameters validation.
Feb 24 2017, 6:58 PM · Restricted Project
aizatsky committed rL296205: [sancov] extending sancov --help documentation.
[sancov] extending sancov --help documentation
Feb 24 2017, 4:07 PM
aizatsky closed D30361: [sancov] extending sancov --help documentation by committing rL296205: [sancov] extending sancov --help documentation.
Feb 24 2017, 4:07 PM
aizatsky added a comment to D30361: [sancov] extending sancov --help documentation.

Full --help output with this change: https://gist.github.com/anonymous/9b20cc6e13b53cf923bf286f0a39972b

Feb 24 2017, 4:05 PM
aizatsky added reviewers for D30361: [sancov] extending sancov --help documentation: kcc, vitalybuka.
Feb 24 2017, 4:04 PM
aizatsky created D30361: [sancov] extending sancov --help documentation.
Feb 24 2017, 4:04 PM

Feb 8 2017

aizatsky committed rL294533: [sancov] sanitizer coverage initialization test.
[sancov] sanitizer coverage initialization test
Feb 8 2017, 4:13 PM
aizatsky closed D29721: [sancov] sanitizer coverage initialization test by committing rL294533: [sancov] sanitizer coverage initialization test.
Feb 8 2017, 4:13 PM
aizatsky committed rL294529: [sancov] using comdat only when it is enabled.
[sancov] using comdat only when it is enabled
Feb 8 2017, 3:24 PM
aizatsky closed D29733: [sancov] using comdat only when it is enabled by committing rL294529: [sancov] using comdat only when it is enabled.
Feb 8 2017, 3:24 PM
aizatsky added a reviewer for D29733: [sancov] using comdat only when it is enabled: kcc.
Feb 8 2017, 3:20 PM
aizatsky created D29733: [sancov] using comdat only when it is enabled.
Feb 8 2017, 3:20 PM
aizatsky abandoned D29731: [sancov] using comdat only when it is enabled.

Will reupload to add llvm-commits correctly

Feb 8 2017, 3:19 PM
aizatsky updated the diff for D29731: [sancov] using comdat only when it is enabled.

using target triple as intended.

Feb 8 2017, 3:19 PM
aizatsky added a comment to D29731: [sancov] using comdat only when it is enabled.

Actually, hold on a second, I'll replace the triple in darwin file, and that should take care of everything.

Feb 8 2017, 3:13 PM
aizatsky added a comment to D29731: [sancov] using comdat only when it is enabled.

Kostya, please take a look.

Feb 8 2017, 3:12 PM
aizatsky added a reviewer for D29731: [sancov] using comdat only when it is enabled: kcc.
Feb 8 2017, 3:10 PM
aizatsky updated the diff for D29731: [sancov] using comdat only when it is enabled.

split trace-pc-guard test into two.

Feb 8 2017, 3:10 PM
aizatsky created D29731: [sancov] using comdat only when it is enabled.
Feb 8 2017, 2:54 PM
aizatsky added a comment to D29662: [sancov] specifying comdat for sancov constructors.

Grhhh. Fails on mac :(

Feb 8 2017, 2:46 PM
aizatsky committed rL294522: [sancov] pc_guard_init is called at least once per DSO..
[sancov] pc_guard_init is called at least once per DSO.
Feb 8 2017, 1:40 PM
aizatsky closed D29722: [sancov] pc_guard_init is called once per DSO. by committing rL294522: [sancov] pc_guard_init is called at least once per DSO..
Feb 8 2017, 1:40 PM
aizatsky committed rL294517: [sancov] specifying comdat for sancov constructors.
[sancov] specifying comdat for sancov constructors
Feb 8 2017, 1:32 PM
aizatsky closed D29662: [sancov] specifying comdat for sancov constructors by committing rL294517: [sancov] specifying comdat for sancov constructors.
Feb 8 2017, 1:32 PM
aizatsky updated the diff for D29721: [sancov] sanitizer coverage initialization test.

XFAIL on tsan.

Feb 8 2017, 12:53 PM
aizatsky updated the diff for D29721: [sancov] sanitizer coverage initialization test.

replaced XFAIL with REQUIRES.

Feb 8 2017, 12:52 PM
aizatsky added a comment to D29662: [sancov] specifying comdat for sancov constructors.

I've added the test. PTAL.

Feb 8 2017, 12:43 PM
aizatsky updated the diff for D29662: [sancov] specifying comdat for sancov constructors.

added .ll test

Feb 8 2017, 12:42 PM
aizatsky updated the diff for D29722: [sancov] pc_guard_init is called once per DSO..

added at least.

Feb 8 2017, 12:42 PM
aizatsky updated the diff for D29722: [sancov] pc_guard_init is called once per DSO..

reworded to say may be called more than once.

Feb 8 2017, 11:44 AM
aizatsky added a comment to D29722: [sancov] pc_guard_init is called once per DSO..

I think that keeping more general "may be called multiple times" is still correct and does give us room to maneuver.

Feb 8 2017, 11:17 AM
aizatsky added reviewers for D29722: [sancov] pc_guard_init is called once per DSO.: kcc, eugenis.
Feb 8 2017, 11:16 AM
aizatsky added reviewers for D29721: [sancov] sanitizer coverage initialization test: kcc, eugenis.
Feb 8 2017, 11:15 AM
aizatsky added a comment to D29662: [sancov] specifying comdat for sancov constructors.

Related test and documentation update:

Feb 8 2017, 11:15 AM
aizatsky added reviewers for D29662: [sancov] specifying comdat for sancov constructors: kcc, eugenis.
Feb 8 2017, 11:15 AM
aizatsky updated the diff for D29662: [sancov] specifying comdat for sancov constructors.

update

Feb 8 2017, 11:12 AM
aizatsky created D29722: [sancov] pc_guard_init is called once per DSO..
Feb 8 2017, 11:11 AM
aizatsky created D29721: [sancov] sanitizer coverage initialization test.
Feb 8 2017, 11:06 AM

Feb 7 2017

aizatsky updated the diff for D29662: [sancov] specifying comdat for sancov constructors.

Updated ctor registration.

Feb 7 2017, 11:18 AM
aizatsky created D29662: [sancov] specifying comdat for sancov constructors.
Feb 7 2017, 9:34 AM

Feb 6 2017

aizatsky accepted D27405: Make sancov.py py3-compatible.

LG then.

Feb 6 2017, 6:25 PM

Feb 3 2017

aizatsky added a comment to D27405: Make sancov.py py3-compatible.

If this script working under python3 is your goal, then I suggest you make the script work first, rather then try to fix lint issues separately. I'd rather we do python3-ification in one change if possible.

Feb 3 2017, 12:56 PM
aizatsky committed rL294035: [libfuzzer] chromium-related compilation fixes.
[libfuzzer] chromium-related compilation fixes
Feb 3 2017, 12:38 PM
aizatsky closed D29502: [libfuzzer] chromium-related compilation fixes by committing rL294035: [libfuzzer] chromium-related compilation fixes.
Feb 3 2017, 12:38 PM
aizatsky created D29502: [libfuzzer] chromium-related compilation fixes.
Feb 3 2017, 11:36 AM

Feb 2 2017

aizatsky added a comment to D27405: Make sancov.py py3-compatible.

Could you please clarify if you test it with python3 and if it works?

Feb 2 2017, 1:14 PM

Feb 1 2017

aizatsky added a comment to D27405: Make sancov.py py3-compatible.

Does this script actually run with python3 after these changes, or are these lint-driven errors? I'm not an expert in python3 (only used python2), but afaik it doesn't have % operator (you are supposed to use "".format()).

Feb 1 2017, 9:52 AM

Jan 20 2017

aizatsky requested changes to D28596: [compiler-rt] General definition for weak functions..

I think we can clean this up a bit.

Jan 20 2017, 5:19 PM

Jan 19 2017

aizatsky accepted D28890: [libFuzzer] Fix minimize_crash issues..

Do you need help landing it?

Jan 19 2017, 8:33 AM

Jan 18 2017

aizatsky committed rL292468: [sancov] applying blacklist to covered points too.
[sancov] applying blacklist to covered points too
Jan 18 2017, 8:00 PM
aizatsky closed D28872: [sancov] applying blacklist to covered points too by committing rL292468: [sancov] applying blacklist to covered points too.
Jan 18 2017, 8:00 PM
aizatsky added a reviewer for D28872: [sancov] applying blacklist to covered points too: vitalybuka.
Jan 18 2017, 2:50 PM
aizatsky created D28872: [sancov] applying blacklist to covered points too.
Jan 18 2017, 2:49 PM

Jan 17 2017

aizatsky accepted D28826: Revert "[asan] Enable -fsanitize-address-use-after-scope on sanitizers bots".
Jan 17 2017, 5:16 PM
aizatsky added a comment to D28596: [compiler-rt] General definition for weak functions..

Another wild thought: is there any template magic that we might invoke to automate creation of function aliases?

Jan 17 2017, 5:10 PM
aizatsky added a comment to D28596: [compiler-rt] General definition for weak functions..

I suggest to make WIN* macros no-op on all platforms that do not need it.

Jan 17 2017, 5:08 PM
aizatsky requested changes to D28596: [compiler-rt] General definition for weak functions..

I don't like that we introduce macros making function definition ugly and opaque. All this to implement one platform hacks. I would prefer to have current version cleaned up to eliminate ifdefs. Something like:

Jan 17 2017, 4:06 PM
aizatsky committed rL292289: [libfuzzer] fixing collected pc addresses for coverage.
[libfuzzer] fixing collected pc addresses for coverage
Jan 17 2017, 3:22 PM
aizatsky closed D28827: [libfuzzer] fixing collected pc addresses for coverage by committing rL292289: [libfuzzer] fixing collected pc addresses for coverage.
Jan 17 2017, 3:22 PM
aizatsky updated the diff for D28827: [libfuzzer] fixing collected pc addresses for coverage.

moved macro to FuzzerDefs.

Jan 17 2017, 3:19 PM
aizatsky created D28827: [libfuzzer] fixing collected pc addresses for coverage.
Jan 17 2017, 1:29 PM
aizatsky accepted D28823: Enabled -fsanitize-address-use-after-scope for -DLLVM_USE_SANITIZER=Address.
Jan 17 2017, 1:12 PM

Jan 11 2017

aizatsky committed rL291736: Revert "[sancov] moving sancov rt to sancov/ directory".
Revert "[sancov] moving sancov rt to sancov/ directory"
Jan 11 2017, 5:48 PM
aizatsky committed rL291735: [sancov] there are windows tests that check linker symbols.
[sancov] there are windows tests that check linker symbols
Jan 11 2017, 5:46 PM
aizatsky committed rL291734: [sancov] moving sancov rt to sancov/ directory.
[sancov] moving sancov rt to sancov/ directory
Jan 11 2017, 5:30 PM
aizatsky closed D28541: [sancov] moving sancov rt to sancov/ directory by committing rL291734: [sancov] moving sancov rt to sancov/ directory.
Jan 11 2017, 5:30 PM · Restricted Project
aizatsky updated the diff for D28541: [sancov] moving sancov rt to sancov/ directory.

adding rtti options (for sanitizer flags).

Jan 11 2017, 5:24 PM · Restricted Project

Jan 10 2017

aizatsky added a comment to D28541: [sancov] moving sancov rt to sancov/ directory.

Is this what you had in mind?

Jan 10 2017, 5:19 PM · Restricted Project
aizatsky added a reviewer for D28541: [sancov] moving sancov rt to sancov/ directory: kcc.
Jan 10 2017, 5:18 PM · Restricted Project
aizatsky retitled D28541: [sancov] moving sancov rt to sancov/ directory from to [sancov] moving sancov rt to sancov/ directory.
Jan 10 2017, 5:18 PM · Restricted Project

Jan 6 2017

aizatsky committed rL291267: [sancov] introducing SANCOV_OPTIONS.
[sancov] introducing SANCOV_OPTIONS
Jan 6 2017, 11:33 AM

Jan 5 2017

aizatsky added a comment to D28359: [compiler-rt] Use common static library for sanitizer_common..

This is all about code duplication, right? When you use static libraries - linking gives you an error. When you use dynamic libraries the code is still duplicated, right? Each .so file will still have its own copy of common functions and data. But loader will just pick the first version.

Jan 5 2017, 1:24 PM
aizatsky added a comment to D28359: [compiler-rt] Use common static library for sanitizer_common..

I worry that our set of static and shared runtimes will be different. If we do this split, we should do it for dynamic libraries too. I don't know if we have static initializers, but we might end up running them twice.

Jan 5 2017, 12:54 PM
aizatsky added inline comments to D28359: [compiler-rt] Use common static library for sanitizer_common..
Jan 5 2017, 12:39 PM
aizatsky added inline comments to D28359: [compiler-rt] Use common static library for sanitizer_common..
Jan 5 2017, 12:27 PM
aizatsky committed rL291141: Revert "[sancov] introducing SANCOV_OPTIONS".
Revert "[sancov] introducing SANCOV_OPTIONS"
Jan 5 2017, 9:06 AM

Jan 4 2017

aizatsky committed rL291089: [sancov] force default flags for windows.
[sancov] force default flags for windows
Jan 4 2017, 11:06 PM
aizatsky committed rL291080: [sancov] enabling tests on ppc and s390.
[sancov] enabling tests on ppc and s390
Jan 4 2017, 8:57 PM
aizatsky committed rL291077: fixing build, accidentally deleted two lines.
fixing build, accidentally deleted two lines
Jan 4 2017, 8:33 PM
aizatsky committed rL291076: [sancov] workaround for absence of weak symbols on win.
[sancov] workaround for absence of weak symbols on win
Jan 4 2017, 8:28 PM
aizatsky committed rL291071: [sancov] workaround for absence of weak symbols on win.
[sancov] workaround for absence of weak symbols on win
Jan 4 2017, 7:59 PM
aizatsky committed rL291068: [sancov] introducing SANCOV_OPTIONS.
[sancov] introducing SANCOV_OPTIONS
Jan 4 2017, 7:25 PM