[asan] Reenable ASan tests in "check-all"

[kubamracek]

Summary

Somehow, in r271049, ASan lit tests and unit tests were removed from “check-all”. Doesn’t seem intentional, let’s fix it.

[etienneb]

Doesn’t seem intentional, let’s fix it.

Agree, the purpose of the patch was to disable test on win64.

Thanks for the fix.

[wang0109]

I think it's a correct fix. Sorry, it's quite embarrasing. Thanks!

[wang0109]

Just did a bit of recall how it happened.. Originally I added only the "OR CMAKE_SIZEOF_VOID_P EQUAL 8" part to exclude some windows only tests for 64-bit. Then I tried to "extend the scope" to exclude other tests for it as well, and copy-pasted the condition without too much thinking..

[rnk]

lgtm, sorry about that

[etienneb]

lgtm

test/asan/CMakeLists.txt

 set(ASAN_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 
 set(ASAN_TESTSUITES)
 set(ASAN_DYNAMIC_TESTSUITES)
 
 # TODO(wwchrome): Re-enable Win64 asan tests when ready.
 # Disable tests for asan Win64 temporarily.
-if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
+if(OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
   set(EXCLUDE_FROM_ALL TRUE)
 endif()
 
 macro(get_bits_for_arch arch bits)
   if (${arch} MATCHES "i386|i686|arm|mips|mipsel")
     set(${bits} 32)
   elseif (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|mips64|mips64el|s390x")
     set(${bits} 64)
if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME)
   set_target_properties(check-asan-dynamic
                         PROPERTIES FOLDER "ASan dynamic tests")
   if(NOT OS_NAME MATCHES "Windows")
     set(EXCLUDE_FROM_ALL FALSE)
   endif()
 endif()
 
 # TODO(wwchrome): Re-enable the tests for asan Win64 when ready.
-if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
+if(OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
   set(EXCLUDE_FROM_ALL FALSE)
 endif()