Page MenuHomePhabricator

wang0109 (Wang Wei)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2016, 3:34 PM (174 w, 11 h)

Recent Activity

Jul 15 2016

wang0109 updated the diff for D22393: [asan Win64] Fix missing frames in TestCase null_deref.
  • update diff: Reuse InitializeDbgHelpIfNeeded()
Jul 15 2016, 5:20 AM

Jul 14 2016

wang0109 added a comment to D22393: [asan Win64] Fix missing frames in TestCase null_deref.

After patch:

Jul 14 2016, 7:07 PM
wang0109 retitled D22393: [asan Win64] Fix missing frames in TestCase null_deref from to [asan Win64] Fix missing frames in TestCase null_deref.
Jul 14 2016, 7:04 PM
wang0109 added a comment to D22371: [asan] Avoid hooking memchr() on Windows64.

Yes, I think the correct behavior is to let SANITIZER_INTERCEPTER_XXXX macros to control both library and non-library interceptions, meaning, we should surround those interceptions in lib/asan/asan_win_dll_thunk.cc with these macros. That is, another CL, since this one is about memchr() in particular.

Jul 14 2016, 11:27 AM
wang0109 retitled D22371: [asan] Avoid hooking memchr() on Windows64 from to [asan] Avoid hooking memchr() on Windows64.
Jul 14 2016, 11:07 AM

Jul 12 2016

wang0109 added a reviewer for D22274: [asan] Fix interception unittest on Windows64.: rnk.
Jul 12 2016, 12:33 PM
wang0109 retitled D22274: [asan] Fix interception unittest on Windows64. from to [asan] Fix interception unittest on Windows64..
Jul 12 2016, 12:18 PM

Jul 11 2016

wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: fix compile for linux/mac
  • update diff: coding style
Jul 11 2016, 2:05 PM
wang0109 updated the diff for D22232: [asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64.
  • update diff: fix typo
Jul 11 2016, 1:04 PM
wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: fix typo
Jul 11 2016, 1:00 PM
wang0109 updated the diff for D22232: [asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64.
  • update diff: rewrite comment
Jul 11 2016, 12:34 PM
wang0109 updated the diff for D22232: [asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64.
  • update diff: assert success of intercepting memcopy()
Jul 11 2016, 12:14 PM
wang0109 retitled D22232: [asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64 from to [asan] Fix unittest Asan-x86_64-inline-Test crashing on Windows64.
Jul 11 2016, 11:27 AM

Jul 10 2016

wang0109 added inline comments to D21942: [asan] Add exception handler to map memory on demand on Win64..
Jul 10 2016, 5:12 PM
wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: fix typo, use CHECK() to replace __debugbreak
Jul 10 2016, 4:57 PM
wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: remove unneeded code, avoid commit limit error 1455
Jul 10 2016, 4:43 PM

Jul 8 2016

wang0109 abandoned D21944: [asan Win64] Fix bug where interception writing address at wrong offset.
Jul 8 2016, 8:30 AM
wang0109 added a comment to D21944: [asan Win64] Fix bug where interception writing address at wrong offset.

This CL is superceded and merged by:

Jul 8 2016, 8:29 AM
wang0109 abandoned D22125: [asan Win64] Use multiple trampolines for interception.
Jul 8 2016, 8:20 AM
wang0109 added a comment to D22125: [asan Win64] Use multiple trampolines for interception.

This CL is superceded and merged by:

Jul 8 2016, 8:19 AM

Jul 7 2016

wang0109 retitled D22125: [asan Win64] Use multiple trampolines for interception from to [asan Win64] Use multiple trampolines for interception.
Jul 7 2016, 8:02 PM

Jul 6 2016

wang0109 added inline comments to D21942: [asan] Add exception handler to map memory on demand on Win64..
Jul 6 2016, 2:15 PM
wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: cleanup code regarding RoundDownTo, GetPageSize
Jul 6 2016, 2:08 PM

Jul 5 2016

wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: remove several ifdefs, rename to InitializePlatformExceptionHandlers
Jul 5 2016, 6:48 AM

Jul 4 2016

wang0109 added inline comments to D21942: [asan] Add exception handler to map memory on demand on Win64..
Jul 4 2016, 8:48 AM

Jul 1 2016

wang0109 updated the diff for D21950: [asan Win64] Implement atomic_compare_exchange_strong for 8 bit.
  • update diff: remove some duplicate codes
Jul 1 2016, 10:10 PM
wang0109 updated the diff for D21944: [asan Win64] Fix bug where interception writing address at wrong offset.
  • update diff: use s32 to ensure it is always 4 bytes
Jul 1 2016, 10:02 PM
wang0109 retitled D21950: [asan Win64] Implement atomic_compare_exchange_strong for 8 bit from to [asan Win64] Implement atomic_compare_exchange_strong for 8 bit.
Jul 1 2016, 7:47 PM
wang0109 updated the diff for D21942: [asan] Add exception handler to map memory on demand on Win64..
  • update diff: format and minor styling
Jul 1 2016, 7:14 PM
wang0109 retitled D21944: [asan Win64] Fix bug where interception writing address at wrong offset from to [asan Win64] Fix bug where interception writing address at wrong offset.
Jul 1 2016, 4:01 PM
wang0109 retitled D21942: [asan] Add exception handler to map memory on demand on Win64. from to [asan] Add exception handler to map memory on demand on Win64..
Jul 1 2016, 3:42 PM

Jun 21 2016

wang0109 updated the diff for D21523: [asan] Use 32TB as shadow offset for asan on Windows64.
  • update diff: fix formatting
Jun 21 2016, 7:39 AM

Jun 20 2016

wang0109 updated the diff for D21523: [asan] Use 32TB as shadow offset for asan on Windows64.
  • update diff: Revert change to 64bit asm instrumentation offset
Jun 20 2016, 2:00 PM
wang0109 added a comment to D21523: [asan] Use 32TB as shadow offset for asan on Windows64.

Yes, I am reverting the change to X86AsmInstrumentation.

Jun 20 2016, 1:54 PM
wang0109 added a comment to D21523: [asan] Use 32TB as shadow offset for asan on Windows64.
X86AsmInstrumentation *
CreateX86AsmInstrumentation(const MCTargetOptions &MCOptions,
                            const MCContext &Ctx, const MCSubtargetInfo *&STI) {
  Triple T(STI->getTargetTriple());
  const bool hasCompilerRTSupport = T.isOSLinux();
  if (ClAsanInstrumentAssembly && hasCompilerRTSupport &&
      MCOptions.SanitizeAddress) {
    if (STI->getFeatureBits()[X86::Mode32Bit] != 0)
      return new X86AddressSanitizer32(STI);
    if (STI->getFeatureBits()[X86::Mode64Bit] != 0)
      return new X86AddressSanitizer64(STI);
  }
  return new X86AsmInstrumentation(STI);
}
Jun 20 2016, 1:51 PM
wang0109 updated the diff for D21523: [asan] Use 32TB as shadow offset for asan on Windows64.
  • update diff: guard for windows 64, no impact on linux
Jun 20 2016, 12:40 PM
wang0109 retitled D21525: [asan] Use 32T as offset on asan Windows64 from to [asan] Use 32T as offset on asan Windows64.
Jun 20 2016, 11:52 AM
wang0109 added a comment to D21524: [asan] Fix shifting compiler warnings when compiler in 64-bits.

LGTM

Jun 20 2016, 11:49 AM
wang0109 updated the diff for D21523: [asan] Use 32TB as shadow offset for asan on Windows64.
  • update diff: use shift notation
Jun 20 2016, 11:39 AM
wang0109 updated the diff for D21523: [asan] Use 32TB as shadow offset for asan on Windows64.
  • update diff: add ULL to end of offsets
Jun 20 2016, 11:37 AM
wang0109 retitled D21523: [asan] Use 32TB as shadow offset for asan on Windows64 from to [asan] Use 32TB as shadow offset for asan on Windows64.
Jun 20 2016, 11:34 AM
wang0109 added a comment to D21519: Add missing decoding patterns toRoundUpToInstrBoundary.

LGTM

Jun 20 2016, 10:53 AM
wang0109 added a comment to D21519: Add missing decoding patterns toRoundUpToInstrBoundary.

The jmp in head, when separated from its "body", would break the trampoline machanism where original function is preserved, because jump from head could go to some unknown region int the tampoline area. See my artwork at: http://imgur.com/5vMplUn . But in 32-bit the same problem likely exists, so it's not worse.

Jun 20 2016, 10:12 AM
wang0109 updated subscribers of D21519: Add missing decoding patterns toRoundUpToInstrBoundary.
Jun 20 2016, 9:32 AM

Jun 13 2016

wang0109 retitled D21310: [asan] Fix an overflow with an Allocator constant from to [asan] Fix an overflow with an Allocator constant.
Jun 13 2016, 2:18 PM

Jun 6 2016

wang0109 updated the diff for D20884: This patch attempts to primitive support for Win64 asan.
  • update diff to use clang-format for VirtualProtect
Jun 6 2016, 10:45 AM
wang0109 added a comment to D21017: [asan] Reenable ASan tests in "check-all".

Just did a bit of recall how it happened.. Originally I added only the "OR CMAKE_SIZEOF_VOID_P EQUAL 8" part to exclude some windows only tests for 64-bit. Then I tried to "extend the scope" to exclude other tests for it as well, and copy-pasted the condition without too much thinking..

Jun 6 2016, 7:41 AM · Restricted Project
wang0109 added a comment to D21017: [asan] Reenable ASan tests in "check-all".

I think it's a correct fix. Sorry, it's quite embarrasing. Thanks!

Jun 6 2016, 7:24 AM · Restricted Project

Jun 5 2016

wang0109 updated the diff for D20884: This patch attempts to primitive support for Win64 asan.
  • update diff to remove some NOLINT and add kExtraPrevBytes
Jun 5 2016, 11:44 AM

Jun 4 2016

wang0109 added inline comments to D20884: This patch attempts to primitive support for Win64 asan.
Jun 4 2016, 11:25 AM

Jun 2 2016

wang0109 updated the diff for D20884: This patch attempts to primitive support for Win64 asan.
  • Merge implementations of 32bit/64bit windows interception.
Jun 2 2016, 11:26 AM
wang0109 updated the diff for D20884: This patch attempts to primitive support for Win64 asan.
  • Update diff to fix array access format and typos, also improve some comments
Jun 2 2016, 9:15 AM

Jun 1 2016

wang0109 updated the diff for D20884: This patch attempts to primitive support for Win64 asan.
  • Define the platform SANITIZER_WINDOWS64
Jun 1 2016, 6:12 PM
wang0109 retitled D20884: This patch attempts to primitive support for Win64 asan from to This patch attempts to primitive support for Win64 asan.
Jun 1 2016, 3:43 PM

May 27 2016

wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Fix username in TODO again.
May 27 2016, 8:53 AM
wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Update diff to fix username in TODO
May 27 2016, 8:44 AM

May 25 2016

wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Update diff for linting style
May 25 2016, 9:03 AM
wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Update comment format again
May 25 2016, 7:22 AM
wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Update comment format
May 25 2016, 7:20 AM

May 24 2016

wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Update cmake files to disable unsupported tests including asan and ubsan with asan
May 24 2016, 3:21 PM

May 20 2016

wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.
  • Update diff for cmake - avoid buildbot fail (need more tests)
May 20 2016, 11:27 AM
wang0109 updated the diff for D20455: [asan] Enable asan Win64 build.

Update the patch to clean up the spaces and add more comment

May 20 2016, 7:47 AM

May 19 2016

wang0109 updated subscribers of D20455: [asan] Enable asan Win64 build.
May 19 2016, 4:28 PM
wang0109 added a reviewer for D20455: [asan] Enable asan Win64 build: etienneb.
May 19 2016, 4:13 PM
wang0109 retitled D20455: [asan] Enable asan Win64 build from to [asan] Enable asan Win64 build.
May 19 2016, 4:12 PM