Page MenuHomePhabricator

etienneb (Etienne Bergeron)
Software Developer

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2016, 12:04 AM (166 w, 8 h)

Recent Activity

Mar 3 2017

etienneb committed rL296878: [compiler-rt][asan] Turn on ASAN unittests for win64..
[compiler-rt][asan] Turn on ASAN unittests for win64.
Mar 3 2017, 8:47 AM
etienneb closed D24742: [compiler-rt][asan] Turn on ASAN unittests for win64..
Mar 3 2017, 8:47 AM

Mar 2 2017

etienneb added a comment to D24742: [compiler-rt][asan] Turn on ASAN unittests for win64..

Seems right on win7

D:\src\llvm\ninja64>ninja check-asan
[32/33] Running the AddressSanitizer tests
-- Testing: 565 tests, 16 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 67.76s
  Expected Passes    : 385
  Passes With Retry  : 1
  Expected Failures  : 17
  Unsupported Tests  : 162
Mar 2 2017, 12:22 PM
etienneb added a comment to D24742: [compiler-rt][asan] Turn on ASAN unittests for win64..

This is an old patch.
I'm gonna rebase it and test it.
thx

Mar 2 2017, 11:38 AM
etienneb accepted D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

thx for the improvement
lgtm

Mar 2 2017, 7:07 AM

Feb 21 2017

etienneb committed rL295761: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.
[compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC
Feb 21 2017, 12:16 PM
etienneb closed D30219: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.
Feb 21 2017, 12:16 PM
etienneb added a comment to D30219: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.

My other idea was to provide raw bytes and emit them into the code section.

Feb 21 2017, 11:31 AM
etienneb updated the summary of D30219: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.
Feb 21 2017, 11:26 AM
etienneb updated the summary of D30219: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.
Feb 21 2017, 11:25 AM
etienneb updated the summary of D30219: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.
Feb 21 2017, 11:21 AM
etienneb created D30219: [compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC.
Feb 21 2017, 11:18 AM
etienneb committed rL295730: [compiler-rt][asan] Add support for desallocation of unhandled pointers.
[compiler-rt][asan] Add support for desallocation of unhandled pointers
Feb 21 2017, 8:21 AM
etienneb closed D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.
Feb 21 2017, 8:21 AM
etienneb updated the diff for D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

fix kcc comments

Feb 21 2017, 8:10 AM

Feb 15 2017

etienneb committed rL295232: [compiler-rt][asan|win] Fix ASAN exception handler missing import.
[compiler-rt][asan|win] Fix ASAN exception handler missing import
Feb 15 2017, 12:59 PM
etienneb closed D30001: [compiler-rt][asan|win] Fix ASAN exception handler missing import.
Feb 15 2017, 12:59 PM
etienneb updated the diff for D30001: [compiler-rt][asan|win] Fix ASAN exception handler missing import.

fix linux unittests

Feb 15 2017, 12:26 PM
etienneb created D30001: [compiler-rt][asan|win] Fix ASAN exception handler missing import.
Feb 15 2017, 11:06 AM
etienneb added a comment to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

Without the fix, the unittest is failing with:

% "D:\src\llvm\ninja\projects\compiler-rt\test\asan\I386WindowsConfig\TestCases\Windows\Output\dll_heap_allocation.cc.tmp"
myglobal: 42
=================================================================
==17584==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x00add6f8 in thread T0
    #0 0x39e7e4 in __asan_wrap_HeapFree d:\src\llvm\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:181
    #1 0xf5e99fe in _stdio_common_vswprintf+0x12e (C:\Windows\system32\ucrtbase.DLL+0x100299fe)
    #2 0x77c094c4 in RtlIsCurrentThreadAttachExempt+0x5e (C:\Windows\SysWOW64\ntdll.dll+0x7dea94c4)
    #3 0x77c28ebd in LdrShutdownProcess+0x96 (C:\Windows\SysWOW64\ntdll.dll+0x7dec8ebd)
    #4 0x77c28e09 in RtlExitUserProcess+0x73 (C:\Windows\SysWOW64\ntdll.dll+0x7dec8e09)
    #5 0x775879c4 in ExitProcess+0x14 (C:\Windows\syswow64\kernel32.dll+0x7dd779c4)
    #6 0x3d28e8 in exit_or_terminate_process d:\th\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:129
    #7 0x3d287e in common_exit d:\th\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:269
    #8 0x3d2a63 in exit d:\th\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:282
    #9 0x3b1159 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:260
    #10 0x77583369 in BaseThreadInitThunk+0x11 (C:\Windows\syswow64\kernel32.dll+0x7dd73369)
    #11 0x77c09901 in RtlInitializeExceptionChain+0x62 (C:\Windows\SysWOW64\ntdll.dll+0x7dea9901)
    #12 0x77c098d4 in RtlInitializeExceptionChain+0x35 (C:\Windows\SysWOW64\ntdll.dll+0x7dea98d4)
Feb 15 2017, 8:03 AM
etienneb updated the diff for D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

rnk comments

Feb 15 2017, 7:56 AM

Feb 14 2017

etienneb committed rL295086: [compiler-rt][asan|win] Fix flaky unittest due to large allocations.
[compiler-rt][asan|win] Fix flaky unittest due to large allocations
Feb 14 2017, 11:09 AM
etienneb closed D29945: [compiler-rt][asan|win] Fix flaky unittest due to large allocations.
Feb 14 2017, 11:08 AM
etienneb added inline comments to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.
Feb 14 2017, 10:18 AM
etienneb updated the diff for D29945: [compiler-rt][asan|win] Fix flaky unittest due to large allocations.

rnk comments.

Feb 14 2017, 10:03 AM
etienneb added inline comments to D29945: [compiler-rt][asan|win] Fix flaky unittest due to large allocations.
Feb 14 2017, 9:54 AM
etienneb added inline comments to D29945: [compiler-rt][asan|win] Fix flaky unittest due to large allocations.
Feb 14 2017, 9:54 AM
etienneb added a comment to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

For this given snippet:

#include <windows.h>
#include <iostream>
Feb 14 2017, 8:51 AM
etienneb added inline comments to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.
Feb 14 2017, 8:36 AM
etienneb created D29945: [compiler-rt][asan|win] Fix flaky unittest due to large allocations.
Feb 14 2017, 8:23 AM
etienneb added inline comments to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.
Feb 14 2017, 7:35 AM
etienneb committed rL295057: [compiler-rt][asan|win] Force tls_init test to use dynamic runtime.
[compiler-rt][asan|win] Force tls_init test to use dynamic runtime
Feb 14 2017, 7:33 AM
etienneb closed D29838: [compiler-rt][asan|win] Force tls_init test to use dynamic runtime.
Feb 14 2017, 7:33 AM

Feb 13 2017

etienneb added a comment to D29857: Catch trivially true statements of the form a != 1 || a != 3. Statements like these are likely errors. They are particularly easy to miss when handling enums: enum State { RUNNING, STOPPED, STARTING, ENDING } ... if (state != RUNNING || state !=....

which one is the final version?

Feb 13 2017, 8:27 AM
etienneb added a comment to D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3.

Could you add some tests with enums (like the one in your description)?
This is missing and it's a nice to have.

Feb 13 2017, 8:03 AM

Feb 10 2017

etienneb added a comment to D29838: [compiler-rt][asan|win] Force tls_init test to use dynamic runtime.

PTAL

Feb 10 2017, 11:03 AM
etienneb retitled D29838: [compiler-rt][asan|win] Force tls_init test to use dynamic runtime from [asan][win] Force tls_init test to use dynamic runtime to [compiler-rt][asan|win] Force tls_init test to use dynamic runtime.
Feb 10 2017, 11:03 AM
etienneb created D29838: [compiler-rt][asan|win] Force tls_init test to use dynamic runtime.
Feb 10 2017, 10:59 AM
etienneb added a comment to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

rnk@, is that what we talked about?

Feb 10 2017, 8:54 AM
etienneb updated the diff for D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

better validation, windows only

Feb 10 2017, 8:52 AM

Feb 2 2017

etienneb accepted D29463: [asan] Intercept SetUnhandledExceptionFilter..

lgtm

Feb 2 2017, 10:54 AM
etienneb accepted D29458: [asan] Move exception code to sanitizer_common..

lgtm

Feb 2 2017, 10:40 AM
etienneb added a comment to D29458: [asan] Move exception code to sanitizer_common..

This code will be used by an other sanitizer?

Feb 2 2017, 9:38 AM

Jan 10 2017

etienneb added a comment to D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements..

jckooijman, this issue is still not solved on ToT.

Jan 10 2017, 7:20 AM
etienneb added a comment to D28502: [compiler-rt] [Interception] Properly check for export table's size before referring to its elements..

good catch
+1 for a test to catch this.

Jan 10 2017, 7:08 AM

Dec 8 2016

etienneb committed rL289063: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..
[compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows.
Dec 8 2016, 8:03 AM
etienneb closed D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..
Dec 8 2016, 8:03 AM

Dec 7 2016

etienneb updated the diff for D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..

fix coding style (line too long)

Dec 7 2016, 10:32 AM
etienneb added a comment to D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..

It's working because libglesv2!memcpy and libglesv2!memcpy are redirected to

INTERCEPTOR(void*, memcpy, void *to, const void *from, uptr size) {
  void *ctx;
  ASAN_INTERCEPTOR_ENTER(ctx, memcpy);
  if (PLATFORM_HAS_DIFFERENT_MEMCPY_AND_MEMMOVE) {
    [...]
  } else {
    [...]
  }
}
Dec 7 2016, 8:49 AM
etienneb added a comment to D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..

This simplified patch is fixing the issue on chromium on win7.
IIRC, there is an other issue on win10. I'll make a separate patch for it.

Dec 7 2016, 8:46 AM
etienneb updated the diff for D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..

split and simplify patch

Dec 7 2016, 8:43 AM
etienneb added a comment to D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..

I'm adding more information on the bug I'm facing. (see comments above)

Dec 7 2016, 7:57 AM

Dec 5 2016

etienneb removed a reviewer for D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386: etienneb.
Dec 5 2016, 11:41 AM

Nov 23 2016

etienneb updated the diff for D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..

fix incorrect defines

Nov 23 2016, 8:56 AM
etienneb added inline comments to D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..
Nov 23 2016, 8:32 AM
etienneb retitled D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows. from to [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows..
Nov 23 2016, 8:28 AM

Nov 15 2016

etienneb accepted D26650: [asan] Don't assert that a target is within 2GB on 32-bit Windows.

lg, thanks for the fix

Nov 15 2016, 7:56 AM

Nov 14 2016

etienneb accepted D26473: [asan/win] Delay load dbghelp.dll to delay ucrtbase.dll initialization.
Nov 14 2016, 8:03 AM

Nov 8 2016

etienneb added a comment to D26404: [asan/win] Add init hooks to .CRT$XLAB.

lg

Nov 8 2016, 12:56 PM
etienneb added a comment to D26404: [asan/win] Add init hooks to .CRT$XLAB.

I tried the patch and it's not solving the bug I was facing.

Nov 8 2016, 11:20 AM

Nov 7 2016

etienneb added a comment to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

bad link! my bad.

Nov 7 2016, 8:37 AM
etienneb added a comment to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.

bug: https://reviews.llvm.org/D25946

Nov 7 2016, 8:36 AM

Oct 25 2016

etienneb added inline comments to D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers.
Oct 25 2016, 9:51 AM
etienneb retitled D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers from to [compiler-rt][asan] Add support for desallocation of unhandled pointers.
Oct 25 2016, 9:03 AM

Sep 30 2016

etienneb updated D25120: [compiler-rt] Fix interception of crt atoll on win10 CRT..
Sep 30 2016, 12:47 PM
etienneb committed rL282904: [compiler-rt] Fix interception of crt atoll on win10 CRT..
[compiler-rt] Fix interception of crt atoll on win10 CRT.
Sep 30 2016, 12:46 PM
etienneb closed D25120: [compiler-rt] Fix interception of crt atoll on win10 CRT. by committing rL282904: [compiler-rt] Fix interception of crt atoll on win10 CRT..
Sep 30 2016, 12:46 PM
etienneb retitled D25120: [compiler-rt] Fix interception of crt atoll on win10 CRT. from to [compiler-rt] Fix interception of crt atoll on win10 CRT..
Sep 30 2016, 12:43 PM
etienneb committed rL282882: [compiler-rt] Add support for the dynamic shadow allocation.
[compiler-rt] Add support for the dynamic shadow allocation
Sep 30 2016, 10:56 AM
etienneb closed D25104: [compiler-rt] Add support for the dynamic shadow allocation.
Sep 30 2016, 10:56 AM
etienneb closed D25104: [compiler-rt] Add support for the dynamic shadow allocation by committing rL282882: [compiler-rt] Add support for the dynamic shadow allocation.
Sep 30 2016, 10:56 AM
etienneb committed rL282881: [asan] Support dynamic shadow address instrumentation.
[asan] Support dynamic shadow address instrumentation
Sep 30 2016, 10:55 AM
etienneb closed D23354: [asan] Support dynamic shadow address instrumentation.
Sep 30 2016, 10:55 AM
etienneb updated the diff for D23354: [asan] Support dynamic shadow address instrumentation.

fix rnk@ comments

Sep 30 2016, 10:55 AM
etienneb added a comment to D23354: [asan] Support dynamic shadow address instrumentation.

Thanks Anna. I modified this patch to include your changes.

Sep 30 2016, 9:45 AM
etienneb updated the diff for D23354: [asan] Support dynamic shadow address instrumentation.

apply anna's patch.

Sep 30 2016, 9:42 AM
etienneb retitled D25104: [compiler-rt] Add support for the dynamic shadow allocation from to [compiler-rt] Add support for the dynamic shadow allocation.
Sep 30 2016, 9:33 AM
etienneb updated subscribers of D23354: [asan] Support dynamic shadow address instrumentation.
Sep 30 2016, 9:01 AM
etienneb reopened D23354: [asan] Support dynamic shadow address instrumentation.

Re-opening this issue.

[compiler-rt] r282096 - revert 282085, 281909, they broke 32-bit dynamic ASan and the sanitizer-windows bot
Sep 30 2016, 9:00 AM
etienneb committed rL282860: [compiler-rt][asan] Disable a broken test on windows 64-bits.
[compiler-rt][asan] Disable a broken test on windows 64-bits
Sep 30 2016, 7:40 AM
etienneb closed D25037: [compiler-rt][asan] Disable a broken test on windows 64-bits by committing rL282860: [compiler-rt][asan] Disable a broken test on windows 64-bits.
Sep 30 2016, 7:40 AM
etienneb committed rL282859: [compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64.
[compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64
Sep 30 2016, 7:38 AM
etienneb closed D25038: [compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64.
Sep 30 2016, 7:38 AM

Sep 28 2016

etienneb retitled D25038: [compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64 from to [compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64.
Sep 28 2016, 12:28 PM
etienneb updated D25037: [compiler-rt][asan] Disable a broken test on windows 64-bits.
Sep 28 2016, 12:16 PM
etienneb retitled D25037: [compiler-rt][asan] Disable a broken test on windows 64-bits from to [compiler-rt][asan] Disable a broken test on windows 64-bits.
Sep 28 2016, 12:15 PM
etienneb committed rL282614: [compiler-rt] Fix interception of multiple defined symbols..
[compiler-rt] Fix interception of multiple defined symbols.
Sep 28 2016, 11:12 AM
etienneb closed D24983: [compiler-rt] Fix interception of multiple defined symbols..
Sep 28 2016, 11:12 AM
etienneb updated the diff for D24983: [compiler-rt] Fix interception of multiple defined symbols..

fix bubak comments

Sep 28 2016, 11:03 AM
etienneb added a comment to D24983: [compiler-rt] Fix interception of multiple defined symbols..

maybe explicit test for this case can be useful

Sep 28 2016, 11:02 AM

Sep 27 2016

etienneb updated the diff for D24983: [compiler-rt] Fix interception of multiple defined symbols..

fix coding style

Sep 27 2016, 1:20 PM
etienneb retitled D24983: [compiler-rt] Fix interception of multiple defined symbols. from to [compiler-rt] Fix interception of multiple defined symbols..
Sep 27 2016, 1:13 PM

Sep 26 2016

etienneb removed a reviewer for D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() ): etienneb.
Sep 26 2016, 8:47 AM
etienneb removed a reviewer for D21303: [clang-tidy] Adds performance-returning-type check.: etienneb.
Sep 26 2016, 8:47 AM
etienneb removed a reviewer for D21298: [Clang-tidy] delete null check: etienneb.
Sep 26 2016, 8:46 AM
etienneb removed a reviewer for D20857: [clang-tidy] Add modernize-explicit-operator-bool check.: etienneb.
Sep 26 2016, 8:46 AM · Restricted Project
etienneb removed a reviewer for D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.: etienneb.
Sep 26 2016, 8:46 AM
etienneb removed a reviewer for D19586: Misleading Indentation check: etienneb.
Sep 26 2016, 8:45 AM

Sep 23 2016

etienneb committed rL282263: [compiler-rt] Fix a broken asan 64-bit test using ld_preload.
[compiler-rt] Fix a broken asan 64-bit test using ld_preload
Sep 23 2016, 10:49 AM
etienneb closed D24838: [compiler-rt] Fix a broken asan 64-bit test using ld_preload.
Sep 23 2016, 10:49 AM