♟ etienneb

[compiler-rt][asan] Turn on ASAN unittests for win64.

Seems right on win7

D:\src\llvm\ninja64>ninja check-asan
[32/33] Running the AddressSanitizer tests
-- Testing: 565 tests, 16 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 67.76s
  Expected Passes    : 385
  Passes With Retry  : 1
  Expected Failures  : 17
  Unsupported Tests  : 162

This is an old patch.
I'm gonna rebase it and test it.
thx

thx for the improvement
lgtm

[compiler-rt][asan] Fix incorrect macro preventing ICF with MSVC

My other idea was to provide raw bytes and emit them into the code section.

[compiler-rt][asan] Add support for desallocation of unhandled pointers

[compiler-rt][asan|win] Fix ASAN exception handler missing import

Without the fix, the unittest is failing with:

% "D:\src\llvm\ninja\projects\compiler-rt\test\asan\I386WindowsConfig\TestCases\Windows\Output\dll_heap_allocation.cc.tmp"
myglobal: 42
=================================================================
==17584==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x00add6f8 in thread T0
    #0 0x39e7e4 in __asan_wrap_HeapFree d:\src\llvm\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:181
    #1 0xf5e99fe in _stdio_common_vswprintf+0x12e (C:\Windows\system32\ucrtbase.DLL+0x100299fe)
    #2 0x77c094c4 in RtlIsCurrentThreadAttachExempt+0x5e (C:\Windows\SysWOW64\ntdll.dll+0x7dea94c4)
    #3 0x77c28ebd in LdrShutdownProcess+0x96 (C:\Windows\SysWOW64\ntdll.dll+0x7dec8ebd)
    #4 0x77c28e09 in RtlExitUserProcess+0x73 (C:\Windows\SysWOW64\ntdll.dll+0x7dec8e09)
    #5 0x775879c4 in ExitProcess+0x14 (C:\Windows\syswow64\kernel32.dll+0x7dd779c4)
    #6 0x3d28e8 in exit_or_terminate_process d:\th\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:129
    #7 0x3d287e in common_exit d:\th\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:269
    #8 0x3d2a63 in exit d:\th\minkernel\crts\ucrt\src\appcrt\startup\exit.cpp:282
    #9 0x3b1159 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:260
    #10 0x77583369 in BaseThreadInitThunk+0x11 (C:\Windows\syswow64\kernel32.dll+0x7dd73369)
    #11 0x77c09901 in RtlInitializeExceptionChain+0x62 (C:\Windows\SysWOW64\ntdll.dll+0x7dea9901)
    #12 0x77c098d4 in RtlInitializeExceptionChain+0x35 (C:\Windows\SysWOW64\ntdll.dll+0x7dea98d4)

[compiler-rt][asan|win] Fix flaky unittest due to large allocations

For this given snippet:

#include <windows.h>
#include <iostream>

[compiler-rt][asan|win] Force tls_init test to use dynamic runtime

which one is the final version?

Could you add some tests with enums (like the one in your description)?
This is missing and it's a nice to have.

rnk@, is that what we talked about?

better validation, windows only

This code will be used by an other sanitizer?

jckooijman, this issue is still not solved on ToT.

good catch
+1 for a test to catch this.

[compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows.

fix coding style (line too long)

It's working because libglesv2!memcpy and libglesv2!memcpy are redirected to

INTERCEPTOR(void*, memcpy, void *to, const void *from, uptr size) {
  void *ctx;
  ASAN_INTERCEPTOR_ENTER(ctx, memcpy);
  if (PLATFORM_HAS_DIFFERENT_MEMCPY_AND_MEMMOVE) {
    [...]
  } else {
    [...]
  }
}

This simplified patch is fixing the issue on chromium on win7.
IIRC, there is an other issue on win10. I'll make a separate patch for it.

split and simplify patch

I'm adding more information on the bug I'm facing. (see comments above)

fix incorrect defines

lg, thanks for the fix

I tried the patch and it's not solving the bug I was facing.

[compiler-rt] Fix interception of crt atoll on win10 CRT.

[compiler-rt] Add support for the dynamic shadow allocation

[asan] Support dynamic shadow address instrumentation

Thanks Anna. I modified this patch to include your changes.

Re-opening this issue.

[compiler-rt] r282096 - revert 282085, 281909, they broke 32-bit dynamic ASan and the sanitizer-windows bot

[compiler-rt][asan] Disable a broken test on windows 64-bits

[compiler-rt][asan] Fix incorrect regexp breaking an asan unittest on win64

[compiler-rt] Fix interception of multiple defined symbols.

In D24983#555642, @vitalybuka wrote:

maybe explicit test for this case can be useful

[compiler-rt] Fix a broken asan 64-bit test using ld_preload

etienneb (Etienne Bergeron)
Software Developer

Projects

User Details

Recent Activity
View All

Oct 7 2019

Mar 3 2017

Mar 2 2017

Feb 21 2017

Feb 15 2017

Feb 14 2017

Feb 13 2017

Feb 10 2017

Feb 2 2017

Jan 10 2017

Dec 8 2016

Dec 7 2016

Dec 5 2016

Nov 23 2016

Nov 15 2016

Nov 14 2016

Nov 8 2016

Nov 7 2016

Oct 25 2016

Sep 30 2016

Sep 28 2016

Sep 27 2016

Sep 26 2016

Sep 23 2016

etienneb (Etienne Bergeron)Software Developer