Page MenuHomePhabricator

[asan] Reenable ASan tests in "check-all"
ClosedPublic

Authored by kubamracek on Jun 6 2016, 4:57 AM.

Details

Summary

Somehow, in r271049, ASan lit tests and unit tests were removed from “check-all”. Doesn’t seem intentional, let’s fix it.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 59705.Jun 6 2016, 4:57 AM
kubamracek retitled this revision from to [asan] Reenable ASan tests in "check-all".
kubamracek updated this object.
kubamracek added a project: Restricted Project.
kubamracek added subscribers: llvm-commits, zaks.anna.
etienneb edited edge metadata.Jun 6 2016, 7:16 AM

Doesn’t seem intentional, let’s fix it.

Agree, the purpose of the patch was to disable test on win64.

Thanks for the fix.

wang0109 edited edge metadata.Jun 6 2016, 7:24 AM

I think it's a correct fix. Sorry, it's quite embarrasing. Thanks!

Just did a bit of recall how it happened.. Originally I added only the "OR CMAKE_SIZEOF_VOID_P EQUAL 8" part to exclude some windows only tests for 64-bit. Then I tried to "extend the scope" to exclude other tests for it as well, and copy-pasted the condition without too much thinking..

rnk accepted this revision.Jun 6 2016, 8:54 AM
rnk edited edge metadata.

lgtm, sorry about that

This revision is now accepted and ready to land.Jun 6 2016, 8:54 AM
etienneb accepted this revision.Jun 6 2016, 8:58 AM
etienneb edited edge metadata.

lgtm

This revision was automatically updated to reflect the committed changes.