This is an archive of the discontinued LLVM Phabricator instance.

Add test for D20156
AbandonedPublic

Authored by rovka on May 11 2016, 4:05 AM.

Details

Summary

This adds a test for PR24071. Its purpose is to make sure that we do not assert after identifying an error in inline asm.

It has to be added in Clang because llc exits after identifying the error, and therefore never reaches the assert. The situation is similar to [1].

http://reviews.llvm.org/D20156

[1] https://www.mail-archive.com/cfe-commits@cs.uiuc.edu/msg70985.html

Diff Detail

Event Timeline

rovka updated this revision to Diff 56873.May 11 2016, 4:05 AM
rovka retitled this revision from to Add test for D20156.
rovka updated this object.
rovka added subscribers: llvm-commits, cfe-commits.
mcrosier resigned from this revision.May 11 2016, 6:22 PM
mcrosier removed a reviewer: mcrosier.
rovka abandoned this revision.May 13 2016, 8:54 AM

With the new diagnostic handler in r269428, we no longer need this test (it will be covered by the existing tests such as CodeGen/AArch64/arm64-inline-asm-error-N.ll, by removing the -exit-on-error flag).