Page MenuHomePhabricator

resistor (Owen Anderson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 11:19 PM (568 w, 1 d)

Recent Activity

Apr 25 2023

resistor committed rGbab6cfede928: Remove code only needed to detect a pre-4.0 API break. (authored by resistor).
Remove code only needed to detect a pre-4.0 API break.
Apr 25 2023, 1:05 PM · Restricted Project, Restricted Project
resistor closed D149125: Remove code only needed to detect a pre-4.0 API break..
Apr 25 2023, 1:05 PM · Restricted Project, Restricted Project

Apr 24 2023

resistor added a reviewer for D149125: Remove code only needed to detect a pre-4.0 API break.: dexonsmith.
Apr 24 2023, 11:07 PM · Restricted Project, Restricted Project
resistor requested review of D149125: Remove code only needed to detect a pre-4.0 API break..
Apr 24 2023, 11:07 PM · Restricted Project, Restricted Project
resistor added a reverting change for rG17a3fbf2a368: Remove code only needed to detect a pre-4.0 API break.: rGad41558d8b52: Revert "Remove code only needed to detect a pre-4.0 API break.".
Apr 24 2023, 10:53 PM · Restricted Project, Restricted Project
resistor committed rGad41558d8b52: Revert "Remove code only needed to detect a pre-4.0 API break." (authored by resistor).
Revert "Remove code only needed to detect a pre-4.0 API break."
Apr 24 2023, 10:53 PM · Restricted Project, Restricted Project
resistor added a reverting change for D149122: Remove code only needed to detect a pre-4.0 API break.: rGad41558d8b52: Revert "Remove code only needed to detect a pre-4.0 API break.".
Apr 24 2023, 10:53 PM · Restricted Project, Restricted Project
resistor committed rG17a3fbf2a368: Remove code only needed to detect a pre-4.0 API break. (authored by resistor).
Remove code only needed to detect a pre-4.0 API break.
Apr 24 2023, 10:42 PM · Restricted Project, Restricted Project
resistor closed D149122: Remove code only needed to detect a pre-4.0 API break..
Apr 24 2023, 10:42 PM · Restricted Project, Restricted Project
resistor added a reviewer for D149122: Remove code only needed to detect a pre-4.0 API break.: dexonsmith.
Apr 24 2023, 10:25 PM · Restricted Project, Restricted Project
resistor requested review of D149122: Remove code only needed to detect a pre-4.0 API break..
Apr 24 2023, 10:24 PM · Restricted Project, Restricted Project

Feb 4 2023

resistor committed rGae51a828685d: Teach the AArch64 backend to materialize immediates using a pair of ORR… (authored by resistor).
Teach the AArch64 backend to materialize immediates using a pair of ORR…
Feb 4 2023, 9:05 PM · Restricted Project, Restricted Project
resistor added a reverting change for rG8d433a0ae55a: Teach the AArch64 backend to materialize immediates using a pair of ORR…: rG80fe7721827c: Revert "Teach the AArch64 backend to materialize immediates using a pair of ORR….
Feb 4 2023, 8:15 PM · Restricted Project, Restricted Project
resistor committed rG80fe7721827c: Revert "Teach the AArch64 backend to materialize immediates using a pair of ORR… (authored by resistor).
Revert "Teach the AArch64 backend to materialize immediates using a pair of ORR…
Feb 4 2023, 8:15 PM · Restricted Project, Restricted Project
resistor added a reverting change for D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions.: rG80fe7721827c: Revert "Teach the AArch64 backend to materialize immediates using a pair of ORR….
Feb 4 2023, 8:15 PM · Restricted Project, Restricted Project
resistor committed rG8d433a0ae55a: Teach the AArch64 backend to materialize immediates using a pair of ORR… (authored by resistor).
Teach the AArch64 backend to materialize immediates using a pair of ORR…
Feb 4 2023, 6:30 PM · Restricted Project, Restricted Project
resistor closed D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..
Feb 4 2023, 6:30 PM · Restricted Project, Restricted Project
resistor added inline comments to D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..
Feb 4 2023, 6:23 PM · Restricted Project, Restricted Project

Jan 29 2023

resistor added inline comments to D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..
Jan 29 2023, 9:43 PM · Restricted Project, Restricted Project
resistor updated the diff for D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..

Update for review comments

Jan 29 2023, 9:42 PM · Restricted Project, Restricted Project

Jan 25 2023

resistor committed rG1a0ec9140c87: Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister… (authored by resistor).
Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister…
Jan 25 2023, 9:12 PM · Restricted Project, Restricted Project
resistor closed D141747: Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister uses..
Jan 25 2023, 9:11 PM · Restricted Project, Restricted Project
resistor added a comment to D141747: Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister uses..

Ping

Jan 25 2023, 9:01 PM · Restricted Project, Restricted Project
resistor added a comment to D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..

Ping

Jan 25 2023, 9:00 PM · Restricted Project, Restricted Project

Jan 16 2023

resistor updated the diff for D141747: Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister uses..

Update for review feedback.

Jan 16 2023, 6:58 PM · Restricted Project, Restricted Project

Jan 15 2023

resistor added a comment to D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..

Ping

Jan 15 2023, 10:44 PM · Restricted Project, Restricted Project

Jan 14 2023

resistor added inline comments to D141747: Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister uses..
Jan 14 2023, 6:21 PM · Restricted Project, Restricted Project

Jan 13 2023

resistor requested review of D141747: Resolve a FIXME in MachineCopyPropagation by allowig propagation to subregister uses..
Jan 13 2023, 8:40 PM · Restricted Project, Restricted Project

Jan 12 2023

resistor committed rGafb613e9e7b7: Remove a workaround for libstdc++4.8 (authored by resistor).
Remove a workaround for libstdc++4.8
Jan 12 2023, 7:17 PM · Restricted Project, Restricted Project
resistor closed D141564: Remove a workaround for libstdc++4.8.
Jan 12 2023, 7:16 PM · Restricted Project, Restricted Project

Jan 11 2023

resistor requested review of D141564: Remove a workaround for libstdc++4.8.
Jan 11 2023, 8:53 PM · Restricted Project, Restricted Project
resistor accepted D141535: [llvm] Refactor leftover ThreadLocal usage in MinGW code.
Jan 11 2023, 12:42 PM · Restricted Project, Restricted Project

Jan 10 2023

resistor committed rG90c184662925: Do not short circuit hoistIVInc when recomputation of poison flags is needed. (authored by resistor).
Do not short circuit hoistIVInc when recomputation of poison flags is needed.
Jan 10 2023, 10:03 PM · Restricted Project, Restricted Project
resistor closed D140836: Do not short circuit hoistIVInc when recomputation of poison flags is needed..
Jan 10 2023, 10:03 PM · Restricted Project, Restricted Project
resistor committed rGe4e0f9330798: Remove the ThreadLocal template from LLVM. (authored by resistor).
Remove the ThreadLocal template from LLVM.
Jan 10 2023, 8:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor closed D141349: Remove the ThreadLocal template from LLVM..
Jan 10 2023, 8:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor committed rG1e0f814e7309: Remove a FIXME that will never be fixed since undef is being removed. (authored by resistor).
Remove a FIXME that will never be fixed since undef is being removed.
Jan 10 2023, 8:06 PM · Restricted Project, Restricted Project
resistor closed D141344: Remove a FIXME that will never be fixed since undef is being removed..
Jan 10 2023, 8:06 PM · Restricted Project, Restricted Project
resistor updated the diff for D140836: Do not short circuit hoistIVInc when recomputation of poison flags is needed..

Fix improperly updated testcase.

Jan 10 2023, 8:05 PM · Restricted Project, Restricted Project

Jan 9 2023

resistor added a reviewer for D141349: Remove the ThreadLocal template from LLVM.: majnemer.
Jan 9 2023, 8:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor added a comment to D141349: Remove the ThreadLocal template from LLVM..

Incorporated build fixes for GCC. Waiting for buildbots to complete.

Jan 9 2023, 8:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor requested review of D141349: Remove the ThreadLocal template from LLVM..
Jan 9 2023, 8:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor added a reverting change for rG54d78b639b9c: Remove the ThreadLocal template from LLVM.: rGef9aa34f0274: Revert "Remove the ThreadLocal template from LLVM.".
Jan 9 2023, 8:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor committed rGef9aa34f0274: Revert "Remove the ThreadLocal template from LLVM." (authored by resistor).
Revert "Remove the ThreadLocal template from LLVM."
Jan 9 2023, 8:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor added a reverting change for rG971786254cc4: Fix warning when building with GCC.: rG9a6e84fd2152: Revert "Fix warning when building with GCC.".
Jan 9 2023, 8:22 PM · Restricted Project, Restricted Project
resistor committed rG9a6e84fd2152: Revert "Fix warning when building with GCC." (authored by resistor).
Revert "Fix warning when building with GCC."
Jan 9 2023, 8:22 PM · Restricted Project, Restricted Project
resistor added a reverting change for D141347: Remove the ThreadLocal template from LLVM.: rGef9aa34f0274: Revert "Remove the ThreadLocal template from LLVM.".
Jan 9 2023, 8:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor committed rG971786254cc4: Fix warning when building with GCC. (authored by resistor).
Fix warning when building with GCC.
Jan 9 2023, 8:19 PM · Restricted Project, Restricted Project
resistor committed rG54d78b639b9c: Remove the ThreadLocal template from LLVM. (authored by resistor).
Remove the ThreadLocal template from LLVM.
Jan 9 2023, 8:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor closed D141347: Remove the ThreadLocal template from LLVM..
Jan 9 2023, 8:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor updated the diff for D141347: Remove the ThreadLocal template from LLVM..

Fix nit

Jan 9 2023, 8:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor requested review of D141347: Remove the ThreadLocal template from LLVM..
Jan 9 2023, 7:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
resistor abandoned D122436: Teach the AArch64 backend that vector reduction NEON instructions implicitly zero the high lanes of the result, meaning that we can eliminate explicit zeroing..
Jan 9 2023, 7:26 PM · Restricted Project, Restricted Project
resistor added a comment to D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..

Credit to czwarich for figuring out the algorithm to test for this.

Would be good to add a description.

Jan 9 2023, 7:25 PM · Restricted Project, Restricted Project
resistor abandoned D17065: Defer CWD in MCContext lookup as late as possible..
Jan 9 2023, 7:24 PM · Restricted Project
resistor abandoned D140605: Support unreachable instructions in SimplifyCFG's tail merging..
Jan 9 2023, 7:23 PM · Restricted Project, Restricted Project
resistor updated the diff for D140836: Do not short circuit hoistIVInc when recomputation of poison flags is needed..

Address review feedback.

Jan 9 2023, 7:20 PM · Restricted Project, Restricted Project
resistor abandoned D141251: Replace un-demanded values with undef in BDCE..
Jan 9 2023, 7:16 PM · Restricted Project, Restricted Project
resistor added a comment to D141251: Replace un-demanded values with undef in BDCE..

Removing the FIXME in https://reviews.llvm.org/D141344

Jan 9 2023, 7:15 PM · Restricted Project, Restricted Project
resistor requested review of D141344: Remove a FIXME that will never be fixed since undef is being removed..
Jan 9 2023, 7:15 PM · Restricted Project, Restricted Project

Jan 8 2023

resistor requested review of D141251: Replace un-demanded values with undef in BDCE..
Jan 8 2023, 9:29 PM · Restricted Project, Restricted Project
resistor updated the diff for D141213: Add an AArch64 DAG combine to eliminate unnecessary XTN operations when truncating v1i64 to v1i32..

Update for comment

Jan 8 2023, 7:31 PM · Restricted Project, Restricted Project

Jan 7 2023

resistor updated the diff for D140659: Teach the AArch64 AdvSIMDScalarPass to support a more complete set of opcodes..

Rebase

Jan 7 2023, 10:45 PM · Restricted Project, Restricted Project
resistor requested review of D141213: Add an AArch64 DAG combine to eliminate unnecessary XTN operations when truncating v1i64 to v1i32..
Jan 7 2023, 9:54 PM · Restricted Project, Restricted Project
resistor updated the diff for D141211: Add an AArch64 DAG combine to eliminate redundant truncates feeding into DUPLANE32 operations..

Fix testcase.

Jan 7 2023, 9:51 PM · Restricted Project, Restricted Project
resistor requested review of D141211: Add an AArch64 DAG combine to eliminate redundant truncates feeding into DUPLANE32 operations..
Jan 7 2023, 8:29 PM · Restricted Project, Restricted Project

Jan 4 2023

resistor updated the diff for D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..

Refactor and add more code comments. Update test comments.

Jan 4 2023, 8:27 PM · Restricted Project, Restricted Project
resistor committed rG733740b18936: Fix a phase-ordering problem in SimplifyCFG. (authored by resistor).
Fix a phase-ordering problem in SimplifyCFG.
Jan 4 2023, 3:47 PM · Restricted Project, Restricted Project
resistor closed D140831: Fix a phase-ordering problem in SimplifyCFG..
Jan 4 2023, 3:47 PM · Restricted Project, Restricted Project
resistor updated the diff for D140831: Fix a phase-ordering problem in SimplifyCFG..

Incorporate suggestion

Jan 4 2023, 3:46 PM · Restricted Project, Restricted Project

Jan 3 2023

resistor requested review of D140952: Teach the AArch64 backend to materialize immediates using a pair of ORR-immediate instructions..
Jan 3 2023, 10:25 PM · Restricted Project, Restricted Project
resistor added a comment to D140751: Implement a FIXME for better poison handling in SimplifyCFG..

I have not been able to construct a test for this manually, and didn't find any hits for it in the test-suite.

Jan 3 2023, 9:30 PM · Restricted Project, Restricted Project
resistor updated the diff for D140751: Implement a FIXME for better poison handling in SimplifyCFG..

Update for feedback

Jan 3 2023, 9:30 PM · Restricted Project, Restricted Project
resistor updated the diff for D140836: Do not short circuit hoistIVInc when recomputation of poison flags is needed..

Extract poison fixup logic to a helper and apply it in the short-circuit case without
going through the rest of the hoisting process.

Jan 3 2023, 7:55 PM · Restricted Project, Restricted Project
resistor updated the diff for D140831: Fix a phase-ordering problem in SimplifyCFG..

Restart case iteration when we fold the switch condition.

Jan 3 2023, 2:42 PM · Restricted Project, Restricted Project
resistor committed rGec40c8f6fe84: [ValueTracking] Improve ComputeNumSignBits to handle Trunc (authored by resistor).
[ValueTracking] Improve ComputeNumSignBits to handle Trunc
Jan 3 2023, 2:26 PM · Restricted Project, Restricted Project
resistor closed D140796: [ValueTracking] Improve ComputeNumSignBits to handle Trunc.
Jan 3 2023, 2:26 PM · Restricted Project, Restricted Project

Jan 2 2023

resistor added inline comments to D140796: [ValueTracking] Improve ComputeNumSignBits to handle Trunc.
Jan 2 2023, 9:09 PM · Restricted Project, Restricted Project
resistor updated the diff for D140796: [ValueTracking] Improve ComputeNumSignBits to handle Trunc.

Update for feedback

Jan 2 2023, 9:08 PM · Restricted Project, Restricted Project
resistor updated the diff for D140831: Fix a phase-ordering problem in SimplifyCFG..

Reduce test case.

Jan 2 2023, 9:00 PM · Restricted Project, Restricted Project

Jan 1 2023

resistor requested review of D140836: Do not short circuit hoistIVInc when recomputation of poison flags is needed..
Jan 1 2023, 9:29 PM · Restricted Project, Restricted Project
resistor updated the diff for D140751: Implement a FIXME for better poison handling in SimplifyCFG..

Update for comments

Jan 1 2023, 8:29 PM · Restricted Project, Restricted Project
resistor added a comment to D140751: Implement a FIXME for better poison handling in SimplifyCFG..

I don't have a test that exercises this, just following up on the FIXME comments.

Jan 1 2023, 8:28 PM · Restricted Project, Restricted Project
resistor updated the diff for D140796: [ValueTracking] Improve ComputeNumSignBits to handle Trunc.

Update for test comments and add tests.

Jan 1 2023, 8:21 PM · Restricted Project, Restricted Project
resistor added inline comments to D140796: [ValueTracking] Improve ComputeNumSignBits to handle Trunc.
Jan 1 2023, 8:12 PM · Restricted Project, Restricted Project
resistor requested review of D140831: Fix a phase-ordering problem in SimplifyCFG..
Jan 1 2023, 5:20 PM · Restricted Project, Restricted Project

Dec 30 2022

resistor requested review of D140796: [ValueTracking] Improve ComputeNumSignBits to handle Trunc.
Dec 30 2022, 10:13 PM · Restricted Project, Restricted Project

Dec 28 2022

resistor requested review of D140751: Implement a FIXME for better poison handling in SimplifyCFG..
Dec 28 2022, 10:07 PM · Restricted Project, Restricted Project
resistor committed rG88e85aa58006: Handle simple diamond CFG hoisting in DivRemPairs. (authored by resistor).
Handle simple diamond CFG hoisting in DivRemPairs.
Dec 28 2022, 10:24 AM · Restricted Project, Restricted Project
resistor closed D140647: Handle simple diamond CFG hoisting in DivRemPairs..
Dec 28 2022, 10:24 AM · Restricted Project, Restricted Project
resistor updated the diff for D140647: Handle simple diamond CFG hoisting in DivRemPairs..

Fix typo.

Dec 28 2022, 10:23 AM · Restricted Project, Restricted Project

Dec 27 2022

resistor updated the diff for D140647: Handle simple diamond CFG hoisting in DivRemPairs..

Update based on feedback.

Dec 27 2022, 9:10 PM · Restricted Project, Restricted Project

Dec 25 2022

resistor updated the diff for D140647: Handle simple diamond CFG hoisting in DivRemPairs..

Add negative tests. Enhance comments to explain the profitability heuristic.
Attempt to fix pre-existing correctness concerns WRT non-transferring predecessors.

Dec 25 2022, 8:00 PM · Restricted Project, Restricted Project
resistor committed rGf34847e112ac: [NFC] Elminate some needless nested-map complexity. (authored by resistor).
[NFC] Elminate some needless nested-map complexity.
Dec 25 2022, 6:36 PM · Restricted Project, Restricted Project
resistor closed D140648: [NFC] Elminate some needless nested-map complexity..
Dec 25 2022, 6:36 PM · Restricted Project, Restricted Project
resistor updated the diff for D140648: [NFC] Elminate some needless nested-map complexity..

Rebase

Dec 25 2022, 6:36 PM · Restricted Project, Restricted Project
resistor committed rG50b311dea3bf: Remove workaround for libstdc++ 4.8. (authored by resistor).
Remove workaround for libstdc++ 4.8.
Dec 25 2022, 6:33 PM · Restricted Project, Restricted Project
resistor closed D140656: Remove workaround for libstdc++ 4.8..
Dec 25 2022, 6:33 PM · Restricted Project, Restricted Project
resistor updated the diff for D140656: Remove workaround for libstdc++ 4.8..

Rebase

Dec 25 2022, 6:33 PM · Restricted Project, Restricted Project

Dec 24 2022

resistor added a reviewer for D140659: Teach the AArch64 AdvSIMDScalarPass to support a more complete set of opcodes.: t.p.northover.
Dec 24 2022, 10:54 PM · Restricted Project, Restricted Project