Page MenuHomePhabricator

resistor (Owen Anderson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 11:19 PM (520 w, 1 d)

Recent Activity

May 26 2022

resistor added a reverting change for rG1e9114984490: Replace the custom linked list in LeaderTableEntry with TinyPtrVector.: rG939a43461ba3: Revert "Replace the custom linked list in LeaderTableEntry with TinyPtrVector.".
May 26 2022, 9:51 AM · Restricted Project, Restricted Project
resistor committed rG939a43461ba3: Revert "Replace the custom linked list in LeaderTableEntry with TinyPtrVector." (authored by resistor).
Revert "Replace the custom linked list in LeaderTableEntry with TinyPtrVector."
May 26 2022, 9:51 AM · Restricted Project, Restricted Project
resistor added a reverting change for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector.: rG939a43461ba3: Revert "Replace the custom linked list in LeaderTableEntry with TinyPtrVector.".
May 26 2022, 9:51 AM · Restricted Project, Restricted Project

May 25 2022

resistor committed rG1e9114984490: Replace the custom linked list in LeaderTableEntry with TinyPtrVector. (authored by resistor).
Replace the custom linked list in LeaderTableEntry with TinyPtrVector.
May 25 2022, 11:53 PM · Restricted Project, Restricted Project
resistor closed D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..
May 25 2022, 11:52 PM · Restricted Project, Restricted Project
resistor updated the diff for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Rebase and address lints

May 25 2022, 11:51 PM · Restricted Project, Restricted Project

May 20 2022

resistor added a comment to D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Ping

May 20 2022, 10:24 PM · Restricted Project, Restricted Project

May 12 2022

resistor updated the diff for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Replicate the leader table insertion ordering of the old linked list.

May 12 2022, 7:54 PM · Restricted Project, Restricted Project
resistor added a comment to D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..
May 12 2022, 7:26 PM · Restricted Project, Restricted Project

May 11 2022

resistor updated the diff for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Format

May 11 2022, 12:12 PM · Restricted Project, Restricted Project
resistor updated the diff for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Fix accidentally walking off of the end of the BB vector.

May 11 2022, 12:11 PM · Restricted Project, Restricted Project
resistor updated the diff for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Fix condition.wq

May 11 2022, 11:24 AM · Restricted Project, Restricted Project

May 10 2022

resistor added inline comments to D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..
May 10 2022, 9:20 AM · Restricted Project, Restricted Project
resistor updated the diff for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..

Address review feedback.

May 10 2022, 9:20 AM · Restricted Project, Restricted Project

May 8 2022

resistor added a reviewer for D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector.: asbirlea.
May 8 2022, 10:40 PM · Restricted Project, Restricted Project
resistor requested review of D125205: Replace the custom linked list in LeaderTableEntry with TinyPtrVector..
May 8 2022, 10:38 PM · Restricted Project, Restricted Project

May 3 2022

resistor removed a reviewer for D120958: [TableGen] Add support for variable length instruction in decoder generator: resistor.
May 3 2022, 9:59 AM · Restricted Project, Restricted Project

Apr 3 2022

resistor added a comment to D122436: Teach the AArch64 backend that vector reduction NEON instructions implicitly zero the high lanes of the result, meaning that we can eliminate explicit zeroing..

Ping

Apr 3 2022, 10:21 PM · Restricted Project, Restricted Project

Mar 29 2022

resistor added a reviewer for D122436: Teach the AArch64 backend that vector reduction NEON instructions implicitly zero the high lanes of the result, meaning that we can eliminate explicit zeroing.: greened.
Mar 29 2022, 10:51 AM · Restricted Project, Restricted Project

Mar 24 2022

resistor requested review of D122436: Teach the AArch64 backend that vector reduction NEON instructions implicitly zero the high lanes of the result, meaning that we can eliminate explicit zeroing..
Mar 24 2022, 2:42 PM · Restricted Project, Restricted Project

Feb 23 2022

resistor committed rGd7105e76319c: Teach the AArch64 backend to instruction select the BCAX instruction. (authored by resistor).
Teach the AArch64 backend to instruction select the BCAX instruction.
Feb 23 2022, 4:00 PM
resistor closed D120112: Teach the AArch64 backend to instruction select the BCAX instruction..
Feb 23 2022, 3:59 PM · Restricted Project

Feb 22 2022

resistor committed rG4745c994e4a7: Set std::numeric_limits<>::tinyness_before to true for floating point types on… (authored by resistor).
Set std::numeric_limits<>::tinyness_before to true for floating point types on…
Feb 22 2022, 3:49 PM
resistor closed D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..
Feb 22 2022, 3:49 PM · Restricted Project

Feb 21 2022

resistor added a comment to D120112: Teach the AArch64 backend to instruction select the BCAX instruction..

You have the operands in the wrong order,

Feb 21 2022, 9:57 PM · Restricted Project
resistor updated the diff for D120112: Teach the AArch64 backend to instruction select the BCAX instruction..

Fix operand order.

Feb 21 2022, 9:57 PM · Restricted Project

Feb 18 2022

resistor requested review of D120112: Teach the AArch64 backend to instruction select the BCAX instruction..
Feb 18 2022, 12:16 AM · Restricted Project
resistor added a comment to D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Ping

Feb 18 2022, 12:01 AM · Restricted Project

Feb 10 2022

resistor updated the diff for D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Rebase

Feb 10 2022, 1:31 PM · Restricted Project

Feb 7 2022

resistor added a comment to D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Ping

Feb 7 2022, 10:54 AM · Restricted Project

Jan 30 2022

resistor added a comment to D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

@ldionne Ping

Jan 30 2022, 7:48 PM · Restricted Project

Jan 12 2022

resistor added a comment to D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Do we also need to test for __aarch64__? https://developer.arm.com/documentation/dui0774/g/chr1383660321827 says that __arm__ is only defined for 32-bit targets.

Jan 12 2022, 9:41 AM · Restricted Project
resistor updated the diff for D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Add arch64 to detect AArch64 properly.

Jan 12 2022, 9:41 AM · Restricted Project

Jan 11 2022

resistor added a comment to D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Which ones were not working? It might be reasonable to XFAIL that part of the test for non mainstream compilers? Technically we only support recent Clangs and GCCs, which I would assume should handle this properly.

Jan 11 2022, 10:41 AM · Restricted Project

Dec 29 2021

resistor updated the diff for D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Remove the platform verification test. Unfortunately, getting this to work consistently
across different compilers isn't really tractable given the state of strict floating point
support in various compilers/versions.

Dec 29 2021, 11:39 AM · Restricted Project
resistor added inline comments to D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..
Dec 29 2021, 10:26 AM · Restricted Project
resistor updated the diff for D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Fix oversight where std::nextafter was always specialized on double rather than the type under test.

Dec 29 2021, 10:25 AM · Restricted Project

Dec 28 2021

resistor updated the diff for D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..

Update tests to account for the change in behavior, and add a
specific test that checks the value of tinyness_before against
the actual platform behavior.

Dec 28 2021, 8:06 PM · Restricted Project
resistor updated the summary of D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..
Dec 28 2021, 11:52 AM · Restricted Project
resistor requested review of D116338: Set std::numeric_limits<>::tinyness_before to true for floating point types on ARM platforms..
Dec 28 2021, 11:51 AM · Restricted Project

Sep 21 2021

resistor committed rGb5fbbdd2025f: Teach InstCombine to eliminate malloc-realloc-free triplets. (authored by resistor).
Teach InstCombine to eliminate malloc-realloc-free triplets.
Sep 21 2021, 11:08 AM
resistor closed D109988: Teach InstCombine to eliminate malloc-realloc-free triplets..
Sep 21 2021, 11:08 AM · Restricted Project
resistor updated the diff for D109988: Teach InstCombine to eliminate malloc-realloc-free triplets..

Squash

Sep 21 2021, 11:07 AM · Restricted Project
resistor added a reviewer for D109988: Teach InstCombine to eliminate malloc-realloc-free triplets.: majnemer.
Sep 21 2021, 9:18 AM · Restricted Project

Sep 17 2021

resistor updated the diff for D109988: Teach InstCombine to eliminate malloc-realloc-free triplets..
  • Teach InstCombine to remove the realloc from free(realloc(...)).
Sep 17 2021, 4:26 PM · Restricted Project
resistor requested review of D109988: Teach InstCombine to eliminate malloc-realloc-free triplets..
Sep 17 2021, 11:30 AM · Restricted Project

Sep 15 2021

resistor committed rG68079ef0eb01: Teach SimplifyCFG to fold switches into lookup tables in more cases. (authored by resistor).
Teach SimplifyCFG to fold switches into lookup tables in more cases.
Sep 15 2021, 3:07 PM
resistor closed D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 15 2021, 3:07 PM · Restricted Project
resistor added inline comments to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 15 2021, 2:10 PM · Restricted Project
resistor updated the diff for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Add negative test for ptrtoint.

Sep 15 2021, 2:10 PM · Restricted Project
resistor added inline comments to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 15 2021, 2:03 PM · Restricted Project
resistor updated the diff for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Add a negative test for non-inbounds GEPs.

Sep 15 2021, 1:24 PM · Restricted Project
resistor added inline comments to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 15 2021, 1:18 PM · Restricted Project
resistor added inline comments to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 15 2021, 1:17 PM · Restricted Project
resistor updated the diff for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Update for comments.

Sep 15 2021, 1:16 PM · Restricted Project

Sep 14 2021

resistor updated the diff for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Update for comments.

Sep 14 2021, 8:44 AM · Restricted Project

Sep 12 2021

resistor added inline comments to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 12 2021, 11:13 PM · Restricted Project
resistor updated the diff for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Update for comments.

Sep 12 2021, 11:13 PM · Restricted Project

Sep 10 2021

resistor added a comment to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Won't this also skip non-zero-offset GEP's?

Sep 10 2021, 7:28 PM · Restricted Project
resistor updated the diff for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..

Update based on comments to preserve original behavior of shouldBuildLookupTablesForConstant().

Sep 10 2021, 3:29 PM · Restricted Project
resistor added inline comments to D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 10 2021, 3:26 PM · Restricted Project

Sep 9 2021

resistor added a reviewer for D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases.: pcwalton.
Sep 9 2021, 10:15 PM · Restricted Project
resistor requested review of D109565: Teach SimplifyCFG to fold switches into lookup tables in more cases..
Sep 9 2021, 10:13 PM · Restricted Project

Aug 30 2021

resistor committed rGdb9de22f2b69: Teach the AArch64 backend patterns to generate the EOR3 instruction. (authored by resistor).
Teach the AArch64 backend patterns to generate the EOR3 instruction.
Aug 30 2021, 1:01 PM
resistor closed D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..
Aug 30 2021, 1:01 PM · Restricted Project

Aug 29 2021

resistor updated the diff for D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..

Update tests for comments.

Aug 29 2021, 8:33 PM · Restricted Project

Aug 27 2021

resistor added inline comments to D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..
Aug 27 2021, 2:28 PM · Restricted Project
resistor added inline comments to D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..
Aug 27 2021, 10:52 AM · Restricted Project
resistor updated the diff for D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..

Update for comments.

Aug 27 2021, 10:52 AM · Restricted Project

Aug 26 2021

resistor updated the diff for D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..

Use CHECK-LABEL

Aug 26 2021, 4:33 PM · Restricted Project
resistor requested review of D108793: Teach the AArch64 backend patterns to generate the EOR3 instruction..
Aug 26 2021, 3:52 PM · Restricted Project

Aug 19 2021

resistor committed rG06a4c858901d: Use v16i8 rather than v2i64 as the VT for memset expansion on AArch64. (authored by resistor).
Use v16i8 rather than v2i64 as the VT for memset expansion on AArch64.
Aug 19 2021, 9:54 AM
resistor closed D108354: Use v16i8 rather than v2i64 as the VT for memset expansion on AArch64..
Aug 19 2021, 9:54 AM · Restricted Project
resistor added a reviewer for D108354: Use v16i8 rather than v2i64 as the VT for memset expansion on AArch64.: danlark.
Aug 19 2021, 1:08 AM · Restricted Project
resistor requested review of D108354: Use v16i8 rather than v2i64 as the VT for memset expansion on AArch64..
Aug 19 2021, 1:06 AM · Restricted Project

Mar 19 2021

resistor accepted D98985: [test] Enable check-lsan on aarch64-*-linux.
Mar 19 2021, 1:38 PM · Restricted Project

Nov 11 2020

resistor added inline comments to D91271: [AArch64] Attempt to sink mul operands.
Nov 11 2020, 12:01 PM · Restricted Project

Nov 3 2020

resistor accepted D90605: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask)..
Nov 3 2020, 10:22 AM · Restricted Project

Nov 2 2020

resistor added a comment to D90606: [llvm][AArch64] Allow TB(N)Z to drop signext for sign bit tests..

Do we need to handle the same pattern for non IN_REG variations?

Nov 2 2020, 10:27 AM · Restricted Project
resistor added inline comments to D90605: [llvm][AArch64] Simplify (and (sign_extend..) #bitmask)..
Nov 2 2020, 10:24 AM · Restricted Project

Oct 29 2020

resistor added a comment to D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..

I'll be the dissenting voice: I don't think this is the right approach. "It's what gas does" is not a sufficient reason to break user code. I think a warning and *possibly* removing support some time well in the future is the right solution here.

Oct 29 2020, 11:57 AM · Restricted Project

Oct 28 2020

resistor accepted D90144: [Scheduling] Fall back to the fast cluster algorithm if the DAG is too complex.
Oct 28 2020, 11:42 AM · Restricted Project

Oct 26 2020

resistor added a comment to D90144: [Scheduling] Fall back to the fast cluster algorithm if the DAG is too complex.

Did the concept of using the static DAG not work?

Oct 26 2020, 9:59 AM · Restricted Project

Sep 22 2020

resistor accepted D88117: [AArch64][SVE] Fix frame offset calculation when d8 is saved..

Nice catch, LGTM.

Sep 22 2020, 3:38 PM · Restricted Project
resistor accepted D88035: [AArch64] Teach analyzeBranch to remove branch equivelent to fallthrough.

LGTM

Sep 22 2020, 12:10 PM · Restricted Project

Sep 21 2020

resistor added inline comments to D88035: [AArch64] Teach analyzeBranch to remove branch equivelent to fallthrough.
Sep 21 2020, 2:54 PM · Restricted Project

Sep 10 2020

resistor committed rG3d9c85e4d85b: Mark FMOV constant materialization as being as cheap as a move. (authored by resistor).
Mark FMOV constant materialization as being as cheap as a move.
Sep 10 2020, 9:39 AM
resistor closed D87316: Mark FMOV constant materialization as being as cheap as a move..
Sep 10 2020, 9:39 AM · Restricted Project

Sep 9 2020

resistor added a reviewer for D87316: Mark FMOV constant materialization as being as cheap as a move.: efriedma.
Sep 9 2020, 11:23 PM · Restricted Project

Sep 8 2020

resistor added a reviewer for D87316: Mark FMOV constant materialization as being as cheap as a move.: t.p.northover.
Sep 8 2020, 11:47 AM · Restricted Project
resistor requested review of D87316: Mark FMOV constant materialization as being as cheap as a move..
Sep 8 2020, 11:45 AM · Restricted Project

Sep 2 2020

resistor added a comment to D87063: [BitcodeReader] Fix O(N^2) in placeholder replacement algorithm..

If the maps are typically small, would SmallDenseMap make sense?

Sep 2 2020, 4:22 PM · Restricted Project

Sep 1 2020

resistor added a reverting change for rGbc9a29b9ee6a: Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain": rG5987da8764b7: Revert "Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain"".
Sep 1 2020, 12:29 PM
resistor committed rG5987da8764b7: Revert "Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain"" (authored by resistor).
Revert "Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain""
Sep 1 2020, 12:29 PM

Aug 28 2020

resistor added a reverting change for rG6102310d814a: [InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block: rGed90f15efb40: Revert "[InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block".
Aug 28 2020, 4:44 PM
resistor committed rGed90f15efb40: Revert "[InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block" (authored by resistor).
Revert "[InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block"
Aug 28 2020, 4:44 PM

Aug 27 2020

resistor committed rGe9d9a612084b: Reapply D70800: Fix AArch64 AAPCS frame record chain (authored by resistor).
Reapply D70800: Fix AArch64 AAPCS frame record chain
Aug 27 2020, 10:30 AM
resistor closed D70800: Fix AArch64 AAPCS frame record chain.
Aug 27 2020, 10:30 AM · Restricted Project

Aug 26 2020

resistor committed rG9936455204fd: Reapply D70800: Fix AArch64 AAPCS frame record chain (authored by resistor).
Reapply D70800: Fix AArch64 AAPCS frame record chain
Aug 26 2020, 12:39 PM
resistor reopened D86387: Fix frame pointer layout on AArch64 Linux..
Aug 26 2020, 10:48 AM · Restricted Project