This is an archive of the discontinued LLVM Phabricator instance.

Differential D159400

[RISCV][NFC] precommit for D159399
ClosedPublic

Authored by BeMg on Sep 2 2023, 4:00 AM.

Details

Reviewers
kito-cheng
craig.topper
Commits
rGd861b3183cb0: [RISCV][NFC] precommit for D159399

Diff Detail

Event Timeline

BeMg created this revision.Sep 2 2023, 4:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2023, 4:00 AM
Herald added subscribers: jobnoorman, luke, sunshaoce and 28 others. · View Herald Transcript
BeMg requested review of this revision.Sep 2 2023, 4:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2023, 4:00 AM
Herald added subscribers: llvm-commits, wangpc, eopXD, MaskRay. · View Herald Transcript
BeMg retitled this revision from [RISCV][NFC] precommit to [RISCV][NFC] precommit for D159399.Sep 2 2023, 4:01 AM
BeMg added a child revision: D159399: [RISCV] Only emit .option when extension is supported.
BeMg added reviewers: kito-cheng, craig.topper.Sep 2 2023, 4:08 AM
Harbormaster completed remote builds in B256409: Diff 555580.Sep 2 2023, 4:33 AM
BeMg added a comment.Sep 17 2023, 7:43 PM

ping

craig.topper accepted this revision.Sep 17 2023, 8:00 PM

LGTM

This revision is now accepted and ready to land.Sep 17 2023, 8:00 PM
Closed by commit rGd861b3183cb0: [RISCV][NFC] precommit for D159399 (authored by BeMg). · Explain WhySep 18 2023, 12:18 AM
This revision was automatically updated to reflect the committed changes.
BeMg added a commit: rGd861b3183cb0: [RISCV][NFC] precommit for D159399.

Revision Contents

PathSize
llvm/
test/
CodeGen/
RISCV/
8 lines

Diff 556929

llvm/test/CodeGen/RISCV/riscv-func-target-feature.ll

Show All 28 Lines
; CHECK-NOT: .option push ; CHECK-NOT: .option push
define void @test4() { define void @test4() {
; CHECK-LABEL: test4 ; CHECK-LABEL: test4
; CHECK-NOT: .option pop ; CHECK-NOT: .option pop
entry: entry:
ret void ret void
} }
; CHECK: .option push
define void @test5() "target-features"="+unaligned-scalar-mem" {
; CHECK-LABEL: test5
; CHECK: .option pop
entry:
ret void
}