This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Remove Myriad.cpp
ClosedPublic

Authored by MaskRay on Aug 23 2023, 11:10 PM.

Details

Summary

I am trying to clean up GCCInstallationDetector::init and noticed that
Myriad.cpp is the only toolchain using ExtraTripleAliases. This is a
little overhead, but I figured that Myriad.cpp is unused.
Its sanitizer runtime part was removed in 2021 by D104279. It seems time
to retire it.

Diff Detail

Event Timeline

MaskRay created this revision.Aug 23 2023, 11:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 11:10 PM
MaskRay requested review of this revision.Aug 23 2023, 11:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 11:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
waltl accepted this revision.Aug 23 2023, 11:15 PM
This revision is now accepted and ready to land.Aug 23 2023, 11:15 PM
brad added inline comments.Aug 24 2023, 12:54 AM
clang/lib/Driver/ToolChains/Gnu.cpp
2958

You might as well remove this.

MaskRay marked an inline comment as done.Aug 24 2023, 6:38 PM
MaskRay added inline comments.
clang/lib/Driver/ToolChains/Gnu.cpp
2958

Will do!

This revision was landed with ongoing or failed builds.Aug 24 2023, 6:44 PM
This revision was automatically updated to reflect the committed changes.
MaskRay marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 6:44 PM
MaskRay added inline comments.Aug 24 2023, 7:26 PM
clang/lib/Driver/ToolChains/Gnu.cpp
2958

There is some Myriad remaining in Sparc.cpp, which can be cleaned up later...

clang/test/Driver/Inputs/basic_myriad_tree/lib/gcc/sparc-myriad-rtems/6.3.0/crti.o