This is an archive of the discontinued LLVM Phabricator instance.

Implement __builtin_fmaximum/fminimum*
Needs ReviewPublic

Authored by tra on Aug 17 2023, 5:27 PM.

Details

Reviewers
fhahn
Summary

The builtins provide FP min/max conforming to IEEE754-2018 standard.

Diff Detail

Event Timeline

tra created this revision.Aug 17 2023, 5:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 5:27 PM
Herald added a subscriber: bixia. · View Herald Transcript
tra updated this revision to Diff 551336.Aug 17 2023, 5:29 PM

formatting cleanup

tra updated this revision to Diff 551338.Aug 17 2023, 5:31 PM

clang-formatted new tests.

tra published this revision for review.Aug 18 2023, 12:02 PM
tra added a reviewer: fhahn.
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 12:02 PM
tra added a comment.Aug 18 2023, 12:02 PM

@fhahn who else should take a look at the patch?

tra updated this revision to Diff 551646.Aug 18 2023, 2:45 PM

Fixed test RUN lines

LGTM, the fmaximum/fminimum fallback support backends has been blocking us for a while in IREE. This patch is a welcome addition to start the support for this. I will let @fhahn accept the patch, since I'm not an expert in this part of code.