This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Autogenerate the fmuladd.f16.ll and llvm.fmuladd.f16.ll codegen tests.
ClosedPublic

Authored by kosarev on Aug 15 2023, 5:02 AM.

Diff Detail

Event Timeline

kosarev created this revision.Aug 15 2023, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:02 AM
kosarev requested review of this revision.Aug 15 2023, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:02 AM
foad added a comment.Aug 15 2023, 5:11 AM

fmuladd.f16.ll and llvm.fmuladd.f16.ll

Do we really need both? Are they testing different things?

No objection to the patch itself.

Do we really need both? Are they testing different things?

fmuladd.f16.ll seems to test negated operands, which llvm.fmuladd.f16.ll doesn't test whereas llvm.fmuladd.f16.ll tests @llvm.fmuladd.v2f16(), which fmuladd.f16.ll doesn't. So looks like these can be combined, but I'm not sure about the differences in the RUN lines; they use different combinations of -denormal-fp-math and -denormal-fp-math-f32.

This revision is now accepted and ready to land.Aug 15 2023, 6:48 AM
This revision was landed with ongoing or failed builds.Aug 16 2023, 4:49 AM
This revision was automatically updated to reflect the committed changes.