This is an archive of the discontinued LLVM Phabricator instance.

Revert "[mlir][Arith] Add arith.is_nan and arith.is_inf predicates"
ClosedPublic

Authored by krzysz00 on Aug 9 2023, 12:34 PM.

Details

Summary

This reverts commit 7c349c369847dc2f1736efb9c90d03521cd44a90.

Per discussion at
https://reviews.llvm.org/rG7c349c369847dc2f1736efb9c90d03521cd44a90
and elsewhere, the lowering to LLVM defined here isn't what it should
be and the fastmath flag usage isn't correct, so arith.is_nan and
arith.is_inf cannot exist in their current form.

It's unclear if those operations should be introduced in the future,
since they make the dialect more complex and don't add any expressive
power. Further discussion may be moved to an RFC (or I'll drop this
patch).

Diff Detail

Event Timeline

krzysz00 created this revision.Aug 9 2023, 12:34 PM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a reviewer: kuhar. · View Herald Transcript
Herald added a reviewer: kuhar. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
krzysz00 requested review of this revision.Aug 9 2023, 12:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2023, 7:13 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.