Could use more work for vectors.
Details
Details
Diff Detail
Diff Detail
Event Timeline
| llvm/test/CodeGen/AArch64/GlobalISel/uaddo-8-16-bits.mir | ||
|---|---|---|
| 27 | update_mir_test_checks is just broken here | |
| llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h | ||
|---|---|---|
| 641–645 | nit: could remove the second comment and just put the decls right next to each other. | |
| llvm/lib/CodeGen/GlobalISel/Utils.cpp | ||
| 785 | nit: put DstTy.getScalarSizeInBits() in a variable | |
| llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-binop-same-val.mir | ||
| 29 | lost comments in this file | |
| llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-bzero.mir | ||
| 21 | ditto | |
| llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-trivial-arith.mir | ||
| 29 | ditto | |
| llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h | ||
|---|---|---|
| 641–645 | I think doxygen only handles that when they have the same name, these are different | |
Comment Actions
LGTM but rebase & retest since MIR patterns landed, it should solve a regression we saw during review
nit: could remove the second comment and just put the decls right next to each other.