This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add more tests for sincos recognition
ClosedPublic

Authored by arsenm on Jul 31 2023, 7:42 AM.

Details

Reviewers
jhuber6
rampitec
yaxunl
vpykhtin
dfukalov
jmmartinez
Group Reviewers
Restricted Project
Summary

These show both broken cases and cases which are handled too
conservatively.

Diff Detail

Event Timeline

arsenm created this revision.Jul 31 2023, 7:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 7:42 AM
arsenm requested review of this revision.Jul 31 2023, 7:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 7:42 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added inline comments.Jul 31 2023, 7:43 AM
llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.weak.ll
7

These should probably be weak definitions, not sure if you're supposed to builtin recognize weak definitions

arsenm updated this revision to Diff 545723.Jul 31 2023, 9:59 AM
arsenm updated this revision to Diff 545735.Jul 31 2023, 10:27 AM
yaxunl accepted this revision as: yaxunl.Aug 1 2023, 11:11 AM

LGTM

This revision is now accepted and ready to land.Aug 1 2023, 11:11 AM