Finishes implementation of
- P2093R14 Formatted output
- P2539R4 Should the output of std::print to a terminal be synchronized with the underlying stream?
Paths
| Differential D156609
[libc++][print] Adds ostream overloads. AbandonedPublic Authored by Mordante on Jul 30 2023, 3:41 AM.
Details
Summary Finishes implementation of
Diff Detail
Unit TestsFailed Event TimelineComment Actions Just skimmed over it. I do not know enough about std::print for an in-depth review, hence just a couple of typos
philnik added inline comments.
Comment Actions Thanks for the reviews!
ldionne added inline comments.
ldionne added inline comments.
This revision now requires changes to proceed.Sep 6 2023, 9:45 AM Comment Actions Rebased and addresses parts of the review comments. Mordante marked 2 inline comments as done. Comment ActionsRebased and partly addresses review comments.
Comment Actions Undoes changes to __availability that were a badly resolved merge conflict. This gave build issues with GCC. Comment Actions Since the CI for Phabricator is turned off this review has been replaced by https://github.com/llvm/llvm-project/pull/73262
Revision Contents
Diff 545416 libcxx/docs/ImplementationDefinedBehavior.rst
libcxx/docs/ReleaseNotes/18.rst
libcxx/docs/Status/Cxx23Papers.csv
libcxx/docs/Status/FormatIssues.csv
libcxx/docs/Status/FormatPaper.csv
libcxx/docs/index.rst
libcxx/include/fstream
libcxx/include/ostream
libcxx/include/print
libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.nonew.abilist
libcxx/src/CMakeLists.txt
libcxx/src/ostream.cpp
libcxx/src/std_stream.h
libcxx/test/libcxx/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/vprint_unicode.pass.cpp
libcxx/test/libcxx/transitive_includes/cxx03.csv
libcxx/test/libcxx/transitive_includes/cxx11.csv
libcxx/test/libcxx/transitive_includes/cxx14.csv
libcxx/test/libcxx/transitive_includes/cxx17.csv
libcxx/test/libcxx/transitive_includes/cxx23.csv
libcxx/test/libcxx/transitive_includes/cxx26.csv
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/locale-specific_form.pass.cpp
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/print.pass.cpp
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/print_tests.h
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/println.pass.cpp
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/vprint_nonunicode.pass.cpp
libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.formatted.print/vprint_unicode.pass.cpp
libcxx/utils/ci/buildkite-pipeline.yml
libcxx/utils/generate_feature_test_macro_components.py
|
Also I think this entry is not sufficiently clear right now. You should explain what implementation-defined behavior you're talking about. Maybe provide a link to the section of the std you're talking about?