This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Set dead on scc on manually selected instructions
ClosedPublic

Authored by arsenm on Jul 28 2023, 5:37 AM.

Details

Reviewers
Pierre-vh
Petar.Avramovic
mbrkusanin
aemerson
foad
Joe_Nash
Group Reviewers
Restricted Project
Summary

In SelectionDAG InstrEmitter automatically puts dead flags on unused
physreg defs everywhere. The generated selectors should also set dead
on physreg defs that were not used in the pattern.

Diff Detail

Event Timeline

arsenm created this revision.Jul 28 2023, 5:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 5:37 AM
arsenm requested review of this revision.Jul 28 2023, 5:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 5:37 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 545118.Jul 28 2023, 5:53 AM
arsenm edited the summary of this revision. (Show Details)

uadde case works fine

Joe_Nash accepted this revision.Jul 28 2023, 10:36 AM
Joe_Nash added a subscriber: Joe_Nash.

LGTM

This revision is now accepted and ready to land.Jul 28 2023, 10:36 AM