Details
- Reviewers
nemanjai jhibbits shchenz - Commits
- rG696ea67f197f: Disable call to fma for soft-float
Diff Detail
Event Timeline
Apologies for updating diff too many times, used arcanist first time. Won't happend again!
compiler-rt builtins library should not just undefining fma for PPC, right (see https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html)? If so, maybe we should at least first try not generating fma for soft-float at the first place where fmul + fadd is fused, like tryEmitFMulAdd in clang front end?
I actually raised D154605 for that one, but it's only for X86.
I was relying on target-features containing "+fma", which is wrong. The review was raised just to get feedback from community working on various targets.
Plan is to disable fma-intrinsic from IR for all targets which doesn't support fma.
Thanks. I think soft-float looks like a candidate for the hasFMA function in D154605.