This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove unused check prefixes for tests. NFC
ClosedPublic

Authored by Jim on Jul 23 2023, 12:54 AM.

Details

Summary

Also remove the warning line for that these prefixes are unused.

Diff Detail

Event Timeline

Jim created this revision.Jul 23 2023, 12:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2023, 12:54 AM
Jim requested review of this revision.Jul 23 2023, 12:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2023, 12:54 AM
This revision is now accepted and ready to land.Jul 23 2023, 6:16 PM
This revision was automatically updated to reflect the committed changes.
asb added a comment.Jul 24 2023, 8:35 AM

I'm not overly opposed to this having landed, but I'll point out the flip-side of removing these (currently) unsued prefixes is that if future codegen or test changes make use of them, we won't automatically get the benefit of deduplicated checks (in the case of shared prefixes being removed) or will have to go and manually add back a new check prefix (in the case of common prefixes no longer being sufficient due to test output diverging).

This patch is fine, and it's not a huge deal either way, but for the record my current view is I wouldn't be in favour of ripping out all future unused prefixes as soon as they appear.

I think it depends on whether there's the expectation that they should be sharing lines or not