[OpenMP][Plugin] Update the global address calculation

[tianshilei1992]

Summary

Current global address caculation doesn't work for AMDGPU in some cases (https://reviews.llvm.org/D142569#4506212).
The root cause is the sh_addr is not substracted when caculating the address.

[jhuber6]

What is the special case that makes this not work? I figured this was working in general since I've used it for the rpc symbol as well.

[tianshilei1992]

rebase

[jdoerfert]

In D155886#4520660, @jhuber6 wrote:

What is the special case that makes this not work? I figured this was working in general since I've used it for the rpc symbol as well.

It seems to depend on the section the data ends up in. Not 100% sure. If this doesn't break anyone, it's good.

[tianshilei1992]

remove the overloaded AMDGPU version

[tianshilei1992]

I'm gonna land this patch and see if AMD's buildbot is happy.

openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp

if (SymbolSize != DeviceGlobal.getSize())
           DeviceGlobal.getName().data(), SymbolSize,
           (size_t)DeviceGlobal.getSize());
 
     // Store the symbol address on the device global metadata.
     DeviceGlobal.setPtr(reinterpret_cast<void *>(SymbolAddr));
 
     return Plugin::success();
   }
-
-private:
-  /// Extract the global's information from the ELF image, section, and symbol.
-  Error getGlobalMetadataFromELF(const DeviceImageTy &Image,
-                                 const ELF64LE::Sym &Symbol,
-                                 const ELF64LE::Shdr &Section,
-                                 GlobalTy &ImageGlobal) override {
-    // The global's address in AMDGPU is computed as the image begin + the ELF
-    // symbol value. Notice we do not add the ELF section offset.
-    ImageGlobal.setPtr(advanceVoidPtr(Image.getStart(), Symbol.st_value));
-
-    // Set the global's size.
-    ImageGlobal.setSize(Symbol.st_size);
-
-    return Plugin::success();
-  }
 };
 
 /// Class implementing the AMDGPU-specific functionalities of the plugin.
 struct AMDGPUPluginTy final : public GenericPluginTy {
   /// Create an AMDGPU plugin and initialize the AMDGPU driver.
   AMDGPUPluginTy()
       : GenericPluginTy(getTripleArch()), Initialized(false),
         HostDevice(nullptr) {}

openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.cpp

 }
 
 Error GenericGlobalHandlerTy::getGlobalMetadataFromELF(
     const DeviceImageTy &Image, const ELF64LE::Sym &Symbol,
     const ELF64LE::Shdr &Section, GlobalTy &ImageGlobal) {
 
   // The global's address is computed as the image begin + the ELF section
   // offset + the ELF symbol value.
-  ImageGlobal.setPtr(
-      advanceVoidPtr(Image.getStart(), Section.sh_offset + Symbol.st_value));
+  ImageGlobal.setPtr(advanceVoidPtr(
+      Image.getStart(), Section.sh_offset - Section.sh_addr + Symbol.st_value));
 
   // Set the global's size.
   ImageGlobal.setSize(Symbol.st_size);
 
   return Plugin::success();
 }
 
 Error GenericGlobalHandlerTy::moveGlobalBetweenDeviceAndHost(