This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state.
ClosedPublic

Authored by craig.topper on Jul 18 2023, 6:52 PM.

Diff Detail

Event Timeline

craig.topper created this revision.Jul 18 2023, 6:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 6:52 PM
craig.topper requested review of this revision.Jul 18 2023, 6:52 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 18 2023, 6:52 PM
asb accepted this revision.Jul 19 2023, 5:37 AM

Should add a release note as well, but otherwise LGTM. My understanding is that all of the intrinsics this exposes have the same level of stability / finalisation as the other vector intrinsics, but please let me know if I understand incorrectly.

This revision is now accepted and ready to land.Jul 19 2023, 5:37 AM
This revision was landed with ongoing or failed builds.Jul 19 2023, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Uh, why are there clang/test/Sema/aarch64* tests full of RISC-V extension names? That's not right at all. One of them is coming from https://reviews.llvm.org/D135011, I haven't traced the rest back, but that's clearly wrong. The test looks to be a copy of the RISC-V one with tweaks to change riscv(64) to arm/aarch64, and -target-feature +sve (with two spaces) added.

Uh, why are there clang/test/Sema/aarch64* tests full of RISC-V extension names? That's not right at all. One of them is coming from https://reviews.llvm.org/D135011, I haven't traced the rest back, but that's clearly wrong. The test looks to be a copy of the RISC-V one with tweaks to change riscv(64) to arm/aarch64, and -target-feature +sve (with two spaces) added.

Fixed in 690edeab78ba6996a44f6fd9e8fce79cb78e7737