This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add XLEN width integer type: riscv_int.h
Needs ReviewPublic

Authored by kito-cheng on Jul 7 2023, 5:01 AM.

Details

Summary

riscv_int.h contain int_xlen_t, uint_xlen_t and related marco.

See also: https://github.com/riscv-non-isa/riscv-c-api-doc/pull/14

Diff Detail

Event Timeline

kito-cheng created this revision.Jul 7 2023, 5:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2023, 5:01 AM
kito-cheng requested review of this revision.Jul 7 2023, 5:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2023, 5:01 AM
kito-cheng updated this revision to Diff 538094.Jul 7 2023, 5:05 AM

Chagnes:

  • Update header comment.
craig.topper added inline comments.Jul 7 2023, 12:50 PM
clang/lib/Headers/riscv_int.h
10

Don't you have to #define __RISCV_INT_H after this to make this a complete include guard?

kito-cheng updated this revision to Diff 538497.Jul 9 2023, 8:01 PM

Changes:

  • Define __RISCV_INT_H
kito-cheng marked an inline comment as done.Jul 9 2023, 8:02 PM
kito-cheng added inline comments.
clang/lib/Headers/riscv_int.h
10

Ooops, thanks for catching this!

kito-cheng marked an inline comment as done.Jul 9 2023, 8:04 PM