This is an archive of the discontinued LLVM Phabricator instance.

Differential D154670

[BOLT][DWARF] Don't check string offsets
ClosedPublic

Authored by ayermolo on Jul 6 2023, 5:53 PM.

Details

Reviewers
rafauler
Amir
maksfb
Commits
rGcfe4a4b04f21: [BOLT][DWARF] Don't check string offsets
Summary

With different linker, the offset of strings can change.

Diff Detail

Event Timeline

ayermolo created this revision.Jul 6 2023, 5:53 PM
Herald added a reviewer: rafauler. · View Herald TranscriptJul 6 2023, 5:53 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Jul 6 2023, 5:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 5:53 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
ayermolo edited the summary of this revision. (Show Details)Jul 6 2023, 5:54 PM
maksfb accepted this revision.Jul 6 2023, 5:54 PM
This revision is now accepted and ready to land.Jul 6 2023, 5:54 PM
This revision was landed with ongoing or failed builds.Jul 6 2023, 5:55 PM
Closed by commit rGcfe4a4b04f21: [BOLT][DWARF] Don't check string offsets (authored by ayermolo). · Explain Why
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rGcfe4a4b04f21: [BOLT][DWARF] Don't check string offsets.
Harbormaster completed remote builds in B243627: Diff 537940.Jul 6 2023, 6:01 PM
thakis added a reverting change: rGde7781ea4285: Revert "[DWARF][BOLT] Implement new mechanism for DWARFRewriter".Jul 7 2023, 5:07 AM

Revision Contents

PathSize
bolt/
test/
X86/
2 lines

Diff 537940

bolt/test/X86/dwarf4-types.test

Show All 24 Lines
# POSTCHECK: version = 0x0004 # POSTCHECK: version = 0x0004
# POSTCHECK: DW_TAG_compile_unit [6] # POSTCHECK: DW_TAG_compile_unit [6]
# POSTCHECK: DW_TAG_subprogram [11] # POSTCHECK: DW_TAG_subprogram [11]
# POSTCHECK: DW_TAG_variable [9] # POSTCHECK: DW_TAG_variable [9]
# POSTCHECK: DW_AT_type [DW_FORM_ref4] (cu + 0x006b => {0x00000112} "Foo2a") # POSTCHECK: DW_AT_type [DW_FORM_ref4] (cu + 0x006b => {0x00000112} "Foo2a")
# POSTCHECK: DW_TAG_variable [9] # POSTCHECK: DW_TAG_variable [9]
# POSTCHECK: DW_AT_type [DW_FORM_ref4] (cu + 0x0074 => {0x0000011b} "Foo3") # POSTCHECK: DW_AT_type [DW_FORM_ref4] (cu + 0x0074 => {0x0000011b} "Foo3")
# POSTCHECK: DW_TAG_base_type [5] # POSTCHECK: DW_TAG_base_type [5]
# POSTCHECK: DW_AT_name [DW_FORM_strp] ( .debug_str[0x00000063] = "int") # POSTCHECK: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "int")
# POSTCHECK: DW_TAG_structure_type [10] # POSTCHECK: DW_TAG_structure_type [10]
# POSTCHECK: DW_AT_signature [DW_FORM_ref_sig8] (0x104ec427d2ebea6f) # POSTCHECK: DW_AT_signature [DW_FORM_ref_sig8] (0x104ec427d2ebea6f)
# POSTCHECK: DW_TAG_structure_type [10] # POSTCHECK: DW_TAG_structure_type [10]
# POSTCHECK: DW_AT_signature [DW_FORM_ref_sig8] (0xb4580bc1535df1e4) # POSTCHECK: DW_AT_signature [DW_FORM_ref_sig8] (0xb4580bc1535df1e4)
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU-SAME: type_signature = 0x675d23e4f33235f2 # POSTCHECKTU-SAME: type_signature = 0x675d23e4f33235f2
# POSTCHECKTU-SAME: type_offset = 0x001e # POSTCHECKTU-SAME: type_offset = 0x001e
Show All 23 Lines