This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Adjust GLIBC_INITS_RSEQ condition
ClosedPublic

Authored by MaskRay on Jun 27 2023, 9:44 PM.

Details

Summary

Commit 9f80831f3627e800709e2434bbbd5bb179b1576e introduced #include <sys/rseq.h>,
but RSEQ_SIG is only defined by some glibc ports (aarch64,arm,mips,powerpc,s390,x86),
causing other hosts (e.g., riscv64, loongarch64) to fail to build.

Diff Detail

Event Timeline

MaskRay created this revision.Jun 27 2023, 9:44 PM
MaskRay requested review of this revision.Jun 27 2023, 9:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 9:44 PM
MaskRay updated this revision to Diff 535234.Jun 27 2023, 9:57 PM

drop Compiler.h. For linux, gcc (2014) / clang have supported __has_include for very long time.

aidengrossman accepted this revision.Jun 27 2023, 10:47 PM

This is definitely a much cleaner solution. Thanks for taking the time to write this up!

This revision is now accepted and ready to land.Jun 27 2023, 10:47 PM
xen0n accepted this revision.Jun 27 2023, 11:00 PM

LGTM from a cursory look. Thanks!

This revision was automatically updated to reflect the committed changes.