Page MenuHomePhabricator

aidengrossman (Aiden Grossman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2022, 11:35 AM (10 w, 6 d)

Recent Activity

Yesterday

aidengrossman added inline comments to D131930: [mlgo] Add in-development instruction based features for regalloc advisor.
Tue, Aug 16, 7:54 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D131930: [mlgo] Add in-development instruction based features for regalloc advisor.

Adjust comments to better document the extraction algorithm and the data that
it returns. Also refactor to passing around a struct rather than a tuple and
adjust a comment in the dev mode logging.

Tue, Aug 16, 7:54 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D131930: [mlgo] Add in-development instruction based features for regalloc advisor.
Tue, Aug 16, 2:29 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D131930: [mlgo] Add in-development instruction based features for regalloc advisor.

Changed up dev mode extra features test to make it less fragile by getting rid
of the exact logging diff check and adding more FileCheck checks on the
instructions and mapping matrix for the first eviction problem.

Tue, Aug 16, 2:27 PM · Restricted Project, Restricted Project

Mon, Aug 15

aidengrossman added reviewers for D131930: [mlgo] Add in-development instruction based features for regalloc advisor: MatzeB, mtrofin.
Mon, Aug 15, 4:46 PM · Restricted Project, Restricted Project
aidengrossman requested review of D131930: [mlgo] Add in-development instruction based features for regalloc advisor.
Mon, Aug 15, 4:44 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor.

Changed InputFeatures and TrainingInputFeatures from being static members to
normal class members.

Mon, Aug 15, 10:05 AM · Restricted Project, Restricted Project

Sun, Aug 14

aidengrossman added inline comments to D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor.
Sun, Aug 14, 7:50 PM · Restricted Project, Restricted Project

Wed, Aug 10

aidengrossman updated the diff for D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor.

Reduced the scope of the change to just refactoring parts of the
MLRegallocEvictAdvisor to set the stage for future work involving
feature lists that vary at runtime.

Wed, Aug 10, 3:11 PM · Restricted Project, Restricted Project

Thu, Aug 4

aidengrossman added a reviewer for D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor: mtrofin.

This patch adds in a DEVELOPMENT_RA_EVICT_FEATURES_LIST macro that contains development features and modifies/refactors the reset of the file in order to be able run these features when the command line option enable-features-under-development is specified. I tested this in release mode and development mode when compiled in MLGO development mode (setting TENSORFLOW_C_LIB_PATH) and I did another build in release mode (LLVM_HAVE_TF_API is false, TENSORFLOW_C_LIB_PATH isn't set) and everything seemed to work correctly, but it definitely wouldn't hurt to have more people testing this change.

Thu, Aug 4, 3:11 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor.

Removed debugging artifacts in TFUtil.cpp

Thu, Aug 4, 3:07 PM · Restricted Project, Restricted Project
aidengrossman requested review of D131209: [mlgo] Add ability to create feature-gated development features in regalloc advisor.
Thu, Aug 4, 3:04 PM · Restricted Project, Restricted Project

Thu, Jul 28

aidengrossman added a comment to D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled.

Thanks for the review and your suggestions. Do you mind pushing this commit? I don't currently have commit access to LLVM. Thanks.

Thu, Jul 28, 5:55 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled.

Rebased against main and adjusted unit tests to check directly
for the cc1 flag in CmdArgs which is directly consumed by the
bitcode writer while creating the .llvmcmd section. Also changed
the flags to better match what is already getting passed in.

Thu, Jul 28, 5:11 PM · Restricted Project, Restricted Project

Wed, Jul 27

aidengrossman updated the diff for D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled.

Added two unit tests to ensure functionality is correct in both
the assertion case and the default case. Should be sufficient
to ensure correct functionality without utilizing regression tests.
However, if regression tests are also desired, let me know and I can
add one in.

Wed, Jul 27, 1:47 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled.
Wed, Jul 27, 12:44 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled.

Moved insertion of cc1 flag to prevent shifting entire array

Wed, Jul 27, 12:43 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled: jansvoboda11, dang.
Wed, Jul 27, 2:54 AM · Restricted Project, Restricted Project
aidengrossman requested review of D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled.
Wed, Jul 27, 2:41 AM · Restricted Project, Restricted Project

Jul 7 2022

aidengrossman added reviewers for D129254: [mlgo] Simplify autogenerated regalloc model: mtrofin, yundiqian.

This patch removes all unnecessary features from the autogenerated regalloc model (simplifying it greatly) and gets rid of the nondeterminism that I was experiencing that trips the mask==1 assertion in the MLRegallocAdvisor. Not anything super critical, but slightly annoying during development as it has to be commented out and commented back in after feature extraction development is completed and doesn't do what it it is supposed to during development. Tested locally as working and all the tests in /llvm/test/CodeGen/MLRegalloc pass for me as well.

Jul 7 2022, 12:20 AM · Restricted Project, Restricted Project
aidengrossman requested review of D129254: [mlgo] Simplify autogenerated regalloc model.
Jul 7 2022, 12:15 AM · Restricted Project, Restricted Project

Jun 27 2022

aidengrossman added a comment to D128225: [CMake][SingleSource] Fix compile with profile generation.

I don't have commit access to the llvm-test-suite repository. Is it possible for someone to push this commit to the test suite repository? My details for the git commit authorship:
Aiden Grossman
agrossman154 at yahoo dot com

Jun 27 2022, 11:12 AM · Restricted Project

Jun 20 2022

aidengrossman added a comment to D128225: [CMake][SingleSource] Fix compile with profile generation.

LGTM

Jun 20 2022, 3:00 PM · Restricted Project
aidengrossman updated the diff for D128225: [CMake][SingleSource] Fix compile with profile generation.

Made behavior consistent between TEST_SUITE_PROFILE_GENERATE and TEST_SUITE_PROFILE_USE.

Jun 20 2022, 2:57 PM · Restricted Project
aidengrossman updated the diff for D128225: [CMake][SingleSource] Fix compile with profile generation.

Fixed modification of gcc-c-torture suite source files by just excluding the test in the relevant CMakeLists.txt file.

Jun 20 2022, 2:44 PM · Restricted Project
aidengrossman added reviewers for D128225: [CMake][SingleSource] Fix compile with profile generation: lenary, vsk, MatzeB.

There seems to be an underlying issue in the compiler when compiling with instrumentation as identified in https://groups.google.com/g/llvm-dev/c/180LAuFPfKs. This patch is a workaround for this issue for people compiling the test suite with PGO instrumentation enabled and not just the TEST_SUITE_BENCHMARKING_ONLY set to ON. Let me know if there is a more elegant/preferred way of solving this within the test suite (Or if this patch is even desired given the fairly atypical use case of PGO with the entire test suite).
9(Reviewers pinged for commits in relevant areas (PGO CMake implementation/gcc-c-torture suite integration))

Jun 20 2022, 2:14 PM · Restricted Project
aidengrossman requested review of D128225: [CMake][SingleSource] Fix compile with profile generation.
Jun 20 2022, 2:03 PM · Restricted Project