Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

aidengrossman (Aiden Grossman)
Undergraduate - UC Davis

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2022, 11:35 AM (69 w, 5 d)

Currently working on cost modelling primarily for training ML models to replace compiler heuristics for performance.

Recent Activity

Tue, Sep 12

aidengrossman committed rG57b731e615d1: [llvm-exegesis] Add retry count to subprocess tests (authored by aidengrossman).
[llvm-exegesis] Add retry count to subprocess tests
Tue, Sep 12, 1:25 PM · Restricted Project, Restricted Project

Tue, Sep 5

aidengrossman committed rGc4a769ba03e4: [llvm-exegesis] Print errno on failures in subprocess (authored by aidengrossman).
[llvm-exegesis] Print errno on failures in subprocess
Tue, Sep 5, 12:42 PM · Restricted Project, Restricted Project
aidengrossman closed D157682: [llvm-exegesis] Print errno on failures in subprocess.
Tue, Sep 5, 12:42 PM · Restricted Project, Restricted Project
aidengrossman committed rGca8dbdc12a72: [llvm-exegesis] Add error for subprocess and dummy perf counters (authored by aidengrossman).
[llvm-exegesis] Add error for subprocess and dummy perf counters
Tue, Sep 5, 12:35 PM · Restricted Project, Restricted Project
aidengrossman closed D157686: [llvm-exegesis] Add error for subprocess and dummy perf counters.
Tue, Sep 5, 12:35 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158052: [llvm-exegesis] Add explicit error for segmenetation faults.

Bump on this when reviewers have a chance. Thanks!

Tue, Sep 5, 3:45 AM · Restricted Project, Restricted Project
aidengrossman added a comment to D157686: [llvm-exegesis] Add error for subprocess and dummy perf counters.

Bump on this when reviewers have a chance. Thanks!

Tue, Sep 5, 3:45 AM · Restricted Project, Restricted Project
aidengrossman added a comment to D157682: [llvm-exegesis] Print errno on failures in subprocess.

Bump on this when reviewers have a chance. Thanks!

Tue, Sep 5, 3:45 AM · Restricted Project, Restricted Project

Sun, Sep 3

aidengrossman abandoned D154680: [llvm-exegesis] Make SubprocessMemoryTest use PIDs.

Abandoning in favor of https://github.com/llvm/llvm-project/pull/65245.

Sun, Sep 3, 10:47 PM · Restricted Project, Restricted Project

Sep 1 2023

aidengrossman added inline comments to D154680: [llvm-exegesis] Make SubprocessMemoryTest use PIDs.
Sep 1 2023, 12:49 PM · Restricted Project, Restricted Project

Aug 30 2023

aidengrossman committed rGd944cab731f1: [IR] Make detailed structural hash test look at diffs (authored by aidengrossman).
[IR] Make detailed structural hash test look at diffs
Aug 30 2023, 10:32 AM · Restricted Project, Restricted Project
aidengrossman closed D159154: [IR] Make detailed structural hash test look at diffs.
Aug 30 2023, 10:32 AM · Restricted Project, Restricted Project
aidengrossman retitled D159154: [IR] Make detailed structural hash test look at diffs from [IR] Make detailed structural hash test llok at diffs to [IR] Make detailed structural hash test look at diffs.
Aug 30 2023, 12:32 AM · Restricted Project, Restricted Project

Aug 29 2023

aidengrossman committed rG09f4c6967f66: [NFC][IR] Update StructuralHash comment (authored by aidengrossman).
[NFC][IR] Update StructuralHash comment
Aug 29 2023, 7:41 PM · Restricted Project, Restricted Project
aidengrossman added a reviewer for D159154: [IR] Make detailed structural hash test look at diffs: aeubanks.
Aug 29 2023, 7:33 PM · Restricted Project, Restricted Project
aidengrossman requested review of D159154: [IR] Make detailed structural hash test look at diffs.
Aug 29 2023, 7:33 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158317: [IR] Add SturcturalHash printer pass.
Aug 29 2023, 7:06 PM · Restricted Project, Restricted Project
aidengrossman committed rG3a42b1fd3eec: [IR] Add SturcturalHash printer pass (authored by aidengrossman).
[IR] Add SturcturalHash printer pass
Aug 29 2023, 7:01 PM · Restricted Project, Restricted Project
aidengrossman closed D158317: [IR] Add SturcturalHash printer pass.
Aug 29 2023, 7:01 PM · Restricted Project, Restricted Project

Aug 28 2023

aidengrossman added inline comments to D158317: [IR] Add SturcturalHash printer pass.
Aug 28 2023, 1:39 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Address reviewer feedback

  • Switch main test to use regular expressions and lit variables for

verification that hashes are correct.

Aug 28 2023, 1:39 PM · Restricted Project, Restricted Project

Aug 26 2023

aidengrossman committed rG1b4932e140ea: [Pass] Enable detailed structural hashing (authored by aidengrossman).
[Pass] Enable detailed structural hashing
Aug 26 2023, 12:57 AM · Restricted Project, Restricted Project
aidengrossman committed rG856c46383951: [CodeGenPrepare] Fix modification status bug (authored by aidengrossman).
[CodeGenPrepare] Fix modification status bug
Aug 26 2023, 12:32 AM · Restricted Project, Restricted Project
aidengrossman closed D158898: [CodeGenPrepare] Fix modification status bug.
Aug 26 2023, 12:32 AM · Restricted Project, Restricted Project

Aug 25 2023

aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Skip printing hashes of function declarations.

Aug 25 2023, 5:24 PM · Restricted Project, Restricted Project
aidengrossman committed rGaad3641e80de: [FunctionPropertiesAnalysis] Add CFG and call properties (authored by aidengrossman).
[FunctionPropertiesAnalysis] Add CFG and call properties
Aug 25 2023, 3:03 PM · Restricted Project, Restricted Project
aidengrossman closed D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.
Aug 25 2023, 3:03 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D158898: [CodeGenPrepare] Fix modification status bug: nikic, reames, skatkov.

Fixes https://github.com/llvm/llvm-project/issues/64938.

Aug 25 2023, 2:45 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158898: [CodeGenPrepare] Fix modification status bug.
Aug 25 2023, 2:42 PM · Restricted Project, Restricted Project
aidengrossman committed rGf532d61de02b: [IR] Add more details to StructuralHash (authored by aidengrossman).
[IR] Add more details to StructuralHash
Aug 25 2023, 2:34 PM · Restricted Project, Restricted Project
aidengrossman closed D158250: [IR] Add more details to StructuralHash.
Aug 25 2023, 2:34 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158317: [IR] Add SturcturalHash printer pass.

Bump on this patch when reviewers have a chance. Thanks!

Aug 25 2023, 2:20 PM · Restricted Project, Restricted Project
aidengrossman committed rG17b48de12073: [ForceFunctionAttrs] Make options additionally work over entire module (authored by aidengrossman).
[ForceFunctionAttrs] Make options additionally work over entire module
Aug 25 2023, 2:07 PM · Restricted Project, Restricted Project
aidengrossman closed D158815: [ForceFunctionAttrs] Make options additionally work over entire module.
Aug 25 2023, 2:06 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.
Aug 25 2023, 1:58 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.

Address reviewer feedback

  • Add handling for vector return types
Aug 25 2023, 1:57 PM · Restricted Project, Restricted Project
aidengrossman retitled D158815: [ForceFunctionAttrs] Make options additionally work over entire module from [opt] Add option to strip optnone attribute to [ForceFunctionAttrs] Make options additionally work over entire module.
Aug 25 2023, 1:20 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158815: [ForceFunctionAttrs] Make options additionally work over entire module.

Switch to modifying ForceFunctionAttrs rather than adding an opt option.

Aug 25 2023, 1:19 PM · Restricted Project, Restricted Project
aidengrossman abandoned D158884: [ForceFunctionAttrs] Make options additionally work over entire module.
Aug 25 2023, 1:18 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158884: [ForceFunctionAttrs] Make options additionally work over entire module.
Aug 25 2023, 1:17 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D158375: [llvm-exegesis] Use mmap2 when mmap is unavailable to fix riscv32 build: aidengrossman, courbet, gchatelet.

Once you adopt @MaskRay's comments regarding the comment wording and preprocessor directives, this should LGTM.

Aug 25 2023, 12:05 AM · Restricted Project, Restricted Project

Aug 24 2023

aidengrossman added a comment to D158250: [IR] Add more details to StructuralHash.

Any opposition to landing this with the detailed parameter set to false in the PM changed checks temporarily while https://github.com/llvm/llvm-project/issues/64938 is fixed (and then enable detailed structural hashing for change status expensive checks once that is fixed)?

Aug 24 2023, 10:57 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D158815: [ForceFunctionAttrs] Make options additionally work over entire module: nikic, aeubanks, jdoerfert.

@jdoerfert also suggested doing this in an IPO pass (like FunctionAttrs) but it seemed simple enough to implement this way. I couldn't think of any benefit of doing it within an IPO pass, but definitely could be missing something. Also wondering if there are reasons for not doing this as I thought there would've been something like this already.

Aug 24 2023, 10:45 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158815: [ForceFunctionAttrs] Make options additionally work over entire module.
Aug 24 2023, 10:36 PM · Restricted Project, Restricted Project

Aug 23 2023

aidengrossman updated the diff for D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.

Address reviewer feedback

Aug 23 2023, 5:38 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.
Aug 23 2023, 5:37 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.

Address reviewer feedback

  • Fix issue with critical edge counting
Aug 23 2023, 5:37 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D158681: [FunctionPropertiesAnalysis] Add CFG and call properties: mtrofin, jdoerfert.
Aug 23 2023, 4:06 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158681: [FunctionPropertiesAnalysis] Add CFG and call properties.
Aug 23 2023, 4:05 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158250: [IR] Add more details to StructuralHash.

Looks like the changes caught a regression:

-- Testing: 1 tests, 1 workers --
FAIL: LLVM :: CodeGen/X86/statepoint-stack-usage.ll (1 of 1)
******************** TEST 'LLVM :: CodeGen/X86/statepoint-stack-usage.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /tmp/llvm-expensive-checks/bin/llc -verify-machineinstrs -stack-symbol-ordering=0 < /tmp/llvm-project/llvm/test/CodeGen/X86/statepoint-stack-usage.ll | /tmp/llvm-expensive-checks/bin/FileCheck /tmp/llvm-project/llvm/test/CodeGen/X86/statepoint-stack-usage.ll
--
Exit Code: 2
Command Output (stderr):
--
+ : 'RUN: at line 1'
+ /tmp/llvm-expensive-checks/bin/llc -verify-machineinstrs -stack-symbol-ordering=0
+ /tmp/llvm-expensive-checks/bin/FileCheck /tmp/llvm-project/llvm/test/CodeGen/X86/statepoint-stack-usage.ll
Pass modifies its input and doesn't report it: CodeGen Prepare
Pass modifies its input and doesn't report it
UNREACHABLE executed at /tmp/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1441!
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: /tmp/llvm-expensive-checks/bin/llc -verify-machineinstrs -stack-symbol-ordering=0
1.      Running pass 'Function Pass Manager' on module '<stdin>'.
2.      Running pass 'CodeGen Prepare' on function '@back_to_back_calls'
 #0 0x00005555580db4c8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/tmp/llvm-expensive-checks/bin/llc+0x2b874c8)
 #1 0x00005555580d8f7e llvm::sys::RunSignalHandlers() (/tmp/llvm-expensive-checks/bin/llc+0x2b84f7e)
 #2 0x00005555580dbca8 SignalHandler(int) Signals.cpp:0:0
 #3 0x0000155554fd9520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
 #4 0x000015555502da7c pthread_kill (/lib/x86_64-linux-gnu/libc.so.6+0x96a7c)
 #5 0x0000155554fd9476 gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x42476)
 #6 0x0000155554fbf7f3 abort (/lib/x86_64-linux-gnu/libc.so.6+0x287f3)
 #7 0x0000555558038700 llvm::install_out_of_memory_new_handler() (/tmp/llvm-expensive-checks/bin/llc+0x2ae4700)
 #8 0x0000555557922b42 (/tmp/llvm-expensive-checks/bin/llc+0x23ceb42)
 #9 0x000055555792b232 llvm::FPPassManager::runOnModule(llvm::Module&) (/tmp/llvm-expensive-checks/bin/llc+0x23d7232)
#10 0x00005555579233fa llvm::legacy::PassManagerImpl::run(llvm::Module&) (/tmp/llvm-expensive-checks/bin/llc+0x23cf3fa)
#11 0x0000555556a5e757 main (/tmp/llvm-expensive-checks/bin/llc+0x150a757)
#12 0x0000155554fc0d90 (/lib/x86_64-linux-gnu/libc.so.6+0x29d90)
#13 0x0000155554fc0e40 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e40)
#14 0x0000555556a58c65 _start (/tmp/llvm-expensive-checks/bin/llc+0x1504c65)
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /tmp/llvm-expensive-checks/bin/FileCheck /tmp/llvm-project/llvm/test/CodeGen/X86/statepoint-stack-usage.ll
--
********************
********************
Failed Tests (1):
  LLVM :: CodeGen/X86/statepoint-stack-usage.ll
Aug 23 2023, 12:32 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158250: [IR] Add more details to StructuralHash.

Address reviewer feedback

  • Remove TODO comment
Aug 23 2023, 12:08 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158317: [IR] Add SturcturalHash printer pass.

Address reviewer feedback

  • Switch pass option name to detailed rather than the much more verbose enable-detailed-structural-hash
Aug 23 2023, 12:06 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Address reviewer feedback

  • Switch pass option name to detailed rather than the much more verbose enable-detailed-structural-hash
Aug 23 2023, 12:02 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158317: [IR] Add SturcturalHash printer pass.

It would probably make sense to move your existing unit test coverage over to the printer pass.

Aug 23 2023, 11:54 AM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Update test that I forgot to save before committing.

Aug 23 2023, 11:42 AM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158317: [IR] Add SturcturalHash printer pass.
Aug 23 2023, 11:31 AM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Split lit test

Aug 23 2023, 11:30 AM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Address reviewer feedback

  • Update test hashes based on most recent revision of earlier patch in stack
  • Make test require 64 bit architecture to prevent failures on 32 bit arches.
Aug 23 2023, 11:21 AM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158250: [IR] Add more details to StructuralHash.
Aug 23 2023, 11:07 AM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158250: [IR] Add more details to StructuralHash.

Address reviewer feedback

Aug 23 2023, 11:07 AM · Restricted Project, Restricted Project

Aug 22 2023

aidengrossman added inline comments to D154275: [llvm-exegesis] Support older kernel versions in subprocess executor.
Aug 22 2023, 11:44 PM · Restricted Project, Restricted Project
aidengrossman committed rG34e3bc0b92d7: [llvm-exegesis] Replace size_t with ssize_t where relevant (authored by aidengrossman).
[llvm-exegesis] Replace size_t with ssize_t where relevant
Aug 22 2023, 11:44 PM · Restricted Project, Restricted Project

Aug 21 2023

aidengrossman added inline comments to D158250: [IR] Add more details to StructuralHash.
Aug 21 2023, 11:36 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158250: [IR] Add more details to StructuralHash.

Update patch

  • Switch to native hashing implementations for APInt/APFloat
  • Switch from hashing type pointers to hashing some details about the type as the former is non-deterministic (which of course is frustratingly masked by my system having ASLR disabled). Left a TODO to refactor the type hashing into a more formal hash_value implementation within the class.
  • Formatting changes.
Aug 21 2023, 11:27 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158317: [IR] Add SturcturalHash printer pass.
Aug 21 2023, 7:36 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158317: [IR] Add SturcturalHash printer pass.

Address reviewer feedback

  • Fix top comment typo
  • Remove mostly useless header comment
  • Switch to using pass options fron the cl::opt in printer pass
  • Update test
Aug 21 2023, 7:35 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158250: [IR] Add more details to StructuralHash.
Aug 21 2023, 3:50 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158250: [IR] Add more details to StructuralHash.
Aug 21 2023, 2:59 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158250: [IR] Add more details to StructuralHash.

Fix minor formatting issue

Aug 21 2023, 2:59 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158250: [IR] Add more details to StructuralHash.

Address reviewer feedback

  • Early exit where pointed out.
  • Switch to hashing operands for the most part (except for in the case of cmp)
  • Add a couple additional operands to hash, particularly integer constants and arguments.
  • Rebase against upstream to include changes to prevent test regressions on 32-bit arches.
Aug 21 2023, 2:57 PM · Restricted Project, Restricted Project

Aug 19 2023

aidengrossman added a reverting change for rG58696d2f5bba: [clang][X86] Add __cpuidex function to cpuid.h: rG8b6f09e257b5: Revert "[clang][X86] Add __cpuidex function to cpuid.h".
Aug 19 2023, 5:19 PM · Restricted Project, Restricted Project
aidengrossman committed rG8b6f09e257b5: Revert "[clang][X86] Add __cpuidex function to cpuid.h" (authored by aidengrossman).
Revert "[clang][X86] Add __cpuidex function to cpuid.h"
Aug 19 2023, 5:19 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions.

It looks like hash_code stores everything as size_t which causes the difference between the 32 bit and 64 bit platforms. The functions end up in different places as MergeFunctions ends up ordering them by hash. I've switched the hashing a little bit (mainly using uint64_t and switching to hash_16_bytes from hash_combine to get rid of the size_t) so that things are consistent across platforms. I've also updated the magic constant as the function header to prevent any unnecessary churn in the test diffs and I've verified that behavior is consistent between 64 and 32 bit builds now.

Aug 19 2023, 5:17 PM · Restricted Project, Restricted Project
aidengrossman committed rG58696d2f5bba: [clang][X86] Add __cpuidex function to cpuid.h (authored by aidengrossman).
[clang][X86] Add __cpuidex function to cpuid.h
Aug 19 2023, 5:16 PM · Restricted Project, Restricted Project
aidengrossman committed rG64da0be1fc06: Reland "[NFCi][MergeFunctions] Consolidate Hashing Functions" (authored by aidengrossman).
Reland "[NFCi][MergeFunctions] Consolidate Hashing Functions"
Aug 19 2023, 5:16 PM · Restricted Project, Restricted Project
aidengrossman updated the summary of D158348: [clang][X86] Add __cpuidex function to cpuid.h.
Aug 19 2023, 1:48 PM · Restricted Project, Restricted Project
aidengrossman updated the summary of D158348: [clang][X86] Add __cpuidex function to cpuid.h.
Aug 19 2023, 1:48 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D158348: [clang][X86] Add __cpuidex function to cpuid.h: aaron.ballman, glandium, mstorsjo, craig.topper.

This is an updated version of https://reviews.llvm.org/D150646 that uses __has_builtin instead of checking for a definition of _MSC_EXTENSIONS. This fixes the cases that I have received so far and shouldn't cause any other issues.

Aug 19 2023, 1:47 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158348: [clang][X86] Add __cpuidex function to cpuid.h.
Aug 19 2023, 1:40 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions.

Thanks for bringing this to my attention! Not sure how I completely missed the buildbot notifications. I've reverted for now so that I can work on a fix out-of-trunk and will resubmit once I have this fixed (and after more thorough testing).

Aug 19 2023, 12:27 PM · Restricted Project, Restricted Project
aidengrossman added a reverting change for rG28134a29fded: [NFCi][MergeFunctions] Consolidate Hashing Functions: rG7ff7df1c629a: Revert "[NFCi][MergeFunctions] Consolidate Hashing Functions".
Aug 19 2023, 12:24 PM · Restricted Project, Restricted Project
aidengrossman committed rG7ff7df1c629a: Revert "[NFCi][MergeFunctions] Consolidate Hashing Functions" (authored by aidengrossman).
Revert "[NFCi][MergeFunctions] Consolidate Hashing Functions"
Aug 19 2023, 12:24 PM · Restricted Project, Restricted Project
aidengrossman added a reverting change for D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions: rG7ff7df1c629a: Revert "[NFCi][MergeFunctions] Consolidate Hashing Functions".
Aug 19 2023, 12:24 PM · Restricted Project, Restricted Project
aidengrossman committed rWecd6d7903975: Remove .DS_Store files from repository (authored by aidengrossman).
Remove .DS_Store files from repository
Aug 19 2023, 12:16 AM · Restricted Project

Aug 18 2023

aidengrossman added reviewers for D158317: [IR] Add SturcturalHash printer pass: aeubanks, jdoerfert, nikic.
Aug 18 2023, 2:54 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158317: [IR] Add SturcturalHash printer pass.
Aug 18 2023, 2:52 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158250: [IR] Add more details to StructuralHash.
Aug 18 2023, 2:31 PM · Restricted Project, Restricted Project
aidengrossman committed rGb8f191e054dd: [FunctionPropertiesAnalysis] Add operand type counts (authored by aidengrossman).
[FunctionPropertiesAnalysis] Add operand type counts
Aug 18 2023, 1:27 PM · Restricted Project, Restricted Project
aidengrossman closed D158018: [FunctionPropertiesAnalysis] Add operand type counts.
Aug 18 2023, 1:27 PM · Restricted Project, Restricted Project
aidengrossman committed rG28134a29fded: [NFCi][MergeFunctions] Consolidate Hashing Functions (authored by aidengrossman).
[NFCi][MergeFunctions] Consolidate Hashing Functions
Aug 18 2023, 1:19 PM · Restricted Project, Restricted Project
aidengrossman closed D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions.
Aug 18 2023, 1:19 PM · Restricted Project, Restricted Project
aidengrossman added inline comments to D158250: [IR] Add more details to StructuralHash.
Aug 18 2023, 12:44 AM · Restricted Project, Restricted Project

Aug 17 2023

aidengrossman added reviewers for D158250: [IR] Add more details to StructuralHash: serge-sans-paille, jdoerfert, aeubanks, nikic.
Aug 17 2023, 11:22 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158250: [IR] Add more details to StructuralHash.
Aug 17 2023, 11:21 PM · Restricted Project, Restricted Project
aidengrossman abandoned D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set.
Aug 17 2023, 7:37 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set.

I believe that /Ze has more in common with -fms-compatibility than -fms-extensions, but I could be wrong. Also, they may just be completely different things at this point. /permissive is closer in spirit to -fms-compatibility.

Aug 17 2023, 3:40 PM · Restricted Project, Restricted Project
aidengrossman updated the diff for D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions.

Address reviewer feedback

  • Add comment that different users might want different behavior so options

should be preferred.

Aug 17 2023, 3:28 PM · Restricted Project, Restricted Project
aidengrossman added a comment to D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set.

I don't think this is the right thing to do, I think I recall saying as much on some other review. The MSVC docs say that /Za//Ze control _MSC_EXTENSION, and as I understand it, /Za is more like our -fms-compatibility flag, so it makes sense to control this macro with -fms-compatibility.

Aug 17 2023, 3:03 PM · Restricted Project, Restricted Project
aidengrossman added reviewers for D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions: serge-sans-paille, jdoerfert, nikic, aeubanks.
Aug 17 2023, 2:10 PM · Restricted Project, Restricted Project
aidengrossman requested review of D158217: [NFCi][MergeFunctions] Consolidate Hashing Functions.
Aug 17 2023, 2:07 PM · Restricted Project, Restricted Project