This is an archive of the discontinued LLVM Phabricator instance.

Differential D153937

[llvm-exegesis] Exclude loongarch when define GLIBC_INITS_RSEQ
AbandonedPublic

Authored by SixWeining on Jun 27 2023, 9:13 PM.

Download Raw Diff

Details

Reviewers

aidengrossman
xen0n
xry111
hev
MaskRay
wangleiat

Summary

Currently LoongArch does not have arch-specific rseq.h, so exclude it.

Fix buildbot failures: https://lab.llvm.org/staging/#/builders/236/builds/4742.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

SixWeining created this revision.Jun 27 2023, 9:13 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 9:13 PM

Herald added a subscriber: mstojanovic. · View Herald Transcript

SixWeining requested review of this revision.Jun 27 2023, 9:13 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 9:13 PM

Herald added subscribers: llvm-commits, courbet. · View Herald Transcript

One nit, otherwise LGTM.

llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
42	Do you mind adding a comment around here explaining why loongarch is excluded (similar to the review description)?

This revision is now accepted and ready to land.Jun 27 2023, 9:19 PM

Hold on... I'll fix this properly.

In D153937#4454715, @MaskRay wrote:

Hold on... I'll fix this properly.

D153938 is better than this.

Harbormaster completed remote builds in B241677: Diff 535226.Jun 27 2023, 10:28 PM

Revision Contents

Path

Size

llvm/

tools/

llvm-exegesis/

lib/

BenchmarkRunner.cpp

2 lines

Diff 535226

llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp

	Show All 33 Lines
	#endif			#endif
	#include <sys/mman.h>			#include <sys/mman.h>
	#include <sys/ptrace.h>			#include <sys/ptrace.h>
	#include <sys/syscall.h>			#include <sys/syscall.h>
	#include <sys/wait.h>			#include <sys/wait.h>
	#include <unistd.h>			#include <unistd.h>

	#ifdef __GLIBC__			#ifdef __GLIBC__
	#if __GLIBC_MINOR__ >= 35			#if __GLIBC_MINOR__ >= 35 && !defined(__loongarch__)
				aidengrossmanUnsubmitted Not Done Reply Inline Actions Do you mind adding a comment around here explaining why loongarch is excluded (similar to the review description)? aidengrossman: Do you mind adding a comment around here explaining why loongarch is excluded (similar to the…
	#define GLIBC_INITS_RSEQ			#define GLIBC_INITS_RSEQ
	#endif // __GLIBC__MINOR > 35			#endif // __GLIBC__MINOR > 35
	#endif // __GLIBC__			#endif // __GLIBC__

	#ifdef GLIBC_INITS_RSEQ			#ifdef GLIBC_INITS_RSEQ
	#include <sys/rseq.h>			#include <sys/rseq.h>
	#endif // HAS_RSEQ			#endif // HAS_RSEQ
	#endif // __linux__			#endif // __linux__
	▲ Show 20 Lines • Show All 485 Lines • Show Last 20 Lines