This is an archive of the discontinued LLVM Phabricator instance.

Differential D153704

[openmp] remove initializeRewriteSymbolsLegacyPassPass
ClosedPublic

Authored by sunshaoce on Jun 24 2023, 9:08 AM.

Details

Reviewers
kazu
aeubanks
nikic
jdoerfert
Commits
rGf042890521f3: [openmp] remove initializeRewriteSymbolsLegacyPassPass
Summary

Fix build error caused by D153679

Diff Detail

Event Timeline

sunshaoce created this revision.Jun 24 2023, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2023, 9:08 AM
Herald added subscribers: StephenFan, guansong, yaxunl. · View Herald Transcript
sunshaoce requested review of this revision.Jun 24 2023, 9:08 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 24 2023, 9:08 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, jplehr, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B240973: Diff 534224.Jun 24 2023, 9:11 AM
nikic added inline comments.Jun 24 2023, 9:11 AM
openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp
81–82

You can remove the entire code starting from here.

tianshilei1992 added a subscriber: tianshilei1992.Jun 24 2023, 9:17 AM
tianshilei1992 added inline comments.
openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp
81–82

we don't need to initialize them anymore?

sunshaoce updated this revision to Diff 534225.Jun 24 2023, 9:21 AM
sunshaoce marked an inline comment as done.

Addressed @nikic's comment. Removed Initialize passes.

Herald added a subscriber: aheejin. · View Herald TranscriptJun 24 2023, 9:21 AM
Harbormaster completed remote builds in B240974: Diff 534225.Jun 24 2023, 9:24 AM
nikic accepted this revision.Jun 24 2023, 9:28 AM

LGTM

openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp
80

You can remove this check (and the JITTargetInitialized) flag as well.

This revision is now accepted and ready to land.Jun 24 2023, 9:28 AM
sunshaoce updated this revision to Diff 534229.Jun 24 2023, 9:33 AM
sunshaoce marked an inline comment as done.

Removed JITTargetInitialized.

This revision was landed with ongoing or failed builds.Jun 24 2023, 9:35 AM
Closed by commit rGf042890521f3: [openmp] remove initializeRewriteSymbolsLegacyPassPass (authored by sunshaoce). · Explain Why
This revision was automatically updated to reflect the committed changes.
sunshaoce added a commit: rGf042890521f3: [openmp] remove initializeRewriteSymbolsLegacyPassPass.
Harbormaster completed remote builds in B240977: Diff 534229.Jun 24 2023, 9:36 AM

Revision Contents

PathSize
openmp/
libomptarget/
plugins-nextgen/
common/
PluginInterface/
38 lines

Diff 534225

openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines#ifdef LIBOMPTARGET_JIT_AMDGPU
if (TT.isAMDGPU()) { if (TT.isAMDGPU()) {
LLVMInitializeAMDGPUTargetInfo(); LLVMInitializeAMDGPUTargetInfo();
LLVMInitializeAMDGPUTarget(); LLVMInitializeAMDGPUTarget();
LLVMInitializeAMDGPUTargetMC(); LLVMInitializeAMDGPUTargetMC();
LLVMInitializeAMDGPUAsmPrinter(); LLVMInitializeAMDGPUAsmPrinter();
JITTargetInitialized = true; JITTargetInitialized = true;
} }
#endif #endif
if (!JITTargetInitialized) if (!JITTargetInitialized)
nikicUnsubmitted
Done
ReplyInline Actions

You can remove this check (and the JITTargetInitialized) flag as well.

nikic: You can remove this check (and the JITTargetInitialized) flag as well.
return; return;
// Initialize passes
PassRegistry &Registry = *PassRegistry::getPassRegistry();
initializeCore(Registry);
initializeScalarOpts(Registry);
initializeVectorization(Registry);
initializeIPO(Registry);
initializeAnalysis(Registry);
initializeTransformUtils(Registry);
initializeInstCombine(Registry);
initializeTarget(Registry);
initializeExpandLargeDivRemLegacyPassPass(Registry);
initializeExpandLargeFpConvertLegacyPassPass(Registry);
initializeExpandMemCmpPassPass(Registry);
initializeScalarizeMaskedMemIntrinLegacyPassPass(Registry);
initializeSelectOptimizePass(Registry);
initializeCodeGenPreparePass(Registry);
initializeAtomicExpandPass(Registry);
initializeRewriteSymbolsLegacyPassPass(Registry);
initializeWinEHPreparePass(Registry);
initializeDwarfEHPrepareLegacyPassPass(Registry);
initializeSafeStackLegacyPassPass(Registry);
initializeSjLjEHPreparePass(Registry);
initializePreISelIntrinsicLoweringLegacyPassPass(Registry);
initializeGlobalMergePass(Registry);
initializeIndirectBrExpandPassPass(Registry);
initializeInterleavedLoadCombinePass(Registry);
initializeInterleavedAccessPass(Registry);
initializeUnreachableBlockElimLegacyPassPass(Registry);
initializeExpandReductionsPass(Registry);
initializeExpandVectorPredicationPass(Registry);
initializeWasmEHPreparePass(Registry);
initializeWriteBitcodePassPass(Registry);
initializeHardwareLoopsLegacyPass(Registry);
initializeTypePromotionLegacyPass(Registry);
initializeReplaceWithVeclibLegacyPass(Registry);
initializeJMCInstrumenterPass(Registry);
} }
nikicUnsubmitted
Done
ReplyInline Actions

You can remove the entire code starting from here.

nikic: You can remove the entire code starting from here.
tianshilei1992Unsubmitted
Not Done
ReplyInline Actions

we don't need to initialize them anymore?

tianshilei1992: we don't need to initialize them anymore?
Expected<std::unique_ptr<Module>> Expected<std::unique_ptr<Module>>
createModuleFromMemoryBuffer(std::unique_ptr<MemoryBuffer> &MB, createModuleFromMemoryBuffer(std::unique_ptr<MemoryBuffer> &MB,
LLVMContext &Context) { LLVMContext &Context) {
SMDiagnostic Err; SMDiagnostic Err;
auto Mod = parseIR(*MB, Err, Context); auto Mod = parseIR(*MB, Err, Context);
if (!Mod) if (!Mod)
return make_error<StringError>("Failed to create module", return make_error<StringError>("Failed to create module",
▲ Show 20 Lines • Show All 277 Lines • Show Last 20 Lines