This is an archive of the discontinued LLVM Phabricator instance.

Differential D153523

[BPF] Remove unused TableGen classes and multiclasses.
Needs ReviewPublic

Authored by kosarev on Jun 22 2023, 3:58 AM.

Details

Reviewers
yonghong-song
Jiong
Summary

And warn on them from now on.

Diff Detail

Event Timeline

kosarev created this revision.Jun 22 2023, 3:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2023, 3:58 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
kosarev requested review of this revision.Jun 22 2023, 3:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2023, 3:58 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kosarev retitled this revision from TODO: BPF to [BPF] Remove unused TableGen classes and multiclasses..Jun 22 2023, 3:59 AM
kosarev edited the summary of this revision. (Show Details)
kosarev updated this revision to Diff 533540.Jun 22 2023, 3:59 AM
kosarev retitled this revision from [BPF] Remove unused TableGen classes and multiclasses. to TODO: BPF.
kosarev edited the summary of this revision. (Show Details)

Fix commit message.

kosarev retitled this revision from TODO: BPF to [BPF] Remove unused TableGen classes and multiclasses..Jun 22 2023, 4:00 AM
kosarev edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B240457: Diff 533540.Jun 22 2023, 4:14 AM
kosarev added a parent revision: D152373: [TableGen] Support warnings on unused classes and multiclasses..Jun 22 2023, 4:34 AM
kosarev added reviewers: yonghong-song, Jiong.
yonghong-song added inline comments.Jul 26 2023, 9:04 PM
llvm/lib/Target/BPF/CMakeLists.txt
8

This option seems not available to the current 'main' branch. But any way, I don't think we should add an option here. We just need to fix the issue in the above. So feel way to submit a patch with above BPFInstrFormats.td change only. Thanks!

Revision Contents

PathSize
llvm/
lib/
Target/
BPF/
4 lines
2 lines

Diff 533540

llvm/lib/Target/BPF/BPFInstrFormats.td

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
def BPF_XOR : BPFArithOp<0xa>; def BPF_XOR : BPFArithOp<0xa>;
def BPF_MOV : BPFArithOp<0xb>; def BPF_MOV : BPFArithOp<0xb>;
def BPF_ARSH : BPFArithOp<0xc>; def BPF_ARSH : BPFArithOp<0xc>;
def BPF_END : BPFArithOp<0xd>; def BPF_END : BPFArithOp<0xd>;
def BPF_XCHG : BPFArithOp<0xe>; def BPF_XCHG : BPFArithOp<0xe>;
def BPF_CMPXCHG : BPFArithOp<0xf>; def BPF_CMPXCHG : BPFArithOp<0xf>;
class BPFEndDir<bits<1> val> {
bits<1> Value = val;
}
def BPF_TO_LE : BPFSrcType<0x0>; def BPF_TO_LE : BPFSrcType<0x0>;
def BPF_TO_BE : BPFSrcType<0x1>; def BPF_TO_BE : BPFSrcType<0x1>;
class BPFJumpOp<bits<4> val> { class BPFJumpOp<bits<4> val> {
bits<4> Value = val; bits<4> Value = val;
} }
def BPF_JA : BPFJumpOp<0x0>; def BPF_JA : BPFJumpOp<0x0>;
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

llvm/lib/Target/BPF/CMakeLists.txt

add_llvm_component_group(BPF) add_llvm_component_group(BPF)
set(LLVM_TARGET_DEFINITIONS BPF.td) set(LLVM_TARGET_DEFINITIONS BPF.td)
tablegen(LLVM BPFGenAsmMatcher.inc -gen-asm-matcher) tablegen(LLVM BPFGenAsmMatcher.inc -gen-asm-matcher)
tablegen(LLVM BPFGenAsmWriter.inc -gen-asm-writer) tablegen(LLVM BPFGenAsmWriter.inc -gen-asm-writer)
tablegen(LLVM BPFGenCallingConv.inc -gen-callingconv) tablegen(LLVM BPFGenCallingConv.inc -gen-callingconv)
tablegen(LLVM BPFGenDAGISel.inc -gen-dag-isel) tablegen(LLVM BPFGenDAGISel.inc -gen-dag-isel -warn-on-unused-entities)
yonghong-songUnsubmitted
Not Done
ReplyInline Actions

This option seems not available to the current 'main' branch. But any way, I don't think we should add an option here. We just need to fix the issue in the above. So feel way to submit a patch with above BPFInstrFormats.td change only. Thanks!

yonghong-song: This option seems not available to the current 'main' branch. But any way, I don't think we…
tablegen(LLVM BPFGenDisassemblerTables.inc -gen-disassembler) tablegen(LLVM BPFGenDisassemblerTables.inc -gen-disassembler)
tablegen(LLVM BPFGenInstrInfo.inc -gen-instr-info) tablegen(LLVM BPFGenInstrInfo.inc -gen-instr-info)
tablegen(LLVM BPFGenMCCodeEmitter.inc -gen-emitter) tablegen(LLVM BPFGenMCCodeEmitter.inc -gen-emitter)
tablegen(LLVM BPFGenRegisterInfo.inc -gen-register-info) tablegen(LLVM BPFGenRegisterInfo.inc -gen-register-info)
tablegen(LLVM BPFGenSubtargetInfo.inc -gen-subtarget) tablegen(LLVM BPFGenSubtargetInfo.inc -gen-subtarget)
add_public_tablegen_target(BPFCommonTableGen) add_public_tablegen_target(BPFCommonTableGen)
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines