This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ] Fix regression in test macro-prefix-map-lambda.cpp
ClosedPublic

Authored by Kai on Jun 20 2023, 7:34 AM.

Details

Summary

The failing test comes from https://reviews.llvm.org/D152570.
Root cause of the failure is that a string constant on SystemZ
has an alignment of 2, not 1. The CSKY target has a similar problem.
The solution is to replace the fixed number with a regex.

Diff Detail

Event Timeline

Kai created this revision.Jun 20 2023, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2023, 7:34 AM
Kai requested review of this revision.Jun 20 2023, 7:34 AM
Kai edited the summary of this revision. (Show Details)Jun 20 2023, 7:46 AM
zibi accepted this revision.Jun 20 2023, 8:22 AM
zibi added a subscriber: zibi.

LGTM

This revision is now accepted and ready to land.Jun 20 2023, 8:22 AM
tuliom accepted this revision.Jun 21 2023, 5:34 AM

This solves the issue on SystemZ.
Thanks!

uweigand accepted this revision.Jun 21 2023, 5:36 AM

LGTM as well.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 5:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript