Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People tuliom

tuliom (Tulio Magno Quites Machado Filho)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2022, 10:49 AM (41 w, 3 d)

Recent Activity
View All

Fri, Sep 8

tuliom added a comment to D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC..
In D159115#4641834, @mgorny wrote:

Is that actually a regression, or merely the test wasn't checking it before?

Fri, Sep 8, 10:09 AM · Unknown Object (Project), Restricted Project
tuliom added a comment to D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC..

Let me elaborate my previous comment...
I'm using Fedora, which has switched the default long double on ppc64le to IEEE 128-bit floating point.
glibc provides 2 printf implementations on ppc64le (different symbols). The headers control which implementation is used.

Fri, Sep 8, 7:02 AM · Unknown Object (Project), Restricted Project
tuliom added a comment to D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC..
In D159115#4640388, @mgorny wrote:

I'm sorry, by "new" you mean the version with uintptr_t or the original as well?

Fri, Sep 8, 6:25 AM · Unknown Object (Project), Restricted Project

Wed, Sep 6

tuliom added a comment to D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC..

This new test does not work on ppc64le.
The returned addresses are different:

Wed, Sep 6, 1:50 PM · Unknown Object (Project), Restricted Project

Aug 16 2023

tuliom added a comment to D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h.

Are there any plans to align the names of these built-ins with GCC? Their built-ins do not have the _ppc part.

Aug 16 2023, 12:12 PM · Unknown Object (Project), Restricted Project
tuliom accepted D158065: [PowerPC] Implement builtin for mffsl.

LGTM

Aug 16 2023, 11:56 AM · Restricted Project, Unknown Object (Project), Restricted Project

Aug 14 2023

tuliom committed rG94f377d88037: flang: Fix module-debug-file-loc-linux.f90 in standalone (authored by tuliom).
flang: Fix module-debug-file-loc-linux.f90 in standalone
Aug 14 2023, 6:24 AM · Restricted Project, Restricted Project
tuliom closed D157642: flang: Fix module-debug-file-loc-linux.f90 in standalone.
Aug 14 2023, 6:23 AM · Restricted Project, Restricted Project

Aug 11 2023

tuliom added a reviewer for D157642: flang: Fix module-debug-file-loc-linux.f90 in standalone: Restricted Project.
Aug 11 2023, 4:41 AM · Restricted Project, Restricted Project

Aug 10 2023

tuliom requested review of D157642: flang: Fix module-debug-file-loc-linux.f90 in standalone.
Aug 10 2023, 12:28 PM · Restricted Project, Restricted Project

Jul 18 2023

tuliom committed rG1be4db73642f: [clang] scan-view: Remove unused python import (authored by tuliom).
[clang] scan-view: Remove unused python import
Jul 18 2023, 12:13 PM · Unknown Object (Project), Restricted Project
tuliom closed D155192: [clang] scan-view: Remove unused python import.
Jul 18 2023, 12:13 PM · Restricted Project, Unknown Object (Project)

Jul 13 2023

tuliom requested review of D155192: [clang] scan-view: Remove unused python import.
Jul 13 2023, 6:02 AM · Restricted Project, Unknown Object (Project)

Jun 21 2023

tuliom accepted D153352: [SystemZ] Fix regression in test macro-prefix-map-lambda.cpp.

This solves the issue on SystemZ.
Thanks!

Jun 21 2023, 5:34 AM · Unknown Object (Project), Restricted Project

Jun 19 2023

tuliom added inline comments to D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.
Jun 19 2023, 6:16 AM · Unknown Object (Project), Restricted Project

May 19 2023

tuliom committed rG7f9b0685061a: [PowerPC][lit] Recognize triple ppc64le.*-linux (authored by tuliom).
[PowerPC][lit] Recognize triple ppc64le.*-linux
May 19 2023, 9:31 AM · Restricted Project, Restricted Project
tuliom closed D149746: [PowerPC][lit] Recognize triple ppc64le.*-linux.
May 19 2023, 9:30 AM · Restricted Project, Restricted Project

May 18 2023

tuliom accepted D150087: [Clang] Support more stdio builtins.

LGTM.
Thanks!

May 18 2023, 2:00 PM · Restricted Project, Unknown Object (Project)

May 16 2023

tuliom added inline comments to D149746: [PowerPC][lit] Recognize triple ppc64le.*-linux.
May 16 2023, 6:19 AM · Restricted Project, Restricted Project

May 8 2023

tuliom requested changes to D150087: [Clang] Support more stdio builtins.
May 8 2023, 6:50 AM · Restricted Project, Unknown Object (Project)

May 5 2023

tuliom added a comment to D149746: [PowerPC][lit] Recognize triple ppc64le.*-linux.
In D149746#4321215, @qiucf wrote:

Will this also recognize powerpc64le-redhat-linux?

May 5 2023, 6:26 AM · Restricted Project, Restricted Project

May 3 2023

tuliom added a reviewer for D149746: [PowerPC][lit] Recognize triple ppc64le.*-linux: Restricted Project.
May 3 2023, 6:54 AM · Restricted Project, Restricted Project
tuliom requested review of D149746: [PowerPC][lit] Recognize triple ppc64le.*-linux.
May 3 2023, 6:53 AM · Restricted Project, Restricted Project

May 2 2023

tuliom requested changes to D149633: [clang][codegen] Add F128 vsnprintf_chk builtin.

@tbaeder Keep in mind that I don't think this will completely fix issue 61913 because there are other 2 functions affected.
Otherwise, I believe this patch is in the right direction.

May 2 2023, 8:27 AM · Restricted Project, Unknown Object (Project)

Feb 13 2023

tuliom added a comment to D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning.

@qiucf Thanks! I still don't have commit access yet. Could you land this patch for me, please?
Please use “Tulio Magno Quites Machado Filho tuliom@redhat.com” to commit the change.

Feb 13 2023, 7:11 AM · Unknown Object (Project), Restricted Project

Feb 10 2023

tuliom requested review of D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning.
Feb 10 2023, 7:13 AM · Unknown Object (Project), Restricted Project

Jan 13 2023

tuliom removed a watcher for lld: tuliom.
Jan 13 2023, 12:15 PM
tuliom added a comment to D140988: [SystemZ] Implement lowering of GET_ROUNDING.

@uweigand I don't have commit access yet. If this new revision is still good, could you land this patch for me, please?
Please use “Tulio Magno Quites Machado Filho tuliom@redhat.com” to commit the change.

Jan 13 2023, 4:31 AM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom updated the diff for D140988: [SystemZ] Implement lowering of GET_ROUNDING.

In this revision, I fix the last missing parts from @nikic 's suggestions:

Jan 13 2023, 4:29 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jan 11 2023

tuliom updated the diff for D140988: [SystemZ] Implement lowering of GET_ROUNDING.

@uweigand You're right.
I hadn't realized the changes to RetVal.
This revision includes that modification.

Jan 11 2023, 1:15 PM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom added inline comments to D140988: [SystemZ] Implement lowering of GET_ROUNDING.
Jan 11 2023, 12:38 PM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom updated the diff for D140988: [SystemZ] Implement lowering of GET_ROUNDING.

Changes since revision 3:

Jan 11 2023, 12:38 PM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom added a comment to D140988: [SystemZ] Implement lowering of GET_ROUNDING.
In D140988#4042746, @uweigand wrote:
CWD1 = efpc() & 3
CWD2 = (CWD1 ^ (CWD1 >> 1)) ^ 1
Jan 11 2023, 12:11 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Jan 10 2023

tuliom added inline comments to D140988: [SystemZ] Implement lowering of GET_ROUNDING.
Jan 10 2023, 12:40 PM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom added inline comments to D140988: [SystemZ] Implement lowering of GET_ROUNDING.
Jan 10 2023, 11:59 AM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom updated the diff for D140988: [SystemZ] Implement lowering of GET_ROUNDING.

Fix the issues pointed out by @uweigand.

Jan 10 2023, 11:57 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jan 5 2023

tuliom added inline comments to D140988: [SystemZ] Implement lowering of GET_ROUNDING.
Jan 5 2023, 5:06 AM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom updated the diff for D140988: [SystemZ] Implement lowering of GET_ROUNDING.

I'm fixing the issues pointed out by @Kai and I'm also fixing formatting issues.

Jan 5 2023, 5:05 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jan 4 2023

tuliom requested review of D140988: [SystemZ] Implement lowering of GET_ROUNDING.
Jan 4 2023, 6:53 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 13 2022

tuliom added a comment to D139450: Warn about unsupported ibmlongdouble.

Thanks @qiucf ! I don't have commit access yet. Could you land this patch for me, please?
Please use “Tulio Magno Quites Machado Filho tuliom@redhat.com” to commit the change.

Dec 13 2022, 8:30 AM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom added inline comments to D139450: Warn about unsupported ibmlongdouble.
Dec 13 2022, 5:46 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 9 2022

tuliom added inline comments to D139450: Warn about unsupported ibmlongdouble.
Dec 9 2022, 1:53 PM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom updated the diff for D139450: Warn about unsupported ibmlongdouble.

Fix the issues pointed by @nikic.

Dec 9 2022, 1:29 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 8 2022

tuliom added a comment to D139450: Warn about unsupported ibmlongdouble.
In D139450#3981486, @qiucf wrote:

Thanks for the patch! But does libc++ support to be built with -mabi=ieeelongdouble now?

Dec 8 2022, 8:25 AM · Restricted Project, Restricted Project, Unknown Object (Project)
tuliom added a watcher for lld: tuliom.
Dec 8 2022, 6:16 AM

Dec 7 2022

tuliom updated the diff for D139450: Warn about unsupported ibmlongdouble.

I'm attaching a new version of the patch.

Dec 7 2022, 4:54 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 6 2022

tuliom requested review of D139450: Warn about unsupported ibmlongdouble.
Dec 6 2022, 11:43 AM · Restricted Project, Restricted Project, Unknown Object (Project)