Page MenuHomePhabricator

dankm (Dan McGregor)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2015, 6:49 PM (195 w, 1 d)

Recent Activity

Thu, Aug 8

dankm abandoned D65556: Phabricator D49466.
Thu, Aug 8, 8:14 AM · Restricted Project, Restricted Project
dankm added a comment to D65556: Phabricator D49466.

Please fix patch title and description

Thu, Aug 8, 8:09 AM · Restricted Project, Restricted Project

Wed, Jul 31

dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

@dankm are you still working on this patch?

Wed, Jul 31, 9:39 PM · Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Latest changes. I've been sitting on these for months, so I don't remember all that changed. The path remapping contract changed somewhat, and it's now based on the git monorepo.

Wed, Jul 31, 9:39 PM · Restricted Project, Restricted Project
dankm created D65556: Phabricator D49466.
Wed, Jul 31, 9:30 PM · Restricted Project, Restricted Project

Jan 23 2019

dankm updated the diff for D56769: Path: enhance prefix mapping.

Nail down the contract a bit.
Add a flag for strict path matching.
I think there's still unresolved issues with tests.

Jan 23 2019, 7:38 PM · Restricted Project

Jan 17 2019

dankm added a reviewer for D56769: Path: enhance prefix mapping: tejohnson.
Jan 17 2019, 6:44 AM · Restricted Project

Jan 16 2019

dankm updated the diff for D56769: Path: enhance prefix mapping.

Attempt to document and test the desired interface.

Jan 16 2019, 4:13 PM · Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Move trailing path separator stripping back to Clang.

Jan 16 2019, 12:32 PM · Restricted Project, Restricted Project
dankm added inline comments to D56769: Path: enhance prefix mapping.
Jan 16 2019, 12:28 PM · Restricted Project
dankm updated the diff for D56769: Path: enhance prefix mapping.

Rewrote and simplified the replace_path_prefix function, and added a bunch of tests to catch corner cases I noticed during testing.

Jan 16 2019, 12:26 PM · Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Sure, I'll (eventually) make a separate review.

Jan 16 2019, 7:45 AM · Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Undo accidental change.

Jan 16 2019, 7:44 AM · Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Update style.

Jan 16 2019, 6:51 AM · Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
I'll update the style nit, and spend some non-tired time on the string remapping. Thanks
Jan 16 2019, 6:49 AM · Restricted Project, Restricted Project

Jan 15 2019

dankm added reviewers for D56769: Path: enhance prefix mapping: joerg, Lekensteyn.
Jan 15 2019, 8:25 PM · Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Enforce path mapping. This requires LLVM review D56769.

Jan 15 2019, 7:23 PM · Restricted Project, Restricted Project
dankm created D56769: Path: enhance prefix mapping.
Jan 15 2019, 7:20 PM · Restricted Project

Jan 14 2019

dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jan 14 2019, 8:10 AM · Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Restored original test case file names.

Jan 14 2019, 8:07 AM · Restricted Project, Restricted Project

Jan 11 2019

dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Could you add more tests to check the error message for bad options (missing =):

-fdebug-prefix-map=bad
-fmacro-prefix-map=bad
-ffile-prefix-map=bad
Jan 11 2019, 1:33 PM · Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

renamed err_drv_invalid_argument_to_prefix_map to err_drv_invalid_argument_to_option
added more frontend tests for macro-prefix-map and file-prefix-map.

Jan 11 2019, 1:29 PM · Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Made diagnostics for file-prefix-map display the actual option name.

Jan 11 2019, 9:04 AM · Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

It would be nice to have this for Clang 8.0, the branch date is within 5 days :)

Jan 11 2019, 8:39 AM · Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

FYI, according to my comment on D49652, assuming I checked it correctly, gcc applies the maps in reverse order of command line specification, not sorted order. It seems unlikely that anyone is actually depending on the order though.

Jan 11 2019, 6:33 AM · Restricted Project, Restricted Project

Jan 10 2019

dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Added unit tests for the prefix remapping.

Jan 10 2019, 2:05 PM · Restricted Project, Restricted Project
dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jan 10 2019, 11:37 AM · Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

PostgreSQL 11 is now using LLVM to do JITing of SQL expressions. We'd need this feature to strip the build directory off the .bc bitcode files so the .deb packages build reproducibly.
@dankm: Are you still working on this? What can we do to help getting this move forward?

Jan 10 2019, 11:33 AM · Restricted Project, Restricted Project

Jul 19 2018

dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 19 2018, 9:40 AM · Restricted Project, Restricted Project
dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 19 2018, 8:41 AM · Restricted Project, Restricted Project

Jul 18 2018

dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Address some of the comments by erichkeane and joerg.

Jul 18 2018, 3:12 PM · Restricted Project, Restricted Project
dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 18 2018, 2:51 PM · Restricted Project, Restricted Project
dankm added a reviewer for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map: joerg.
Jul 18 2018, 10:16 AM · Restricted Project, Restricted Project
dankm added reviewers for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map: rnk, erichkeane.
Jul 18 2018, 10:10 AM · Restricted Project, Restricted Project

Jul 17 2018

dankm added a reviewer for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map: rsmith.
Jul 17 2018, 9:02 PM · Restricted Project, Restricted Project
dankm added a reviewer for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map: echristo.
Jul 17 2018, 9:01 PM · Restricted Project, Restricted Project
dankm created D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 17 2018, 8:51 PM · Restricted Project, Restricted Project

Nov 30 2015

dankm added inline comments to D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback..
Nov 30 2015, 7:44 AM

Nov 27 2015

dankm removed rL LLVM as the repository for D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback..
Nov 27 2015, 7:38 PM
dankm added reviewers for D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback.: eugenis, kutuzov.viktor.84.
Nov 27 2015, 7:31 PM
dankm retitled D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback. from Skip all non-shared objects in FindFirstDSOCallback. to [asan] Skip all non-shared objects in FindFirstDSOCallback..
Nov 27 2015, 7:22 PM
dankm updated subscribers of D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback..
Nov 27 2015, 7:14 PM
dankm added reviewers for D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback.: llvm-commits, dim.
Nov 27 2015, 7:12 PM
dankm added a comment to D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback..

The changes to CMakeLists.txt are to ensure that the shared runtime doesn't link libc before libthr. If that happens then the pthread implementation doesn't get intercepted properly.

Nov 27 2015, 7:10 PM
dankm retitled D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback. from to Skip all non-shared objects in FindFirstDSOCallback..
Nov 27 2015, 7:07 PM