Update release notes

Thanks, I'll update the release notes & description right away.

@MaskRay if this meets your approval, are you able to commit it for me?

Maybe for the description something like:

Renamed & cleaned up unit tests

Avoiding "Fix" in the description is a good suggestion. Whether it's a bugfix or not is a matter of perspective, and what's really happening here is I'm adjusting compliant implementation defined behavior, not really fixing it.

Fix unit tests on windows

Rebase and hopefully fix builds.

Fix typo in release notes

Added unit test

Despite needing unit tests, I'd like some eyes on this change.

In D149272#4306103, @aaron.ballman wrote:

LGTM, but please add a release note when landing.

Rebase & add add release note.

I certainly like the idea. I'll spend some time later looking at the implementation, but from a quick glance it looks good.

In D148975#4296895, @MaskRay wrote:

Thank you! I feel that specifying multiple -fdebug-prefix-map= is a very uncommon situation, so a release note entry is likely overkill.
I updated the HelpText, though.

Correct test case

In D149272#4301103, @raj.khem wrote:

This would fix https://github.com/llvm/llvm-project/issues/62192

And restore original change

Add test case

Hoorat for me. I just managed to produce a reduced test case. That'll be added to the review.

This fixes an issue I wasn't able to reduce. Some lambdas wound up with the real filename in their name, rather than the remapped path from -ffile-prefix-map.

Thanks! Since I don't have privileges to push, can you do that on my behalf?

In D135284#3886471, @MaskRay wrote:

In D135284#3886469, @dankm wrote:

Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary.

Did you upload a new patch to the differential? I cannot see it.

Added a simple testcase, and updated commit message.

Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary.

In D132390#3757188, @MaskRay wrote:

I've created https://github.com/llvm/llvm-project/issues/57437 for 15.0.0 backport. If it is too late, we can request 15.0.1 backport.

Is it possible to get this into 15? Or do we need to wait for 16 at this point?

Since I don't have commit access, can one of you commit this for me, please?

One more attemt to fix Windows tests before I actually install a
Windows VM to work on it..

Attempt to fix the test case on Windows.

Use subdirectory rather than substring prefix matching in unit test.

In D132390#3742950, @dankm wrote:

Sure it does. It's somewhat undocumented, and arguably a bug in its own right (I was torn when I implemented the original prefix mapping stuff), but it's a simple prefix substitution. /t=/lu turns /tmp into /lump happily.

In D132390#3741646, @MaskRay wrote:

The test doesn't help. %t=... does not match the path component %t.foo. A nested directory is needed to test the situation.

Updated debug-prefix-map.s test cases to detect this.

In D132390#3740751, @dblaikie wrote:

Test case?

Run clang-format

I'm thinking about changing all the definitions of DebugPrefixMap like structures to just one named type, so that this is consistent everywhere.

I like the idea of this, and fits what I had in mind for the original D49466 review. I want to take a closer look, but right now LGTM.

In D49466#1760860, @MaskRay wrote:

Add back remapDIPath that was unintentionally deleted by D69213, caught by a test.

Small adjustment of the code

Ping?

In D56769#1624345, @Lekensteyn wrote:

Should this be abandoned for D49466?

In D49466#1681534, @phosek wrote:

@dankm is it OK if we take over this change to push it forward?

• Address feedback from @Lekensteyn

Whoops. There are extra changes here I didn't mean to submit :/

• Address feedback from @Lekensteyn

In D65556#1610001, @lebedev.ri wrote:

Please fix patch title and description

In D49466#1586140, @manojgupta wrote:

@dankm are you still working on this patch?

Latest changes. I've been sitting on these for months, so I don't remember all that changed. The path remapping contract changed somewhat, and it's now based on the git monorepo.

Nail down the contract a bit.
Add a flag for strict path matching.
I think there's still unresolved issues with tests.

Attempt to document and test the desired interface.

Move trailing path separator stripping back to Clang.

Rewrote and simplified the replace_path_prefix function, and added a bunch of tests to catch corner cases I noticed during testing.

Sure, I'll (eventually) make a separate review.

Undo accidental change.

Update style.

Enforce path mapping. This requires LLVM review D56769.

Restored original test case file names.

In D49466#1354468, @Lekensteyn wrote:

Could you add more tests to check the error message for bad options (missing =):

-fdebug-prefix-map=bad
-fmacro-prefix-map=bad
-ffile-prefix-map=bad

renamed err_drv_invalid_argument_to_prefix_map to err_drv_invalid_argument_to_option
added more frontend tests for macro-prefix-map and file-prefix-map.

Made diagnostics for file-prefix-map display the actual option name.

In D49466#1354238, @Lekensteyn wrote:

It would be nice to have this for Clang 8.0, the branch date is within 5 days :)

In D49466#1353437, @alxu wrote:

FYI, according to my comment on D49652, assuming I checked it correctly, gcc applies the maps in reverse order of command line specification, not sorted order. It seems unlikely that anyone is actually depending on the order though.

Added unit tests for the prefix remapping.

In D49466#1296790, @ChristophBerg wrote:

PostgreSQL 11 is now using LLVM to do JITing of SQL expressions. We'd need this feature to strip the build directory off the .bc bitcode files so the .deb packages build reproducibly.
@dankm: Are you still working on this? What can we do to help getting this move forward?

Address some of the comments by erichkeane and joerg.