Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

dankm (Dan McGregor)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 27 2015, 6:49 PM (409 w, 11 h)

Recent Activity

Jun 15 2023

dankm updated the summary of D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.
Jun 15 2023, 4:09 PM · Restricted Project, Restricted Project
dankm updated the diff for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Update release notes

Jun 15 2023, 3:59 PM · Restricted Project, Restricted Project
dankm added a comment to D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Thanks, I'll update the release notes & description right away.

Jun 15 2023, 3:58 PM · Restricted Project, Restricted Project

Jun 13 2023

dankm added a comment to D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

@MaskRay if this meets your approval, are you able to commit it for me?

Jun 13 2023, 8:23 AM · Restricted Project, Restricted Project

Jun 12 2023

dankm retitled D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments from [clang] Fix filename remapping in template arguments to [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.
Jun 12 2023, 9:27 PM · Restricted Project, Restricted Project
dankm added a comment to D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Maybe for the description something like:

Jun 12 2023, 9:27 PM · Restricted Project, Restricted Project
dankm updated the diff for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Renamed & cleaned up unit tests

Jun 12 2023, 9:21 PM · Restricted Project, Restricted Project
dankm added a comment to D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Avoiding "Fix" in the description is a good suggestion. Whether it's a bugfix or not is a matter of perspective, and what's really happening here is I'm adjusting compliant implementation defined behavior, not really fixing it.

Jun 12 2023, 9:14 PM · Restricted Project, Restricted Project
dankm updated the diff for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Fix unit tests on windows

Jun 12 2023, 12:35 PM · Restricted Project, Restricted Project
dankm updated the diff for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Rebase and hopefully fix builds.

Jun 12 2023, 9:55 AM · Restricted Project, Restricted Project

Jun 9 2023

dankm retitled D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments from [clang] Fix file mapping template arguments to [clang] Fix filename remapping in template arguments.
Jun 9 2023, 2:08 PM · Restricted Project, Restricted Project
dankm updated the diff for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Fix typo in release notes

Jun 9 2023, 1:39 PM · Restricted Project, Restricted Project
dankm updated the diff for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.

Added unit test

Jun 9 2023, 1:29 PM · Restricted Project, Restricted Project
dankm added inline comments to D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments.
Jun 9 2023, 12:47 PM · Restricted Project, Restricted Project
dankm added reviewers for D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments: MaskRay, aaron.ballman.
Jun 9 2023, 12:21 PM · Restricted Project, Restricted Project
dankm published D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments for review.

Despite needing unit tests, I'd like some eyes on this change.

Jun 9 2023, 12:06 PM · Restricted Project, Restricted Project

May 2 2023

dankm updated the summary of D149272: [clang] Call printName to get name of Decl.
May 2 2023, 8:26 AM · debug-info, Restricted Project, Restricted Project

Apr 28 2023

dankm added a comment to D149272: [clang] Call printName to get name of Decl.

LGTM, but please add a release note when landing.

Apr 28 2023, 2:07 PM · debug-info, Restricted Project, Restricted Project
dankm updated the diff for D149272: [clang] Call printName to get name of Decl.

Rebase & add add release note.

Apr 28 2023, 2:06 PM · debug-info, Restricted Project, Restricted Project

Apr 27 2023

dankm added a comment to D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking.

I certainly like the idea. I'll spend some time later looking at the implementation, but from a quick glance it looks good.

Apr 27 2023, 2:52 PM · Restricted Project, Restricted Project
dankm added a comment to D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match.

Thank you! I feel that specifying multiple -fdebug-prefix-map= is a very uncommon situation, so a release note entry is likely overkill.
I updated the HelpText, though.

Apr 27 2023, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
dankm added a reviewer for D149272: [clang] Call printName to get name of Decl: debug-info.
Apr 27 2023, 2:42 PM · debug-info, Restricted Project, Restricted Project
dankm added a project to D149272: [clang] Call printName to get name of Decl: debug-info.
Apr 27 2023, 1:03 PM · debug-info, Restricted Project, Restricted Project
dankm updated the diff for D149272: [clang] Call printName to get name of Decl.

Correct test case

Apr 27 2023, 9:08 AM · debug-info, Restricted Project, Restricted Project
dankm added inline comments to D149272: [clang] Call printName to get name of Decl.
Apr 27 2023, 9:03 AM · debug-info, Restricted Project, Restricted Project
dankm added inline comments to D149272: [clang] Call printName to get name of Decl.
Apr 27 2023, 8:48 AM · debug-info, Restricted Project, Restricted Project

Apr 26 2023

dankm added a comment to D149272: [clang] Call printName to get name of Decl.
Apr 26 2023, 9:48 PM · debug-info, Restricted Project, Restricted Project
dankm updated the diff for D149272: [clang] Call printName to get name of Decl.

And restore original change

Apr 26 2023, 6:54 PM · debug-info, Restricted Project, Restricted Project
dankm updated the diff for D149272: [clang] Call printName to get name of Decl.

Add test case

Apr 26 2023, 6:53 PM · debug-info, Restricted Project, Restricted Project
dankm added a comment to D149272: [clang] Call printName to get name of Decl.

Hoorat for me. I just managed to produce a reduced test case. That'll be added to the review.

Apr 26 2023, 4:43 PM · debug-info, Restricted Project, Restricted Project
dankm added inline comments to D149272: [clang] Call printName to get name of Decl.
Apr 26 2023, 1:35 PM · debug-info, Restricted Project, Restricted Project
dankm added a comment to D149272: [clang] Call printName to get name of Decl.

This fixes an issue I wasn't able to reduce. Some lambdas wound up with the real filename in their name, rather than the remapped path from -ffile-prefix-map.

Apr 26 2023, 10:26 AM · debug-info, Restricted Project, Restricted Project
dankm requested review of D149272: [clang] Call printName to get name of Decl.
Apr 26 2023, 10:23 AM · debug-info, Restricted Project, Restricted Project

Dec 12 2022

dankm added inline comments to D136554: Implement CWG2631.
Dec 12 2022, 3:13 PM · Restricted Project, Restricted Project

Oct 26 2022

dankm added a comment to D135284: [Driver] allow target override containing . in executable name.

Thanks! Since I don't have privileges to push, can you do that on my behalf?

Oct 26 2022, 2:03 PM · Restricted Project, Restricted Project
dankm retitled D135284: [Driver] allow target override containing . in executable name from [Driver] select alternative target containing . in executable name to [Driver] allow target override containing . in executable name.
Oct 26 2022, 1:42 PM · Restricted Project, Restricted Project
dankm added a comment to D135284: [Driver] allow target override containing . in executable name.

Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary.

Did you upload a new patch to the differential? I cannot see it.

Oct 26 2022, 1:41 PM · Restricted Project, Restricted Project
dankm updated the diff for D135284: [Driver] allow target override containing . in executable name.

Added a simple testcase, and updated commit message.

Oct 26 2022, 1:40 PM · Restricted Project, Restricted Project
dankm added a comment to D135284: [Driver] allow target override containing . in executable name.

Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary.

Oct 26 2022, 1:34 PM · Restricted Project, Restricted Project

Oct 21 2022

dankm retitled D135284: [Driver] allow target override containing . in executable name from RFC: [Driver] select alternative target containing . in executable name to [Driver] select alternative target containing . in executable name.
Oct 21 2022, 12:19 PM · Restricted Project, Restricted Project

Oct 5 2022

dankm added a reviewer for D135284: [Driver] allow target override containing . in executable name: dim.
Oct 5 2022, 4:32 PM · Restricted Project, Restricted Project
dankm published D135284: [Driver] allow target override containing . in executable name for review.
Oct 5 2022, 10:19 AM · Restricted Project, Restricted Project

Aug 31 2022

dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

I've created https://github.com/llvm/llvm-project/issues/57437 for 15.0.0 backport. If it is too late, we can request 15.0.1 backport.

Aug 31 2022, 10:41 AM · Restricted Project, Restricted Project

Aug 29 2022

dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Is it possible to get this into 15? Or do we need to wait for 16 at this point?

Aug 29 2022, 6:12 PM · Restricted Project, Restricted Project

Aug 24 2022

dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Since I don't have commit access, can one of you commit this for me, please?

Aug 24 2022, 7:08 PM · Restricted Project, Restricted Project
dankm updated the diff for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

One more attemt to fix Windows tests before I actually install a
Windows VM to work on it..

Aug 24 2022, 2:37 PM · Restricted Project, Restricted Project
dankm updated the diff for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Attempt to fix the test case on Windows.

Aug 24 2022, 8:56 AM · Restricted Project, Restricted Project
dankm added inline comments to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.
Aug 24 2022, 6:40 AM · Restricted Project, Restricted Project

Aug 23 2022

dankm updated the diff for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Use subdirectory rather than substring prefix matching in unit test.

Aug 23 2022, 4:21 PM · Restricted Project, Restricted Project
dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Sure it does. It's somewhat undocumented, and arguably a bug in its own right (I was torn when I implemented the original prefix mapping stuff), but it's a simple prefix substitution. /t=/lu turns /tmp into /lump happily.

Aug 23 2022, 9:19 AM · Restricted Project, Restricted Project
dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

The test doesn't help. %t=... does not match the path component %t.foo. A nested directory is needed to test the situation.

Aug 23 2022, 8:54 AM · Restricted Project, Restricted Project

Aug 22 2022

dankm updated the diff for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Updated debug-prefix-map.s test cases to detect this.

Aug 22 2022, 2:22 PM · Restricted Project, Restricted Project
dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Test case?

Aug 22 2022, 2:19 PM · Restricted Project, Restricted Project
dankm updated the diff for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

Run clang-format

Aug 22 2022, 1:04 PM · Restricted Project, Restricted Project
dankm added a reviewer for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info: debug-info.
Aug 22 2022, 9:52 AM · Restricted Project, Restricted Project
dankm added a comment to D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.

I'm thinking about changing all the definitions of DebugPrefixMap like structures to just one named type, so that this is consistent everywhere.

Aug 22 2022, 9:36 AM · Restricted Project, Restricted Project
dankm added reviewers for D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info: MaskRay, dblaikie, raj.khem.
Aug 22 2022, 9:34 AM · Restricted Project, Restricted Project
dankm requested review of D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info.
Aug 22 2022, 9:25 AM · Restricted Project, Restricted Project

May 5 2020

dankm added a comment to D76869: [Clang] Restore replace_path_prefix instead of startswith .

I like the idea of this, and fits what I had in mind for the original D49466 review. I want to take a closer look, but right now LGTM.

May 5 2020, 9:01 PM · Restricted Project, Restricted Project
dankm accepted D75012: [ReleaseNotes] Mention -fmacro-prefix-map and -ffile-prefix-map..
May 5 2020, 9:01 PM · Restricted Project

Nov 26 2019

dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Add back remapDIPath that was unintentionally deleted by D69213, caught by a test.

Small adjustment of the code

Nov 26 2019, 3:42 PM · Restricted Project, Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Ping?

Nov 26 2019, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2019

dankm abandoned D56769: Path: enhance prefix mapping.

Should this be abandoned for D49466?

Nov 25 2019, 2:48 PM · Restricted Project

Nov 18 2019

dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

@dankm is it OK if we take over this change to push it forward?

Nov 18 2019, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Nov 18 2019, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Whoops. There are extra changes here I didn't mean to submit :/

Nov 18 2019, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Nov 18 2019, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Nov 18 2019, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2019

dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Nov 17 2019, 3:19 PM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2019

dankm abandoned D65556: Phabricator D49466.
Aug 8 2019, 8:14 AM · Restricted Project, Restricted Project
dankm added a comment to D65556: Phabricator D49466.

Please fix patch title and description

Aug 8 2019, 8:09 AM · Restricted Project, Restricted Project

Jul 31 2019

dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

@dankm are you still working on this patch?

Jul 31 2019, 9:39 PM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Latest changes. I've been sitting on these for months, so I don't remember all that changed. The path remapping contract changed somewhat, and it's now based on the git monorepo.

Jul 31 2019, 9:39 PM · Restricted Project, Restricted Project, Restricted Project
dankm created D65556: Phabricator D49466.
Jul 31 2019, 9:30 PM · Restricted Project, Restricted Project

Jan 23 2019

dankm updated the diff for D56769: Path: enhance prefix mapping.

Nail down the contract a bit.
Add a flag for strict path matching.
I think there's still unresolved issues with tests.

Jan 23 2019, 7:38 PM · Restricted Project

Jan 17 2019

dankm added a reviewer for D56769: Path: enhance prefix mapping: tejohnson.
Jan 17 2019, 6:44 AM · Restricted Project

Jan 16 2019

dankm updated the diff for D56769: Path: enhance prefix mapping.

Attempt to document and test the desired interface.

Jan 16 2019, 4:13 PM · Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Move trailing path separator stripping back to Clang.

Jan 16 2019, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
dankm added inline comments to D56769: Path: enhance prefix mapping.
Jan 16 2019, 12:28 PM · Restricted Project
dankm updated the diff for D56769: Path: enhance prefix mapping.

Rewrote and simplified the replace_path_prefix function, and added a bunch of tests to catch corner cases I noticed during testing.

Jan 16 2019, 12:26 PM · Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Sure, I'll (eventually) make a separate review.

Jan 16 2019, 7:45 AM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Undo accidental change.

Jan 16 2019, 7:44 AM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Update style.

Jan 16 2019, 6:51 AM · Restricted Project, Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
I'll update the style nit, and spend some non-tired time on the string remapping. Thanks
Jan 16 2019, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Jan 15 2019

dankm added reviewers for D56769: Path: enhance prefix mapping: joerg, Lekensteyn.
Jan 15 2019, 8:25 PM · Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Enforce path mapping. This requires LLVM review D56769.

Jan 15 2019, 7:23 PM · Restricted Project, Restricted Project, Restricted Project
dankm created D56769: Path: enhance prefix mapping.
Jan 15 2019, 7:20 PM · Restricted Project

Jan 14 2019

dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jan 14 2019, 8:10 AM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Restored original test case file names.

Jan 14 2019, 8:07 AM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2019

dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Could you add more tests to check the error message for bad options (missing =):

-fdebug-prefix-map=bad
-fmacro-prefix-map=bad
-ffile-prefix-map=bad
Jan 11 2019, 1:33 PM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

renamed err_drv_invalid_argument_to_prefix_map to err_drv_invalid_argument_to_option
added more frontend tests for macro-prefix-map and file-prefix-map.

Jan 11 2019, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Made diagnostics for file-prefix-map display the actual option name.

Jan 11 2019, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

It would be nice to have this for Clang 8.0, the branch date is within 5 days :)

Jan 11 2019, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

FYI, according to my comment on D49652, assuming I checked it correctly, gcc applies the maps in reverse order of command line specification, not sorted order. It seems unlikely that anyone is actually depending on the order though.

Jan 11 2019, 6:33 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2019

dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Added unit tests for the prefix remapping.

Jan 10 2019, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jan 10 2019, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
dankm added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

PostgreSQL 11 is now using LLVM to do JITing of SQL expressions. We'd need this feature to strip the build directory off the .bc bitcode files so the .deb packages build reproducibly.
@dankm: Are you still working on this? What can we do to help getting this move forward?

Jan 10 2019, 11:33 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2018

dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 19 2018, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
dankm added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Jul 19 2018, 8:41 AM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2018

dankm updated the diff for D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

Address some of the comments by erichkeane and joerg.

Jul 18 2018, 3:12 PM · Restricted Project, Restricted Project, Restricted Project