User Details
- User Since
- Nov 27 2015, 6:49 PM (409 w, 11 h)
Jun 15 2023
Update release notes
Thanks, I'll update the release notes & description right away.
Jun 13 2023
@MaskRay if this meets your approval, are you able to commit it for me?
Jun 12 2023
Maybe for the description something like:
Renamed & cleaned up unit tests
Avoiding "Fix" in the description is a good suggestion. Whether it's a bugfix or not is a matter of perspective, and what's really happening here is I'm adjusting compliant implementation defined behavior, not really fixing it.
Fix unit tests on windows
Rebase and hopefully fix builds.
Jun 9 2023
Fix typo in release notes
Added unit test
Despite needing unit tests, I'd like some eyes on this change.
May 2 2023
Apr 28 2023
Rebase & add add release note.
Apr 27 2023
I certainly like the idea. I'll spend some time later looking at the implementation, but from a quick glance it looks good.
Correct test case
Apr 26 2023
And restore original change
Add test case
Hoorat for me. I just managed to produce a reduced test case. That'll be added to the review.
This fixes an issue I wasn't able to reduce. Some lambdas wound up with the real filename in their name, rather than the remapped path from -ffile-prefix-map.
Dec 12 2022
Oct 26 2022
Thanks! Since I don't have privileges to push, can you do that on my behalf?
Added a simple testcase, and updated commit message.
Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary.
Oct 21 2022
Oct 5 2022
Aug 31 2022
Aug 29 2022
Is it possible to get this into 15? Or do we need to wait for 16 at this point?
Aug 24 2022
Since I don't have commit access, can one of you commit this for me, please?
One more attemt to fix Windows tests before I actually install a
Windows VM to work on it..
Attempt to fix the test case on Windows.
Aug 23 2022
Use subdirectory rather than substring prefix matching in unit test.
Aug 22 2022
Updated debug-prefix-map.s test cases to detect this.
Run clang-format
I'm thinking about changing all the definitions of DebugPrefixMap like structures to just one named type, so that this is consistent everywhere.
May 5 2020
I like the idea of this, and fits what I had in mind for the original D49466 review. I want to take a closer look, but right now LGTM.
Nov 26 2019
Ping?
Nov 25 2019
Nov 18 2019
- Address feedback from @Lekensteyn
Whoops. There are extra changes here I didn't mean to submit :/
- Address feedback from @Lekensteyn
Nov 17 2019
Aug 8 2019
Jul 31 2019
Latest changes. I've been sitting on these for months, so I don't remember all that changed. The path remapping contract changed somewhat, and it's now based on the git monorepo.
Jan 23 2019
Nail down the contract a bit.
Add a flag for strict path matching.
I think there's still unresolved issues with tests.
Jan 17 2019
Jan 16 2019
Attempt to document and test the desired interface.
Move trailing path separator stripping back to Clang.
Rewrote and simplified the replace_path_prefix function, and added a bunch of tests to catch corner cases I noticed during testing.
Sure, I'll (eventually) make a separate review.
Undo accidental change.
Update style.
I'll update the style nit, and spend some non-tired time on the string remapping. Thanks
Jan 15 2019
Enforce path mapping. This requires LLVM review D56769.
Jan 14 2019
Restored original test case file names.
Jan 11 2019
renamed err_drv_invalid_argument_to_prefix_map to err_drv_invalid_argument_to_option
added more frontend tests for macro-prefix-map and file-prefix-map.
Made diagnostics for file-prefix-map display the actual option name.
Jan 10 2019
Added unit tests for the prefix remapping.
Jul 19 2018
Jul 18 2018
Address some of the comments by erichkeane and joerg.