This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Do not release VGPRs if there may be pending scratch stores
ClosedPublic

Authored by foad on Jun 19 2023, 9:12 AM.

Diff Detail

Event Timeline

foad created this revision.Jun 19 2023, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 9:12 AM
foad requested review of this revision.Jun 19 2023, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 9:12 AM
gandhi21299 added inline comments.
llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
1420

Shouldn't this return true?

arsenm added inline comments.Jun 19 2023, 9:54 AM
llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
1420

It should be false but the comment should say never not always

rampitec accepted this revision.Jun 19 2023, 10:35 AM

LGTM (modulo the comment).

This revision is now accepted and ready to land.Jun 19 2023, 10:35 AM
This revision was landed with ongoing or failed builds.Jun 19 2023, 1:17 PM
This revision was automatically updated to reflect the committed changes.