Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/AMDGPU/v_mac.ll | ||
---|---|---|
9 | The tests in these files appear to check for usage of mac or mad. So we would need to know whether equivalent fma/fmac should be expected on GFX11, and why they are not present. There are other tests for fma on GFX11, though I'm not sure if they cover similar cases. Additionally, the hand written tests basically look for a single instruction. It seems a shame to reduce that clarity. It might be better to skip this patch. |
llvm/test/CodeGen/AMDGPU/v_mac.ll | ||
---|---|---|
9 | Or, alternatively, maybe file a ticket, add a TODO and let the test catch the changes in the output? |
llvm/test/CodeGen/AMDGPU/v_mac.ll | ||
---|---|---|
9 | That is potentially an option. But if we knew at this moment there was no way to produce fma on GFX11 from the input IR, I would prefer not to land this patch, and there would be no ticket to file. |
llvm/test/CodeGen/AMDGPU/v_mac.ll | ||
---|---|---|
9 | It's not legal because these don't have the contract flag. mad requires no denormals but doesn't require contract. fma requires contract but respects the denormal mode |
The tests in these files appear to check for usage of mac or mad. So we would need to know whether equivalent fma/fmac should be expected on GFX11, and why they are not present. There are other tests for fma on GFX11, though I'm not sure if they cover similar cases. Additionally, the hand written tests basically look for a single instruction. It seems a shame to reduce that clarity. It might be better to skip this patch.