This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GFX11] Add test coverage for 16-bit conversions, part 8.
ClosedPublic

Authored by kosarev on Jun 13 2023, 5:37 AM.

Diff Detail

Event Timeline

kosarev created this revision.Jun 13 2023, 5:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 5:37 AM
kosarev requested review of this revision.Jun 13 2023, 5:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 5:37 AM
kosarev updated this revision to Diff 530964.Jun 13 2023, 10:03 AM

Removed unused prefixes.

kosarev updated this revision to Diff 531284.Jun 14 2023, 5:40 AM

Removed converted manual tests.

kosarev edited the summary of this revision. (Show Details)Jun 14 2023, 5:53 AM
Joe_Nash accepted this revision.Jun 14 2023, 6:50 AM
Joe_Nash added inline comments.
llvm/test/CodeGen/AMDGPU/v_madak_f16.ll
74

Nit: Why aren't we using v_fmaak or v_fmamk here?

This revision is now accepted and ready to land.Jun 14 2023, 6:50 AM
foad added inline comments.Jun 15 2023, 9:16 AM
llvm/test/CodeGen/AMDGPU/v_madak_f16.ll
74

It's not allowed to fuse mul+add->fma by default, without "contract" or some other fast math flags.