This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] Use transform.apply_patterns in vector tests
ClosedPublic

Authored by springerm on Jun 5 2023, 9:06 AM.

Details

Summary

All vector transform ops are now PatternDescriptorOpInterface ops that merely select the patterns. The patterns are applied by the apply_patterns op. This is to ensure that ops are properly tracked. (TrackingListener is used in the implementation of apply_patterns.) Furthermore, handles are no longer invalidated when applying patterns in the vector tests.

Depends On: D152167

Diff Detail

Event Timeline

springerm created this revision.Jun 5 2023, 9:06 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Jun 5 2023, 9:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 9:06 AM
nicolasvasilache accepted this revision.Jun 5 2023, 11:26 AM

nice cleanup, thanks!

This revision is now accepted and ready to land.Jun 5 2023, 11:26 AM
This revision was landed with ongoing or failed builds.Jun 6 2023, 12:27 AM
This revision was automatically updated to reflect the committed changes.