[libc][NFC] Add LIBC_INLINE and attribute.h header includes to targets' FMA.h.

[lntue]

Summary

Targets' FMA.h headers are missing LIBC_INLINE and attributes.h header.

[gchatelet]

I think you need to edit https://github.com/llvm/llvm-project/blob/1c8b7c5299710b3d02cebbdef34c41157f3237f2/utils/bazel/llvm-project-overlay/libc/BUILD.bazel#L687-L705 as well.

You can try running bazelisk-linux-amd64 test --config=ci @llvm-project//libc/... from the llvm-project/utils/bazel folder to check whether everything's alright.

[brooksmoses]

Looks good to me with the build-file changes requested by @gchatelet. (Specifically, you'll need to add ":__support_macros_attributes" to the deps list.)

[lntue]

Update dependency for bazel layout.

[lntue]

In D152024#4392029, @gchatelet wrote:

I think you need to edit https://github.com/llvm/llvm-project/blob/1c8b7c5299710b3d02cebbdef34c41157f3237f2/utils/bazel/llvm-project-overlay/libc/BUILD.bazel#L687-L705 as well.

You can try running bazelisk-linux-amd64 test --config=ci @llvm-project//libc/... from the llvm-project/utils/bazel folder to check whether everything's alright.

Thanks for the suggestion! I've updated the dependency for bazel layout.

[lntue]

In D152024#4392051, @brooksmoses wrote:

Looks good to me with the build-file changes requested by @gchatelet. (Specifically, you'll need to add ":__support_macros_attributes" to the deps list.)

I've updated the bazel layout. Thanks!

libc/src/__support/FPUtil/aarch64/FMA.h

 //===-- Aarch64 implementations of the fma function -------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_LIBC_SRC_SUPPORT_FPUTIL_AARCH64_FMA_H
 #define LLVM_LIBC_SRC_SUPPORT_FPUTIL_AARCH64_FMA_H
 
+#include "src/__support/macros/attributes.h" // LIBC_INLINE
 #include "src/__support/macros/properties/architectures.h"
 #include "src/__support/macros/properties/cpu_features.h" // LIBC_TARGET_CPU_HAS_FMA
 
 #if !defined(LIBC_TARGET_ARCH_IS_AARCH64)
 #error "Invalid include"
 #endif
 
 #if !defined(LIBC_TARGET_CPU_HAS_FMA)
 #error "FMA instructions are not supported"
 #endif
 
 #include "src/__support/CPP/type_traits.h"
 
 namespace __llvm_libc {
 namespace fputil {
 
 template <typename T>
-cpp::enable_if_t<cpp::is_same_v<T, float>, T> fma(T x, T y, T z) {
+LIBC_INLINE cpp::enable_if_t<cpp::is_same_v<T, float>, T> fma(T x, T y, T z) {
   float result;
-  __asm__ __volatile__("fmadd %s0, %s1, %s2, %s3\n\t"
-                       : "=w"(result)
-                       : "w"(x), "w"(y), "w"(z));
+  LIBC_INLINE_ASM("fmadd %s0, %s1, %s2, %s3\n\t"
   return result;
 }
 
 template <typename T>
-cpp::enable_if_t<cpp::is_same_v<T, double>, T> fma(T x, T y, T z) {
+LIBC_INLINE cpp::enable_if_t<cpp::is_same_v<T, double>, T> fma(T x, T y, T z) {
   double result;
-  __asm__ __volatile__("fmadd %d0, %d1, %d2, %d3\n\t"
-                       : "=w"(result)
-                       : "w"(x), "w"(y), "w"(z));
+  LIBC_INLINE_ASM("fmadd %d0, %d1, %d2, %d3\n\t"
   return result;
 }
 
 } // namespace fputil
 } // namespace __llvm_libc
 
 #endif // LLVM_LIBC_SRC_SUPPORT_FPUTIL_AARCH64_FMA_H

libc/src/__support/FPUtil/riscv64/FMA.h

 //===-- RISCV64 implementations of the fma function -------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_LIBC_SRC_SUPPORT_FPUTIL_RISCV64_FMA_H
 #define LLVM_LIBC_SRC_SUPPORT_FPUTIL_RISCV64_FMA_H
 
+#include "src/__support/macros/attributes.h" // LIBC_INLINE
 #include "src/__support/macros/properties/architectures.h"
 #include "src/__support/macros/properties/cpu_features.h" // LIBC_TARGET_CPU_HAS_FMA
 
 #if !defined(LIBC_TARGET_ARCH_IS_RISCV64)
 #error "Invalid include"
 #endif
 
 #if !defined(LIBC_TARGET_CPU_HAS_FMA)
 #error "FMA instructions are not supported"
 #endif
 
 #include "src/__support/CPP/type_traits.h"
 
 namespace __llvm_libc {
 namespace fputil {
 
 template <typename T>
-cpp::enable_if_t<cpp::is_same_v<T, float>, T> fma(T x, T y, T z) {
+LIBC_INLINE cpp::enable_if_t<cpp::is_same_v<T, float>, T> fma(T x, T y, T z) {
   float result;
-  __asm__ __volatile__("fmadd.s %0, %1, %2, %3\n\t"
-                       : "=f"(result)
-                       : "f"(x), "f"(y), "f"(z));
+  LIBC_INLINE_ASM("fmadd.s %0, %1, %2, %3\n\t"
   return result;
 }
 
 template <typename T>
-cpp::enable_if_t<cpp::is_same_v<T, double>, T> fma(T x, T y, T z) {
+LIBC_INLINE cpp::enable_if_t<cpp::is_same_v<T, double>, T> fma(T x, T y, T z) {
   double result;
-  __asm__ __volatile__("fmadd.d %0, %1, %2, %3\n\t"
-                       : "=f"(result)
-                       : "f"(x), "f"(y), "f"(z));
+  LIBC_INLINE_ASM("fmadd.d %0, %1, %2, %3\n\t"
   return result;
 }
 
 } // namespace fputil
 } // namespace __llvm_libc
 
 #endif // LLVM_LIBC_SRC_SUPPORT_FPUTIL_RISCV64_FMA_H

libc/src/__support/FPUtil/x86_64/FMA.h

 //===-- x86_64 implementations of the fma function --------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_LIBC_SRC_SUPPORT_FPUTIL_X86_64_FMA_H
 #define LLVM_LIBC_SRC_SUPPORT_FPUTIL_X86_64_FMA_H
 
+#include "src/__support/macros/attributes.h" // LIBC_INLINE
 #include "src/__support/macros/properties/architectures.h"
 #include "src/__support/macros/properties/cpu_features.h" // LIBC_TARGET_CPU_HAS_FMA
 
 #if !defined(LIBC_TARGET_ARCH_IS_X86_64)
 #error "Invalid include"
 #endif
 
 #if !defined(LIBC_TARGET_CPU_HAS_FMA)

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

libc_support_library(
     textual_hdrs = fma_platform_hdrs,
     deps = [
         ":__support_builtin_wrappers",
         ":__support_cpp_bit",
         ":__support_cpp_type_traits",
         ":__support_fputil_fenv_impl",
         ":__support_fputil_float_properties",
         ":__support_fputil_fp_bits",
+        ":__support_macros_attributes",
         ":__support_macros_optimization",
         ":__support_macros_properties_cpu_features",
         ":__support_uint128",
         ":libc_root",
     ],
 )
 
 libc_support_library(