- User Since
- Oct 28 2014, 11:30 AM (283 w, 6 d)
I continue to accept this. But, I missed some obvious things previously so, wait for @abrachet to take a look as well.
One thing though, this change is now wider than the original description. So, update the description here (and also in your local git repo if you use git llvm push.)
Fri, Apr 3
This patch largely looks good, but I have a question inline.
Couple of nits inline but LGTM.
Thu, Apr 2
Looking at this now.
This change implements the topic I brought up many weeks ago: http://lists.llvm.org/pipermail/libc-dev/2020-January/000038.html.
Wed, Apr 1
Tue, Mar 31
Mon, Mar 30
Sat, Mar 28
Fri, Mar 27
Thu, Mar 26
Wed, Mar 25
This patch is not ready for review yet. For one, it does not have any tests. I am only sharing to showcase the move early.
This is another part I broke off from my sinf/cosf patch.
Tue, Mar 24
- Remove a leftover if block in add_loader_test.
- Add warning in the add_loader_test rule if the host is not unix.
Instead of this narrow check, what we really want is a check to ensure that all implementation detail resides in the namespace __llvm_libc. Anything outside would be special and requiring a NOLINT... for them is reasonable. Have you considered such an approach?
- Add "" arg to __builtin_nanf.
- Remove cosf and sinf from linux API; will add them in the patch adding their implementation.
Mon, Mar 23
Sorry it took me this long to comment here. Part of it was because I had to educate myself about mutli-byte characters and wide characters. Few high level questions:
Sun, Mar 22
Sat, Mar 21
OK with one naming fix suggested inline.
This is OK as a start. But, can we follow up with a study on running clang-tidy as part of our build rules? Like, what are the pros and cons? For the pros, I can think of:
Fri, Mar 20
Thu, Mar 19
Use -ffreestanding instead of -w.
Remove incorrect/redundant target_compile_options.
- Do not run loader tests as part of check-libc as they are not yet sanitizer ready.
- Use add_executable with -nostdlib flag instead of calling the linker directly.
Wed, Mar 18
- Fix a typo in a test
- Add two more tests
Tue, Mar 17
I just uploaded https://reviews.llvm.org/D76271. I tested it with this patch to make sure it is working as expected.
Mon, Mar 16
I think what is outstanding wrt comments is very minor. So, feel free to land and we can iterate if required after landing.
LGTM. I will write back before the end of today about the single object rule.
Sat, Mar 14
Sorry for the long delay here. I am feeling much better now and should be more responsive.
Thu, Mar 12
Wed, Mar 11
Ah sorry, this completely slipped from my radar. I am currently sick, but will try get to this before the end of this week.