Page MenuHomePhabricator

sivachandra (Siva Chandra)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2014, 11:30 AM (401 w, 20 h)

Recent Activity

Mon, Jun 27

sivachandra committed rG8bb1dd7d34d0: [libc] Add a simple arm32 config. (authored by sivachandra).
[libc] Add a simple arm32 config.
Mon, Jun 27, 2:04 AM · Restricted Project, Restricted Project
sivachandra committed rGfe8017476c77: [libc][NFC] Make the support thread library an object library. (authored by sivachandra).
[libc][NFC] Make the support thread library an object library.
Mon, Jun 27, 1:48 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D128335: [libc][mem*] Introduce Algorithms for new mem framework.
Mon, Jun 27, 1:46 AM · Restricted Project, Restricted Project

Fri, Jun 24

sivachandra committed rG4965cea2f357: [libc] Add compound assignment and pre-increment operators to UInt. (authored by sivachandra).
[libc] Add compound assignment and pre-increment operators to UInt.
Fri, Jun 24, 11:48 PM · Restricted Project, Restricted Project
sivachandra committed rGa83034ef2b3d: [libc][Obvious] Compare values of the same type in memory_utils/backend_test. (authored by sivachandra).
[libc][Obvious] Compare values of the same type in memory_utils/backend_test.
Fri, Jun 24, 9:53 PM · Restricted Project, Restricted Project
sivachandra committed rGbcdd9fbf0876: [libc][Obvious] Fix incorrect nested namespace name. (authored by sivachandra).
[libc][Obvious] Fix incorrect nested namespace name.
Fri, Jun 24, 9:49 PM · Restricted Project, Restricted Project
sivachandra committed rG66a6c1073a20: [libc] Add a cacheline size of arm target. (authored by sivachandra).
[libc] Add a cacheline size of arm target.
Fri, Jun 24, 9:46 PM · Restricted Project, Restricted Project
sivachandra added a comment to D128304: [libc] Add Uint128 type as a fallback when __uint128_t is not available..

I have landed this now unblock other work. I am happy to do follow up changes as required.

Fri, Jun 24, 9:05 AM · Restricted Project, Restricted Project
sivachandra committed rG300f8da8e868: [libc] Add Uint128 type as a fallback when __uint128_t is not available. (authored by sivachandra).
[libc] Add Uint128 type as a fallback when __uint128_t is not available.
Fri, Jun 24, 9:04 AM · Restricted Project, Restricted Project
sivachandra closed D128304: [libc] Add Uint128 type as a fallback when __uint128_t is not available..
Fri, Jun 24, 9:03 AM · Restricted Project, Restricted Project
sivachandra committed rGf4580c6d5a44: [libc][NFC] Remove the templatization from the linux implementation of thread. (authored by sivachandra).
[libc][NFC] Remove the templatization from the linux implementation of thread.
Fri, Jun 24, 1:23 AM · Restricted Project, Restricted Project

Thu, Jun 23

sivachandra committed rZORG24f77e8e0f99: [libc] Add arm32 worker and a builder on it for libc. (authored by sivachandra).
[libc] Add arm32 worker and a builder on it for libc.
Thu, Jun 23, 11:46 PM · Restricted Project
sivachandra closed D128326: [libc] Add arm32 worker and a builder on it for libc..
Thu, Jun 23, 11:46 PM · Restricted Project
sivachandra added a reverting change for rG306f2731f482: [libc][NFC] Eliminate the internal header library target.: rGba93b23eb328: [libc] Revert "Eliminate the internal header library target.".
Thu, Jun 23, 1:54 PM · Restricted Project, Restricted Project
sivachandra committed rGba93b23eb328: [libc] Revert "Eliminate the internal header library target." (authored by sivachandra).
[libc] Revert "Eliminate the internal header library target."
Thu, Jun 23, 1:54 PM · Restricted Project, Restricted Project
sivachandra committed rG306f2731f482: [libc][NFC] Eliminate the internal header library target. (authored by sivachandra).
[libc][NFC] Eliminate the internal header library target.
Thu, Jun 23, 1:48 PM · Restricted Project, Restricted Project
sivachandra committed rG0a537a1299b0: [libc][NFC] Convert pthread tests which create threads to integration tests. (authored by sivachandra).
[libc][NFC] Convert pthread tests which create threads to integration tests.
Thu, Jun 23, 1:38 PM · Restricted Project, Restricted Project
sivachandra committed rGd5475af2f761: [libc][NFC] Convert threads unittests in to integration tests. (authored by sivachandra).
[libc][NFC] Convert threads unittests in to integration tests.
Thu, Jun 23, 1:33 PM · Restricted Project, Restricted Project
sivachandra closed D128381: [libc][NFC] Convert threads unittests in to integration tests..
Thu, Jun 23, 1:33 PM · Restricted Project, Restricted Project

Wed, Jun 22

sivachandra updated the diff for D128381: [libc][NFC] Convert threads unittests in to integration tests..

Remove a now empty directory.

Wed, Jun 22, 3:56 PM · Restricted Project, Restricted Project
sivachandra requested review of D128381: [libc][NFC] Convert threads unittests in to integration tests..
Wed, Jun 22, 2:33 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D127046: [libc][math] fmod/fmodf implementation..
Wed, Jun 22, 9:49 AM · Restricted Project, Restricted Project

Tue, Jun 21

sivachandra requested review of D128326: [libc] Add arm32 worker and a builder on it for libc..
Tue, Jun 21, 11:49 PM · Restricted Project
sivachandra added inline comments to D128304: [libc] Add Uint128 type as a fallback when __uint128_t is not available..
Tue, Jun 21, 11:36 PM · Restricted Project, Restricted Project
sivachandra updated the diff for D128304: [libc] Add Uint128 type as a fallback when __uint128_t is not available..

Address comments.

Tue, Jun 21, 11:36 PM · Restricted Project, Restricted Project
sivachandra committed rG5aa9efbab548: [libc] Fix bug in UInt comparison operators. (authored by sivachandra).
[libc] Fix bug in UInt comparison operators.
Tue, Jun 21, 10:41 PM · Restricted Project, Restricted Project
sivachandra closed D128303: [libc] Fix bug in UInt comparison operators..
Tue, Jun 21, 10:41 PM · Restricted Project, Restricted Project
sivachandra requested review of D128304: [libc] Add Uint128 type as a fallback when __uint128_t is not available..
Tue, Jun 21, 2:05 PM · Restricted Project, Restricted Project
sivachandra requested review of D128303: [libc] Fix bug in UInt comparison operators..
Tue, Jun 21, 1:49 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D127046: [libc][math] fmod/fmodf implementation..
Tue, Jun 21, 9:23 AM · Restricted Project, Restricted Project

Sun, Jun 19

sivachandra added a reverting change for rG2846c2bb4fa4: [libc] Temporary disable environment tests for PATH variable.: rGa5cb6edb475b: [libc] Revert: Temporary disable environment tests for PATH variable..
Sun, Jun 19, 2:41 PM · Restricted Project, Restricted Project
sivachandra committed rGa5cb6edb475b: [libc] Revert: Temporary disable environment tests for PATH variable. (authored by sivachandra).
[libc] Revert: Temporary disable environment tests for PATH variable.
Sun, Jun 19, 2:41 PM · Restricted Project, Restricted Project

Fri, Jun 17

sivachandra committed rGbe6af89f85eb: [libc] Add TLS image initialization to aarch64 startup code. (authored by sivachandra).
[libc] Add TLS image initialization to aarch64 startup code.
Fri, Jun 17, 10:51 PM · Restricted Project, Restricted Project
sivachandra closed D128032: [libc] Add TLS image initialization to aarch64 startup code..
Fri, Jun 17, 10:51 PM · Restricted Project, Restricted Project
sivachandra retitled D128032: [libc] Add TLS image initialization to aarch64 startup code. from [libc] Add TLS image initializing to aarch64 statup code. to [libc] Add TLS image initialization to aarch64 startup code..
Fri, Jun 17, 10:45 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D127985: [libc] add printf oct conversion.
Fri, Jun 17, 10:37 AM · Restricted Project, Restricted Project
sivachandra accepted D127995: [libc] add printf pointer conv.
Fri, Jun 17, 10:28 AM · Restricted Project, Restricted Project

Thu, Jun 16

sivachandra requested review of D128032: [libc] Add TLS image initialization to aarch64 startup code..
Thu, Jun 16, 11:28 PM · Restricted Project, Restricted Project
sivachandra accepted D127914: [libc] fix line buffered empty file writes.
Thu, Jun 16, 9:13 AM · Restricted Project, Restricted Project
sivachandra accepted D126082: [libc] add printf hex conversion.
Thu, Jun 16, 9:10 AM · Restricted Project, Restricted Project
sivachandra accepted D127920: [libc] Add a status page for math functions..
Thu, Jun 16, 9:07 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D127920: [libc] Add a status page for math functions..
Thu, Jun 16, 9:06 AM · Restricted Project, Restricted Project

Wed, Jun 15

sivachandra committed rGf8fae5b66068: [libc][Obvious] Include arm_acle.h only for aarch64 builds. (authored by sivachandra).
[libc][Obvious] Include arm_acle.h only for aarch64 builds.
Wed, Jun 15, 11:08 PM · Restricted Project, Restricted Project
sivachandra committed rG33d14e3cd3b3: [libc][aarch64] Set frame pointer of the new thread to the stack pointer. (authored by sivachandra).
[libc][aarch64] Set frame pointer of the new thread to the stack pointer.
Wed, Jun 15, 11:00 PM · Restricted Project, Restricted Project
sivachandra accepted D126831: [libc] add printf.
Wed, Jun 15, 11:26 AM · Restricted Project, Restricted Project
sivachandra accepted D127773: [libc] refactor printf file writing.
Wed, Jun 15, 11:25 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D127773: [libc] refactor printf file writing.
Wed, Jun 15, 1:23 AM · Restricted Project, Restricted Project
sivachandra committed rG0f72a0d2aea3: [libc][Obvious] Removed few unused vars. (authored by sivachandra).
[libc][Obvious] Removed few unused vars.
Wed, Jun 15, 1:14 AM · Restricted Project, Restricted Project
sivachandra added a comment to D127773: [libc] refactor printf file writing.

Nit: You should probably keep the addition of vfprintf_internal in the other patch.

Wed, Jun 15, 1:05 AM · Restricted Project, Restricted Project
sivachandra committed rGf0e608de27b3: [libc] Add linux threads targets only if __support/OSUtil targets are available. (authored by sivachandra).
[libc] Add linux threads targets only if __support/OSUtil targets are available.
Wed, Jun 15, 12:19 AM · Restricted Project, Restricted Project

Tue, Jun 14

sivachandra committed rGa099139fa9c4: [libc][NFC] Add src.__support.OSUtil targets conditionally. (authored by sivachandra).
[libc][NFC] Add src.__support.OSUtil targets conditionally.
Tue, Jun 14, 11:34 PM · Restricted Project, Restricted Project
sivachandra committed rG2eafb96289da: [libc][NFC] Use uint32_t to represent futex words. (authored by sivachandra).
[libc][NFC] Use uint32_t to represent futex words.
Tue, Jun 14, 10:48 PM · Restricted Project, Restricted Project
sivachandra added a comment to D127571: Initiating a RISC-V port of llvm-libc.

When I do objdump -dr <path/to/libllvmlibc.a>, I see this:

Tue, Jun 14, 10:09 AM · Restricted Project, Restricted Project
sivachandra added a comment to D127571: Initiating a RISC-V port of llvm-libc.

Ah, never mind. I missed that you attached the archive. I will dig more into it.

Tue, Jun 14, 9:08 AM · Restricted Project, Restricted Project
sivachandra added a comment to D127571: Initiating a RISC-V port of llvm-libc.

That your libllvmlibc.a includes many syscall dependent entrypoints, and that your patch does not include a RISC-V syscall implementation, I am not confident that this is being tested in the correct way. As I requested in an earlier comment, I would like to see the ELF header for one of the object files in libllvmlibc.a. For example, can your share what you see when you run

Tue, Jun 14, 9:06 AM · Restricted Project, Restricted Project

Mon, Jun 13

sivachandra added inline comments to D126831: [libc] add printf.
Mon, Jun 13, 10:12 PM · Restricted Project, Restricted Project
sivachandra accepted D127692: [libc] Guard common macro names.
Mon, Jun 13, 2:18 PM · Restricted Project, Restricted Project
sivachandra added a comment to D127571: Initiating a RISC-V port of llvm-libc.

Can you share the elf header for one of the object files in libllvmlibc.a. Also, can you share the list of files in libllvmlibc.a? The way to do it would be do:

Mon, Jun 13, 1:13 PM · Restricted Project, Restricted Project
sivachandra requested changes to D127571: Initiating a RISC-V port of llvm-libc.

Also, please provide a plan for CI builders.

Mon, Jun 13, 1:03 PM · Restricted Project, Restricted Project
sivachandra added a comment to D127571: Initiating a RISC-V port of llvm-libc.

I see a large number of syscall dependent entrypoints in your entrypoints.txt file. Without a RISCV syscall implementation they would fail. Did you run check-libc at all? If yes, and if you did get a clean run, can you share the output?

Mon, Jun 13, 1:02 PM · Restricted Project, Restricted Project
sivachandra updated subscribers of D127571: Initiating a RISC-V port of llvm-libc.

Can someone explain LLVM_LIBC_CACHELINE_SIZE ?

Mon, Jun 13, 11:03 AM · Restricted Project, Restricted Project

Sun, Jun 12

sivachandra added a comment to D127571: Initiating a RISC-V port of llvm-libc.

As @lntue has pointed out, the way start a new port would be to start with an entrypoints.txt and stick to default build. Default build is the mode in which one uses headers from the system libc. You can copy the entrypoints.txt for aarch64 and start peeling away entrypoints until you are able to build and test the remaining. In one of your messages, I see that you are hitting an errors with fenv functions. Remove them from your entrypoints.txt as they are target CPU specific implementations. To keep it easy, start with only string.h and math.h functions.

Sun, Jun 12, 10:25 PM · Restricted Project, Restricted Project

Fri, Jun 10

sivachandra committed rG5db4177817a8: [libc] Add pthread_detach and thrd_detach. (authored by sivachandra).
[libc] Add pthread_detach and thrd_detach.
Fri, Jun 10, 10:30 PM · Restricted Project, Restricted Project
sivachandra closed D127479: [libc] Add pthread_detach and thrd_detach..
Fri, Jun 10, 10:29 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D126831: [libc] add printf.
Fri, Jun 10, 12:12 PM · Restricted Project, Restricted Project
sivachandra accepted D124495: [libc] Implement double precision FMA for targets without FMA instructions..

Nit: The changes to sqrt*.cpp and str_to_float.h are not related - please land them separately as "Obvious".

Fri, Jun 10, 10:50 AM · Restricted Project, Restricted Project
sivachandra updated the diff for D127479: [libc] Add pthread_detach and thrd_detach..

Remove debug messages.

Fri, Jun 10, 10:36 AM · Restricted Project, Restricted Project
sivachandra requested review of D127479: [libc] Add pthread_detach and thrd_detach..
Fri, Jun 10, 1:55 AM · Restricted Project, Restricted Project

Thu, Jun 9

sivachandra added inline comments to D126829: [libc] add buffering to FILE writes.
Thu, Jun 9, 10:31 PM · Restricted Project, Restricted Project
sivachandra accepted D126829: [libc] add buffering to FILE writes.

LGTM modulo one comment about the NBF operation.

Thu, Jun 9, 2:54 PM · Restricted Project, Restricted Project
sivachandra committed rG214be9d1cd16: [libc] Add compile options to pthread_create target. (authored by sivachandra).
[libc] Add compile options to pthread_create target.
Thu, Jun 9, 10:27 AM · Restricted Project, Restricted Project
sivachandra closed D127381: [libc] Add compile options to pthread_create target..
Thu, Jun 9, 10:27 AM · Restricted Project, Restricted Project
sivachandra added a comment to D126829: [libc] add buffering to FILE writes.

Good to go after the comments addressed.

Thu, Jun 9, 1:34 AM · Restricted Project, Restricted Project
sivachandra requested review of D127381: [libc] Add compile options to pthread_create target..
Thu, Jun 9, 12:06 AM · Restricted Project, Restricted Project

Wed, Jun 8

sivachandra accepted D125929: [libc] add printf base 10 integer conversion.

Feel free to submit after addressing the comments.

Wed, Jun 8, 10:01 PM · Restricted Project, Restricted Project
sivachandra accepted D127341: [libc] simplify printf converter tests.
Wed, Jun 8, 9:57 PM · Restricted Project, Restricted Project
sivachandra added a comment to D126829: [libc] add buffering to FILE writes.

The idea of "split point" makes it almost equivalent to the split approach I proposed. Taking a step back and looking at it objectively, consider that once a file is in a buffering mode, it is in that mode for its life time. Likewise, FBF is a mode by itself but LBF is FBF plus something else. To reflect these conceptual notions in code, we should use the approach of building LBF over FBF. That will keep FBF and LBF implementations simple and focused. Quantitatively also, the current state of this patch demonstrates that mixing makes it more complicated than it was previously.

Wed, Jun 8, 9:19 AM · Restricted Project, Restricted Project
sivachandra added a comment to D127222: [libc] Fix build when __FE_DENORM is defined.

Feel free to submit now.

Wed, Jun 8, 1:46 AM · Restricted Project, Restricted Project
sivachandra added a comment to D127091: [libc][math] Differential "diff" test for hypot/hypotf functions..

Feel free to submit now.

Wed, Jun 8, 1:46 AM · Restricted Project, Restricted Project
sivachandra added a comment to D127097: [libc][math] Improved FBits performance and readablity..

Feel free to submit now.

Wed, Jun 8, 1:46 AM · Restricted Project, Restricted Project
sivachandra committed rZORGd77bf1b41157: [libc] Enable steps back on the release builder. (authored by sivachandra).
[libc] Enable steps back on the release builder.
Wed, Jun 8, 1:36 AM · Restricted Project

Tue, Jun 7

sivachandra committed rZORGd94f377de133: [libc] Temporarily make the release builder a passthrough. (authored by sivachandra).
[libc] Temporarily make the release builder a passthrough.
Tue, Jun 7, 11:56 PM · Restricted Project
sivachandra added a comment to D126829: [libc] add buffering to FILE writes.

While this is probably OK logically, it is way harder to reason than before. I am not yet convinced that this idea of flush_point and mixing line buffering and fully buffering is better.

Tue, Jun 7, 3:25 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D125929: [libc] add printf base 10 integer conversion.
Tue, Jun 7, 12:04 PM · Restricted Project, Restricted Project
sivachandra accepted D125929: [libc] add printf base 10 integer conversion.

LGTM - But, if some of the changes to the tests are unrelated, then do it separately.

Tue, Jun 7, 11:58 AM · Restricted Project, Restricted Project
sivachandra requested review of D127238: [libc] Fix a bug in file write logic..
Tue, Jun 7, 11:18 AM · Restricted Project, Restricted Project
sivachandra accepted D127222: [libc] Fix build when __FE_DENORM is defined.

Can we hold off on landing this until we resolve the bot problems?

Tue, Jun 7, 10:02 AM · Restricted Project, Restricted Project
sivachandra accepted D127097: [libc][math] Improved FBits performance and readablity..
Tue, Jun 7, 2:01 AM · Restricted Project, Restricted Project

Mon, Jun 6

sivachandra accepted D127097: [libc][math] Improved FBits performance and readablity..

As with the other patch, while this is accepted, please hold-off on submitting until further notice here.

Mon, Jun 6, 11:24 PM · Restricted Project, Restricted Project
sivachandra accepted D127091: [libc][math] Differential "diff" test for hypot/hypotf functions..

While accepted, please hold-off on submission until further notice. Our bots have been taken off-line for maintenance. Once we bring them back, I will update this patch.

Mon, Jun 6, 11:15 PM · Restricted Project, Restricted Project
sivachandra accepted D127174: Replace Goals and Why section with Introduction.
Mon, Jun 6, 11:13 PM · Restricted Project, Restricted Project
sivachandra committed rG0539a6b4203d: [libc] Align the new thread stack as required by the target ABI. (authored by sivachandra).
[libc] Align the new thread stack as required by the target ABI.
Mon, Jun 6, 2:46 PM · Restricted Project, Restricted Project
sivachandra accepted D127129: [libc] Fix cmake compatibility issue with list(POP_FRONT)..
Mon, Jun 6, 10:35 AM · Restricted Project, Restricted Project
sivachandra accepted D126830: [libc] move printf_main in to object library.
Mon, Jun 6, 8:53 AM · Restricted Project, Restricted Project

Jun 5 2022

sivachandra added a comment to D127046: [libc][math] fmod/fmodf implementation..

Thanks a lot for the patch. It seems like it includes a bunch of cleanups / "better this way" items not related to the main goal of the patch. Can you please separate out those parts in to a different patch so that we can keep the review focused? Also, we cannot strictly use std C++ headers. So, no cerrno also. Include errno.h instead.

Jun 5 2022, 11:42 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D126829: [libc] add buffering to FILE writes.
Jun 5 2022, 11:39 PM · Restricted Project, Restricted Project

Jun 2 2022

sivachandra added inline comments to D126831: [libc] add printf.
Jun 2 2022, 1:26 AM · Restricted Project, Restricted Project
sivachandra accepted D126830: [libc] move printf_main in to object library.
Jun 2 2022, 1:17 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D126829: [libc] add buffering to FILE writes.
Jun 2 2022, 1:08 AM · Restricted Project, Restricted Project

Jun 1 2022

sivachandra committed rG70c8d12b79a5: [libc] Add pthread_create and pthread_join functions. (authored by sivachandra).
[libc] Add pthread_create and pthread_join functions.
Jun 1 2022, 6:48 PM · Restricted Project, Restricted Project