Page MenuHomePhabricator
People sivachandra

sivachandra (Siva Chandra)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2014, 11:30 AM (438 w, 2 d)

Recent Activity
View All

Today

sivachandra accepted D145584: [libc] Add support for setjmp and longjmp in riscv.
Fri, Mar 24, 1:03 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 22

sivachandra accepted D146001: [libc] enable printf using system FILE.
Wed, Mar 22, 1:12 PM · Restricted Project, Restricted Project

Tue, Mar 21

sivachandra added inline comments to D146001: [libc] enable printf using system FILE.
Tue, Mar 21, 10:25 AM · Restricted Project, Restricted Project

Mon, Mar 20

sivachandra accepted D146322: [libc] Add environment variables to GPU libc test for AMDGPU.

This is essentially a GPU only change. Stamping anyway.

Mon, Mar 20, 11:15 AM · Restricted Project, Restricted Project

Fri, Mar 17

sivachandra added a comment to D146256: [libc] Enable integration tests targeting the GPU.
In D146256#4202873, @JonChesterfield wrote:

Libc could walk the ctors array before main and the dtors after, as normal function pointers. We might even be able to persuade hip or openmp to lower their ctor/dtors as function pointers in the same arrays, where they happen to launch a special kernel that walks at least one of them.

Fri, Mar 17, 11:40 AM · Restricted Project, Restricted Project
sivachandra accepted D146256: [libc] Enable integration tests targeting the GPU.

OK from the libc structuring point of view.

Fri, Mar 17, 9:54 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D146256: [libc] Enable integration tests targeting the GPU.
Fri, Mar 17, 9:13 AM · Restricted Project, Restricted Project
sivachandra added a comment to D146256: [libc] Enable integration tests targeting the GPU.

The libc infra components LGTM.

Fri, Mar 17, 12:00 AM · Restricted Project, Restricted Project

Thu, Mar 16

sivachandra added a comment to D145995: [libc] add basic wide char functions.

Except of the definition of the new types, the rest LGTM. We should of course formally define our position on the locales that we care about.

Thu, Mar 16, 10:43 PM · Restricted Project, Restricted Project
sivachandra accepted D146100: [libc][bazel] add targets for sprintf.

LGTM modulo answer to @lntue's question.

Thu, Mar 16, 8:08 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D146001: [libc] enable printf using system FILE.
Thu, Mar 16, 3:50 PM · Restricted Project, Restricted Project
sivachandra added a comment to D145584: [libc] Add support for setjmp and longjmp in riscv.

Mostly LGTM but I have left some questions inline. About the structuring, to avoid complicated conditionals in CMake and source code both, we should structure it this way:

Thu, Mar 16, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
sivachandra added a reviewer for D146253: [libc] Enabled more tests for targets other than x86_64: lntue.
Thu, Mar 16, 11:53 AM · Restricted Project, Restricted Project
sivachandra committed rGb0f920605779: [libc][Obvious] Remove the STARTUP attribute from the api test listing. (authored by sivachandra).
[libc][Obvious] Remove the STARTUP attribute from the api test listing.
Thu, Mar 16, 10:49 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D146001: [libc] enable printf using system FILE.
Thu, Mar 16, 10:36 AM · Restricted Project, Restricted Project
sivachandra accepted D146237: [libc] Remove startup option from integration tests.
Thu, Mar 16, 10:01 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D145913: [libc] Add initial support for an RPC mechanism for the GPU.
Thu, Mar 16, 8:59 AM · Restricted Project, Restricted Project
sivachandra accepted D145913: [libc] Add initial support for an RPC mechanism for the GPU.

I have no major comments so stepping aside.

Thu, Mar 16, 8:43 AM · Restricted Project, Restricted Project

Wed, Mar 15

sivachandra accepted D146184: [libc] Inherit integration test dependencies from the startup target.
Wed, Mar 15, 10:33 PM · Restricted Project, Restricted Project
sivachandra committed rG08b9835072c0: [libc][docs] Add a section about allocations and deallocations to the style doc. (authored by sivachandra).
[libc][docs] Add a section about allocations and deallocations to the style doc.
Wed, Mar 15, 8:42 PM · Restricted Project, Restricted Project
sivachandra closed D146115: [libc][docs] Add a section about allocations and deallocations to the style doc..
Wed, Mar 15, 8:42 PM · Restricted Project, Restricted Project
sivachandra committed rGbe721a38c61c: [libc][docs] Move the link to "Compiler Support" under "Status". (authored by sivachandra).
[libc][docs] Move the link to "Compiler Support" under "Status".
Wed, Mar 15, 8:41 PM · Restricted Project, Restricted Project
sivachandra closed D146112: [libc][docs] Move the link to "Compiler Support" under "Status"..
Wed, Mar 15, 8:41 PM · Restricted Project, Restricted Project
sivachandra accepted D146177: [libc] Add aliases to C memory functions for integration tests.
Wed, Mar 15, 5:00 PM · Restricted Project, Restricted Project
sivachandra accepted D146048: [libc][NFC] Clean up clang-tidy warnings for `src/__support` and `src/math`..
Wed, Mar 15, 3:35 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D146048: [libc][NFC] Clean up clang-tidy warnings for `src/__support` and `src/math`..
Wed, Mar 15, 3:21 PM · Restricted Project, Restricted Project
sivachandra added a comment to D145584: [libc] Add support for setjmp and longjmp in riscv.

Sorry for the delay. Going by my godbolt experiments, the problem you seem to be addressing (you have already said it) is clang specific: https://godbolt.org/z/GxfMor1KM

Wed, Mar 15, 3:16 PM · Restricted Project, Restricted Project, Restricted Project
sivachandra added inline comments to D146048: [libc][NFC] Clean up clang-tidy warnings for `src/__support` and `src/math`..
Wed, Mar 15, 3:02 PM · Restricted Project, Restricted Project
sivachandra added a comment to D146161: [libc] Enable __llvm_libc_syscall and fork on riscv64..

I have updated the commit message to make it clear that this change is for riscv64.

Wed, Mar 15, 1:54 PM · Restricted Project, Restricted Project
sivachandra retitled D146161: [libc] Enable __llvm_libc_syscall and fork on riscv64. from [libc] Enable __llvm_libc_syscall and fork to [libc] Enable __llvm_libc_syscall and fork on riscv64..
Wed, Mar 15, 1:54 PM · Restricted Project, Restricted Project
sivachandra accepted D146161: [libc] Enable __llvm_libc_syscall and fork on riscv64..
Wed, Mar 15, 1:53 PM · Restricted Project, Restricted Project
sivachandra added a comment to D146048: [libc][NFC] Clean up clang-tidy warnings for `src/__support` and `src/math`..

Do you have any resolution on the const local variable naming convention?

Wed, Mar 15, 11:05 AM · Restricted Project, Restricted Project
sivachandra accepted D146145: [libc] Enable spawn lib in riscv.

We have libc RISCV64 builders now: https://lab.llvm.org/buildbot/#/workers/202
Please watch them after landing.

Wed, Mar 15, 9:46 AM · Restricted Project, Restricted Project
sivachandra added a comment to D146145: [libc] Enable spawn lib in riscv.

LGTM with one comment.

Wed, Mar 15, 9:10 AM · Restricted Project, Restricted Project
sivachandra added a comment to D145584: [libc] Add support for setjmp and longjmp in riscv.

Also, does it happen at -O3 as well?

Wed, Mar 15, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
sivachandra added a comment to D145584: [libc] Add support for setjmp and longjmp in riscv.

Can you share the code that results in large number of instructions and register saving?

Wed, Mar 15, 12:46 AM · Restricted Project, Restricted Project, Restricted Project
sivachandra requested review of D146115: [libc][docs] Add a section about allocations and deallocations to the style doc..
Wed, Mar 15, 12:33 AM · Restricted Project, Restricted Project

Tue, Mar 14

sivachandra updated the diff for D146112: [libc][docs] Move the link to "Compiler Support" under "Status"..

Address comments.

Tue, Mar 14, 11:48 PM · Restricted Project, Restricted Project
sivachandra requested review of D146112: [libc][docs] Move the link to "Compiler Support" under "Status"..
Tue, Mar 14, 10:54 PM · Restricted Project, Restricted Project
sivachandra added a reviewer for D146111: [libc] [test] Add missing <cstdint> include: michaelrj.
Tue, Mar 14, 10:32 PM · Restricted Project, Restricted Project
sivachandra committed rZORG9b3a8f8d7f6b: [libc] Fix syntax. (authored by sivachandra).
[libc] Fix syntax.
Tue, Mar 14, 12:54 PM · Restricted Project
sivachandra committed rZORG3f2bde982c4d: [libc] Exclude compiler-rt and Scudo on RISCV builders. (authored by sivachandra).
[libc] Exclude compiler-rt and Scudo on RISCV builders.
Tue, Mar 14, 12:52 PM · Restricted Project
sivachandra committed rZORG50424edc74fc: [libc] Do not run benchmark tests under GCC as they don't build with gcc. (authored by sivachandra).
[libc] Do not run benchmark tests under GCC as they don't build with gcc.
Tue, Mar 14, 12:32 PM · Restricted Project
sivachandra accepted D146065: [libc] Update supported riscv libs.
Tue, Mar 14, 12:19 PM · Restricted Project, Restricted Project
sivachandra committed rZORG5aa8591622a7: [libc] Exclude few build steps under riscv. (authored by sivachandra).
[libc] Exclude few build steps under riscv.
Tue, Mar 14, 12:13 PM · Restricted Project
sivachandra accepted D145821: [libc][NFC] add an atof test for a fuzz failure.
Tue, Mar 14, 11:37 AM · Restricted Project, Restricted Project
sivachandra accepted D146049: [libc] Add instructions for linux headers.
Tue, Mar 14, 11:27 AM · Restricted Project, Restricted Project
sivachandra added inline comments to D146065: [libc] Update supported riscv libs.
Tue, Mar 14, 11:15 AM · Restricted Project, Restricted Project
sivachandra added a comment to D146065: [libc] Update supported riscv libs.

I think you need to rebase this.

Tue, Mar 14, 10:22 AM · Restricted Project, Restricted Project
sivachandra accepted D146040: [libc] Remove dummy archive and file from integration test.
Tue, Mar 14, 7:28 AM · Restricted Project, Restricted Project
sivachandra committed rGffcd6cabaf5b: [bazel][libc] Add errno target to function_deps of tests. (authored by sivachandra).
[bazel][libc] Add errno target to function_deps of tests.
Tue, Mar 14, 12:41 AM · Restricted Project
sivachandra closed D146014: [bazel][libc] Add errno target to function_deps of tests..
Tue, Mar 14, 12:40 AM · Restricted Project, Restricted Project
sivachandra requested review of D146014: [bazel][libc] Add errno target to function_deps of tests..
Tue, Mar 14, 12:24 AM · Restricted Project, Restricted Project

Mon, Mar 13

sivachandra committed rG537e6e70951e: [libc] Enable more functions on riscv64. (authored by sivachandra).
[libc] Enable more functions on riscv64.
Mon, Mar 13, 11:34 PM · Restricted Project, Restricted Project
sivachandra added a comment to D145584: [libc] Add support for setjmp and longjmp in riscv.

I have left comments in longjmp.cpp but same questions apply for setjmp.cpp as well.

Mon, Mar 13, 9:51 PM · Restricted Project, Restricted Project, Restricted Project
sivachandra accepted D145878: [libc] Update cross-compilation instructions.
Mon, Mar 13, 9:30 PM · Restricted Project, Restricted Project
sivachandra added a comment to D146005: [libc] Make libc_errno point to internal errno for non-public builds..
In D146005#4191501, @lntue wrote:

I assume the failed sys/stat tests are fixed with https://reviews.llvm.org/D146004?

Mon, Mar 13, 9:24 PM · Restricted Project, Restricted Project
sivachandra committed rG547e34566600: [libc] Make libc_errno point to internal errno for non-public builds. (authored by sivachandra).
[libc] Make libc_errno point to internal errno for non-public builds.
Mon, Mar 13, 9:22 PM · Restricted Project, Restricted Project
sivachandra closed D146005: [libc] Make libc_errno point to internal errno for non-public builds..
Mon, Mar 13, 9:22 PM · Restricted Project, Restricted Project
sivachandra updated the summary of D146005: [libc] Make libc_errno point to internal errno for non-public builds..
Mon, Mar 13, 9:05 PM · Restricted Project, Restricted Project
sivachandra updated the diff for D146005: [libc] Make libc_errno point to internal errno for non-public builds..

Rebase

Mon, Mar 13, 9:05 PM · Restricted Project, Restricted Project
sivachandra committed rG55612b8ec421: [libc] Switch sys/stat implementations over to libc_errno. (authored by sivachandra).
[libc] Switch sys/stat implementations over to libc_errno.
Mon, Mar 13, 9:03 PM · Restricted Project, Restricted Project
sivachandra closed D146004: [libc] Switch sys/stat implementations over to libc_errno..
Mon, Mar 13, 9:03 PM · Restricted Project, Restricted Project
sivachandra requested review of D146005: [libc] Make libc_errno point to internal errno for non-public builds..
Mon, Mar 13, 6:38 PM · Restricted Project, Restricted Project
sivachandra requested review of D146004: [libc] Switch sys/stat implementations over to libc_errno..
Mon, Mar 13, 6:28 PM · Restricted Project, Restricted Project
sivachandra committed rG7e6462d90cdd: [libc][NFC] Switch nanosleep_test and getcwd_test to libc_errno. (authored by sivachandra).
[libc][NFC] Switch nanosleep_test and getcwd_test to libc_errno.
Mon, Mar 13, 6:27 PM · Restricted Project, Restricted Project
sivachandra committed rGbb03705726ef: [libc] Switch termios implementations to libc_errno. (authored by sivachandra).
[libc] Switch termios implementations to libc_errno.
Mon, Mar 13, 6:02 PM · Restricted Project, Restricted Project
sivachandra committed rG67de5381a3eb: [libc][NFC] Switch unistd.h tests to libc_errno. (authored by sivachandra).
[libc][NFC] Switch unistd.h tests to libc_errno.
Mon, Mar 13, 5:53 PM · Restricted Project, Restricted Project
sivachandra committed rGaf783db7fd3b: [libc][NFC] Switch sys/*.h tests over to libc_errno. (authored by sivachandra).
[libc][NFC] Switch sys/*.h tests over to libc_errno.
Mon, Mar 13, 5:02 PM · Restricted Project, Restricted Project
sivachandra committed rG40c443e28b8f: [libc][NFC] Switch mman.h tests to libc_errno and update Bazel build. (authored by sivachandra).
[libc][NFC] Switch mman.h tests to libc_errno and update Bazel build.
Mon, Mar 13, 3:47 PM · Restricted Project, Restricted Project
sivachandra committed rG0b70f95c1626: [libc][NFC] Switch startup tests to libc_errno. (authored by sivachandra).
[libc][NFC] Switch startup tests to libc_errno.
Mon, Mar 13, 3:23 PM · Restricted Project, Restricted Project
sivachandra committed rG30d894239adb: [libc][NFC] Switch string and errno tests to libc_errno. (authored by sivachandra).
[libc][NFC] Switch string and errno tests to libc_errno.
Mon, Mar 13, 3:23 PM · Restricted Project, Restricted Project
sivachandra committed rGadff2b291ca8: [libc][NFC] Switch all uses of errno in math and math tests to libc_errno. (authored by sivachandra).
[libc][NFC] Switch all uses of errno in math and math tests to libc_errno.
Mon, Mar 13, 3:23 PM · Restricted Project, Restricted Project
sivachandra accepted D145983: [libc] Fix policy CMP0116 warnings for cmake 3.20 or above..
Mon, Mar 13, 1:40 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D145983: [libc] Fix policy CMP0116 warnings for cmake 3.20 or above..
Mon, Mar 13, 1:23 PM · Restricted Project, Restricted Project
sivachandra accepted D145912: [libc] Set the stub filename to the target name instead of the source.
Mon, Mar 13, 12:53 PM · Restricted Project, Restricted Project
sivachandra committed rG71825a889afe: [libc][NFC] Add string.h header to various platform headers.txt. (authored by sivachandra).
[libc][NFC] Add string.h header to various platform headers.txt.
Mon, Mar 13, 8:36 AM · Restricted Project, Restricted Project
sivachandra committed rZORG8a087e5aa629: [libc] Enable integration tests and api test with gcc. (authored by sivachandra).
[libc] Enable integration tests and api test with gcc.
Mon, Mar 13, 8:25 AM · Restricted Project
sivachandra added a comment to D145898: [libc] Declare __dso_handle in the integration test instead of startup..

Sorry, I did not intend to push this without review. Because of a mix of branches on my local checkout, I ended up pushing it accidentally.

Mon, Mar 13, 12:50 AM · Restricted Project, Restricted Project
sivachandra committed rG2869d31a7ac1: [libc] Enable integration tests when built with gcc. (authored by sivachandra).
[libc] Enable integration tests when built with gcc.
Mon, Mar 13, 12:48 AM · Restricted Project, Restricted Project
sivachandra committed rG5b1ad43c2b40: [libc] Declare __dso_handle in the integration test instead of startup. (authored by sivachandra).
[libc] Declare __dso_handle in the integration test instead of startup.
Mon, Mar 13, 12:48 AM · Restricted Project, Restricted Project
sivachandra closed D145898: [libc] Declare __dso_handle in the integration test instead of startup..
Mon, Mar 13, 12:47 AM · Restricted Project, Restricted Project
sivachandra committed rGc1bb7108a2ff: [libc] Special case sniffing of thread start args for riscv. (authored by sivachandra).
[libc] Special case sniffing of thread start args for riscv.
Mon, Mar 13, 12:30 AM · Restricted Project, Restricted Project

Sun, Mar 12

sivachandra requested review of D145898: [libc] Declare __dso_handle in the integration test instead of startup..
Sun, Mar 12, 11:33 PM · Restricted Project, Restricted Project

Sat, Mar 11

sivachandra committed rG5d6923345320: [libc][NFC] Reduce the number of threads created in cnd_test to 1000 form 10000. (authored by sivachandra).
[libc][NFC] Reduce the number of threads created in cnd_test to 1000 form 10000.
Sat, Mar 11, 11:11 PM · Restricted Project, Restricted Project
sivachandra accepted D145839: WIP: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB.
Sat, Mar 11, 12:02 AM · Restricted Project, Restricted Project

Thu, Mar 9

sivachandra added a comment to D145670: [libc] Extend the linux thread implementation for riscv64..
In D145670#4181239, @mikhail.ramalho wrote:

Unrelated topic: I started to get some rounding mode errors this morning, are you seeing them too @sivachandra or is it just on my side?

Thu, Mar 9, 9:02 AM · Restricted Project, Restricted Project
sivachandra committed rGcf90633cf215: [libc] Extend the linux thread implementation for riscv64. (authored by sivachandra).
[libc] Extend the linux thread implementation for riscv64.
Thu, Mar 9, 8:59 AM · Restricted Project, Restricted Project
sivachandra closed D145670: [libc] Extend the linux thread implementation for riscv64..
Thu, Mar 9, 8:59 AM · Restricted Project, Restricted Project
sivachandra requested review of D145670: [libc] Extend the linux thread implementation for riscv64..
Thu, Mar 9, 12:49 AM · Restricted Project, Restricted Project
sivachandra committed rGb32acff7b749: [libc][Obvious] Fix bad include and type in threads/tss_get.h. (authored by sivachandra).
[libc][Obvious] Fix bad include and type in threads/tss_get.h.
Thu, Mar 9, 12:48 AM · Restricted Project, Restricted Project

Wed, Mar 8

sivachandra committed rGd2e0a98391e3: [libc][NFC] Compile tests also with -fpie. (authored by sivachandra).
[libc][NFC] Compile tests also with -fpie.
Wed, Mar 8, 11:46 PM · Restricted Project, Restricted Project
sivachandra accepted D145608: [libc] Add intrinsic for thread fence to the atomic support.
Wed, Mar 8, 11:37 PM · Restricted Project, Restricted Project
sivachandra added a comment to D145608: [libc] Add intrinsic for thread fence to the atomic support.
In D145608#4180187, @jhuber6 wrote:

I think libstdc++ uses always_inline

Wed, Mar 8, 11:37 PM · Restricted Project, Restricted Project
sivachandra committed rG6ab95b0d5360: [libc][Obvious] Add missing dep to include.sys_mman. (authored by sivachandra).
[libc][Obvious] Add missing dep to include.sys_mman.
Wed, Mar 8, 11:27 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D145608: [libc] Add intrinsic for thread fence to the atomic support.
Wed, Mar 8, 8:36 PM · Restricted Project, Restricted Project
sivachandra committed rG6822156a58ff: [libc] Widen the riscv64 full build config. (authored by sivachandra).
[libc] Widen the riscv64 full build config.
Wed, Mar 8, 3:06 PM · Restricted Project, Restricted Project
sivachandra committed rZORGbc74e26407da: [libc] Add a riscv64 worker and two builders on it. (authored by sivachandra).
[libc] Add a riscv64 worker and two builders on it.
Wed, Mar 8, 2:14 PM · Restricted Project
sivachandra closed D145470: [libc] Add a riscv64 worker and two builders on it..
Wed, Mar 8, 2:14 PM · Restricted Project
sivachandra added inline comments to rGdea96e7dcad8: [libc] Remove log10 from the list of riscv64 entrypoints..
Wed, Mar 8, 12:23 PM · Restricted Project, Restricted Project