Page MenuHomePhabricator

sivachandra (Siva Chandra)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2014, 11:30 AM (307 w, 5 d)

Recent Activity

Thu, Sep 17

sivachandra accepted D87516: [libc] Add implementation for hypotf.
Thu, Sep 17, 9:05 AM · Restricted Project

Tue, Sep 15

sivachandra added a comment to D87687: [libc] Fix typo in platform_defs.h.inc.

BTW, you can submit all of these as obvious :)

Tue, Sep 15, 7:06 AM · Restricted Project
sivachandra accepted D87687: [libc] Fix typo in platform_defs.h.inc.
Tue, Sep 15, 7:01 AM · Restricted Project
sivachandra accepted D87690: [libc] Add missing LibcFPTestHelpers library.

How did you catch these? With dynamic linking enabled?

Tue, Sep 15, 7:00 AM · Restricted Project
sivachandra accepted D87689: [libc] Add missing TableGen dependency.
Tue, Sep 15, 6:58 AM · Restricted Project

Mon, Sep 14

sivachandra accepted D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function..
Mon, Sep 14, 7:50 AM · Restricted Project
sivachandra accepted D87421: [libc] Decouple string functions..
Mon, Sep 14, 7:34 AM · Restricted Project

Thu, Sep 10

sivachandra committed rGcb19e8c6d192: [libc][obvious] Include Sqrt.h in SqrtLongDoubleX86.h. (authored by sivachandra).
[libc][obvious] Include Sqrt.h in SqrtLongDoubleX86.h.
Thu, Sep 10, 1:27 PM
sivachandra committed rG878cb5170de9: [libc][NFC][obvious] Remove a redudant dep of strcmp implementation. (authored by sivachandra).
[libc][NFC][obvious] Remove a redudant dep of strcmp implementation.
Thu, Sep 10, 12:36 PM

Wed, Sep 9

sivachandra committed rGfb542b0b8c20: [libc][MPFRWrapper] Provide a way to include MPFR header in downstream repos. (authored by sivachandra).
[libc][MPFRWrapper] Provide a way to include MPFR header in downstream repos.
Wed, Sep 9, 12:59 PM
sivachandra closed D87412: [libc][MPFRWrapper] Provide a way to include MPFR header in downstream repos..
Wed, Sep 9, 12:59 PM · Restricted Project
sivachandra requested review of D87412: [libc][MPFRWrapper] Provide a way to include MPFR header in downstream repos..
Wed, Sep 9, 12:57 PM · Restricted Project
sivachandra committed rGba5b1371ecc5: [libc][NFC] Add spec files as dependencies of integration test. (authored by sivachandra).
[libc][NFC] Add spec files as dependencies of integration test.
Wed, Sep 9, 10:23 AM
sivachandra committed rGe59d829971e7: [libc][obvious] Fix strtok_r signature in the spec. (authored by sivachandra).
[libc][obvious] Fix strtok_r signature in the spec.
Wed, Sep 9, 9:51 AM

Thu, Sep 3

sivachandra committed rG17ac4543d427: [libc][obvious] Use constants of type double in remquo_test. (authored by sivachandra).
[libc][obvious] Use constants of type double in remquo_test.
Thu, Sep 3, 10:27 PM
sivachandra committed rG8514ecb02d43: [libc] Add implementations of remquo[f|l] and remainder[f|l]. (authored by sivachandra).
[libc] Add implementations of remquo[f|l] and remainder[f|l].
Thu, Sep 3, 10:00 PM
sivachandra closed D86666: [libc] Add implementations of remquo[f|l] and remainder[f|l]..
Thu, Sep 3, 10:00 PM · Restricted Project
sivachandra added a comment to D86666: [libc] Add implementations of remquo[f|l] and remainder[f|l]..

Added comment as suggested.

Thu, Sep 3, 9:37 PM · Restricted Project
sivachandra updated the diff for D86666: [libc] Add implementations of remquo[f|l] and remainder[f|l]..

Add comment as suggested.

Thu, Sep 3, 9:37 PM · Restricted Project

Wed, Aug 26

sivachandra requested review of D86666: [libc] Add implementations of remquo[f|l] and remainder[f|l]..
Wed, Aug 26, 5:11 PM · Restricted Project
sivachandra accepted D86616: [cmake] Make gtest include directories a part of the library interface.

Libc change LGTM.

Wed, Aug 26, 8:32 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Aug 25

sivachandra committed rGfe44992b797f: [libc][NFC] For remquo quotient, compare only 3 bits of MPFR and libc results. (authored by sivachandra).
[libc][NFC] For remquo quotient, compare only 3 bits of MPFR and libc results.
Tue, Aug 25, 11:43 PM
sivachandra accepted D84726: [libc] Add implementations for sqrt, sqrtf, and sqrtl..

Please follow up with patches to switch to NormalFloat and a doc explaining the algorithm.

Tue, Aug 25, 10:59 PM · Restricted Project
sivachandra committed rG1948acb61b1d: [libc][obvious] Add back the accidentally removed MPFRNumber destructor. (authored by sivachandra).
[libc][obvious] Add back the accidentally removed MPFRNumber destructor.
Tue, Aug 25, 9:59 PM
sivachandra committed rG3f4674a5577d: [libc] Extend MPFRMatcher to handle multiple-input-multiple-output functions. (authored by sivachandra).
[libc] Extend MPFRMatcher to handle multiple-input-multiple-output functions.
Tue, Aug 25, 9:43 PM
sivachandra closed D86506: [libc] Extend MPFRMatcher to handle multiple-input-multiple-output functions..
Tue, Aug 25, 9:43 PM · Restricted Project

Mon, Aug 24

sivachandra requested review of D86506: [libc] Extend MPFRMatcher to handle multiple-input-multiple-output functions..
Mon, Aug 24, 10:13 PM · Restricted Project

Aug 20 2020

sivachandra committed rG87bf0b0ee986: [libc] Add a class called NormalFloat which represents normalized floats. (authored by sivachandra).
[libc] Add a class called NormalFloat which represents normalized floats.
Aug 20 2020, 9:01 AM
sivachandra closed D86241: [libc] Add a class called NormalFloat which represents normalized floats..
Aug 20 2020, 9:00 AM · Restricted Project
sivachandra committed rGed8982da3e31: [libc][NFC] Switch math tests to the new ULP based tolerance. (authored by sivachandra).
[libc][NFC] Switch math tests to the new ULP based tolerance.
Aug 20 2020, 8:32 AM
sivachandra closed D86267: [libc][NFC] Switch math tests to the new ULP based tolerance..
Aug 20 2020, 8:31 AM · Restricted Project
sivachandra added inline comments to D86241: [libc] Add a class called NormalFloat which represents normalized floats..
Aug 20 2020, 12:51 AM · Restricted Project
sivachandra updated the diff for D86241: [libc] Add a class called NormalFloat which represents normalized floats..

Address comments.

Aug 20 2020, 12:51 AM · Restricted Project

Aug 19 2020

sivachandra requested review of D86267: [libc][NFC] Switch math tests to the new ULP based tolerance..
Aug 19 2020, 11:21 PM · Restricted Project
sivachandra committed rGe2645488ca3b: [libc][obvious] Fix x86 long double conversion to integer. (authored by sivachandra).
[libc][obvious] Fix x86 long double conversion to integer.
Aug 19 2020, 3:02 PM
sivachandra added a comment to D86241: [libc] Add a class called NormalFloat which represents normalized floats..

@lntue - I want to use this change for few followup implementations. Also, I see that you have normalizaton functions in your sqrt patch wherein you use a binary search approach for normalization. I did a simple linear normalization in this patch. You can absorb this into your patch and implement the binary search normalization over it. I don't want to appear like I am stealing ;)

Aug 19 2020, 1:05 PM · Restricted Project
sivachandra requested review of D86241: [libc] Add a class called NormalFloat which represents normalized floats..
Aug 19 2020, 1:00 PM · Restricted Project

Aug 18 2020

sivachandra committed rGf768eb216f59: [libc][obvious] Fix link order of math tests. (authored by sivachandra).
[libc][obvious] Fix link order of math tests.
Aug 18 2020, 11:06 AM
sivachandra accepted D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..
Aug 18 2020, 10:14 AM · Restricted Project

Aug 17 2020

sivachandra accepted D85953: [libc] Make mem* benchmark boxplots transparent..
Aug 17 2020, 6:01 AM · Restricted Project

Aug 14 2020

sivachandra accepted D85945: [libc] Add restrict qualifiers to string library; give consistent naming scheme to TableGen files..
Aug 14 2020, 9:05 AM · Restricted Project

Aug 13 2020

sivachandra accepted D85779: [libc] Add strtok_r implementation..
Aug 13 2020, 12:06 PM · Restricted Project
sivachandra added inline comments to D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..
Aug 13 2020, 12:06 AM · Restricted Project

Aug 12 2020

sivachandra added a comment to D85779: [libc] Add strtok_r implementation..

LGTM but not yet accepting as I asked for some extension to the tests.

Aug 12 2020, 10:26 PM · Restricted Project
sivachandra committed rG578ac8bfa5e9: [libc][obvious] Remove the unused file utils/CPP/StringRef.h. (authored by sivachandra).
[libc][obvious] Remove the unused file utils/CPP/StringRef.h.
Aug 12 2020, 12:20 PM
sivachandra added inline comments to D85779: [libc] Add strtok_r implementation..
Aug 12 2020, 12:13 PM · Restricted Project
sivachandra added inline comments to D85779: [libc] Add strtok_r implementation..
Aug 12 2020, 8:54 AM · Restricted Project
sivachandra added inline comments to D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..
Aug 12 2020, 8:30 AM · Restricted Project
sivachandra added inline comments to D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..
Aug 12 2020, 7:36 AM · Restricted Project
sivachandra committed rGa87576592c63: [libc][obvious] Switch copysign[f|l] and fabs[f|l] to the new test matchers. (authored by sivachandra).
[libc][obvious] Switch copysign[f|l] and fabs[f|l] to the new test matchers.
Aug 12 2020, 12:21 AM

Aug 11 2020

sivachandra committed rG01b99c6e1d96: [libc][obvious] Switch nearest integer function tests to the new matchers. (authored by sivachandra).
[libc][obvious] Switch nearest integer function tests to the new matchers.
Aug 11 2020, 11:34 PM
sivachandra added a comment to D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..

@cgyurgyik - PTAL. The latest diff looks correct to me (as in, what I intended to upload) and includes a fix to strstr. Without the fix, a strstr test fails with the nullptr change to the tests.

strstr change LGTM. Not familiar enough with test suite to make that call so I'll let abrachet LGTM this.

Aug 11 2020, 6:56 PM · Restricted Project
sivachandra added a comment to D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..

@cgyurgyik - PTAL. The latest diff looks correct to me (as in, what I intended to upload) and includes a fix to strstr. Without the fix, a strstr test fails with the nullptr change to the tests.

Aug 11 2020, 4:38 PM · Restricted Project
sivachandra updated the diff for D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..

Correct diff (hopefully) with a fix to strstr included.

Aug 11 2020, 4:34 PM · Restricted Project
sivachandra added inline comments to D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..
Aug 11 2020, 4:04 PM · Restricted Project
sivachandra requested review of D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr..
Aug 11 2020, 3:09 PM · Restricted Project
sivachandra committed rGdf79e18796d0: [libc][obvious] Remove a commented out block. (authored by sivachandra).
[libc][obvious] Remove a commented out block.
Aug 11 2020, 1:40 PM
sivachandra added inline comments to D85615: [libc] Add strtok implementation..
Aug 11 2020, 10:35 AM · Restricted Project
sivachandra accepted D85615: [libc] Add strtok implementation..
Aug 11 2020, 7:20 AM · Restricted Project

Aug 10 2020

sivachandra added inline comments to D85615: [libc] Add strtok implementation..
Aug 10 2020, 8:26 PM · Restricted Project
sivachandra added a comment to D74021: Created uChar implementation for libc.

Hey guys, I'm rebasing and starting work on this again, sorry for the wait I moved 2000 miles from Michigan to Oregon.

I have a question tho.

Uchar and wchar both rely on mbstate_t which is a global variable for their conversions.

I'm currently using an enum to hold the valid states different conversions can be in, and I'm wondering how it should all be layered together?

Aug 10 2020, 3:02 PM · Restricted Project, Restricted Project
sivachandra added inline comments to D85615: [libc] Add strtok implementation..
Aug 10 2020, 2:44 PM · Restricted Project

Aug 7 2020

sivachandra committed rGf6d74b29d6dc: [libc][NFC] Disable a loader test as ld.gold fails to link. (authored by sivachandra).
[libc][NFC] Disable a loader test as ld.gold fails to link.
Aug 7 2020, 11:47 PM
sivachandra committed rGdb936e0e9153: [libc][NFC] Add library of floating point test matchers. (authored by sivachandra).
[libc][NFC] Add library of floating point test matchers.
Aug 7 2020, 11:34 PM
sivachandra closed D85486: [libc][NFC] Add library of floating point test matchers..
Aug 7 2020, 11:34 PM · Restricted Project
sivachandra committed rG5d59385ba67e: [libc] Setup TLS in x86_64 loader. (authored by sivachandra).
[libc] Setup TLS in x86_64 loader.
Aug 7 2020, 11:19 PM
sivachandra closed D82700: [libc] Setup TLS in x86_64 loader..
Aug 7 2020, 11:19 PM · Restricted Project
sivachandra added inline comments to D82700: [libc] Setup TLS in x86_64 loader..
Aug 7 2020, 11:18 PM · Restricted Project
sivachandra updated the diff for D82700: [libc] Setup TLS in x86_64 loader..
  • Rebase
  • Address comments.
  • Along the way, fixed some loader test depenency handling.
Aug 7 2020, 11:17 PM · Restricted Project
sivachandra added a reviewer for D82700: [libc] Setup TLS in x86_64 loader.: asteinhauser.
Aug 7 2020, 11:12 PM · Restricted Project
sivachandra accepted D85386: [libc] Add strcpsn and strpbrk implementation..
Aug 7 2020, 1:12 PM · Restricted Project

Aug 6 2020

sivachandra updated the diff for D85486: [libc][NFC] Add library of floating point test matchers..

Fix naming style in Test.cpp.

Aug 6 2020, 4:28 PM · Restricted Project
sivachandra requested review of D85486: [libc][NFC] Add library of floating point test matchers..
Aug 6 2020, 4:14 PM · Restricted Project
sivachandra accepted D85326: [libc] Add tolower, toupper implementation..
Aug 6 2020, 10:42 AM · Restricted Project
sivachandra accepted D85407: [libc][NFC] Fix build when using UBSan.

I am OK with this but added @gchatelet so that he can be aware of this.

Aug 6 2020, 10:30 AM
sivachandra added a reviewer for D85407: [libc][NFC] Fix build when using UBSan: gchatelet.
Aug 6 2020, 10:29 AM

Aug 5 2020

sivachandra accepted D85103: [libc] Add strspn implementation..
Aug 5 2020, 9:03 AM · Restricted Project
sivachandra added inline comments to D85103: [libc] Add strspn implementation..
Aug 5 2020, 8:20 AM · Restricted Project

Aug 4 2020

sivachandra accepted D85270: [libc] Add isspace, isprint, isxdigit implementations..
Aug 4 2020, 11:15 PM · Restricted Project
sivachandra added inline comments to D85103: [libc] Add strspn implementation..
Aug 4 2020, 11:06 PM · Restricted Project
sivachandra added inline comments to D85103: [libc] Add strspn implementation..
Aug 4 2020, 12:04 PM · Restricted Project
sivachandra accepted D85059: [libc] Add implementations for isblank, iscntrl, isgraph, ispunct..
Aug 4 2020, 11:25 AM · Restricted Project
sivachandra added inline comments to D85059: [libc] Add implementations for isblank, iscntrl, isgraph, ispunct..
Aug 4 2020, 11:25 AM · Restricted Project

Jul 31 2020

sivachandra added inline comments to D84875: [libc] Adds strrchr implementation..
Jul 31 2020, 1:00 PM · Restricted Project
sivachandra accepted D84960: [libc] Add islower and isupper implementation. .

Nit: Make the subject line have just one sentence like, "Add implementations of islower and isupper".

Jul 31 2020, 10:36 AM · Restricted Project
sivachandra added inline comments to D84875: [libc] Adds strrchr implementation..
Jul 31 2020, 10:31 AM · Restricted Project
sivachandra accepted D84875: [libc] Adds strrchr implementation..
Jul 31 2020, 10:30 AM · Restricted Project

Jul 30 2020

sivachandra committed rGa32af8252fde: [libc] Add a tool called WrapperGen. (authored by sivachandra).
[libc] Add a tool called WrapperGen.
Jul 30 2020, 4:08 PM
sivachandra closed D84848: [libc] Add a tool called WrapperGen..
Jul 30 2020, 4:07 PM · Restricted Project
sivachandra accepted D84893: [libc] Implements isdigit and isalnum..

Overall LGTM. To avoid call instructions to other classification functions, for example isalnum calls isdigit and or isalpha does it make sense to have a library of static inline implementations in a header file. Then, the implementation functions will call the static inline functions, but the call overhead is avoided because of them being static inline. WDYT?

Inlining is good, but comes at a price of abstraction.

  1. In this case, we probably want to use the static inline definition as the one provided for isdigit as well, right? Even though, its two lines of code, I think its better to avoid defining it twice.
Jul 30 2020, 9:21 AM · Restricted Project

Jul 29 2020

sivachandra added a comment to D84726: [libc] Add implementations for sqrt, sqrtf, and sqrtl..

I need more time to read through the patch. But I have left few comments about the structuring of the code.

Jul 29 2020, 11:44 PM · Restricted Project
sivachandra added a comment to D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

We currently have UnitTest depend on FPUtil. I think that an creates unnecessary dependency for tests which do not need FPUtil for testing. So, a plan could be:

Jul 29 2020, 11:14 PM · Restricted Project
sivachandra added a comment to D84893: [libc] Implements isdigit and isalnum..

Overall LGTM. To avoid call instructions to other classification functions, for example isalnum calls isdigit and or isalpha does it make sense to have a library of static inline implementations in a header file. Then, the implementation functions will call the static inline functions, but the call overhead is avoided because of them being static inline. WDYT?

Jul 29 2020, 10:56 PM · Restricted Project
sivachandra added a comment to D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

The functionality LGTM. May be a few more comments would have helped me read this faster, but never mind for now. I am want to spend a little more time the layering of FPUtils, MPFRWrapper and UnitTest. Will come back soon with more comments.

Jul 29 2020, 5:53 PM · Restricted Project
sivachandra accepted D84611: [libc] Adds fuzz test for strstr and alphabetizes string fuzz CMakeList..
Jul 29 2020, 1:14 PM · Restricted Project
sivachandra added a comment to D84611: [libc] Adds fuzz test for strstr and alphabetizes string fuzz CMakeList..

Few nits and questions inline but overall LGTM.

Jul 29 2020, 12:23 PM · Restricted Project
sivachandra added a comment to D84848: [libc] Add a tool called WrapperGen..

This looks good. I wonder though how we will deal with global variables. Those can't be easily wrapped like functions can.

Jul 29 2020, 10:05 AM · Restricted Project
sivachandra requested review of D84848: [libc] Add a tool called WrapperGen..
Jul 29 2020, 7:42 AM · Restricted Project

Jul 28 2020

sivachandra committed rGcd7a5c3cd9a4: [libc][obvious] Add license headers to APIIndexer.[cpp|h]. (authored by sivachandra).
[libc][obvious] Add license headers to APIIndexer.[cpp|h].
Jul 28 2020, 5:06 PM
sivachandra committed rG462b3564f1bd: [libc][obvious] Add the new ctype.h target to the list of x86_64 headers. (authored by sivachandra).
[libc][obvious] Add the new ctype.h target to the list of x86_64 headers.
Jul 28 2020, 4:42 PM