- User Since
- Oct 28 2014, 11:30 AM (325 w, 2 d)
Wed, Jan 20
Tue, Jan 19
Mon, Jan 18
Thu, Jan 14
Few inline nits.
Wed, Jan 13
I am to blame for this. I did consider the approach you are suggesting, and also few other less ideal approaches. What you are proposing is the most appropriate way I would think but I did not like it previously for a few reasons.
Tue, Jan 12
Mon, Jan 11
Fri, Jan 8
Accepting now so that we can start our 3 step approach to arrive at the final state @mcgrathr proposed.
Thu, Jan 7
Wed, Jan 6
Tue, Jan 5
Add nextafter* to the list of aarch64 entrypoints.
Add test source file missed previously.
Add a TODO about raising floating point exceptions in a later pass.
Wed, Dec 30
Tue, Dec 29
Dec 18 2020
Dec 17 2020
Dec 16 2020
Dec 15 2020
Dec 14 2020
Dec 11 2020
Dec 10 2020
Return max integer or min integer value on overflow.
This simple implementation is probably OK to start with. But, I will add @gchatelet as he might also be having plans to add optimized versions of memcmp.
Add an explicit overflow test.
Remove aarch64 entrypoints as we do not yet have exception support for aarch64.
Dec 8 2020
Fix the comment as suggested in the review comment.
Dec 4 2020
Forgot to mention couple of nits.
Thanks for the patch. Feel free to do labs and llabs as well. You can drive all of them off of a C++ template implementation.
Dec 3 2020
I think we can chisel this out to be a little more cleaner but we can do it in a later pass.
Dec 2 2020
Nov 30 2020
Just realized I missed selecting accept.
Mostly LGTM. I have left a few nits along with a not-a-nit comment.
Nov 29 2020
Thanks for the patch. I am adding @gchatelet as a reviewer as he is the current owner/maintainer of the mem* functions.