- User Since
- Oct 28 2014, 11:30 AM (346 w, 2 d)
Tue, Jun 15
Mon, Jun 14
Wed, Jun 9
Tue, Jun 8
May 13 2021
fma and fmaf have been enabled on the bots so this is ready to go.
May 12 2021
May 11 2021
Does this need clang-11?
May 10 2021
This change also triggers a failure on the aarch64 bots like this: https://lab.llvm.org/buildbot/#/builders/138/builds/4761
Unfortunately, I had to revert this as the bots were failing like this: https://lab.llvm.org/buildbot/#/builders/78/builds/11551.
I looked around for a bit to see if I can fix forward, but I do not think I know enough about the various x86_64 arch names. May be -march=k8 is all we need, but I will let you decide what the best course of action is.
May 7 2021
May 6 2021
Thanks for explaining.
Overall LGTM. I have few questions I want to get clarity on.
May 5 2021
Sorry I missed this.
Apr 30 2021
LGTM with one additional suggestion.
Apr 29 2021
Mixed build - You only pick those parts from LLVM libc which you are interested in and get the rest from the system libc. In this mode, we don't use headers from LLVM libc.
Full build - This mode behaves as if LLVM libc is the only libc. So, we want to ensure that the libc build does not get mixed up with headers from the system libc. The lint step helps us with this.
I will send a patch to fix the CMake logic.
Ah, you are probably doing a mixed build with linting enabled. I think that is a bug in the CMake logic. It should not allow you to switch on linting in mixed build mode (mixed build mode is the default mode). Linting should be on only in full build mode.
FWIW, we have full build builders on the public buildbot which build with linting enabled. Example: https://lab.llvm.org/buildbot/#/builders/163
Can you share what linting errors you are getting? The include order is setup so that when doing a full build, the build picks up LLVM libc's header files and does not lead to lint errors. If you are seeing lint errors, it could imply that DEPS in the CMake targets are incomplete. The includes for <math.h> and <fenv.h> are as they are to keep the mixed builds working.
Apr 28 2021
Apr 26 2021
Sorry for the long delay. I have a nitty comment inline. Also, can you please change the way the subject line is written: Instead of "Introduces asctime, asctime_r to LLVM libc, based on C99/C2X/Single Unix Sp.", can you change it to, "Introduce asctime, asctime_r to LLVM libc". Change the rest of the description in a similar way.
- Fix a typo.
- Add similar targets for cosf as well.
Apr 25 2021
LGTM but I have added a comment to add a sollya script. Good to go after that.
Apr 20 2021
Overall, a very nice change. Thanks for doing it. The clang-tidy warnings in the equals method are legitimate and should be fixed before submitting.
Apr 19 2021
Add fma to the x86_64 entrypoint list.
I have not yet fully tested this patch on x86_64. Will update soon if it requires any changes.
Apr 16 2021
Note that Fuchsia does not block us from using this feature in LLVM libc source tree as only ctype tests from LLVM libc run in Fuchsia.
Accepting this as it looks like zxtest can be extended to have this feature. Irrespective though, as I think more about it, it is definitely of value when listing the differently-typed tests that can all be listed in a single file/single test.
While I am not opposed to this, I want to learn the usefulness of this feature. IIUC, this limits to a single ParamType - as in a uni-dimensional type variance. We have examples in math functions where there is two-dimensional type variance. I am not sure the feature added in this patch can help with it. For such cases, have used template test classes and helper macros to list the various combination of tests: https://github.com/llvm/llvm-project/blob/main/libc/test/src/math/RoundToIntegerTest.h.
FYI this has caused widespread redness in the bots. The fixes seem to be straightforward so I do not think we need to revert.
Apr 15 2021
Apr 13 2021
Apr 12 2021
Mar 30 2021
Instead of defaulting to empty string here, do you want it to default to
That seems reasonable to me so feel free to send a patch with that fix.
Else, feel free to suggest other options.
Mar 28 2021
Mar 26 2021
Mar 24 2021
Mar 23 2021
Mar 22 2021
Mar 21 2021
Mar 19 2021
Mar 16 2021
Couple of questions inline. Feel free to submit after answering/addressing them.
Mar 13 2021
Mar 12 2021
Mar 11 2021
Mar 8 2021
Mar 4 2021
Remove empty '//' in lit test file.