- User Since
- Oct 28 2014, 11:30 AM (307 w, 5 d)
Thu, Sep 17
Tue, Sep 15
BTW, you can submit all of these as obvious :)
How did you catch these? With dynamic linking enabled?
Mon, Sep 14
Thu, Sep 10
Wed, Sep 9
Thu, Sep 3
Added comment as suggested.
Add comment as suggested.
Wed, Aug 26
Libc change LGTM.
Tue, Aug 25
Please follow up with patches to switch to NormalFloat and a doc explaining the algorithm.
Mon, Aug 24
Aug 20 2020
Aug 19 2020
@lntue - I want to use this change for few followup implementations. Also, I see that you have normalizaton functions in your sqrt patch wherein you use a binary search approach for normalization. I did a simple linear normalization in this patch. You can absorb this into your patch and implement the binary search normalization over it. I don't want to appear like I am stealing ;)
Aug 18 2020
Aug 17 2020
Aug 14 2020
Aug 13 2020
Aug 12 2020
LGTM but not yet accepting as I asked for some extension to the tests.
Aug 11 2020
@cgyurgyik - PTAL. The latest diff looks correct to me (as in, what I intended to upload) and includes a fix to strstr. Without the fix, a strstr test fails with the nullptr change to the tests.
Correct diff (hopefully) with a fix to strstr included.
Aug 10 2020
Aug 7 2020
- Address comments.
- Along the way, fixed some loader test depenency handling.
Aug 6 2020
Fix naming style in Test.cpp.
I am OK with this but added @gchatelet so that he can be aware of this.
Aug 5 2020
Aug 4 2020
Jul 31 2020
Nit: Make the subject line have just one sentence like, "Add implementations of islower and isupper".
Jul 30 2020
Jul 29 2020
I need more time to read through the patch. But I have left few comments about the structuring of the code.
We currently have UnitTest depend on FPUtil. I think that an creates unnecessary dependency for tests which do not need FPUtil for testing. So, a plan could be:
Overall LGTM. To avoid call instructions to other classification functions, for example isalnum calls isdigit and or isalpha does it make sense to have a library of static inline implementations in a header file. Then, the implementation functions will call the static inline functions, but the call overhead is avoided because of them being static inline. WDYT?
The functionality LGTM. May be a few more comments would have helped me read this faster, but never mind for now. I am want to spend a little more time the layering of FPUtils, MPFRWrapper and UnitTest. Will come back soon with more comments.
Few nits and questions inline but overall LGTM.