♟ sivachandra

[libc] Extend the current fenv functions to aarch64.

[libc][NFC][Obvious] Add a missing dep.

[libc][NFC] Use ASSERT_EQ instead of EXPECT_EQ in fenv/exception_status_test

I am to blame for this. I did consider the approach you are suggesting, and also few other less ideal approaches. What you are proposing is the most appropriate way I would think but I did not like it previously for a few reasons.

[libc][NFC] Use more specific comparison macros in LdExpTest.h.

In D93195#2492555, @gchatelet wrote:

LGTM, can you please wait for @sivachandra answer about using assert in code before submitting? Thx!

[libc][NFC] Make __support/common.h an in tree header.

Accepting now so that we can start our 3 step approach to arrive at the final state @mcgrathr proposed.

Sorry for the delay. And yes, you did the right thing, @gchatelet is the best reviewer for this. Overall, this LGTM, but I prefer @gchatelet to approve it.

[libc] Use a wrapper for rand instead of calling std::rand in fma tests.

[libc] Add implementations of nextafter[f|l] functions.

[libc] Add implementations of nearbyint[f|l].

Add nextafter* to the list of aarch64 entrypoints.

Add test source file missed previously.

Add a TODO about raising floating point exceptions in a later pass.

[libc][NFC] Use ASSERT_FP_EQ to compare nan values in tests.

[libc] Add implementations of rounding functions which depend rounding mode.

[libc][NFC] Use `#include <math.h>` in utils/FPUtil/ManipulationFunctions.h.

[libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests.

[libc][Obvious] Fix typo is wrappergen unittest.

[libc] Refactor WrapperGen to make the flow cleaner.

In D93210#2460196, @gchatelet wrote:

@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.

[libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests.

[libc][NFC] Rename global `nan` in tests to `aNaN`.

[libc][NFC][Obvious] Remove few unnecessary #include directives in tests.

[libc] Add remainder[f|l] and remquo[f|l] to the list of aarch64 entrypoints.

[libc][NFC] Skip adding dummy targets for skipped unit tests.

[libc][Obvious] Mark functions in DummyFEnv.h as static inline.

[libc][Obvious] Include <fenv.h> from DummyFenv.h.

[libc] Let wrappergen pick LLVM libc mangled name from aliasee file.

[libc] Add implementations of lround[f|l] and llround[f|l].

Return max integer or min integer value on overflow.

This simple implementation is probably OK to start with. But, I will add @gchatelet as he might also be having plans to add optimized versions of memcmp.

Add an explicit overflow test.

Remove aarch64 entrypoints as we do not yet have exception support for aarch64.

[libc] Raise x87 exceptions by synchronizing with "fwait".

Fix the comment as suggested in the review comment.

Forgot to mention couple of nits.

Thanks for the patch. Feel free to do labs and llabs as well. You can drive all of them off of a C++ template implementation.

I think we can chisel this out to be a little more cleaner but we can do it in a later pass.

[libc][NFC] Remove dependence on xmmintrin.h to read/write MXCSR.

[libc] Add simple x86_64 floating point exception and rounding mode support.

[libc] Fix couple of corner cases in remquo.

Just realized I missed selecting accept.

Mostly LGTM. I have left a few nits along with a not-a-nit comment.

Thanks for the patch. I am adding @gchatelet as a reviewer as he is the current owner/maintainer of the mem* functions.

sivachandra (Siva Chandra)
User

Projects

User Details

Recent Activity
View All

Yesterday

Wed, Jan 20

Tue, Jan 19

Mon, Jan 18

Thu, Jan 14

Wed, Jan 13

Tue, Jan 12

Mon, Jan 11

Fri, Jan 8

Thu, Jan 7

Wed, Jan 6

Tue, Jan 5

Wed, Dec 30

Tue, Dec 29

Dec 18 2020

Dec 17 2020

Dec 16 2020

Dec 15 2020

Dec 14 2020

Dec 11 2020

Dec 10 2020

Dec 8 2020

Dec 4 2020

Dec 3 2020

Dec 2 2020

Nov 30 2020

Nov 29 2020

sivachandra (Siva Chandra)User