Page MenuHomePhabricator

michaelrj (Michael Jones)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 2:09 PM (91 w, 4 d)

Recent Activity

Fri, Jun 17

michaelrj committed rG121c6454141d: [libc] add printf pointer conv (authored by michaelrj).
[libc] add printf pointer conv
Fri, Jun 17, 5:18 PM · Restricted Project, Restricted Project
michaelrj closed D127995: [libc] add printf pointer conv.
Fri, Jun 17, 5:18 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D127995: [libc] add printf pointer conv.
Fri, Jun 17, 5:17 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D127995: [libc] add printf pointer conv.

yes, I've added ptr_converter to the CMake now

Fri, Jun 17, 10:12 AM · Restricted Project, Restricted Project
michaelrj added inline comments to D127985: [libc] add printf oct conversion.
Fri, Jun 17, 9:57 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D127985: [libc] add printf oct conversion.

address comments

Fri, Jun 17, 9:57 AM · Restricted Project, Restricted Project
michaelrj committed rGad709a752daa: [libc][obvious] fix sign warning in file_writer (authored by michaelrj).
[libc][obvious] fix sign warning in file_writer
Fri, Jun 17, 9:48 AM · Restricted Project, Restricted Project
michaelrj closed D127984: [libc][obvious] fix sign warning in file_writer.
Fri, Jun 17, 9:48 AM · Restricted Project, Restricted Project

Thu, Jun 16

michaelrj updated the diff for D127517: [libc] add integer writing to printf.

rebase onto new changes, specifically converters getting return values.

Thu, Jun 16, 11:46 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D127995: [libc] add printf pointer conv.

add converter test

Thu, Jun 16, 11:35 AM · Restricted Project, Restricted Project
michaelrj requested review of D127995: [libc] add printf pointer conv.
Thu, Jun 16, 11:26 AM · Restricted Project, Restricted Project
michaelrj committed rG1e6c819d6dbe: [libc][obvious] fix address test on windows (authored by michaelrj).
[libc][obvious] fix address test on windows
Thu, Jun 16, 10:54 AM · Restricted Project, Restricted Project
michaelrj closed D127989: [libc][obvious] fix address test on windows.
Thu, Jun 16, 10:54 AM · Restricted Project, Restricted Project
michaelrj requested review of D127989: [libc][obvious] fix address test on windows.
Thu, Jun 16, 10:52 AM · Restricted Project, Restricted Project
michaelrj requested review of D127985: [libc] add printf oct conversion.
Thu, Jun 16, 10:15 AM · Restricted Project, Restricted Project
michaelrj requested review of D127984: [libc][obvious] fix sign warning in file_writer.
Thu, Jun 16, 10:14 AM · Restricted Project, Restricted Project
michaelrj committed rG5bcda1d3a937: [libc] fix line buffered empty file writes (authored by michaelrj).
[libc] fix line buffered empty file writes
Thu, Jun 16, 9:55 AM · Restricted Project, Restricted Project
michaelrj closed D127914: [libc] fix line buffered empty file writes.
Thu, Jun 16, 9:55 AM · Restricted Project, Restricted Project
michaelrj committed rG652ecb251ec9: [libc] add printf hex conversion (authored by michaelrj).
[libc] add printf hex conversion
Thu, Jun 16, 9:51 AM · Restricted Project, Restricted Project
michaelrj closed D126082: [libc] add printf hex conversion.
Thu, Jun 16, 9:51 AM · Restricted Project, Restricted Project

Wed, Jun 15

michaelrj requested review of D127914: [libc] fix line buffered empty file writes.
Wed, Jun 15, 4:16 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126082: [libc] add printf hex conversion.

rebase on new changes and move length modifier handling to a shared function.

Wed, Jun 15, 12:05 PM · Restricted Project, Restricted Project
michaelrj committed rGad233c6047fc: [libc] add printf (authored by michaelrj).
[libc] add printf
Wed, Jun 15, 11:46 AM · Restricted Project, Restricted Project
michaelrj committed rG2e6eccfe34c1: [libc] refactor printf file writing (authored by michaelrj).
[libc] refactor printf file writing
Wed, Jun 15, 11:46 AM · Restricted Project, Restricted Project
michaelrj closed D126831: [libc] add printf.
Wed, Jun 15, 11:45 AM · Restricted Project, Restricted Project
michaelrj closed D127773: [libc] refactor printf file writing.
Wed, Jun 15, 11:45 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D127773: [libc] refactor printf file writing.

fix nit before land

Wed, Jun 15, 11:38 AM · Restricted Project, Restricted Project
michaelrj added inline comments to D127773: [libc] refactor printf file writing.
Wed, Jun 15, 10:58 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D127773: [libc] refactor printf file writing.

address comments and move macro to a shared location

Wed, Jun 15, 10:58 AM · Restricted Project, Restricted Project

Tue, Jun 14

michaelrj updated the summary of D126831: [libc] add printf.
Tue, Jun 14, 12:08 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126831: [libc] add printf.

I split the file handling rewrite into its own separate patch after addressing the comments (https://reviews.llvm.org/D127773), this is now just adding true printf.

Tue, Jun 14, 12:08 PM · Restricted Project, Restricted Project
michaelrj requested review of D127773: [libc] refactor printf file writing.
Tue, Jun 14, 12:06 PM · Restricted Project, Restricted Project

Mon, Jun 13

michaelrj added inline comments to D126831: [libc] add printf.
Mon, Jun 13, 4:47 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126831: [libc] add printf.

move shared fprintf functionality into internal function, as well as other cleanups

Mon, Jun 13, 4:47 PM · Restricted Project, Restricted Project
michaelrj accepted D127694: [libc] Add explicit casts for string functions.

LGTM

Mon, Jun 13, 1:53 PM · Restricted Project, Restricted Project

Fri, Jun 10

michaelrj committed rG02f4affe2d85: [libc] add EXP_MAT_MASK to x87 long double (authored by michaelrj).
[libc] add EXP_MAT_MASK to x87 long double
Fri, Jun 10, 4:26 PM · Restricted Project, Restricted Project
michaelrj closed D127550: [libc] add EXP_MAT_MASK to x87 long double.
Fri, Jun 10, 4:26 PM · Restricted Project, Restricted Project
michaelrj requested review of D127550: [libc] add EXP_MAT_MASK to x87 long double.
Fri, Jun 10, 4:10 PM · Restricted Project, Restricted Project
michaelrj added a comment to D127517: [libc] add integer writing to printf.

While the idea of having a seperate "safe" version of printf is not inherently bad, it's already been tried to little success. In the standard right now is the definitions for the _s versions of printf functions. These have bounds checking and disable %n, but are also not widely used. Convincing developers to switch is hard, so my current plan is to use the compile-time switch I've added to disable %n by default in the existing printf functions. This provides the security enhancements by default for all of the people who don't care/didn't know that %n existed, while still allowing people to turn it back on if they are really sure they know what they're doing.

Fri, Jun 10, 1:00 PM · Restricted Project, Restricted Project
michaelrj requested review of D127517: [libc] add integer writing to printf.
Fri, Jun 10, 11:24 AM · Restricted Project, Restricted Project
michaelrj accepted D127479: [libc] Add pthread_detach and thrd_detach..

LGTM

Fri, Jun 10, 10:14 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D126831: [libc] add printf.

rebase

Fri, Jun 10, 10:06 AM · Restricted Project, Restricted Project
michaelrj committed rG6ce490e5a617: [libc] add buffering to FILE writes (authored by michaelrj).
[libc] add buffering to FILE writes
Fri, Jun 10, 9:59 AM · Restricted Project, Restricted Project
michaelrj closed D126829: [libc] add buffering to FILE writes.
Fri, Jun 10, 9:59 AM · Restricted Project, Restricted Project

Thu, Jun 9

michaelrj accepted D124495: [libc] Implement double precision FMA for targets without FMA instructions..

overall, LGTM with a couple nits. Also, if you're going to add a clz header to FPUtil then please add a TODO for me to change str_to_float.h over to using it, or alternately change it yourself.

Thu, Jun 9, 4:57 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126082: [libc] add printf hex conversion.

add tests and header guards

Thu, Jun 9, 4:41 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D126829: [libc] add buffering to FILE writes.
Thu, Jun 9, 4:06 PM · Restricted Project, Restricted Project
michaelrj committed rGe1c54d4ddc5e: [libc] move printf_main in to object library (authored by michaelrj).
[libc] move printf_main in to object library
Thu, Jun 9, 2:35 PM · Restricted Project, Restricted Project
michaelrj closed D126830: [libc] move printf_main in to object library.
Thu, Jun 9, 2:35 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126830: [libc] move printf_main in to object library.

rebase before landing

Thu, Jun 9, 2:12 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D126829: [libc] add buffering to FILE writes.
Thu, Jun 9, 2:06 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126829: [libc] add buffering to FILE writes.

address comments

Thu, Jun 9, 2:06 PM · Restricted Project, Restricted Project
michaelrj committed rG1be3669dda4d: [libc] add printf base 10 integer conversion (authored by michaelrj).
[libc] add printf base 10 integer conversion
Thu, Jun 9, 10:27 AM · Restricted Project, Restricted Project
michaelrj closed D125929: [libc] add printf base 10 integer conversion.
Thu, Jun 9, 10:27 AM · Restricted Project, Restricted Project
michaelrj added inline comments to D125929: [libc] add printf base 10 integer conversion.
Thu, Jun 9, 10:17 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D125929: [libc] add printf base 10 integer conversion.

address comments and add simple converter test

Thu, Jun 9, 10:16 AM · Restricted Project, Restricted Project
michaelrj committed rG0bff6a3e3913: [libc] simplify printf converter tests (authored by michaelrj).
[libc] simplify printf converter tests
Thu, Jun 9, 10:05 AM · Restricted Project, Restricted Project
michaelrj closed D127341: [libc] simplify printf converter tests.
Thu, Jun 9, 10:05 AM · Restricted Project, Restricted Project
michaelrj accepted D127381: [libc] Add compile options to pthread_create target..

LGTM

Thu, Jun 9, 9:56 AM · Restricted Project, Restricted Project

Wed, Jun 8

michaelrj added inline comments to D125929: [libc] add printf base 10 integer conversion.
Wed, Jun 8, 2:21 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D125929: [libc] add printf base 10 integer conversion.

move tests into sprintf_tests and split converter_test changes into a separate patch

Wed, Jun 8, 2:21 PM · Restricted Project, Restricted Project
michaelrj requested review of D127341: [libc] simplify printf converter tests.
Wed, Jun 8, 1:15 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126829: [libc] add buffering to FILE writes.

split the buffering modes into different functions, as well as cleaning up each implementation to be simpler in its specific case.

Wed, Jun 8, 11:13 AM · Restricted Project, Restricted Project
michaelrj added inline comments to D127238: [libc] Fix a bug in file write logic..
Wed, Jun 8, 10:14 AM · Restricted Project, Restricted Project

Tue, Jun 7

michaelrj updated the diff for D126829: [libc] add buffering to FILE writes.

change to a simpler algorithm

Tue, Jun 7, 4:54 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D126829: [libc] add buffering to FILE writes.
Tue, Jun 7, 12:47 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126829: [libc] add buffering to FILE writes.

address comments

Tue, Jun 7, 12:47 PM · Restricted Project, Restricted Project
michaelrj accepted D127222: [libc] Fix build when __FE_DENORM is defined.

LGTM

Tue, Jun 7, 9:51 AM · Restricted Project, Restricted Project

Mon, Jun 6

michaelrj updated the diff for D125929: [libc] add printf base 10 integer conversion.

switch to using limits.h for type size masks, additionally adjust the buffer size to be more exact.

Mon, Jun 6, 1:47 PM · Restricted Project, Restricted Project

Fri, Jun 3

michaelrj updated the summary of D126831: [libc] add printf.
Fri, Jun 3, 4:42 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126831: [libc] add printf.

switch to unlocked writes with the lock aquisition happening before the parsing. Additionally track errors better.

Fri, Jun 3, 4:42 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126830: [libc] move printf_main in to object library.

move writers to be object libraries

Fri, Jun 3, 3:06 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D126829: [libc] add buffering to FILE writes.
Fri, Jun 3, 2:53 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D126829: [libc] add buffering to FILE writes.

rewrite to be closer to the original

Fri, Jun 3, 2:52 PM · Restricted Project, Restricted Project

Wed, Jun 1

michaelrj requested review of D126831: [libc] add printf.
Wed, Jun 1, 3:03 PM · Restricted Project, Restricted Project
michaelrj requested review of D126830: [libc] move printf_main in to object library.
Wed, Jun 1, 3:02 PM · Restricted Project, Restricted Project
michaelrj requested review of D126829: [libc] add buffering to FILE writes.
Wed, Jun 1, 3:01 PM · Restricted Project, Restricted Project

Tue, May 31

michaelrj committed rGba7e1cddda62: [libc] add fprintf and file_writer (authored by michaelrj).
[libc] add fprintf and file_writer
Tue, May 31, 1:59 PM · Restricted Project, Restricted Project
michaelrj closed D125939: [libc] add fprintf and file_writer.
Tue, May 31, 1:59 PM · Restricted Project, Restricted Project
michaelrj updated the summary of D125939: [libc] add fprintf and file_writer.
Tue, May 31, 1:58 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D125939: [libc] add fprintf and file_writer.

move to constexpr variables for test strings

Tue, May 31, 1:58 PM · Restricted Project, Restricted Project
michaelrj accepted D125174: [libc] Implement FLAGS option for generating all combinations for targets..

LGTM

Tue, May 31, 1:23 PM · Restricted Project, Restricted Project

May 20 2022

michaelrj added a comment to D126082: [libc] add printf hex conversion.

This patch doesn't have comprehensive unit tests yet, but should be good to go once I add those.

May 20 2022, 11:52 AM · Restricted Project, Restricted Project
michaelrj requested review of D126082: [libc] add printf hex conversion.
May 20 2022, 11:51 AM · Restricted Project, Restricted Project
michaelrj added inline comments to D125929: [libc] add printf base 10 integer conversion.
May 20 2022, 10:33 AM · Restricted Project, Restricted Project

May 19 2022

michaelrj updated the diff for D125929: [libc] add printf base 10 integer conversion.

address comments

May 19 2022, 2:08 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D125939: [libc] add fprintf and file_writer.
May 19 2022, 1:33 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D125939: [libc] add fprintf and file_writer.

add handling for FILE errors

May 19 2022, 1:32 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D125978: [libc] Add strlcat.
May 19 2022, 12:49 PM · Restricted Project, Restricted Project
michaelrj accepted D125978: [libc] Add strlcat.

LGTM

May 19 2022, 12:47 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D125978: [libc] Add strlcat.
May 19 2022, 11:39 AM · Restricted Project, Restricted Project

May 18 2022

michaelrj requested review of D125939: [libc] add fprintf and file_writer.
May 18 2022, 5:02 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D125929: [libc] add printf base 10 integer conversion.

add sprintf integer tests

May 18 2022, 3:59 PM · Restricted Project, Restricted Project
michaelrj committed rG72f6dfb37875: [libc][windows] fix strlcpy tests (authored by michaelrj).
[libc][windows] fix strlcpy tests
May 18 2022, 2:12 PM · Restricted Project, Restricted Project
michaelrj closed D125917: [libc][windows] fix strlcpy tests.
May 18 2022, 2:12 PM · Restricted Project, Restricted Project
michaelrj requested review of D125929: [libc] add printf base 10 integer conversion.
May 18 2022, 2:10 PM · Restricted Project, Restricted Project
michaelrj requested review of D125917: [libc][windows] fix strlcpy tests.
May 18 2022, 11:45 AM · Restricted Project, Restricted Project
michaelrj committed rGf8ae591fc985: [libc] fix missing semicolon in bsd_ext.td (authored by michaelrj).
[libc] fix missing semicolon in bsd_ext.td
May 18 2022, 11:22 AM · Restricted Project, Restricted Project
michaelrj closed D125913: [libc] fix missing semicolon in bsd_ext.td.
May 18 2022, 11:22 AM · Restricted Project, Restricted Project
michaelrj requested review of D125913: [libc] fix missing semicolon in bsd_ext.td.
May 18 2022, 11:18 AM · Restricted Project, Restricted Project