Page MenuHomePhabricator

michaelrj (Michael Jones)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 2:09 PM (141 w, 1 d)

Recent Activity

Today

michaelrj accepted D152322: [libc] Temporarily suppress -fsanitize=function for qsort comparator.

LGTM

Wed, Jun 7, 11:05 AM · Restricted Project, Restricted Project

Yesterday

michaelrj added inline comments to D149594: [libc] Add explicit constructor calls to fix compilation when using UInt<T>.
Tue, Jun 6, 1:12 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D152280: [libc] Add platform independent floating point rounding mode checks..
Tue, Jun 6, 1:04 PM · Restricted Project, Restricted Project
michaelrj added a comment to D152288: [libc] Add a test for `fputs` to check using `stdout` and `stderr`.

This should probably be more similar to the putc test, which writes to a file so that the result can be checked.

Tue, Jun 6, 10:23 AM · Restricted Project, Restricted Project

Mon, Jun 5

michaelrj accepted D152190: [CMake][libc] Don't put archive in build/lib/<target triple> by default.

LGTM

Mon, Jun 5, 3:46 PM · Restricted Project, Restricted Project
michaelrj added a comment to D148837: [LIBC] Strengthen `pthread_join` tests; NFC.

I like the general idea of having a more thorough test for pthreads as a whole, but it should probably be in a separate file instead of replacing the pthread_join test. I think it would fit better in the pthread_test file.

Mon, Jun 5, 12:51 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D148371: [libc] Add support to compile some syscalls on 32 bit platform.
Mon, Jun 5, 12:46 PM · Restricted Project, Restricted Project
michaelrj added a comment to D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions.

Every platform we support gets broken occasionally by patches that forget to take it into account. Without buildbots telling us when the platform is broken, then we can't fix it. An example for this would be the arm32 failing to update for several months and our strtol tests breaking on it, leading to this patch: https://reviews.llvm.org/D151935.
For this reason we require anyone adding a new platform to demonstrate their plan for supporting that platform through CI. You can look at the "CI Builders" section on this page for more details: https://libc.llvm.org/porting.html

Mon, Jun 5, 12:35 PM · Restricted Project, Restricted Project
michaelrj added a comment to D150211: [libc] Rework of cpp::optional to support more types.

Ideally we would not like to replace the current optional implementation. Instead we would prefer to modify the current optional so that it supports the features that we need, and only replace it if modification isn't practical. Can you explain why you think that modifying the existing implementation of optional cannot work for your use case?

Mon, Jun 5, 12:29 PM · Restricted Project, Restricted Project

Fri, Jun 2

michaelrj added a comment to D152032: [libc] Disable the string_to_float test on NVPTX.

The patch is fine, but I am confused as to how the str_to_float tests were passing with the high_precision_decimal tests failing, given that str_to_float uses high_precision_decimal.

Fri, Jun 2, 2:07 PM · Restricted Project, Restricted Project

Thu, Jun 1

michaelrj committed rG722832e6d764: [libc] Add strtoint32 and strtoint64 tests (authored by michaelrj).
[libc] Add strtoint32 and strtoint64 tests
Thu, Jun 1, 3:07 PM · Restricted Project, Restricted Project
michaelrj closed D151935: [libc] Add strtoint32 and strtoint64 tests.
Thu, Jun 1, 3:06 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D151935: [libc] Add strtoint32 and strtoint64 tests.
Thu, Jun 1, 3:03 PM · Restricted Project, Restricted Project
michaelrj requested review of D151935: [libc] Add strtoint32 and strtoint64 tests.
Thu, Jun 1, 2:05 PM · Restricted Project, Restricted Project

Tue, May 30

michaelrj accepted D151674: [libc][RISCV] Add log, log2, log1p, log10 for RISC-V64 entrypoints..
Tue, May 30, 10:41 AM · Restricted Project, Restricted Project

Thu, May 25

michaelrj accepted D151123: [libc] Enable hermetic floating point tests.

LGTM

Thu, May 25, 4:05 PM · Restricted Project, Restricted Project
michaelrj accepted D151377: [libc][darwin] Add OSUtil for darwin arm64 target so that unit tests can be run..

LGTM

Thu, May 25, 4:04 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D150399: [libc] add options to printf decimal floats.
Thu, May 25, 3:59 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D150399: [libc] add options to printf decimal floats.

address comments, still need to mess with the is_lowest_block and zero_blocks_after_point functions. They aren't strictly necessary, but they do provide significant speed improvements.

Thu, May 25, 3:59 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D151377: [libc][darwin] Add OSUtil for darwin arm64 target so that unit tests can be run..
Thu, May 25, 3:19 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D150399: [libc] add options to printf decimal floats.

updates and cleanup

Thu, May 25, 1:28 PM · Restricted Project, Restricted Project

Wed, May 24

michaelrj accepted D151367: [libc] Rearrange error and signal tables..

LGTM

Wed, May 24, 1:02 PM · Restricted Project, Restricted Project

Tue, May 23

michaelrj added inline comments to D151234: [libc] Change UInt integer conversion operators to use standard types..
Tue, May 23, 10:59 AM · Restricted Project, Restricted Project
michaelrj accepted D151234: [libc] Change UInt integer conversion operators to use standard types..

LGTM

Tue, May 23, 10:58 AM · Restricted Project, Restricted Project

Mon, May 22

michaelrj accepted D151158: [libc] Add -fno-exceptions and -fno-rtti to integration test build..

LGTM

Mon, May 22, 3:01 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149594: [libc] Add explicit constructor calls to fix compilation when using UInt<T>.
Mon, May 22, 2:32 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D151155: [libc] Add an option to make `libc` only build the `libc-hdrgen` tool.
Mon, May 22, 2:22 PM · Restricted Project, Restricted Project
michaelrj committed rGae3b59e62398: [libc] Use MPFR for strtofloat fuzzing (authored by michaelrj).
[libc] Use MPFR for strtofloat fuzzing
Mon, May 22, 11:05 AM · Restricted Project, Restricted Project
michaelrj closed D150905: [libc] Use MPFR for strtofloat fuzzing.
Mon, May 22, 11:05 AM · Restricted Project, Restricted Project

Fri, May 19

michaelrj added inline comments to D150399: [libc] add options to printf decimal floats.
Fri, May 19, 3:48 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D150905: [libc] Use MPFR for strtofloat fuzzing.

changed how MPFR is included to support downstream configs in the same way as MPFRUtils

Fri, May 19, 3:48 PM · Restricted Project, Restricted Project

Thu, May 18

michaelrj updated the diff for D150399: [libc] add options to printf decimal floats.

cleanup for all three modes after some testing.

Thu, May 18, 4:57 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D150905: [libc] Use MPFR for strtofloat fuzzing.
Thu, May 18, 4:00 PM · Restricted Project, Restricted Project
michaelrj accepted D150906: [libc] Add a str() method to FPBits which returns a string representation..

LGTM

Thu, May 18, 2:45 PM · Restricted Project, Restricted Project
michaelrj added a comment to D150513: [libc] Simplify RPC send and recv callback interface.

LGTM

Thu, May 18, 2:44 PM · Restricted Project, Restricted Project
michaelrj added a comment to D150906: [libc] Add a str() method to FPBits which returns a string representation..

I'll test this patch on aarch64 to check the float128 support

Thu, May 18, 2:21 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D150906: [libc] Add a str() method to FPBits which returns a string representation..
Thu, May 18, 2:12 PM · Restricted Project, Restricted Project
michaelrj abandoned D150598: [libc] use LLVM atof for fuzz precheck.

Abandoned in favor of https://reviews.llvm.org/D150905

Thu, May 18, 1:35 PM · Restricted Project, Restricted Project
michaelrj requested review of D150905: [libc] Use MPFR for strtofloat fuzzing.
Thu, May 18, 1:34 PM · Restricted Project, Restricted Project
michaelrj accepted D150901: [libc] Use the new wide integer to hex string facility in LibcTest..

LGTM

Thu, May 18, 12:56 PM · Restricted Project, Restricted Project

Wed, May 17

michaelrj accepted D150703: [libc] Restrict access to the RPC Process internals.
Wed, May 17, 3:46 PM · Restricted Project, Restricted Project
michaelrj added a comment to D150703: [libc] Restrict access to the RPC Process internals.

LGTM

Wed, May 17, 3:46 PM · Restricted Project, Restricted Project

Tue, May 16

michaelrj accepted D150698: [libc] Remove *TestMain libraries and combine them with the main test libraries..

LGTM

Tue, May 16, 1:23 PM · Restricted Project, Restricted Project

Mon, May 15

michaelrj requested review of D150598: [libc] use LLVM atof for fuzz precheck.
Mon, May 15, 11:23 AM · Restricted Project, Restricted Project

Fri, May 12

michaelrj accepted D150475: [libc][math] Implement fast division / modulus for UInt / (uint32_t * 2^e)..

LGTM, thank you for adding this!

Fri, May 12, 1:53 PM · Restricted Project, Restricted Project

Thu, May 11

michaelrj added a comment to D150399: [libc] add options to printf decimal floats.

Currently ryu_long_double_constants is empty, this is because it's 12 megabytes and arcanist complains when I try to upload it. I can add it for testing purposes, or you can generate it yourself with ryu_tablegen.py. It writes to the console so pipe it to a file. You'll also need to set POW10_ADDITIONAL_BITS_TABLE to 120, IDX_SIZE to 128, and MID_INT_SIZE to 320 in ryu_long_double_constants.h.

Thu, May 11, 2:22 PM · Restricted Project, Restricted Project
michaelrj requested review of D150399: [libc] add options to printf decimal floats.
Thu, May 11, 2:18 PM · Restricted Project, Restricted Project

Tue, May 9

michaelrj added a comment to D150211: [libc] Rework of cpp::optional to support more types.

I agree that optional supporting UInt is good, my question is whether replacing the existing implementation with a completely new one is the best strategy.

Tue, May 9, 2:21 PM · Restricted Project, Restricted Project
michaelrj added a comment to D150211: [libc] Rework of cpp::optional to support more types.

Before I review this patch, I want to confirm that this is the right strategy. If the main goal is to support Uint<> in optional is there a way to do that without a complete replacement of optional?

Tue, May 9, 1:43 PM · Restricted Project, Restricted Project

May 8 2023

michaelrj accepted D150088: [libc][NFC] Simplify string-table generation internals..

I think you meant to put me as a reviewer instead of the description.

May 8 2023, 10:14 AM · Restricted Project, Restricted Project

May 4 2023

michaelrj requested review of D149907: [libc] add scanf system file support.
May 4 2023, 2:26 PM · Restricted Project, Restricted Project

May 3 2023

michaelrj committed rG3befa46b9122: [libc] Make printf decimal long doubles use hex (authored by michaelrj).
[libc] Make printf decimal long doubles use hex
May 3 2023, 11:12 AM · Restricted Project, Restricted Project
michaelrj closed D148179: [libc] Make printf decimal long doubles use hex.
May 3 2023, 11:12 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D148179: [libc] Make printf decimal long doubles use hex.

add comment to clarify the variable named "a"

May 3 2023, 11:08 AM · Restricted Project, Restricted Project
michaelrj committed rGee17fd7d46a9: [libc] add socket function (authored by michaelrj).
[libc] add socket function
May 3 2023, 11:01 AM · Restricted Project, Restricted Project
michaelrj closed D149622: [libc] add socket function.
May 3 2023, 11:01 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D149622: [libc] add socket function.

fix issues that came up in testing before landing

May 3 2023, 10:33 AM · Restricted Project, Restricted Project

May 2 2023

michaelrj accepted D149705: [libc] Enable the 'stdlib' unit tests to be hermetic.

LGTM

May 2 2023, 4:44 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149705: [libc] Enable the 'stdlib' unit tests to be hermetic.
May 2 2023, 4:41 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D149622: [libc] add socket function.

address comments and fix how types are set up.

May 2 2023, 3:40 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149622: [libc] add socket function.
May 2 2023, 3:39 PM · Restricted Project, Restricted Project
michaelrj committed rG48882561253f: [libc][bazel] static link test targets (authored by michaelrj).
[libc][bazel] static link test targets
May 2 2023, 2:56 PM · Restricted Project
michaelrj closed D149674: [libc][bazel] static link test targets.
May 2 2023, 2:55 PM · Restricted Project, Restricted Project
michaelrj requested review of D149674: [libc][bazel] static link test targets.
May 2 2023, 11:27 AM · Restricted Project, Restricted Project

May 1 2023

michaelrj requested review of D149622: [libc] add socket function.
May 1 2023, 4:29 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D147738: [libc] Enable linux directory entries syscalls in riscv64.
May 1 2023, 1:32 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149594: [libc] Add explicit constructor calls to fix compilation when using UInt<T>.
May 1 2023, 10:32 AM · Restricted Project, Restricted Project

Apr 28 2023

michaelrj committed rG2dc97921afba: [libc][NFC] Start cleanup of time functions (authored by michaelrj).
[libc][NFC] Start cleanup of time functions
Apr 28 2023, 3:43 PM · Restricted Project, Restricted Project
michaelrj closed D149487: [libc][NFC] Start cleanup of time functions.
Apr 28 2023, 3:43 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D149487: [libc][NFC] Start cleanup of time functions.

move time_t change into separate patch.

Apr 28 2023, 3:33 PM · Restricted Project, Restricted Project
michaelrj requested review of D149487: [libc][NFC] Start cleanup of time functions.
Apr 28 2023, 2:49 PM · Restricted Project, Restricted Project
michaelrj committed rG377b82a088d4: [libc] add exception to atof differential fuzz (authored by michaelrj).
[libc] add exception to atof differential fuzz
Apr 28 2023, 1:51 PM · Restricted Project, Restricted Project
michaelrj closed D149359: [libc] add exception to atof differential fuzz.
Apr 28 2023, 1:50 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149359: [libc] add exception to atof differential fuzz.
Apr 28 2023, 11:03 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D149359: [libc] add exception to atof differential fuzz.

address comments

Apr 28 2023, 11:03 AM · Restricted Project, Restricted Project

Apr 27 2023

michaelrj accepted D149306: [libc] Support the string conversion methods on the GPU.
Apr 27 2023, 4:42 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149359: [libc] add exception to atof differential fuzz.
Apr 27 2023, 1:41 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D149359: [libc] add exception to atof differential fuzz.

switch to system atof for exception detection.

Apr 27 2023, 1:41 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D149359: [libc] add exception to atof differential fuzz.
Apr 27 2023, 12:06 PM · Restricted Project, Restricted Project
michaelrj requested review of D149359: [libc] add exception to atof differential fuzz.
Apr 27 2023, 10:45 AM · Restricted Project, Restricted Project

Apr 26 2023

michaelrj added a comment to D149306: [libc] Support the string conversion methods on the GPU.

LGTM with a nit.

Apr 26 2023, 4:41 PM · Restricted Project, Restricted Project
michaelrj committed rGd94fe9728087: [libc][bazel] add file printf targets and support (authored by michaelrj).
[libc][bazel] add file printf targets and support
Apr 26 2023, 2:31 PM · Restricted Project, Restricted Project
michaelrj closed D147008: [libc][bazel] add file printf targets and support.
Apr 26 2023, 2:31 PM · Restricted Project, Restricted Project

Apr 25 2023

michaelrj committed rG97a03eb2eb5a: [libc] Fix sched_get_priority_max() syscall invocation (authored by tzussman).
[libc] Fix sched_get_priority_max() syscall invocation
Apr 25 2023, 4:18 PM · Restricted Project, Restricted Project
michaelrj closed D149102: [libc] Fix sched_get_priority_max() syscall invocation.
Apr 25 2023, 4:18 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D147008: [libc][bazel] add file printf targets and support.

remove unnecessary char* initializer for cstring and rename the header to c_string.h to clarify that this isn't related to cstring (the libc++ header).

Apr 25 2023, 4:14 PM · Restricted Project, Restricted Project
michaelrj added a comment to D149102: [libc] Fix sched_get_priority_max() syscall invocation.

That's fine, I'll land this for you.

Apr 25 2023, 4:09 PM · Restricted Project, Restricted Project

Apr 24 2023

michaelrj updated the diff for D147008: [libc][bazel] add file printf targets and support.

move to LIBC_INLINE

Apr 24 2023, 5:07 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D147008: [libc][bazel] add file printf targets and support.
Apr 24 2023, 5:07 PM · Restricted Project, Restricted Project
michaelrj accepted D149102: [libc] Fix sched_get_priority_max() syscall invocation.

LGTM, thank you for catching this.

Apr 24 2023, 3:20 PM · Restricted Project, Restricted Project
michaelrj updated the diff for D147008: [libc][bazel] add file printf targets and support.

address comments

Apr 24 2023, 3:19 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D147008: [libc][bazel] add file printf targets and support.
Apr 24 2023, 3:19 PM · Restricted Project, Restricted Project
michaelrj added inline comments to D147008: [libc][bazel] add file printf targets and support.
Apr 24 2023, 11:02 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D147008: [libc][bazel] add file printf targets and support.

address comments

Apr 24 2023, 11:02 AM · Restricted Project, Restricted Project
michaelrj accepted D148784: [libc] Run all unit tests, irrespective of whether they belong to a test suite..

LGTM

Apr 24 2023, 10:33 AM · Restricted Project, Restricted Project
michaelrj added a comment to D148371: [libc] Add support to compile some syscalls on 32 bit platform.

we should probably figure out what the appropriate waitpid errno values are before landing this. It's possible that the syscall returns them as negative numbers, but I haven't tested it yet.

Apr 24 2023, 10:25 AM · Restricted Project, Restricted Project
michaelrj added a comment to D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions.

Overall LGTM, though are we sure that having the riscv 64 bit and 32 bit targets is the correct path? On other platforms so far we've separated the 32 bit and 64 bit targets.

Apr 24 2023, 10:17 AM · Restricted Project, Restricted Project

Apr 20 2023

michaelrj added a comment to D148844: [libc] Add null-terminator to the thread name obtained from the syscall..

LGTM

Apr 20 2023, 2:48 PM · Restricted Project, Restricted Project
michaelrj committed rG86fe88c8d91b: [libc] Support constexpr uint initialization (authored by michaelrj).
[libc] Support constexpr uint initialization
Apr 20 2023, 1:09 PM · Restricted Project, Restricted Project
michaelrj closed D148759: [libc] Support constexpr uint initialization.
Apr 20 2023, 1:09 PM · Restricted Project, Restricted Project