User Details
- User Since
- Sep 21 2020, 2:09 PM (91 w, 4 d)
Fri, Jun 17
yes, I've added ptr_converter to the CMake now
address comments
Thu, Jun 16
rebase onto new changes, specifically converters getting return values.
add converter test
Wed, Jun 15
rebase on new changes and move length modifier handling to a shared function.
fix nit before land
address comments and move macro to a shared location
Tue, Jun 14
I split the file handling rewrite into its own separate patch after addressing the comments (https://reviews.llvm.org/D127773), this is now just adding true printf.
Mon, Jun 13
move shared fprintf functionality into internal function, as well as other cleanups
LGTM
Fri, Jun 10
While the idea of having a seperate "safe" version of printf is not inherently bad, it's already been tried to little success. In the standard right now is the definitions for the _s versions of printf functions. These have bounds checking and disable %n, but are also not widely used. Convincing developers to switch is hard, so my current plan is to use the compile-time switch I've added to disable %n by default in the existing printf functions. This provides the security enhancements by default for all of the people who don't care/didn't know that %n existed, while still allowing people to turn it back on if they are really sure they know what they're doing.
LGTM
rebase
Thu, Jun 9
overall, LGTM with a couple nits. Also, if you're going to add a clz header to FPUtil then please add a TODO for me to change str_to_float.h over to using it, or alternately change it yourself.
add tests and header guards
rebase before landing
address comments
address comments and add simple converter test
LGTM
Wed, Jun 8
move tests into sprintf_tests and split converter_test changes into a separate patch
split the buffering modes into different functions, as well as cleaning up each implementation to be simpler in its specific case.
Tue, Jun 7
change to a simpler algorithm
address comments
LGTM
Mon, Jun 6
switch to using limits.h for type size masks, additionally adjust the buffer size to be more exact.
Fri, Jun 3
switch to unlocked writes with the lock aquisition happening before the parsing. Additionally track errors better.
move writers to be object libraries
rewrite to be closer to the original
Wed, Jun 1
Tue, May 31
move to constexpr variables for test strings
LGTM
May 20 2022
This patch doesn't have comprehensive unit tests yet, but should be good to go once I add those.
May 19 2022
address comments
add handling for FILE errors
LGTM
May 18 2022
add sprintf integer tests