Page MenuHomePhabricator

michaelrj (Michael Jones)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 2:09 PM (22 w, 2 d)

Recent Activity

Mon, Feb 1

michaelrj committed rGc73c23f2a91f: [libc][NFC] Add a death test API adaptation macro (authored by michaelrj).
[libc][NFC] Add a death test API adaptation macro
Mon, Feb 1, 11:19 AM
michaelrj closed D95648: [libc][NFC] Add a death test API adaptation macro.
Mon, Feb 1, 11:19 AM · Restricted Project
michaelrj committed rGcb2e2d506814: [libc] Small adjustments to fenv tests (authored by michaelrj).
[libc] Small adjustments to fenv tests
Mon, Feb 1, 10:41 AM
michaelrj closed D95650: [libc] Small adjustments to fenv tests.
Mon, Feb 1, 10:40 AM · Restricted Project

Fri, Jan 29

michaelrj updated the diff for D95650: [libc] Small adjustments to fenv tests.

fix the comments and change the final test in RaiseAndTest

Fri, Jan 29, 10:39 AM · Restricted Project

Thu, Jan 28

michaelrj committed rGd4eea5cf0f5d: [libc][NFC] Add a few casts to suppress loss of precision warnings (authored by michaelrj).
[libc][NFC] Add a few casts to suppress loss of precision warnings
Thu, Jan 28, 5:16 PM
michaelrj closed D95646: [libc][NFC] Add a few casts to suppress loss of precision warnings.
Thu, Jan 28, 5:16 PM · Restricted Project
michaelrj updated the diff for D95648: [libc][NFC] Add a death test API adaptation macro.

update all of the EXPECT_DEATH calls

Thu, Jan 28, 5:07 PM · Restricted Project
michaelrj updated the diff for D95646: [libc][NFC] Add a few casts to suppress loss of precision warnings.

clarify the type for the constant being shifted

Thu, Jan 28, 4:56 PM · Restricted Project
michaelrj requested review of D95650: [libc] Small adjustments to fenv tests.
Thu, Jan 28, 4:40 PM · Restricted Project
michaelrj requested review of D95648: [libc][NFC] Add a death test API adaptation macro.
Thu, Jan 28, 4:14 PM · Restricted Project
michaelrj requested review of D95646: [libc][NFC] Add a few casts to suppress loss of precision warnings.
Thu, Jan 28, 3:55 PM · Restricted Project
michaelrj updated the diff for D95637: [libc] Set the ES bit when raising FP exceptions on x86.

documentation changes

Thu, Jan 28, 1:11 PM · Restricted Project
michaelrj requested review of D95637: [libc] Set the ES bit when raising FP exceptions on x86.
Thu, Jan 28, 11:51 AM · Restricted Project

Tue, Jan 26

michaelrj closed D95006: [libc][NFC] add "LlvmLibc" as a prefix to all test names.

This change was landed manually since it was too big for arcanist. The change is here and then the follow up change is here.

Tue, Jan 26, 10:08 AM · Restricted Project

Jan 20 2021

michaelrj committed rG689de5841c1c: [libc][NFC][obvious] fix the names of MPFR tests (authored by michaelrj).
[libc][NFC][obvious] fix the names of MPFR tests
Jan 20 2021, 3:44 PM
michaelrj committed rG1df0dbfcb5c0: [libc][NFC] add "LlvmLibc" as a prefix to all test names (authored by michaelrj).
[libc][NFC] add "LlvmLibc" as a prefix to all test names
Jan 20 2021, 3:23 PM

Jan 19 2021

michaelrj requested review of D95006: [libc][NFC] add "LlvmLibc" as a prefix to all test names.
Jan 19 2021, 3:19 PM · Restricted Project

Jan 14 2021

michaelrj closed D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

This change was accepted and landed. (Github link: https://github.com/llvm/llvm-project/commit/a0b65a7bcd6065688189b3d678c42ed6af9603db#diff-16c8c6eb85e05438f5d6c60ff9869072a3a3b1618aa1481ac7a0cb049f06f51d )

Jan 14 2021, 1:06 PM · Restricted Project

Jan 13 2021

michaelrj committed rGea8034ec35a9: [libc][NFC] change isblank and iscntrl from implicit casting (authored by michaelrj).
[libc][NFC] change isblank and iscntrl from implicit casting
Jan 13 2021, 2:07 PM
michaelrj closed D94634: [libc][NFC] change isblank and iscntrl from implicit casting.
Jan 13 2021, 2:07 PM · Restricted Project
michaelrj requested review of D94634: [libc][NFC] change isblank and iscntrl from implicit casting.
Jan 13 2021, 2:04 PM · Restricted Project
michaelrj committed rG4cfccd513351: [libc][NFC] add macro for fuchsia to switch test backend to zxtest (authored by michaelrj).
[libc][NFC] add macro for fuchsia to switch test backend to zxtest
Jan 13 2021, 1:28 PM
michaelrj closed D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.
Jan 13 2021, 1:28 PM · Restricted Project
michaelrj updated the summary of D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.
Jan 13 2021, 1:26 PM · Restricted Project
michaelrj updated the diff for D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.

fix phrasing in commit message

Jan 13 2021, 1:26 PM · Restricted Project
michaelrj updated the diff for D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.

fixed phrasing in comment

Jan 13 2021, 1:04 PM · Restricted Project
michaelrj added inline comments to D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.
Jan 13 2021, 12:18 PM · Restricted Project
michaelrj updated the diff for D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.

fix the headerguards and add a comment explaining the undef in FuchsiaTest.h

Jan 13 2021, 12:17 PM · Restricted Project
michaelrj updated the diff for D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.

add headerguards to the new Test.h and FuchsiaTest.h

Jan 13 2021, 11:52 AM · Restricted Project
michaelrj requested review of D94625: [libc][NFC] add macro for fuchsia to switch test backend to zxtest.
Jan 13 2021, 11:41 AM · Restricted Project

Jan 12 2021

michaelrj committed rG04edcc02638b: [libc] add isascii and toascii implementations (authored by michaelrj).
[libc] add isascii and toascii implementations
Jan 12 2021, 3:41 PM
michaelrj closed D94558: [libc] add isascii and toascii implementations.
Jan 12 2021, 3:41 PM · Restricted Project
michaelrj updated the diff for D94558: [libc] add isascii and toascii implementations.

add the functions to the spec in the correct places,
and add them to the entrypoints list for aarch64

Jan 12 2021, 3:00 PM · Restricted Project
michaelrj requested review of D94558: [libc] add isascii and toascii implementations.
Jan 12 2021, 2:45 PM · Restricted Project

Jan 11 2021

michaelrj accepted D94445: [libc][NFC] Make __support/common.h an in tree header..

LGTM

Jan 11 2021, 1:09 PM · Restricted Project
michaelrj added inline comments to D93195: [libc] Add memmove implementation..
Jan 11 2021, 12:01 PM · Restricted Project

Jan 8 2021

michaelrj committed rGb02ca0969ea3: [libc][NFC] add includes for internal headers to all libc functions (authored by michaelrj).
[libc][NFC] add includes for internal headers to all libc functions
Jan 8 2021, 4:40 PM
michaelrj committed rGa0b65a7bcd60: [libc] Switch to use a macro which does not insert a section for every libc… (authored by michaelrj).
[libc] Switch to use a macro which does not insert a section for every libc…
Jan 8 2021, 3:54 PM
michaelrj updated the diff for D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

fix the previous patch, the macro was placed on the wrong line.

Jan 8 2021, 11:51 AM · Restricted Project
michaelrj updated the diff for D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

Add the macro definition for fuchsia (or others) to hook into for extra attributes on the libc functions

Jan 8 2021, 10:59 AM · Restricted Project

Jan 7 2021

michaelrj added a comment to D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

submit comment

Jan 7 2021, 3:04 PM · Restricted Project
michaelrj updated the diff for D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

update the macro in common.h to force the decltypes to use the definition in the __llvm_libc namespace

Jan 7 2021, 3:03 PM · Restricted Project
michaelrj updated the diff for D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

update fmaf.cpp to be in line with the rest of the functions.

Jan 7 2021, 10:43 AM · Restricted Project

Jan 6 2021

michaelrj updated the diff for D94195: [libc] Switch to use a macro which does not insert a section for every libc function..

fix the alias name in common.h.def

Jan 6 2021, 3:01 PM · Restricted Project
michaelrj requested review of D94195: [libc] Switch to use a macro which does not insert a section for every libc function..
Jan 6 2021, 2:35 PM · Restricted Project

Dec 16 2020

michaelrj accepted D93417: [libc] Refactor WrapperGen to make the flow cleaner..

accepted with nits

Dec 16 2020, 3:43 PM · Restricted Project

Dec 11 2020

michaelrj accepted D93142: [libc] Let wrappergen pick LLVM libc mangled name from aliasee file..

LGTM

Dec 11 2020, 2:21 PM · Restricted Project

Dec 4 2020

michaelrj committed rGe60f2cbd0cd8: [libc] add tests to WrapperGen (authored by michaelrj).
[libc] add tests to WrapperGen
Dec 4 2020, 10:14 AM
michaelrj closed D92137: [libc] add tests to WrapperGen.
Dec 4 2020, 10:14 AM · Restricted Project
michaelrj updated the diff for D92137: [libc] add tests to WrapperGen.

final cleanup

Dec 4 2020, 10:08 AM · Restricted Project

Dec 2 2020

michaelrj added a comment to D92137: [libc] add tests to WrapperGen.

submit comments

Dec 2 2020, 3:22 PM · Restricted Project
michaelrj updated the diff for D92137: [libc] add tests to WrapperGen.

added more tests

Dec 2 2020, 3:22 PM · Restricted Project

Dec 1 2020

michaelrj updated the diff for D92137: [libc] add tests to WrapperGen.

remove references to targetos

Dec 1 2020, 4:58 PM · Restricted Project
michaelrj added a comment to D92137: [libc] add tests to WrapperGen.

after talking with Siva about it it looks like we're going to stick with this for the moment and not go with lit tests. The reason is that currently the wrappergen unit tests about as dependent on LLVM support as wrappergen itself, adding lit tests would make portability potentially harder.

Dec 1 2020, 4:55 PM · Restricted Project
michaelrj updated the diff for D92137: [libc] add tests to WrapperGen.

add testapi.td so that the tests are no longer platform dependent and clean up the code a little.

Dec 1 2020, 4:55 PM · Restricted Project

Nov 30 2020

michaelrj added a comment to D92137: [libc] add tests to WrapperGen.

submit comments

Nov 30 2020, 3:25 PM · Restricted Project
michaelrj updated the diff for D92137: [libc] add tests to WrapperGen.

address most of the comments

Nov 30 2020, 3:25 PM · Restricted Project
michaelrj added a comment to D92137: [libc] add tests to WrapperGen.

I'm not quite sure why a lit test would be better in this situation, does it have better support for testing complete binaries?

Nov 30 2020, 10:28 AM · Restricted Project

Nov 25 2020

michaelrj requested review of D92137: [libc] add tests to WrapperGen.
Nov 25 2020, 2:41 PM · Restricted Project

Nov 20 2020

michaelrj updated the summary of D91665: [libc] Make more of the libc unit testing llvm independent.
Nov 20 2020, 4:29 PM · Restricted Project
michaelrj committed rG8a4ee3550b7c: [libc] Make more of the libc unit testing llvm independent (authored by michaelrj).
[libc] Make more of the libc unit testing llvm independent
Nov 20 2020, 4:27 PM
michaelrj closed D91665: [libc] Make more of the libc unit testing llvm independent.
Nov 20 2020, 4:27 PM · Restricted Project
michaelrj updated the diff for D91665: [libc] Make more of the libc unit testing llvm independent.

remove commented out include

Nov 20 2020, 4:26 PM · Restricted Project
michaelrj committed rG3e18fb339039: [libc] Switch functions to using global headers (authored by michaelrj).
[libc] Switch functions to using global headers
Nov 20 2020, 4:07 PM
michaelrj closed D91394: [libc] Switch functions to using global headers.
Nov 20 2020, 4:07 PM · Restricted Project

Nov 19 2020

michaelrj added a comment to D91665: [libc] Make more of the libc unit testing llvm independent.

submit comments

Nov 19 2020, 1:41 PM · Restricted Project
michaelrj updated the diff for D91665: [libc] Make more of the libc unit testing llvm independent.

This change finishes the work started in the previous one, all of the tests now pass.
Big thank you to abrachet for the comments.

Nov 19 2020, 1:41 PM · Restricted Project

Nov 18 2020

michaelrj added a comment to D91665: [libc] Make more of the libc unit testing llvm independent.

submit comments

Nov 18 2020, 2:09 PM · Restricted Project
michaelrj updated the diff for D91665: [libc] Make more of the libc unit testing llvm independent.

(NOT QUITE WORKING) get the rest of the llvm dependencies out StreamWrapper and FDReader

Nov 18 2020, 2:09 PM · Restricted Project

Nov 17 2020

michaelrj added a comment to D91568: [libc] make part of libc's unit test framework independent of llvm.

I guess I've got some more changes ahead of me. This new commit (linked here) is where I plan on putting the next set, and it currently has a few based on what you've said.

Nov 17 2020, 3:51 PM · Restricted Project
michaelrj requested review of D91665: [libc] Make more of the libc unit testing llvm independent.
Nov 17 2020, 3:49 PM · Restricted Project
michaelrj updated the summary of D91394: [libc] Switch functions to using global headers.
Nov 17 2020, 11:05 AM · Restricted Project
michaelrj updated the diff for D91394: [libc] Switch functions to using global headers.

switch the tests to using the global headers to match the sources they're testing.

Nov 17 2020, 11:05 AM · Restricted Project
michaelrj committed rGa200d6cdf0f7: [libc] make part of libc's unit test framework independent of llvm (authored by michaelrj).
[libc] make part of libc's unit test framework independent of llvm
Nov 17 2020, 10:43 AM
michaelrj closed D91568: [libc] make part of libc's unit test framework independent of llvm.
Nov 17 2020, 10:43 AM · Restricted Project
michaelrj added a comment to D91568: [libc] make part of libc's unit test framework independent of llvm.

update: I was reminded of the other patch that I'm currently in the process of getting reviewed (linked here: https://reviews.llvm.org/D91394) that will make the string and math tests independent of headergen since they can use the system libc's header. This means if I can make the unit tests fully independent then you can bring up both the string and math parts of LLVM-libc without the whole project.

Nov 17 2020, 10:39 AM · Restricted Project
michaelrj added a comment to D91568: [libc] make part of libc's unit test framework independent of llvm.

Do our tests depend on the generated headers? I thought they did, if so it will be very hard to remove our dependency on the rest of llvm.

Nov 17 2020, 10:30 AM · Restricted Project

Nov 16 2020

michaelrj requested review of D91568: [libc] make part of libc's unit test framework independent of llvm.
Nov 16 2020, 2:28 PM · Restricted Project
michaelrj updated the summary of D91394: [libc] Switch functions to using global headers.
Nov 16 2020, 10:14 AM · Restricted Project
michaelrj updated the diff for D91394: [libc] Switch functions to using global headers.

reset the #includes for everything not in src/string and src/math

Nov 16 2020, 10:14 AM · Restricted Project

Nov 12 2020

michaelrj requested review of D91394: [libc] Switch functions to using global headers.
Nov 12 2020, 4:31 PM · Restricted Project

Nov 6 2020

michaelrj accepted D90985: [libc] Extend WrapperGen to emit aliases..

lgtm with nits

Nov 6 2020, 3:59 PM · Restricted Project
michaelrj accepted D90900: [libc][WrapperGen] Replace the C _Noreturn annotation with C++ [[noreturn]]..

LGTM

Nov 6 2020, 9:38 AM · Restricted Project

Nov 5 2020

michaelrj committed rG5c801de13cc2: [libc] Fix WrapperGen seeing no arguments as a void argument. (authored by michaelrj).
[libc] Fix WrapperGen seeing no arguments as a void argument.
Nov 5 2020, 11:13 AM
michaelrj closed D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..
Nov 5 2020, 11:13 AM · Restricted Project
michaelrj added a comment to D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..

submit messages (I really gotta remember to mark these before I run the arc command)

Nov 5 2020, 10:53 AM · Restricted Project
michaelrj updated the diff for D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..

make error message more helpful

Nov 5 2020, 10:53 AM · Restricted Project
michaelrj added a comment to D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..

submit comments

Nov 5 2020, 10:32 AM · Restricted Project
michaelrj updated the diff for D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..

add check for a void argument as well as other arguments in the same function.

Nov 5 2020, 10:31 AM · Restricted Project
michaelrj added a comment to D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..

submit comments

Nov 5 2020, 10:11 AM · Restricted Project
michaelrj updated the diff for D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..

change continue to break

Nov 5 2020, 10:10 AM · Restricted Project

Nov 4 2020

michaelrj requested review of D90800: [libc] Fix WrapperGen seeing no arguments as a void argument..
Nov 4 2020, 3:01 PM · Restricted Project

Nov 3 2020

michaelrj committed rG5080840d280d: [LIBC][NFC] Rename errno and assert files to match other files with functions (authored by michaelrj).
[LIBC][NFC] Rename errno and assert files to match other files with functions
Nov 3 2020, 1:29 PM
michaelrj closed D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions.
Nov 3 2020, 1:29 PM · Restricted Project
michaelrj updated the diff for D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions.

added header guard to llvmlibc_errno.h, and a comment on assert.h explaining the lack of header guard (thank you to abrachet).

Nov 3 2020, 1:27 PM · Restricted Project
michaelrj updated the diff for D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions.

fix missing newline at the end of a file.

Nov 3 2020, 11:04 AM · Restricted Project
michaelrj updated the summary of D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions.
Nov 3 2020, 10:58 AM · Restricted Project
michaelrj updated the diff for D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions.

move the errno macro to its own file to match assert.

Nov 3 2020, 10:57 AM · Restricted Project
michaelrj retitled D90653: [LIBC][NFC] Rename errno and assert files to match other files with functions from [LIBC][NFC] Rename errno files to match other files with functions to [LIBC][NFC] Rename errno and assert files to match other files with functions.
Nov 3 2020, 10:39 AM · Restricted Project