Page MenuHomePhabricator

brooksmoses (Brooks Moses)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 15 2017, 2:00 PM (92 w, 17 h)

Recent Activity

Aug 9 2019

brooksmoses added a comment to rL368479: [X86] Remove custom handling for extloads from LowerLoad..

This breaks the build with an unused-variable warning:

Aug 9 2019, 1:58 PM

Jun 14 2019

brooksmoses added a comment to rL363474: adding more fmf propagation for selects plus tests.

Hey, so I'm seeing these tests starting to fail with llc errors. The output looks like this (after going through the output-scanning layer):

Jun 14 2019, 7:15 PM

Jun 7 2019

brooksmoses added a comment to D62223: [DAGCombiner][X86][AArch64][AMDGPU] (x + C) - y -> (x - y) + C fold.

Unfortunately, we (Google) are seeing some regressions on our internal benchmarks on x86_64 -- mostly around 2%, but in some cases a good bit more -- from this revision and some of the subsequent revisions in the series, notably r362217. Just wanted to give you a heads-up at this point -- we're still working to try to understand the underlying reasons and get a reproducing test-case, but it looks like these are going to block our internal release until they're addressed.

Jun 7 2019, 4:20 PM · Restricted Project

Jun 6 2019

brooksmoses added a comment to rL362539: Revert r362472 as it is breaking PPC build bots.

For what it's worth, I was also seeing some run-time errors on x86 coming from the change that this reverts. I haven't dug into things to track them down, beyond determining that this change makes them go away again.

Jun 6 2019, 1:07 AM

May 22 2019

brooksmoses added a comment to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.

Thanks for the quick fix for bug 41973!

May 22 2019, 11:50 AM

Jun 9 2018

brooksmoses added a comment to D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..

While you're doing that, maybe also fix "refer different places" in the comment on line 447 to be "refer to different places". :)

Jun 9 2018, 2:01 AM

Apr 18 2018

brooksmoses added a comment to D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators..

Thanks for the summary, John. To confirm, I found two examples of bugs involving local variables, as well as the field-based examples. And, indeed, all of the false positives were in unit tests.

Apr 18 2018, 10:22 AM · Restricted Project

Apr 16 2018

brooksmoses added a comment to D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes).

A further concern about this in the general case from the reviewer of one of my test-cleanup changes: The "var = *&var" idiom is not necessarily equivalent to "var = var" in cases of user-defined types, because operator& may be overloaded.

Apr 16 2018, 2:06 AM
brooksmoses added a comment to D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes).

Some further statistics, now that I've done a full cleanup on our code:

Apr 16 2018, 1:16 AM

Apr 15 2018

brooksmoses added a comment to D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes).

Further note: I'm noticing that nearly all the signal is from -Wself-assign-field and all the noise is from -Wself-assign. So that would be one obvious way to make this higher-signal in what's enabled in -Wall, if that were a desire.

Apr 15 2018, 4:56 PM
brooksmoses added a comment to D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes).

I have noticed two things when attempting to release LLVM with this revision internally at Google:

Apr 15 2018, 3:09 PM

Dec 15 2017

brooksmoses added a comment to D39407: [(new) Pass Manager] instantiate SimplifyCFG with the same options as the old PM.

We're seeing about 10% regressions in an internal benchmark as a result of this change. Still digging further, but wanted to send a heads-up.

Dec 15 2017, 2:02 PM