Page MenuHomePhabricator

lntue (Tue Ly)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2020, 2:12 PM (28 w, 4 d)

Recent Activity

Wed, Jan 6

lntue accepted D94198: [libc] Use a wrapper for rand instead of calling std::rand in fma tests..
Wed, Jan 6, 2:49 PM · Restricted Project
lntue committed rG4726bec8f29b: [libc] Add implementation of fmaf. (authored by lntue).
[libc] Add implementation of fmaf.
Wed, Jan 6, 2:15 PM
lntue closed D94018: [libc] Add implementation of fmaf..
Wed, Jan 6, 2:15 PM · Restricted Project
lntue added inline comments to D94018: [libc] Add implementation of fmaf..
Wed, Jan 6, 1:49 PM · Restricted Project
lntue updated the diff for D94018: [libc] Add implementation of fmaf..

Add comments.

Wed, Jan 6, 1:48 PM · Restricted Project
lntue updated the diff for D94018: [libc] Add implementation of fmaf..

Address comments.

Wed, Jan 6, 1:43 PM · Restricted Project

Tue, Jan 5

lntue updated the diff for D94018: [libc] Add implementation of fmaf..

Add comments explaining the correction part.

Tue, Jan 5, 11:17 PM · Restricted Project
lntue added inline comments to D94018: [libc] Add implementation of fmaf..
Tue, Jan 5, 11:15 PM · Restricted Project
lntue accepted D94109: [libc] Add implementations of nextafter[f|l] functions..
Tue, Jan 5, 8:45 PM · Restricted Project
lntue accepted D94112: [libc] Add implementations of nearbyint[f|l]..
Tue, Jan 5, 4:01 PM · Restricted Project
lntue added inline comments to D94109: [libc] Add implementations of nextafter[f|l] functions..
Tue, Jan 5, 4:00 PM · Restricted Project
lntue updated the diff for D94018: [libc] Add implementation of fmaf..

Fix comment typo.

Tue, Jan 5, 6:50 AM · Restricted Project

Mon, Jan 4

lntue updated the diff for D94018: [libc] Add implementation of fmaf..

Remove unused local variables.

Mon, Jan 4, 11:37 PM · Restricted Project
lntue updated the diff for D94018: [libc] Add implementation of fmaf..

[trivial] Fix test comment.

Mon, Jan 4, 10:18 AM · Restricted Project
lntue requested review of D94018: [libc] Add implementation of fmaf..
Mon, Jan 4, 10:15 AM · Restricted Project

Tue, Dec 29

lntue accepted D93889: [libc] Add implementations of rounding functions which depend rounding mode..
Tue, Dec 29, 9:37 AM · Restricted Project

Dec 11 2020

lntue accepted D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..
Dec 11 2020, 6:27 AM · Restricted Project

Dec 10 2020

lntue added inline comments to D93007: [libc] Add implementations of lround[f|l] and llround[f|l]..
Dec 10 2020, 8:09 AM · Restricted Project

Dec 8 2020

lntue accepted D92821: [libc] Raise x87 exceptions by synchronizing with "fwait"..
Dec 8 2020, 10:35 AM · Restricted Project

Dec 3 2020

lntue accepted D92546: [libc] Add simple x86_64 floating point exception and rounding mode support..
Dec 3 2020, 8:24 AM · Restricted Project
lntue committed rG3b487d51e2ec: [libc] Add implementation of hypot. (authored by lntue).
[libc] Add implementation of hypot.
Dec 3 2020, 8:09 AM
lntue closed D91831: [libc] Add implementation of hypot..
Dec 3 2020, 8:09 AM · Restricted Project
lntue updated the diff for D91831: [libc] Add implementation of hypot..

Change UInt_t to UIntType.

Dec 3 2020, 8:04 AM · Restricted Project
lntue added inline comments to D91831: [libc] Add implementation of hypot..
Dec 3 2020, 7:49 AM · Restricted Project

Dec 1 2020

lntue accepted D92353: [libc] Fix couple of corner cases in remquo..
Dec 1 2020, 12:04 PM · Restricted Project

Nov 20 2020

lntue accepted D91817: [libc] Combine all math differential fuzzers into one target..
Nov 20 2020, 6:24 AM · Restricted Project

Nov 19 2020

lntue requested review of D91831: [libc] Add implementation of hypot..
Nov 19 2020, 5:02 PM · Restricted Project
lntue added inline comments to D91817: [libc] Combine all math differential fuzzers into one target..
Nov 19 2020, 1:34 PM · Restricted Project
lntue accepted D91763: [libc] Add differential fuzzers for ldexp and remquo..
Nov 19 2020, 6:29 AM · Restricted Project

Nov 18 2020

lntue accepted D91752: [libc] Fix the overflow check condition of ldexp..
Nov 18 2020, 8:44 PM · Restricted Project

Nov 17 2020

lntue accepted D91591: [libc] Add implementations of ldexp[f|l]..
Nov 17 2020, 12:02 PM · Restricted Project
lntue added inline comments to D91591: [libc] Add implementations of ldexp[f|l]..
Nov 17 2020, 6:29 AM · Restricted Project

Nov 10 2020

lntue committed rGd41280467d69: [libc] Add implementations of fdim[f|l]. (authored by lntue).
[libc] Add implementations of fdim[f|l].
Nov 10 2020, 3:49 PM
lntue closed D90906: [libc] Add implementations of fdim[f|l]..
Nov 10 2020, 3:49 PM · Restricted Project
lntue added inline comments to D90906: [libc] Add implementations of fdim[f|l]..
Nov 10 2020, 6:03 AM · Restricted Project

Nov 9 2020

lntue added inline comments to D90906: [libc] Add implementations of fdim[f|l]..
Nov 9 2020, 10:20 PM · Restricted Project
lntue updated the diff for D90906: [libc] Add implementations of fdim[f|l]..

Update constants for FDimTest.

Nov 9 2020, 10:14 PM · Restricted Project
lntue updated the diff for D90906: [libc] Add implementations of fdim[f|l]..

[libc] Add implementations of fdim[f|l].

Nov 9 2020, 9:48 PM · Restricted Project
lntue updated the diff for D90906: [libc] Add implementations of fdim[f|l]..

[libc] Add implementations of fdim[f|l].

Nov 9 2020, 9:47 PM · Restricted Project

Nov 5 2020

lntue requested review of D90906: [libc] Add implementations of fdim[f|l]..
Nov 5 2020, 11:29 PM · Restricted Project

Nov 4 2020

lntue accepted D90806: [libc] Add implementations of ilogb[f|l]..
Nov 4 2020, 6:13 PM · Restricted Project
lntue accepted D90805: [libc][NFC] Make test macros callable from helper methods of test classes..
Nov 4 2020, 6:13 PM · Restricted Project

Oct 27 2020

lntue accepted D90262: [libc][NFC] Use a convenience macro to declare special floating point constants..
Oct 27 2020, 3:42 PM · Restricted Project

Oct 13 2020

lntue added inline comments to D89267: [libc] Use entrypoints.txt as the single source of list of functions for a platform..
Oct 13 2020, 1:27 PM · Restricted Project

Sep 17 2020

lntue committed rGf55963d501e4: [libc] Add implementation for hypotf (authored by lntue).
[libc] Add implementation for hypotf
Sep 17 2020, 8:47 PM
lntue closed D87516: [libc] Add implementation for hypotf.
Sep 17 2020, 8:47 PM · Restricted Project
lntue updated the diff for D87516: [libc] Add implementation for hypotf.

Change to snake_case.

Sep 17 2020, 8:46 PM · Restricted Project

Sep 14 2020

lntue updated the diff for D87516: [libc] Add implementation for hypotf.

Change to early return pattern.

Sep 14 2020, 12:41 PM · Restricted Project
lntue added inline comments to D87516: [libc] Add implementation for hypotf.
Sep 14 2020, 12:41 PM · Restricted Project
lntue committed rGabf1c82dcc5c: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function. (authored by lntue).
[libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function.
Sep 14 2020, 11:57 AM
lntue closed D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function..
Sep 14 2020, 11:56 AM · Restricted Project
lntue updated the diff for D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function..

Remove TODO's.

Sep 14 2020, 11:55 AM · Restricted Project
lntue added inline comments to D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function..
Sep 14 2020, 11:06 AM · Restricted Project

Sep 11 2020

lntue updated the diff for D87516: [libc] Add implementation for hypotf.

Fix comments alignment and remove commented tests.

Sep 11 2020, 8:09 AM · Restricted Project
lntue requested review of D87516: [libc] Add implementation for hypotf.
Sep 11 2020, 7:49 AM · Restricted Project
lntue requested review of D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function..
Sep 11 2020, 7:36 AM · Restricted Project

Sep 3 2020

lntue accepted D86666: [libc] Add implementations of remquo[f|l] and remainder[f|l]..
Sep 3 2020, 9:43 PM · Restricted Project
lntue added inline comments to D86666: [libc] Add implementations of remquo[f|l] and remainder[f|l]..
Sep 3 2020, 12:32 PM · Restricted Project

Aug 26 2020

lntue committed rG5078825aa982: [libc] Add implementations for sqrt, sqrtf, and sqrtl. (authored by lntue).
[libc] Add implementations for sqrt, sqrtf, and sqrtl.
Aug 26 2020, 6:47 AM
lntue closed D84726: [libc] Add implementations for sqrt, sqrtf, and sqrtl..
Aug 26 2020, 6:46 AM · Restricted Project
lntue added inline comments to D84726: [libc] Add implementations for sqrt, sqrtf, and sqrtl..
Aug 26 2020, 6:21 AM · Restricted Project

Aug 25 2020

lntue accepted D86506: [libc] Extend MPFRMatcher to handle multiple-input-multiple-output functions..
Aug 25 2020, 8:19 AM · Restricted Project

Aug 20 2020

lntue accepted D86267: [libc][NFC] Switch math tests to the new ULP based tolerance..
Aug 20 2020, 7:56 AM · Restricted Project
lntue accepted D86241: [libc] Add a class called NormalFloat which represents normalized floats..
Aug 20 2020, 7:53 AM · Restricted Project

Aug 19 2020

lntue added inline comments to D86241: [libc] Add a class called NormalFloat which represents normalized floats..
Aug 19 2020, 11:08 PM · Restricted Project

Aug 18 2020

lntue updated the diff for D84726: [libc] Add implementations for sqrt, sqrtf, and sqrtl..

Update to the new floating point testing facility.

Aug 18 2020, 9:22 PM · Restricted Project
lntue committed rG9887a70e7a76: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions… (authored by lntue).
[libc] Add ULP function to MPFRNumber class to test correctly rounded functions…
Aug 18 2020, 10:52 AM
lntue closed D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..
Aug 18 2020, 10:52 AM · Restricted Project
lntue updated the diff for D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

Update comments.

Aug 18 2020, 10:48 AM · Restricted Project
lntue added inline comments to D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..
Aug 18 2020, 9:40 AM · Restricted Project
lntue updated the diff for D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

Update comments

Aug 18 2020, 9:38 AM · Restricted Project

Aug 16 2020

lntue updated the diff for D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

Correct the eps when the input is a power of 2, and add a check for correct rounding to even when it is a tie.

Aug 16 2020, 2:32 PM · Restricted Project

Aug 13 2020

lntue added inline comments to D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..
Aug 13 2020, 8:09 AM · Restricted Project

Aug 12 2020

lntue updated the diff for D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

Merge with reviews.llvm.org/D85486

Aug 12 2020, 10:44 PM · Restricted Project

Aug 7 2020

lntue accepted D85486: [libc][NFC] Add library of floating point test matchers..
Aug 7 2020, 8:19 AM · Restricted Project

Aug 5 2020

lntue added a comment to D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

We currently have UnitTest depend on FPUtil. I think that an creates unnecessary dependency for tests which do not need FPUtil for testing. So, a plan could be:

Instead of EXPECT_EQ and friends for floating point numbers, we will decouple UnitTest from FPUtil using matchers implemented in FPUtil. Say, EXPECT_FP_MATCH etc.

WDYT? If you concur, then you need not do the work. I will do it, and you can absorb those changes into this patch.

Aug 5 2020, 12:16 PM · Restricted Project

Jul 29 2020

lntue updated the diff for D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..

Fix explicit specialization in class scope.

Jul 29 2020, 1:37 PM · Restricted Project

Jul 28 2020

lntue requested review of D84726: [libc] Add implementations for sqrt, sqrtf, and sqrtl..
Jul 28 2020, 2:04 PM · Restricted Project
lntue requested review of D84725: [libc] Add ULP function to MPFRNumber class to test correctly rounded functions such as SQRT, FMA..
Jul 28 2020, 2:02 PM · Restricted Project

Jul 23 2020

lntue added inline comments to D84469: [libc] Adds implementation for memrchr..
Jul 23 2020, 4:05 PM · Restricted Project
lntue committed rG1404d9d68a9c: [libc] Remove unused #include <vector> in fmin_test, fminf_test, and fminl_test. (authored by lntue).
[libc] Remove unused #include <vector> in fmin_test, fminf_test, and fminl_test.
Jul 23 2020, 12:31 PM
lntue committed rG4096088e1941: [libc] Add implementations of fmax, fmaxf, and fmaxl. (authored by lntue).
[libc] Add implementations of fmax, fmaxf, and fmaxl.
Jul 23 2020, 12:24 PM
lntue closed D84385: [libc] Add implementations of fmax, fmaxf, and fmaxl..
Jul 23 2020, 12:24 PM · Restricted Project
lntue updated the diff for D84385: [libc] Add implementations of fmax, fmaxf, and fmaxl..

[libc] Add implementations of fmax, fmaxf, and fmaxl.

Jul 23 2020, 12:13 PM · Restricted Project

Jul 22 2020

Herald added a project to D84385: [libc] Add implementations of fmax, fmaxf, and fmaxl.: Restricted Project.
Jul 22 2020, 11:09 PM · Restricted Project

Jul 21 2020

lntue committed rG7ce32f87f962: Add implementations for fmin, fminf, and fminl. Testing infrastructure update… (authored by lntue).
Add implementations for fmin, fminf, and fminl. Testing infrastructure update…
Jul 21 2020, 2:28 PM
lntue committed rG34f66c1438ef: Add implementations for fmin, fminf, and fminl. Testing infrastructure update… (authored by lntue).
Add implementations for fmin, fminf, and fminl. Testing infrastructure update…
Jul 21 2020, 2:15 PM
lntue committed rGe138ad41e0e6: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point… (authored by lntue).
Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point…
Jul 21 2020, 1:52 PM
lntue closed D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..
Jul 21 2020, 1:52 PM · Restricted Project
lntue added inline comments to D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..
Jul 21 2020, 10:41 AM · Restricted Project
lntue updated the diff for D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..

Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double).

Jul 21 2020, 10:41 AM · Restricted Project

Jul 20 2020

lntue added a comment to D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..

Why add support to the TEST macros for this when we have the MPFR macros which I think handle floats better than we can with TEST. Comparisons with floating points are not fun, its why we use the mpfr library in the first place. Is there even a need to use the TEST macros with floats?

Let me give some explanation from my side for this. For non-trivial math functions like trignometric functions, comparing with MPFR result makes sense because we can use MPFR as source of truth/correctness. But, for functions like fmin and friends, comparing with MPFR is an overkill. I agree that comparing floating points in general could be problematic and that is the reason why we did not allow floating comparisons until now. But, if we restrict ourselves to values which have an exact bit representation, then comparisons are precise and deterministic. For example, zero, infinity and small decimals like 10.0, 1.2345 etc. have exact bit representation in all relevant floating point formats Likewise, if a floating point number is actually constructed from the bit representation, then that number has exact bit representation by construction. So, comparing such numbers would be precise.

One can ask, how can we ensure one uses only exact floating point numbers in tests. I don't have a good answer other than saying "code review". May be we can write a clang-tidy driven tool in future. Irrespective, I think this patch improves the readability of the tests. @lntue is the expert here so he might have more to add.

Jul 20 2020, 9:47 PM · Restricted Project
lntue added inline comments to D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..
Jul 20 2020, 9:23 PM · Restricted Project
lntue updated the diff for D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..

Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double).

Jul 20 2020, 9:22 PM · Restricted Project
lntue updated the diff for D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double)..

Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double).

Jul 20 2020, 9:16 PM · Restricted Project

Jul 17 2020

lntue accepted D83980: [libc][NFC] Use RemoveCVType to implement IsIntegral and IsPointerType..
Jul 17 2020, 7:37 AM · Restricted Project

Jul 15 2020

lntue added inline comments to D82997: [libc] Add implementations of fmin, fminf and fminl..
Jul 15 2020, 11:54 PM · Restricted Project
lntue updated the diff for D82997: [libc] Add implementations of fmin, fminf and fminl..

Add implementations of fmin, fminf, and fminl. Testing infrastructure update is splitted to https://reviews.llvm.org/D83931.

Jul 15 2020, 11:51 PM · Restricted Project
Herald added a project to D83931: Update Test (EXPECT_EQ and friends) to accept __uint128_t and floating point types (float, double, long double).: Restricted Project.
Jul 15 2020, 11:33 PM · Restricted Project

Jul 14 2020

lntue updated the diff for D82997: [libc] Add implementations of fmin, fminf and fminl..

Refactor utohexstr and overloads of raw_stream.operator<<

Jul 14 2020, 11:18 PM · Restricted Project