Page MenuHomePhabricator

lntue (Tue Ly)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2020, 2:12 PM (134 w, 4 d)

Recent Activity

Yesterday

lntue added a comment to D142781: [libc][math] Implement acoshf function correctly rounded to all rounding modes..

I cannot apply to main (revision f7c1982), the patch fails.

Sat, Jan 28, 10:01 AM · Restricted Project, Restricted Project
lntue updated the diff for D142781: [libc][math] Implement acoshf function correctly rounded to all rounding modes..

Sync to HEAD.

Sat, Jan 28, 9:59 AM · Restricted Project, Restricted Project

Fri, Jan 27

lntue requested review of D142781: [libc][math] Implement acoshf function correctly rounded to all rounding modes..
Fri, Jan 27, 1:09 PM · Restricted Project, Restricted Project
lntue accepted D142774: [libc] Do not install to the default triple in GPU mode.
Fri, Jan 27, 11:58 AM · Restricted Project, Restricted Project
lntue accepted D142776: [libc] Add code for detecting NVIDIA GPUs as well.
Fri, Jan 27, 11:30 AM · Restricted Project, Restricted Project
lntue committed rG46b15fd19e84: [libc][math] Implement asinhf function correctly rounded for all rounding modes. (authored by lntue).
[libc][math] Implement asinhf function correctly rounded for all rounding modes.
Fri, Jan 27, 8:13 AM · Restricted Project, Restricted Project
lntue closed D142681: [libc][math] Implement asinhf function correctly rounded for all rounding modes..
Fri, Jan 27, 8:12 AM · Restricted Project, Restricted Project
lntue committed rGa369bb8a3b18: [libc][cmake] Fix LIBC_TARGET_OS query from compiler triple for `darwin`. (authored by lntue).
[libc][cmake] Fix LIBC_TARGET_OS query from compiler triple for `darwin`.
Fri, Jan 27, 7:15 AM · Restricted Project, Restricted Project
lntue closed D141282: [libc][cmake] Fix LIBC_TARGET_OS query from compiler triple for `darwin`..
Fri, Jan 27, 7:15 AM · Restricted Project, Restricted Project

Thu, Jan 26

lntue requested review of D142681: [libc][math] Implement asinhf function correctly rounded for all rounding modes..
Thu, Jan 26, 5:42 PM · Restricted Project, Restricted Project

Wed, Jan 25

lntue accepted D142518: [libc] Implement strcasestr.
Wed, Jan 25, 7:15 AM · Restricted Project, Restricted Project
lntue accepted D142517: [libc] Templatize strstr.
Wed, Jan 25, 7:03 AM · Restricted Project, Restricted Project
lntue accepted D142510: [libc] add scanf pointer conversion.
Wed, Jan 25, 7:01 AM · Restricted Project, Restricted Project
lntue accepted D142515: [libc] fix strtointmax tests.
Wed, Jan 25, 6:58 AM · Restricted Project, Restricted Project
lntue accepted D142495: [libc] add scanf current position conversion.
Wed, Jan 25, 6:57 AM · Restricted Project, Restricted Project
lntue accepted D141426: [libc] Use a prebuilt libc-hdrgen binary if available..
Wed, Jan 25, 6:42 AM · Restricted Project, Restricted Project

Tue, Jan 24

lntue accepted D142434: [libc][NFC] Replace "inline" keyword with "LIBC_INLINE"..
Tue, Jan 24, 10:30 AM · Restricted Project, Restricted Project

Mon, Jan 23

lntue accepted D142398: [libc][NFC] Another round of replacement of static inline with LIBC_INLINE..
Mon, Jan 23, 2:07 PM · Restricted Project, Restricted Project

Fri, Jan 20

lntue accepted D142108: [libc][NFC] Detect host CPU features using try_compile instead of try_run..
Fri, Jan 20, 9:36 AM · Restricted Project, Restricted Project

Thu, Jan 19

lntue accepted D142154: [libc][NFC] Replace static inline and inline annotations with LIBC_INLINE..
Thu, Jan 19, 5:53 PM · Restricted Project, Restricted Project
lntue added a comment to D142108: [libc][NFC] Detect host CPU features using try_compile instead of try_run..

I have two design questions:

  • Do we want to merge "architectures.h" and "cpu_features.h" since they usually are used together?
  • Do we want to autogenerate the C files since they are not quite minimal?
Thu, Jan 19, 8:20 AM · Restricted Project, Restricted Project

Tue, Jan 10

lntue accepted D141428: [libc] Use the boostrap build's target triple if available..
Tue, Jan 10, 2:53 PM · Restricted Project, Restricted Project

Mon, Jan 9

lntue committed rG72a794c2200a: [libc][Obvious] Re-enable log10 tests. (authored by lntue).
[libc][Obvious] Re-enable log10 tests.
Mon, Jan 9, 12:56 PM · Restricted Project, Restricted Project
lntue committed rG05727d94de75: [libc][Obvious] Fix typos in LLVMLibCArchitectures.cmake defining target… (authored by lntue).
[libc][Obvious] Fix typos in LLVMLibCArchitectures.cmake defining target…
Mon, Jan 9, 12:54 PM · Restricted Project, Restricted Project
lntue closed D141314: [libc] Fix typos in LLVMLibCArchitectures.cmake defining target architectures..
Mon, Jan 9, 12:54 PM · Restricted Project, Restricted Project
lntue requested review of D141314: [libc] Fix typos in LLVMLibCArchitectures.cmake defining target architectures..
Mon, Jan 9, 12:16 PM · Restricted Project, Restricted Project
lntue requested review of D141282: [libc][cmake] Fix LIBC_TARGET_OS query from compiler triple for `darwin`..
Mon, Jan 9, 7:09 AM · Restricted Project, Restricted Project
lntue added inline comments to D141235: [libc] Templatize str{,n}cmp.
Mon, Jan 9, 6:54 AM · Restricted Project, Restricted Project

Sun, Jan 8

lntue committed rG9e5fde59a466: [libc][Obvious] Temporarily disable log10_test for further investigation. (authored by lntue).
[libc][Obvious] Temporarily disable log10_test for further investigation.
Sun, Jan 8, 3:22 PM · Restricted Project, Restricted Project
lntue committed rG1b9c21fda951: [libc][Obvious] Remove constexpr fomr exact_mult in double_double.h (authored by lntue).
[libc][Obvious] Remove constexpr fomr exact_mult in double_double.h
Sun, Jan 8, 2:54 PM · Restricted Project, Restricted Project
lntue committed rG5814b7b27963: [libc][math] Implement log10 function correctly rounded for all rounding modes (authored by lntue).
[libc][math] Implement log10 function correctly rounded for all rounding modes
Sun, Jan 8, 2:42 PM · Restricted Project, Restricted Project
lntue closed D139846: [libc][math] Implement log10 function correctly rounded for all rounding modes.
Sun, Jan 8, 2:42 PM · Restricted Project, Restricted Project
lntue updated the diff for D139846: [libc][math] Implement log10 function correctly rounded for all rounding modes.

Update log algorithm doc and unit tests.

Sun, Jan 8, 2:41 PM · Restricted Project, Restricted Project

Sat, Jan 7

lntue accepted D140492: [libc] Fix -Wimplicit-int-conversion warnings.
Sat, Jan 7, 11:51 AM · Restricted Project, Restricted Project

Thu, Jan 5

lntue accepted D140967: [libc] get_table_negative cannot be constexpr.
Thu, Jan 5, 6:24 AM · Restricted Project, Restricted Project

Dec 22 2022

lntue accepted D140597: [libc][NFC] Use operator new and operator delete in POSIX file actions API..
Dec 22 2022, 7:31 PM · Restricted Project, Restricted Project
lntue accepted D140574: [libc][NFC] Use operator delete to cleanup a File object..
Dec 22 2022, 12:04 PM · Restricted Project, Restricted Project
lntue accepted D140441: [libc] change str to int tests to be templated.
Dec 22 2022, 10:29 AM · Restricted Project, Restricted Project
lntue accepted D140526: [libc] Handle allocation failures gracefully in FILE related API..
Dec 22 2022, 5:56 AM · Restricted Project, Restricted Project

Dec 21 2022

lntue added inline comments to D140441: [libc] change str to int tests to be templated.
Dec 21 2022, 6:10 PM · Restricted Project, Restricted Project
lntue accepted D140461: [libc][NFC] Use the custom operator new from strndup..
Dec 21 2022, 6:51 AM · Restricted Project, Restricted Project
lntue accepted D140459: [libc] Gracefully handle allocation failures around BlockStore..
Dec 21 2022, 6:51 AM · Restricted Project, Restricted Project

Dec 20 2022

lntue added a comment to D140441: [libc] change str to int tests to be templated.

Look like you'll need to update the bazel layout for the tests. It complains about missing files.

Dec 20 2022, 7:41 PM · Restricted Project, Restricted Project
lntue accepted D140178: [libc] add fuzz target for strtointeger functions.
Dec 20 2022, 10:44 AM · Restricted Project, Restricted Project
lntue added inline comments to D140178: [libc] add fuzz target for strtointeger functions.
Dec 20 2022, 10:36 AM · Restricted Project, Restricted Project
lntue accepted D140376: [libc][NFC] Simplify how the definiton of NULL macro is added to string.h..
Dec 20 2022, 9:30 AM · Restricted Project, Restricted Project
lntue accepted D140378: [libc] Add a baremetal config..
Dec 20 2022, 9:29 AM · Restricted Project, Restricted Project
lntue accepted D140375: [libc] Simplify generation of errno.h..
Dec 20 2022, 9:25 AM · Restricted Project, Restricted Project

Dec 15 2022

lntue accepted D140078: [libc] Handle allocation failures in the dirent API gracefully..
Dec 15 2022, 12:54 PM · Restricted Project, Restricted Project
lntue accepted D140070: [libc] fix shifting exact multiples of 64 in uint.
Dec 15 2022, 12:00 PM · Restricted Project, Restricted Project
lntue added inline comments to D140078: [libc] Handle allocation failures in the dirent API gracefully..
Dec 15 2022, 11:59 AM · Restricted Project, Restricted Project
lntue added inline comments to D140078: [libc] Handle allocation failures in the dirent API gracefully..
Dec 15 2022, 6:53 AM · Restricted Project, Restricted Project
lntue added inline comments to D140070: [libc] fix shifting exact multiples of 64 in uint.
Dec 15 2022, 6:43 AM · Restricted Project, Restricted Project
lntue accepted D140049: [libc][NFC] Rename "loader" to "startup"..
Dec 15 2022, 6:37 AM · Restricted Project, Restricted Project

Dec 13 2022

lntue updated the diff for D139846: [libc][math] Implement log10 function correctly rounded for all rounding modes.

Sync to HEAD.

Dec 13 2022, 9:49 PM · Restricted Project, Restricted Project
lntue committed rGd6802581700b: [libc] Implement a high-precision floating point class. (authored by lntue).
[libc] Implement a high-precision floating point class.
Dec 13 2022, 9:38 PM · Restricted Project, Restricted Project
lntue closed D136799: [libc] Implement a high-precision floating point class..
Dec 13 2022, 9:37 PM · Restricted Project, Restricted Project
lntue added inline comments to D136799: [libc] Implement a high-precision floating point class..
Dec 13 2022, 10:31 AM · Restricted Project, Restricted Project
lntue added inline comments to D136799: [libc] Implement a high-precision floating point class..
Dec 13 2022, 9:13 AM · Restricted Project, Restricted Project
lntue updated the diff for D136799: [libc] Implement a high-precision floating point class..

Address comments.

Dec 13 2022, 9:12 AM · Restricted Project, Restricted Project

Dec 12 2022

lntue updated the summary of D139846: [libc][math] Implement log10 function correctly rounded for all rounding modes.
Dec 12 2022, 8:25 AM · Restricted Project, Restricted Project
lntue requested review of D139846: [libc][math] Implement log10 function correctly rounded for all rounding modes.
Dec 12 2022, 8:14 AM · Restricted Project, Restricted Project

Dec 10 2022

lntue accepted D139584: [libc] Add custom operator new to handle allocation failures gracefully..
Dec 10 2022, 2:41 AM · Restricted Project, Restricted Project

Dec 9 2022

lntue added inline comments to D139584: [libc] Add custom operator new to handle allocation failures gracefully..
Dec 9 2022, 8:58 PM · Restricted Project, Restricted Project

Dec 7 2022

lntue added inline comments to D139576: [libc] move errno out of file internals.
Dec 7 2022, 4:54 PM · Restricted Project, Restricted Project
lntue abandoned D130008: [libc][Experimental] Use nearest integer instructions to speed up exp*f..
Dec 7 2022, 4:49 PM · Restricted Project, Restricted Project
lntue added inline comments to D139584: [libc] Add custom operator new to handle allocation failures gracefully..
Dec 7 2022, 4:41 PM · Restricted Project, Restricted Project
lntue committed rG360b41c7ba7f: [libc] Fix undefined behavior in UInt<>::shift_right. (authored by lntue).
[libc] Fix undefined behavior in UInt<>::shift_right.
Dec 7 2022, 3:38 PM · Restricted Project, Restricted Project
lntue closed D139566: [libc] Fix undefined behavior in UInt<>::shift_right..
Dec 7 2022, 3:38 PM · Restricted Project, Restricted Project
lntue added inline comments to D139566: [libc] Fix undefined behavior in UInt<>::shift_right..
Dec 7 2022, 1:10 PM · Restricted Project, Restricted Project
lntue requested review of D139566: [libc] Fix undefined behavior in UInt<>::shift_right..
Dec 7 2022, 11:27 AM · Restricted Project, Restricted Project
lntue added inline comments to D136799: [libc] Implement a high-precision floating point class..
Dec 7 2022, 9:04 AM · Restricted Project, Restricted Project
lntue added a reviewer for D136799: [libc] Implement a high-precision floating point class.: renyichen.
Dec 7 2022, 8:57 AM · Restricted Project, Restricted Project
lntue updated the diff for D136799: [libc] Implement a high-precision floating point class..

Change the name of the class to DyadicFloat, add normalization, and add tests.

Dec 7 2022, 8:56 AM · Restricted Project, Restricted Project

Dec 5 2022

lntue accepted D139348: [libc] Fix wrappergen_test.cpp on runtimes build.
Dec 5 2022, 2:22 PM · Restricted Project, Restricted Project

Dec 2 2022

lntue committed rG28f13353b6b1: [libc][Obvious] Update error bounds for uint_test.QuickMulHiTests. (authored by lntue).
[libc][Obvious] Update error bounds for uint_test.QuickMulHiTests.
Dec 2 2022, 3:16 PM · Restricted Project, Restricted Project
lntue committed rGb80f535879a3: [libc][math] Implement full multiplication and quick_mul_hi for UInt class. (authored by lntue).
[libc][math] Implement full multiplication and quick_mul_hi for UInt class.
Dec 2 2022, 2:54 PM · Restricted Project, Restricted Project
lntue closed D138541: [libc][math] Implement full multiplication and quick_mul_hi for UInt class..
Dec 2 2022, 2:54 PM · Restricted Project, Restricted Project
lntue accepted D139216: [libc] Skip tests that depend on undefined targets.
Dec 2 2022, 11:55 AM · Restricted Project, Restricted Project

Dec 1 2022

lntue updated the diff for D138541: [libc][math] Implement full multiplication and quick_mul_hi for UInt class..

Add comments about error bounds and efficiency of quick_mul_hi + More tests.

Dec 1 2022, 8:31 AM · Restricted Project, Restricted Project
lntue added inline comments to D139064: Onboard signbitf to llvmlibc math functions..
Dec 1 2022, 6:21 AM · Restricted Project, Restricted Project

Nov 30 2022

lntue committed rG926dd32aab1d: [libc][math] Improve the performance of subtraction for UInt<>. (authored by lntue).
[libc][math] Improve the performance of subtraction for UInt<>.
Nov 30 2022, 7:51 AM · Restricted Project, Restricted Project
lntue closed D138506: [libc][math] Improve the performance of subtraction for UInt<>..
Nov 30 2022, 7:51 AM · Restricted Project, Restricted Project

Nov 29 2022

lntue accepted D138856: [libc][docs] Add documentation for the new GPU mode.
Nov 29 2022, 6:30 AM · Restricted Project, Restricted Project

Nov 22 2022

lntue updated the summary of D138541: [libc][math] Implement full multiplication and quick_mul_hi for UInt class..
Nov 22 2022, 8:45 PM · Restricted Project, Restricted Project
lntue requested review of D138541: [libc][math] Implement full multiplication and quick_mul_hi for UInt class..
Nov 22 2022, 8:42 PM · Restricted Project, Restricted Project
lntue updated the summary of D138506: [libc][math] Improve the performance of subtraction for UInt<>..
Nov 22 2022, 8:39 AM · Restricted Project, Restricted Project
lntue requested review of D138506: [libc][math] Improve the performance of subtraction for UInt<>..
Nov 22 2022, 8:38 AM · Restricted Project, Restricted Project

Nov 19 2022

lntue committed rG0d41b32b741e: [libc][math] Remove UInt<128>::operation* specialization. (authored by lntue).
[libc][math] Remove UInt<128>::operation* specialization.
Nov 19 2022, 1:17 PM · Restricted Project, Restricted Project
lntue closed D138239: [libc][math] Remove UInt<128>::operation* specialization..
Nov 19 2022, 1:16 PM · Restricted Project, Restricted Project
lntue committed rGe205fc1836c9: [libc] Add sub_with_borrow to builtin_wrapper.h (authored by lntue).
[libc] Add sub_with_borrow to builtin_wrapper.h
Nov 19 2022, 1:12 PM · Restricted Project, Restricted Project
lntue closed D138182: [libc] Add sub_with_borrow to builtin_wrapper.h.
Nov 19 2022, 1:12 PM · Restricted Project, Restricted Project

Nov 18 2022

lntue updated the diff for D138182: [libc] Add sub_with_borrow to builtin_wrapper.h.

Add DEFINE_NAMED_PAIR_TEMPLATE and update return values for builtins wrappers.

Nov 18 2022, 10:05 AM · Restricted Project, Restricted Project

Nov 17 2022

lntue added a comment to D138239: [libc][math] Remove UInt<128>::operation* specialization..

Do you have a benchmark comparing the new implementation vs. this specialized implementation? It appears that you currently only have the new implementation and the old generic implementation.

Nov 17 2022, 3:44 PM · Restricted Project, Restricted Project
lntue updated the summary of D138239: [libc][math] Remove UInt<128>::operation* specialization..
Nov 17 2022, 3:43 PM · Restricted Project, Restricted Project
lntue added inline comments to D138182: [libc] Add sub_with_borrow to builtin_wrapper.h.
Nov 17 2022, 3:42 PM · Restricted Project, Restricted Project
lntue updated the summary of D138239: [libc][math] Remove UInt<128>::operation* specialization..
Nov 17 2022, 2:54 PM · Restricted Project, Restricted Project
lntue requested review of D138239: [libc][math] Remove UInt<128>::operation* specialization..
Nov 17 2022, 2:53 PM · Restricted Project, Restricted Project

Nov 16 2022

lntue requested review of D138182: [libc] Add sub_with_borrow to builtin_wrapper.h.
Nov 16 2022, 9:59 PM · Restricted Project, Restricted Project
lntue accepted D138076: [libc] add scanf entrypoints.
Nov 16 2022, 7:20 AM · Restricted Project, Restricted Project