Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152020

[RISCV] Split scheduler classes for vector min/max from compares.
ClosedPublic
Actions

Authored by craig.topper on Jun 2 2023, 12:04 PM.

Details

Reviewers
reames
frasercrmck
rogfer01
michaelmaitland
• pcwang-thead
Commits
rG8dd28c5682d6: [RISCV] Split scheduler classes for vector min/max from compares.
Summary

Compares write a mask result. Min/max write a full result. This
makes them sufficiently different to have their own classes.

Diff Detail

Event Timeline

craig.topper created this revision.Jun 2 2023, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2023, 12:04 PM
Herald added subscribers: jobnoorman, luke, VincentWu and 26 others. · View Herald Transcript
craig.topper requested review of this revision.Jun 2 2023, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2023, 12:04 PM
Herald added subscribers: eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B236234: Diff 527927.Jun 2 2023, 12:56 PM
• pcwang-thead added a comment.Jun 4 2023, 8:12 PM

Should we modify VPseudoVMINMAX_VV_VX and VPseudoVMAX_VV_VF too?

craig.topper planned changes to this revision.Jun 4 2023, 8:57 PM
craig.topper updated this revision to Diff 529064.Jun 6 2023, 3:41 PM

Update the pseudoinstructions

Harbormaster completed remote builds in B237093: Diff 529064.Jun 6 2023, 7:27 PM
• pcwang-thead accepted this revision.Jun 6 2023, 8:00 PM

LGTM

This revision is now accepted and ready to land.Jun 6 2023, 8:00 PM
Closed by commit rG8dd28c5682d6: [RISCV] Split scheduler classes for vector min/max from compares. (authored by craig.topper). · Explain WhyJun 6 2023, 10:26 PM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG8dd28c5682d6: [RISCV] Split scheduler classes for vector min/max from compares..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
30 lines
26 lines
12 lines
40 lines

Diff 529161

View Options

llvm/lib/Target/RISCV/RISCVInstrInfoV.td

Loading...
View Options

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td

Loading...
View Options

llvm/lib/Target/RISCV/RISCVSchedSiFive7.td

Loading...
View Options

llvm/lib/Target/RISCV/RISCVScheduleV.td

Loading...