This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Lower gang dim to MLIR
ClosedPublic

Authored by clementval on Jun 1 2023, 10:51 PM.

Details

Summary

Lower gang dim from the parse tree to the new MLIR
representation.

Depends on D151972

Diff Detail

Event Timeline

clementval created this revision.Jun 1 2023, 10:51 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 1 2023, 10:51 PM
clementval requested review of this revision.Jun 1 2023, 10:51 PM
jeanPerier accepted this revision.EditedJun 13 2023, 6:36 AM

Patch application issue, but the code and tests look good.

This revision is now accepted and ready to land.Jun 13 2023, 6:36 AM
razvanlupusoru accepted this revision.Jun 13 2023, 8:02 AM

Looks great!

razvanlupusoru added inline comments.Jun 13 2023, 8:12 AM
flang/test/Lower/OpenACC/acc-loop.f90
281

By the way, I think that the acc dialect should allow gang num and dim at same time even though spec does not. Namely, I see no reason you cannot specify how many gangs to use per dimension. That said, if you do reject this case at semantic verification, then your test might not work.

clang-format

This revision was landed with ongoing or failed builds.Jun 13 2023, 11:20 PM
This revision was automatically updated to reflect the committed changes.