This is an archive of the discontinued LLVM Phabricator instance.

Differential D151317

[compiler-rt] Introduce asm macros for interceptor trampolines
ClosedPublic

Authored by melver on May 24 2023, 5:10 AM.

Details

Reviewers
dvyukov
vitalybuka
Commits
rG15711bd63189: [compiler-rt] Introduce asm macros for interceptor trampolines
Summary

This introduces macros for asm sources to define trampolines, and
aliases to trampolines.

Because we currently do not yet have any real trampolines, this change
is a NFC.

Depends on D151316

Diff Detail

Event Timeline

melver created this revision.May 24 2023, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 5:10 AM
Herald added subscribers: luke, Enna1, frasercrmck and 21 others. · View Herald Transcript
melver requested review of this revision.May 24 2023, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 5:10 AM
Herald added subscribers: Restricted Project, • pcwang-thead. · View Herald Transcript
melver added a child revision: D151318: [compiler-rt] Unify Linux and *BSD interceptors more.May 24 2023, 5:11 AM
dvyukov accepted this revision.May 24 2023, 5:13 AM
This revision is now accepted and ready to land.May 24 2023, 5:13 AM
Harbormaster completed remote builds in B234157: Diff 525113.May 24 2023, 5:36 AM
vitalybuka accepted this revision.May 24 2023, 6:08 PM
This revision was landed with ongoing or failed builds.May 25 2023, 3:02 AM
Closed by commit rG15711bd63189: [compiler-rt] Introduce asm macros for interceptor trampolines (authored by melver). · Explain Why
This revision was automatically updated to reflect the committed changes.
melver added a commit: rG15711bd63189: [compiler-rt] Introduce asm macros for interceptor trampolines.

Revision Contents

Diff 525511

compiler-rt/lib/hwasan/hwasan_setjmp_aarch64.S

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(setjmp_bionic)) ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(setjmp_bionic))
ASM_WRAPPER_NAME(setjmp_bionic): ASM_WRAPPER_NAME(setjmp_bionic):
CFI_STARTPROC CFI_STARTPROC
BTI_C BTI_C
mov x1, #1 mov x1, #1
b ASM_WRAPPER_NAME(sigsetjmp) b ASM_WRAPPER_NAME(sigsetjmp)
CFI_ENDPROC CFI_ENDPROC
ASM_SIZE(ASM_WRAPPER_NAME(setjmp_bionic)) ASM_SIZE(ASM_WRAPPER_NAME(setjmp_bionic))
ASM_INTERCEPTOR_TRAMPOLINE(setjmp_bionic)
#endif #endif
.global ASM_WRAPPER_NAME(sigsetjmp) .global ASM_WRAPPER_NAME(sigsetjmp)
ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(sigsetjmp)) ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(sigsetjmp))
ASM_WRAPPER_NAME(sigsetjmp): ASM_WRAPPER_NAME(sigsetjmp):
CFI_STARTPROC CFI_STARTPROC
BTI_C BTI_C
stp x19, x20, [x0, #0<<3] stp x19, x20, [x0, #0<<3]
Show All 10 LinesASM_WRAPPER_NAME(sigsetjmp):
str x2, [x0, #13<<3] str x2, [x0, #13<<3]
// We always have the second argument to __sigjmp_save (savemask) set, since // We always have the second argument to __sigjmp_save (savemask) set, since
// the _setjmp function above has set it for us as `false`. // the _setjmp function above has set it for us as `false`.
// This function is defined in hwasan_interceptors.cc // This function is defined in hwasan_interceptors.cc
b __sigjmp_save b __sigjmp_save
CFI_ENDPROC CFI_ENDPROC
ASM_SIZE(ASM_WRAPPER_NAME(sigsetjmp)) ASM_SIZE(ASM_WRAPPER_NAME(sigsetjmp))
ASM_INTERCEPTOR_TRAMPOLINE(sigsetjmp)
.macro WEAK_ALIAS first second
.weak \second
.equ \second\(), \first
.endm
#if SANITIZER_ANDROID #if SANITIZER_ANDROID
WEAK_ALIAS ASM_WRAPPER_NAME(sigsetjmp), sigsetjmp ASM_TRAMPOLINE_ALIAS(sigsetjmp, sigsetjmp)
WEAK_ALIAS ASM_WRAPPER_NAME(setjmp_bionic), setjmp ASM_TRAMPOLINE_ALIAS(setjmp, setjmp_bionic)
#else #else
WEAK_ALIAS ASM_WRAPPER_NAME(sigsetjmp), __sigsetjmp ASM_TRAMPOLINE_ALIAS(__sigsetjmp, sigsetjmp)
#endif #endif
WEAK_ALIAS ASM_WRAPPER_NAME(setjmp), _setjmp ASM_TRAMPOLINE_ALIAS(_setjmp, setjmp)
#endif #endif
// We do not need executable stack. // We do not need executable stack.
NO_EXEC_STACK_DIRECTIVE NO_EXEC_STACK_DIRECTIVE
GNU_PROPERTY_BTI_PAC GNU_PROPERTY_BTI_PAC

compiler-rt/lib/hwasan/hwasan_setjmp_riscv64.S

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines
#endif #endif
// We always have the second argument to __sigjmp_save (savemask) set, since // We always have the second argument to __sigjmp_save (savemask) set, since
// the _setjmp function above has set it for us as `false`. // the _setjmp function above has set it for us as `false`.
// This function is defined in hwasan_interceptors.cc // This function is defined in hwasan_interceptors.cc
tail __sigjmp_save tail __sigjmp_save
CFI_ENDPROC CFI_ENDPROC
ASM_SIZE(ASM_WRAPPER_NAME(sigsetjmp)) ASM_SIZE(ASM_WRAPPER_NAME(sigsetjmp))
ASM_INTERCEPTOR_TRAMPOLINE(sigsetjmp)
.macro WEAK_ALIAS first second ASM_TRAMPOLINE_ALIAS(__sigsetjmp, sigsetjmp)
.weak \second ASM_INTERCEPTOR_TRAMPOLINE(setjmp)
.equ \second\(), \first ASM_TRAMPOLINE_ALIAS(_setjmp, setjmp)
.endm
WEAK_ALIAS ASM_WRAPPER_NAME(sigsetjmp), __sigsetjmp
WEAK_ALIAS ASM_WRAPPER_NAME(setjmp), _setjmp
#endif #endif
// We do not need executable stack. // We do not need executable stack.
NO_EXEC_STACK_DIRECTIVE NO_EXEC_STACK_DIRECTIVE

compiler-rt/lib/hwasan/hwasan_setjmp_x86_64.S

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines.Linterceptor_sigsetjmp:
mov (%rsp), %rax mov (%rsp), %rax
mov %rax, (7*8)(%rdi) mov %rax, (7*8)(%rdi)
jmp __sigjmp_save jmp __sigjmp_save
CFI_ENDPROC CFI_ENDPROC
ASM_SIZE(ASM_WRAPPER_NAME(sigsetjmp)) ASM_SIZE(ASM_WRAPPER_NAME(sigsetjmp))
ASM_INTERCEPTOR_TRAMPOLINE(sigsetjmp)
.macro WEAK_ALIAS first second ASM_TRAMPOLINE_ALIAS(__sigsetjmp, sigsetjmp)
.weak \second ASM_INTERCEPTOR_TRAMPOLINE(setjmp)
.equ \second\(), \first ASM_TRAMPOLINE_ALIAS(_setjmp, setjmp)
.endm
WEAK_ALIAS ASM_WRAPPER_NAME(sigsetjmp), __sigsetjmp
WEAK_ALIAS ASM_WRAPPER_NAME(setjmp), _setjmp
#endif #endif
// We do not need executable stack. // We do not need executable stack.
NO_EXEC_STACK_DIRECTIVE NO_EXEC_STACK_DIRECTIVE

compiler-rt/lib/sanitizer_common/sanitizer_asm.h

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
#if !defined(__APPLE__) #if !defined(__APPLE__)
# define ASM_HIDDEN(symbol) .hidden symbol # define ASM_HIDDEN(symbol) .hidden symbol
# define ASM_TYPE_FUNCTION(symbol) .type symbol, %function # define ASM_TYPE_FUNCTION(symbol) .type symbol, %function
# define ASM_SIZE(symbol) .size symbol, .-symbol # define ASM_SIZE(symbol) .size symbol, .-symbol
# define ASM_SYMBOL(symbol) symbol # define ASM_SYMBOL(symbol) symbol
# define ASM_SYMBOL_INTERCEPTOR(symbol) symbol # define ASM_SYMBOL_INTERCEPTOR(symbol) symbol
# define ASM_WRAPPER_NAME(symbol) __interceptor_##symbol # define ASM_WRAPPER_NAME(symbol) __interceptor_##symbol
# define ASM_TRAMPOLINE_ALIAS(symbol, name) \
.weak symbol; \
.set symbol, ASM_WRAPPER_NAME(name)
# define ASM_INTERCEPTOR_TRAMPOLINE(name)
#else #else
# define ASM_HIDDEN(symbol) # define ASM_HIDDEN(symbol)
# define ASM_TYPE_FUNCTION(symbol) # define ASM_TYPE_FUNCTION(symbol)
# define ASM_SIZE(symbol) # define ASM_SIZE(symbol)
# define ASM_SYMBOL(symbol) _##symbol # define ASM_SYMBOL(symbol) _##symbol
# define ASM_SYMBOL_INTERCEPTOR(symbol) _wrap_##symbol # define ASM_SYMBOL_INTERCEPTOR(symbol) _wrap_##symbol
# define ASM_WRAPPER_NAME(symbol) __interceptor_##symbol # define ASM_WRAPPER_NAME(symbol) __interceptor_##symbol
#endif #endif
Show All 16 Lines

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_aarch64.inc.S

Show All 34 Lines.L_exit:
bl COMMON_INTERCEPTOR_SPILL_AREA bl COMMON_INTERCEPTOR_SPILL_AREA
ldr x30, [x0] ldr x30, [x0]
ldp x0, xzr, [sp], 16 ldp x0, xzr, [sp], 16
hint #29 // autiasp hint #29 // autiasp
ret ret
ASM_SIZE(vfork) ASM_SIZE(vfork)
.weak vfork ASM_INTERCEPTOR_TRAMPOLINE(vfork)
.set vfork, ASM_WRAPPER_NAME(vfork) ASM_TRAMPOLINE_ALIAS(vfork, vfork)
GNU_PROPERTY_BTI_PAC GNU_PROPERTY_BTI_PAC
#endif #endif

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_arm.inc.S

Show All 37 Lines.L_exit:
mov pc, lr mov pc, lr
.LCPI0_0: .LCPI0_0:
.long _ZN14__interception10real_vforkE - (.LPC0_0+8) .long _ZN14__interception10real_vforkE - (.LPC0_0+8)
ASM_SIZE(vfork) ASM_SIZE(vfork)
.weak vfork ASM_INTERCEPTOR_TRAMPOLINE(vfork)
.set vfork, ASM_WRAPPER_NAME(vfork) ASM_TRAMPOLINE_ALIAS(vfork, vfork)
#endif #endif

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_i386.inc.S

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
.L_exit: .L_exit:
mov 4(%esp), %eax mov 4(%esp), %eax
mov 8(%esp), %ebx mov 8(%esp), %ebx
add $12, %esp add $12, %esp
ret ret
ASM_SIZE(vfork) ASM_SIZE(vfork)
.weak vfork ASM_INTERCEPTOR_TRAMPOLINE(vfork)
.set vfork, ASM_WRAPPER_NAME(vfork) ASM_TRAMPOLINE_ALIAS(vfork, vfork)
#endif #endif

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_loongarch64.inc.S

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines.L_exit:
ld.d $ra, $a0, 0 ld.d $ra, $a0, 0
// load value by stack // load value by stack
ld.d $a0, $sp, 8 ld.d $a0, $sp, 8
// adjust stack // adjust stack
addi.d $sp, $sp, 16 addi.d $sp, $sp, 16
jr $ra jr $ra
ASM_SIZE(vfork) ASM_SIZE(vfork)
.weak vfork ASM_INTERCEPTOR_TRAMPOLINE(vfork)
.set vfork, ASM_WRAPPER_NAME(vfork) ASM_TRAMPOLINE_ALIAS(vfork, vfork)
#endif #endif

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_riscv64.inc.S

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines.L_exit:
ld ra, 0(x10) ld ra, 0(x10)
// load value by stack // load value by stack
ld x10, 8(sp) ld x10, 8(sp)
// adjust stack // adjust stack
addi sp, sp, 16 addi sp, sp, 16
ret ret
ASM_SIZE(vfork) ASM_SIZE(vfork)
.weak vfork ASM_INTERCEPTOR_TRAMPOLINE(vfork)
.set vfork, ASM_WRAPPER_NAME(vfork) ASM_TRAMPOLINE_ALIAS(vfork, vfork)
#endif #endif

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_x86_64.inc.S

Show All 28 LinesASM_WRAPPER_NAME(vfork):
je .L_exit je .L_exit
lea 16(%rsp), %rdi lea 16(%rsp), %rdi
call COMMON_INTERCEPTOR_HANDLE_VFORK@PLT call COMMON_INTERCEPTOR_HANDLE_VFORK@PLT
.L_exit: .L_exit:
pop %rax pop %rax
ret ret
ASM_SIZE(vfork) ASM_SIZE(ASM_WRAPPER_NAME(vfork))
.weak vfork ASM_INTERCEPTOR_TRAMPOLINE(vfork)
.set vfork, ASM_WRAPPER_NAME(vfork) ASM_TRAMPOLINE_ALIAS(vfork, vfork)
#endif #endif