This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Unify Linux and *BSD interceptors more
ClosedPublic

Authored by melver on May 24 2023, 5:11 AM.

Details

Summary

The Linux and *BSD interceptors are almost identical, except for *BSD,
where the overridden intercepted function is not defined weak due to
some incompliant linker behaviour.

Since most of the interception machinery is shared between Linux and
*BSD (see INTERCEPT_FUNCTION macro), it makes sense to unify interceptor
definition and declarations as much as possible to ease future changes.

NFC.

Depends on D151317

Diff Detail

Event Timeline

melver created this revision.May 24 2023, 5:11 AM
melver requested review of this revision.May 24 2023, 5:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 5:11 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov accepted this revision.May 24 2023, 5:16 AM
This revision is now accepted and ready to land.May 24 2023, 5:16 AM
vitalybuka accepted this revision.May 24 2023, 6:13 PM
This revision was landed with ongoing or failed builds.May 25 2023, 3:02 AM
This revision was automatically updated to reflect the committed changes.