Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D151343

[msan] Strip __interceptor_ from reports
ClosedPublic
Actions

Authored by melver on May 24 2023, 9:15 AM.

Details

Reviewers
dvyukov
vitalybuka
Commits
rG5732cdc1be51: [msan] Strip __interceptor_ from reports
Summary

Showing __interceptor_ as part of the function name in reports does not
make sense and is distracting.

Strip the interceptor function name before printing.

Depends on D151319

Diff Detail

Event Timeline

melver created this revision.May 24 2023, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 9:15 AM
Herald added a subscriber: Enna1. · View Herald Transcript
melver requested review of this revision.May 24 2023, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 9:15 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver mentioned this in D151085: [compiler-rt] Allow 3 simultaneous interceptors on Linux.May 24 2023, 9:17 AM
melver added a child revision: D151085: [compiler-rt] Allow 3 simultaneous interceptors on Linux.May 24 2023, 9:21 AM
Harbormaster completed remote builds in B234226: Diff 525211.May 24 2023, 9:49 AM
vitalybuka accepted this revision.May 24 2023, 6:23 PM
vitalybuka added inline comments.
compiler-rt/lib/msan/msan_report.cpp
271

It's always called with func, can you please rename "what" to function

compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cpp
44

there is common_flags()->demangle flag which sometimes useful as last resort
it could be nice if it applies to DemangleFunctionName and StripFunctionName

This revision is now accepted and ready to land.May 24 2023, 6:23 PM
dvyukov accepted this revision.May 25 2023, 12:24 AM
melver marked 2 inline comments as done.May 25 2023, 2:03 AM
melver added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cpp
44

https://reviews.llvm.org/D151411

Closed by commit rG5732cdc1be51: [msan] Strip __interceptor_ from reports (authored by melver). · Explain WhyMay 25 2023, 3:03 AM
This revision was automatically updated to reflect the committed changes.
melver marked an inline comment as done.
melver added a commit: rG5732cdc1be51: [msan] Strip __interceptor_ from reports.
melver removed a child revision: D151085: [compiler-rt] Allow 3 simultaneous interceptors on Linux.May 25 2023, 1:19 PM

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
msan/
4 lines
11 lines
sanitizer_common/
3 lines
9 lines
test/
msan/
Linux/
4 lines
4 lines
4 lines
2 lines
2 lines
6 lines
2 lines

Diff 525514

View Options

compiler-rt/lib/msan/msan_report.h

Loading...
View Options

compiler-rt/lib/msan/msan_report.cpp

Loading...
View Options

compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.h

Loading...
View Options

compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cpp

Loading...
View Options

compiler-rt/test/msan/Linux/b64.cpp

Loading...
View Options

compiler-rt/test/msan/Linux/sendmsg.cpp

Loading...
View Options

compiler-rt/test/msan/fgets_fputs.cpp

Loading...
View Options

compiler-rt/test/msan/fread_fwrite.cpp

Loading...
View Options

compiler-rt/test/msan/getaddrinfo-positive.cpp

Loading...
View Options

compiler-rt/test/msan/scoped-interceptors.cpp

Loading...
View Options

compiler-rt/test/msan/strndup.cpp

Loading...