This patch adds memory annotation parsing to llvm-exegesis. The memory
annotations cannot be used currently, but this allows for using parsed
memory annotations within a FunctionExecutorImpl to set up a specified
execution environment.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
@courbet This patch (and the next one) are ready for review on my side when you have some time.
llvm/tools/llvm-exegesis/lib/SnippetFile.h | ||
---|---|---|
32 | From a design perspective I don't think readSnippets should know about ExecutionMode. The parser just parses, let's check in that there are no memory mappings in the BenchmarkCode when using it (e.g. in main). |
Comment Actions
Just updated it to throw an error in llvm-exegesis.cpp rather than generate invalid comments. Definitely a much cleaner design. Thanks for the suggestion!
Comment Actions
Should be closed by f0655b0d06129330f710b3cb9955cec7e778bfd0. I forgot to add in the Phabricator information when cherry-picking from my branch with the changes.
From a design perspective I don't think readSnippets should know about ExecutionMode. The parser just parses, let's check in that there are no memory mappings in the BenchmarkCode when using it (e.g. in main).